Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of

2023-11-13 Thread Oleksii
On Mon, 2023-11-13 at 18:01 +0100, Jan Beulich wrote: > On 11.11.2023 11:24, Oleksii wrote: > > This patch should be reworked as it fails Arm builds: > > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920 > > Took me a while to actually find the error. Would have been nice if >

Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of

2023-11-13 Thread Jan Beulich
On 11.11.2023 11:24, Oleksii wrote: > This patch should be reworked as it fails Arm builds: > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920 Took me a while to actually find the error. Would have been nice if you had explained what's going wrong, supplying the link only as

Re: [PATCH v2 06/15] xen/asm-generic: ifdef inclusion of

2023-11-11 Thread Oleksii
This patch should be reworked as it fails Arm builds: https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920 It looks like it is not possible just to #ifdef CONFIG_MEM_ACCESS. An empty asm-generic mem_access.h will be better solution. Could you please share your opinion? ~ Oleks

[PATCH v2 06/15] xen/asm-generic: ifdef inclusion of

2023-11-10 Thread Oleksii Kurochko
ifdefing inclusion of in allows to avoid generation of empty header for the case when !CONFIG_MEM_ACCESS. Suggested-by: Jan Beulich Signed-off-by: Oleksii Kurochko --- Changes in V2: - add Suggested-by: Jan Beulich - update the commit message - remove --- xen/includ