On 11.11.2023 11:24, Oleksii wrote: > This patch should be reworked as it fails Arm builds: > https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1068867920
Took me a while to actually find the error. Would have been nice if you had explained what's going wrong, supplying the link only as extra info. > It looks like it is not possible just to #ifdef CONFIG_MEM_ACCESS. > > An empty asm-generic mem_access.h will be better solution. I remain unconvinced. The issue looks to be with p2m_mem_access_check(). One solution would be to move that declaration into the common header. But there's no common code referencing it, so Arm's and x86's version might as well diverge at some point. Hence from my pov it again boils down to Arm's traps.c including asm/mem_access.h explicitly, to bring the declaration in scope. None of the common files really have a need to have a dependency on the arch-specific header when MEM_ACCESS=n. Jan
