Re: [PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page() hooks

2021-12-17 Thread Julien Grall
Hi Jan, On 24/09/2021 10:44, Jan Beulich wrote: Or really, in the case of ->map_page(), accommodate it in the existing "flags" parameter. All call sites will pass 0 for now. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian For the Arm bits: Acked-by: Julien Grall Cheers, -- Julien Gra

Re: [PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page() hooks

2021-11-30 Thread Jan Beulich
On 30.11.2021 14:49, Roger Pau Monné wrote: > On Fri, Sep 24, 2021 at 11:44:50AM +0200, Jan Beulich wrote: >> Or really, in the case of ->map_page(), accommodate it in the existing >> "flags" parameter. All call sites will pass 0 for now. > > It feels slightly weird from an interface PoV that the

Re: [PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page() hooks

2021-11-30 Thread Roger Pau Monné
On Fri, Sep 24, 2021 at 11:44:50AM +0200, Jan Beulich wrote: > Or really, in the case of ->map_page(), accommodate it in the existing > "flags" parameter. All call sites will pass 0 for now. It feels slightly weird from an interface PoV that the map handler takes the order from the flags parameter

[PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page() hooks

2021-09-24 Thread Jan Beulich
Or really, in the case of ->map_page(), accommodate it in the existing "flags" parameter. All call sites will pass 0 for now. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian --- v2: Re-base over change earlier in the series. --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthr