On 30.11.2021 14:49, Roger Pau Monné wrote: > On Fri, Sep 24, 2021 at 11:44:50AM +0200, Jan Beulich wrote: >> Or really, in the case of ->map_page(), accommodate it in the existing >> "flags" parameter. All call sites will pass 0 for now. > > It feels slightly weird from an interface PoV that the map handler > takes the order from the flags parameter, while the unmap one has a > function parameter for it.
Well, I wouldn't want to call the unmap parameter "flags" just for consistency. If there ever is a flag to be passed, I guess that's going to be the natural course of action. >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> Reviewed-by: Kevin Tian <kevin.t...@intel.com> > > Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks. Jan
