Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-07 Thread Jan Beulich
On 04.12.2020 16:52, Dario Faggioli wrote: > On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: >> The cpupool id is an unsigned value in the public interface header, >> so >> there is no reason why it is a signed value in struct cpupool. >> >> Switch it to unsigned int. >> > I think we can ad

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-07 Thread Jan Beulich
On 07.12.2020 15:48, Jürgen Groß wrote: > On 07.12.20 10:59, Jan Beulich wrote: >> On 01.12.2020 10:01, Jürgen Groß wrote: >>> On 01.12.20 09:55, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: > --- a/xen/common/sched/private.h > +++ b/xen/common/sched/private.h > @@

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-07 Thread Jürgen Groß
On 07.12.20 10:59, Jan Beulich wrote: On 01.12.2020 10:01, Jürgen Groß wrote: On 01.12.20 09:55, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: --- a/xen/common/sched/private.h +++ b/xen/common/sched/private.h @@ -505,8 +505,8 @@ static inline void sched_unit_unpause(const struct

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-07 Thread Jan Beulich
On 01.12.2020 10:01, Jürgen Groß wrote: > On 01.12.20 09:55, Jan Beulich wrote: >> On 01.12.2020 09:21, Juergen Gross wrote: >>> --- a/xen/common/sched/private.h >>> +++ b/xen/common/sched/private.h >>> @@ -505,8 +505,8 @@ static inline void sched_unit_unpause(const struct >>> sched_unit *unit) >>

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-07 Thread Jan Beulich
On 04.12.2020 16:52, Dario Faggioli wrote: > On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: >> The cpupool id is an unsigned value in the public interface header, >> so >> there is no reason why it is a signed value in struct cpupool. >> >> Switch it to unsigned int. >> > I think we can ad

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-04 Thread Dario Faggioli
On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: > The cpupool id is an unsigned value in the public interface header, > so > there is no reason why it is a signed value in struct cpupool. > > Switch it to unsigned int. > I think we can add: "No functional change intended" > Signed-off-b

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jan Beulich
On 01.12.2020 10:01, Jürgen Groß wrote: > On 01.12.20 09:55, Jan Beulich wrote: >> On 01.12.2020 09:21, Juergen Gross wrote: >>> @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) >>>* - unknown scheduler >>>*/ >>> static struct cpupool *cpupool_create( >>> -int poolid, unsi

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jürgen Groß
On 01.12.20 09:55, Jan Beulich wrote: On 01.12.2020 09:21, Juergen Gross wrote: @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) * - unknown scheduler */ static struct cpupool *cpupool_create( -int poolid, unsigned int sched_id, int *perr) +unsigned int poolid, unsign

Re: [PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Jan Beulich
On 01.12.2020 09:21, Juergen Gross wrote: > @@ -243,11 +243,11 @@ void cpupool_put(struct cpupool *pool) > * - unknown scheduler > */ > static struct cpupool *cpupool_create( > -int poolid, unsigned int sched_id, int *perr) > +unsigned int poolid, unsigned int sched_id, int *perr) > {

[PATCH v2 04/17] xen/cpupool: switch cpupool id to unsigned

2020-12-01 Thread Juergen Gross
The cpupool id is an unsigned value in the public interface header, so there is no reason why it is a signed value in struct cpupool. Switch it to unsigned int. Signed-off-by: Juergen Gross --- V2: - new patch --- xen/common/sched/core.c| 2 +- xen/common/sched/cpupool.c | 48 +