Re: [PATCH v2] xen/arm: p2m_set_entry reuse mask variables

2022-04-26 Thread Paran Lee
Thansk! > It is common to add a changelog after "---". This helps the reviewer to > know what changed in your patch. I think this experience will be very helpful for the next more meaningful patch. > > "1UL << order" refers to the number of pages and not a mask. So I don't > think re-using the l

Re: [PATCH v2] xen/arm: p2m_set_entry reuse mask variables

2022-04-26 Thread Julien Grall
Hi, On 26/04/2022 16:49, Paran Lee wrote: Reuse mask variables on order shift duplicated calculation. Signed-off-by: Paran Lee --- xen/arch/arm/p2m.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) It is common to add a changelog after "---". This helps the reviewer to know

[PATCH v2] xen/arm: p2m_set_entry reuse mask variables

2022-04-26 Thread Paran Lee
Reuse mask variables on order shift duplicated calculation. Signed-off-by: Paran Lee --- xen/arch/arm/p2m.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 1d1059f7d2..cdb3b56aa1 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/ar