Thansk! > It is common to add a changelog after "---". This helps the reviewer to > know what changed in your patch.
I think this experience will be very helpful for the next more meaningful patch. > > "1UL << order" refers to the number of pages and not a mask. So I don't > think re-using the local variable 'mask' is a good idea because the code > is a lot more confusing. I agree too. > Instead, I think your other patch is the way to go with a small tweak to > use 1UL (which BTW should be mentioned in the commit message). > > Either Stefano or I can deal with the change on commit. Thank you so much for your detailed patch review. BR Paran Lee
