Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-17 Thread Jürgen Groß
On 17.11.20 15:13, Jan Beulich wrote: On 26.10.2020 10:13, Juergen Gross wrote: @@ -992,6 +994,78 @@ static struct notifier_block cpu_nfb = { .notifier_call = cpu_callback }; +#ifdef CONFIG_HYPFS +static HYPFS_DIR_INIT(cpupool_pooldir, "id"); This "id" string won't appear anywhere,

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-17 Thread Jan Beulich
On 26.10.2020 10:13, Juergen Gross wrote: > @@ -992,6 +994,78 @@ static struct notifier_block cpu_nfb = { > .notifier_call = cpu_callback > }; > > +#ifdef CONFIG_HYPFS > +static HYPFS_DIR_INIT(cpupool_pooldir, "id"); This "id" string won't appear anywhere, will it? I would have expected th

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Dario Faggioli
On Wed, 2020-11-11 at 16:00 +0100, Jürgen Groß wrote: > On 11.11.20 15:56, Jan Beulich wrote: > > On 11.11.2020 15:51, Dario Faggioli wrote: > > > > > > Having a hypfs_add_dir() stub would also allow to achieve this, and > > then, going forward, perhaps also elsewhere. > > I thought about that.

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Jürgen Groß
On 11.11.20 15:56, Jan Beulich wrote: On 11.11.2020 15:51, Dario Faggioli wrote: On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote: Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Dario Faggioli
On Wed, 2020-11-11 at 15:56 +0100, Jürgen Groß wrote: > On 11.11.20 15:51, Dario Faggioli wrote: > > > > What would you think about doing this in an helper function > > (hypfs_cpupool_init() ?), implemented inside the above #ifdef and > > as an > > empty stub if !CONFIG_HYPFS ? > > > > That will

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Jan Beulich
On 11.11.2020 15:51, Dario Faggioli wrote: > On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote: >> Add /cpupool/ directories to hypfs. Those are completely >> dynamic, so the related hypfs access functions need to be >> implemented. >> >> Signed-off-by: Juergen Gross >> > So, I'm almost sold.

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Jürgen Groß
On 11.11.20 15:51, Dario Faggioli wrote: On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote: Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross So, I'm almost sold... Just one commen

Re: [PATCH 10/12] xen/hypfs: add cpupool directories

2020-11-11 Thread Dario Faggioli
On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote: > Add /cpupool/ directories to hypfs. Those are completely > dynamic, so the related hypfs access functions need to be > implemented. > > Signed-off-by: Juergen Gross > So, I'm almost sold... Just one comment: > --- a/xen/common/sched/cpupo

[PATCH 10/12] xen/hypfs: add cpupool directories

2020-10-26 Thread Juergen Gross
Add /cpupool/ directories to hypfs. Those are completely dynamic, so the related hypfs access functions need to be implemented. Signed-off-by: Juergen Gross --- docs/misc/hypfs-paths.pandoc | 9 + xen/common/sched/cpupool.c | 78 2 files changed, 87 in