On Wed, 2020-11-11 at 15:56 +0100, Jürgen Groß wrote: > On 11.11.20 15:51, Dario Faggioli wrote: > > > > What would you think about doing this in an helper function > > (hypfs_cpupool_init() ?), implemented inside the above #ifdef and > > as an > > empty stub if !CONFIG_HYPFS ? > > > > That will save us from having the #ifdef-s again here. > > > > I'm asking because it's certainly not critical and I don't have a > > too > > strong opinion about it. But I do think the code would look better. > > I'm fine either way. > > In case nobody objects I'll change it. > Ok, cool. If you do that and resend, and that's the only change, you can add:
Reviewed-by: Dario Faggioli <dfaggi...@suse.com> Thanks and Regards -- Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
signature.asc
Description: This is a digitally signed message part
