Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-31 Thread Roger Pau Monné
On Fri, Jul 31, 2020 at 10:05:07AM +0200, Jan Beulich wrote: > On 28.07.2020 11:06, Roger Pau Monné wrote: > > On Mon, Jul 27, 2020 at 09:47:52PM +0200, Jan Beulich wrote: > >> On 27.07.2020 16:55, Roger Pau Monné wrote: > >>> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: > ---

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-31 Thread Jan Beulich
On 28.07.2020 11:06, Roger Pau Monné wrote: > On Mon, Jul 27, 2020 at 09:47:52PM +0200, Jan Beulich wrote: >> On 27.07.2020 16:55, Roger Pau Monné wrote: >>> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: --- /dev/null +++ b/xen/include/asm-x86/asm-defns.h >>> >>> Maybe this

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-31 Thread Jan Beulich
On 28.07.2020 15:55, Andrew Cooper wrote: > On 15/07/2020 11:48, Jan Beulich wrote: >> --- a/xen/arch/x86/arch.mk >> +++ b/xen/arch/x86/arch.mk >> @@ -20,6 +20,7 @@ $(call as-option-add,CFLAGS,CC,"rdrand % >> $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) >> $(call as-option-a

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Jan Beulich
On 28.07.2020 15:59, Andrew Cooper wrote: On 27/07/2020 20:47, Jan Beulich wrote: On 27.07.2020 16:55, Roger Pau Monné wrote: On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: --- /dev/null +++ b/xen/include/asm-x86/asm-defns.h Maybe this could be asm-insn.h or a different name? I

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Jan Beulich
On 28.07.2020 15:55, Andrew Cooper wrote: On 15/07/2020 11:48, Jan Beulich wrote: --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -20,6 +20,7 @@ $(call as-option-add,CFLAGS,CC,"rdrand % $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) $(call as-option-add,CFLAGS,CC

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Andrew Cooper
On 27/07/2020 20:47, Jan Beulich wrote: > On 27.07.2020 16:55, Roger Pau Monné wrote: >> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-x86/asm-defns.h >> >> Maybe this could be asm-insn.h or a different name? I find it >> confusing to have

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Andrew Cooper
On 15/07/2020 11:48, Jan Beulich wrote: > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -20,6 +20,7 @@ $(call as-option-add,CFLAGS,CC,"rdrand % > $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) > $(call as-option-add,CFLAGS,CC,"xsaveopt (%rax)",-DHAVE_AS_XSAVEOPT

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Roger Pau Monné
On Mon, Jul 27, 2020 at 09:47:52PM +0200, Jan Beulich wrote: > On 27.07.2020 16:55, Roger Pau Monné wrote: > > On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: > > > --- /dev/null > > > +++ b/xen/include/asm-x86/asm-defns.h > > > > Maybe this could be asm-insn.h or a different name? I

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-27 Thread Jan Beulich
On 27.07.2020 16:55, Roger Pau Monné wrote: On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: --- /dev/null +++ b/xen/include/asm-x86/asm-defns.h Maybe this could be asm-insn.h or a different name? I find it confusing to have asm-defns.h and an asm_defs.h. While indeed I anticipat

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-27 Thread Roger Pau Monné
On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: > Introduce proper assembler macros instead, enabled only when the > assembler itself doesn't support the insns. To avoid duplicating the > macros for assembly and C files, have them processed into asm-macros.h. > This in turn requires ad

[PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-15 Thread Jan Beulich
Introduce proper assembler macros instead, enabled only when the assembler itself doesn't support the insns. To avoid duplicating the macros for assembly and C files, have them processed into asm-macros.h. This in turn requires adding a multiple inclusion guard when generating that header. No chan