On 27/07/2020 20:47, Jan Beulich wrote: > On 27.07.2020 16:55, Roger Pau Monné wrote: >> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-x86/asm-defns.h >> >> Maybe this could be asm-insn.h or a different name? I find it >> confusing to have asm-defns.h and an asm_defs.h. > > While indeed I anticipated a reply to this effect, I don't consider > asm-insn.h or asm-macros.h suitable: We don't want to limit this > header to a more narrow purpose than "all sorts of definition", I > don't think. Hence I chose that name despite its similarity to the > C header's one.
Roger is correct. Having asm-defns.h and asm_defs.h is too confusing, and there is already too much behind the scenes magic here. What is the anticipated end result, file wise, because that might highlight a better way forward. ~Andrew
