Re: [PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing

2023-01-19 Thread Jan Beulich
On 19.01.2023 19:19, Andrew Cooper wrote: > On 19/01/2023 1:19 pm, Jan Beulich wrote: >> Clearly within the for_each_vcpu() the vCPU of this loop is meant, not >> the (loop invariant) one the fault occurred on. >> >> Signed-off-by: Jan Beulich > > Wow that's been broken for the entire lifetime of

Re: [PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing

2023-01-19 Thread Andrew Cooper
On 19/01/2023 1:19 pm, Jan Beulich wrote: > Clearly within the for_each_vcpu() the vCPU of this loop is meant, not > the (loop invariant) one the fault occurred on. > > Signed-off-by: Jan Beulich Wow that's been broken for the entire lifetime of the pagetable_dying op 0 3d5e6a3ff38 from 2010, but

[PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing

2023-01-19 Thread Jan Beulich
Clearly within the for_each_vcpu() the vCPU of this loop is meant, not the (loop invariant) one the fault occurred on. Signed-off-by: Jan Beulich --- Quitle likely this mistake would have been avoided if the function scope variable was named "curr", leaving "v" available for purposes likethe one