On 19/01/2023 1:19 pm, Jan Beulich wrote: > Clearly within the for_each_vcpu() the vCPU of this loop is meant, not > the (loop invariant) one the fault occurred on. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Wow that's been broken for the entire lifetime of the pagetable_dying op 0 3d5e6a3ff38 from 2010, but it still deserves a fixes tag. Preferably with that, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > Quitle likely this mistake would have been avoided if the function scope > variable was named "curr", leaving "v" available for purposes likethe > one here. Doing the rename now would, however, be quite a bit of code > churn. Perhaps, but that pattern was far less prevalent back then, and the real cause of this bug is sh_page_fault() being far too big and sprawling. ~Andrew
