Re: [PATCH] xen/console: pre-compute domain prefix for printouts

2025-02-13 Thread Jan Beulich
On 14.02.2025 00:28, Andrew Cooper wrote: > On 13/02/2025 10:35 pm, dm...@proton.me wrote: >> Every guest_printk() call computes "(d%d) " prefix on every call. >> Move prefix generation to the domain creation time. >> >> Signed-off-by: Denis Mukhin > > I'm on the fence here. > > Part of that is

Re: [PATCH] xen/console: pre-compute domain prefix for printouts

2025-02-13 Thread Denis Mukhin
On Thursday, February 13th, 2025 at 3:28 PM, Andrew Cooper wrote: > > > On 13/02/2025 10:35 pm, dm...@proton.me wrote: > > > Every guest_printk() call computes "(d%d) " prefix on every call. > > Move prefix generation to the domain creation time. > > > > Signed-off-by: Denis Mukhin dmuk...@ford.

Re: [PATCH] xen/console: pre-compute domain prefix for printouts

2025-02-13 Thread Andrew Cooper
On 13/02/2025 10:35 pm, dm...@proton.me wrote: > Every guest_printk() call computes "(d%d) " prefix on every call. > Move prefix generation to the domain creation time. > > Signed-off-by: Denis Mukhin I'm on the fence here. Part of that is speaking as someone who has had to shrink struct domain

[PATCH] xen/console: pre-compute domain prefix for printouts

2025-02-13 Thread dmkhn
Every guest_printk() call computes "(d%d) " prefix on every call. Move prefix generation to the domain creation time. Signed-off-by: Denis Mukhin --- xen/arch/x86/pv/shim.c | 2 ++ xen/common/domain.c| 2 ++ xen/drivers/char/console.c | 6 +- xen/include/xen/sched.h| 1 + 4 f