On 14.02.2025 00:28, Andrew Cooper wrote: > On 13/02/2025 10:35 pm, dm...@proton.me wrote: >> Every guest_printk() call computes "(d%d) " prefix on every call. >> Move prefix generation to the domain creation time. >> >> Signed-off-by: Denis Mukhin <dmuk...@ford.com> > > I'm on the fence here. > > Part of that is speaking as someone who has had to shrink struct domain > several times to keep it fitting within 1 page.
Just wanted to mention exactly this as well. I'm pretty strongly against us doing anything like this. If we started here, likely other things possible to "cache" would show up. > But as to calculating it every time, does that matter? In production > environments, we get a handful of print lines per domain across their > lifetime. Is the saving really worth it? +1 Jan
