RE: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-18 Thread Tian, Kevin
> From: Roger Pau Monné > Sent: Friday, January 15, 2021 1:21 AM > > On Thu, Jan 14, 2021 at 02:41:29PM +0100, Jan Beulich wrote: > > On 14.01.2021 13:33, Roger Pau Monné wrote: > > > On Thu, Jan 14, 2021 at 12:45:27PM +0100, Jan Beulich wrote: > > >> On 14.01.2021 11:22, Roger Pau Monné wrote: >

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-15 Thread Jason Andryuk
On Thu, Jan 14, 2021 at 5:22 AM Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: > > On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > > > > > > On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné > > > wrote: > > > > > > > > On Wed, Jan 13, 2021 at 10:

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-15 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 12:54:22PM +0100, Jan Beulich wrote: > On 12.01.2021 18:32, Roger Pau Monne wrote: > > @@ -967,10 +879,10 @@ static void hvm_pirq_eoi(struct pirq *pirq) > > * since interrupt is still not EOIed > > */ > > if ( --pirq_dpci->pending || > > - !pt_irq_ne

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-15 Thread Jan Beulich
On 14.01.2021 18:22, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 02:30:15PM +0100, Jan Beulich wrote: >> On 14.01.2021 13:54, Roger Pau Monné wrote: >>> On Thu, Jan 14, 2021 at 12:48:59PM +0100, Jan Beulich wrote: On 13.01.2021 14:11, Roger Pau Monné wrote: > On Wed, Jan 13, 2021 at 0

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 02:30:15PM +0100, Jan Beulich wrote: > On 14.01.2021 13:54, Roger Pau Monné wrote: > > On Thu, Jan 14, 2021 at 12:48:59PM +0100, Jan Beulich wrote: > >> On 13.01.2021 14:11, Roger Pau Monné wrote: > >>> On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > Fro

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 02:41:29PM +0100, Jan Beulich wrote: > On 14.01.2021 13:33, Roger Pau Monné wrote: > > On Thu, Jan 14, 2021 at 12:45:27PM +0100, Jan Beulich wrote: > >> On 14.01.2021 11:22, Roger Pau Monné wrote: > >>> On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: > On

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 14.01.2021 13:33, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 12:45:27PM +0100, Jan Beulich wrote: >> On 14.01.2021 11:22, Roger Pau Monné wrote: >>> On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > I guess I'd a

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 14.01.2021 13:58, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 01:12:00PM +0100, Jan Beulich wrote: >> On 14.01.2021 12:56, Andrew Cooper wrote: >>> On 14/01/2021 11:48, Jan Beulich wrote: On 13.01.2021 14:11, Roger Pau Monné wrote: > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian,

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 14.01.2021 13:54, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 12:48:59PM +0100, Jan Beulich wrote: >> On 13.01.2021 14:11, Roger Pau Monné wrote: >>> On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > From: Roger Pau Monne > As with previous patches, I'm having a hard t

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 01:12:00PM +0100, Jan Beulich wrote: > On 14.01.2021 12:56, Andrew Cooper wrote: > > On 14/01/2021 11:48, Jan Beulich wrote: > >> On 13.01.2021 14:11, Roger Pau Monné wrote: > >>> On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > >

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 12:48:59PM +0100, Jan Beulich wrote: > On 13.01.2021 14:11, Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > >>> From: Roger Pau Monne > >>> As with previous patches, I'm having a hard time figuring out why this > >>> was required in

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Thu, Jan 14, 2021 at 12:45:27PM +0100, Jan Beulich wrote: > On 14.01.2021 11:22, Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: > >> On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > >>> I guess I'd also need to disable MSI for the two devices to

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 14.01.2021 12:56, Andrew Cooper wrote: > On 14/01/2021 11:48, Jan Beulich wrote: >> On 13.01.2021 14:11, Roger Pau Monné wrote: >>> On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > From: Roger Pau Monne > As with previous patches, I'm having a hard time figuring out why th

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Andrew Cooper
On 14/01/2021 11:48, Jan Beulich wrote: > On 13.01.2021 14:11, Roger Pau Monné wrote: >> On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: From: Roger Pau Monne As with previous patches, I'm having a hard time figuring out why this was required in the first place. I see n

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 12.01.2021 18:32, Roger Pau Monne wrote: > @@ -967,10 +879,10 @@ static void hvm_pirq_eoi(struct pirq *pirq) > * since interrupt is still not EOIed > */ > if ( --pirq_dpci->pending || > - !pt_irq_need_timer(pirq_dpci->flags) ) > + /* When the interrupt source is

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 13.01.2021 14:11, Roger Pau Monné wrote: > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: >>> From: Roger Pau Monne >>> As with previous patches, I'm having a hard time figuring out why this >>> was required in the first place. I see no reason for Xen to be >>> deasserting the gue

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 14.01.2021 11:22, Roger Pau Monné wrote: > On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: >> On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: >>> I guess I'd also need to disable MSI for the two devices to ensure >>> they are both using the GSI? >> >> lspci in dom0 shows the

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Jan Beulich
On 13.01.2021 22:31, Jason Andryuk wrote: > On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: >> I guess I'd also need to disable MSI for the two devices to ensure >> they are both using the GSI? > > lspci in dom0 shows the USB xhci controller, iwlwifi, and e1000e > devices all with IRQ 16 and

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-14 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote: > On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > > > > On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné > > wrote: > > > > > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > > > > > > > I have some laptops

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > > On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné wrote: > > > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > > > I have some laptops running OpenXT where the USB controller and NIC > > > share an interrupt, and I assig

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > > On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné > > wrote: > > > > > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > > > From: Roger Pau Monne > > >

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné wrote: > > > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > > From: Roger Pau Monne > > > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > > > > > Current inte

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > From: Roger Pau Monne > > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > > > Current interrupt pass though code will setup a timer for each > > > interrupt injected t

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > Current interrupt pass though code will setup a timer for each > > interrupt injected to the guest that requires an EOI from the guest. > > Such timer would

RE: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-12 Thread Tian, Kevin
> From: Roger Pau Monne > Sent: Wednesday, January 13, 2021 1:33 AM > > Current interrupt pass though code will setup a timer for each > interrupt injected to the guest that requires an EOI from the guest. > Such timer would perform two actions if the guest doesn't EOI the > interrupt before a gi

[PATCH] x86/dpci: remove the dpci EOI timer

2021-01-12 Thread Roger Pau Monne
Current interrupt pass though code will setup a timer for each interrupt injected to the guest that requires an EOI from the guest. Such timer would perform two actions if the guest doesn't EOI the interrupt before a given period of time. The first one is deasserting the virtual line, the second is