On Thu, Jan 14, 2021 at 12:54:22PM +0100, Jan Beulich wrote: > On 12.01.2021 18:32, Roger Pau Monne wrote: > > @@ -967,10 +879,10 @@ static void hvm_pirq_eoi(struct pirq *pirq) > > * since interrupt is still not EOIed > > */ > > if ( --pirq_dpci->pending || > > - !pt_irq_need_timer(pirq_dpci->flags) ) > > + /* When the interrupt source is MSI no Ack should be performed. */ > > + pirq_dpci->flags & HVM_IRQ_DPCI_TRANSLATE ) > > If we settle on this timer being possible to drop, then there's > just one cosmetic issue here (which can be fixed while committing > I suppose) - there is a pair of parentheses missing here.
I will be sending an updated version of this patch in a longer series. I've added the parentheses instead of keeping pt_irq_need_timer, as I would also like to get rid of HVM_IRQ_DPCI_TRANSLATE at some point and then the change here is straightforward to perform. Thanks, Roger.
