Re: [PATCH] MAINTAINERS: add me as an additional stubdom maintainer

2025-07-12 Thread Samuel Thibault
bandwidth (and I have not been actually really working on stubdom since 2008...) Acked-by: Samuel Thibault Samuel

Re: [MINI-OS PATCH v2 1/2] 9pfs: add fstat file operation hook

2025-03-24 Thread Samuel Thibault
Jan Beulich, le lun. 24 mars 2025 11:21:48 +0100, a ecrit: > On 23.03.2025 15:57, Jürgen Groß wrote: > > On 23.03.25 01:01, Samuel Thibault wrote: > >> Juergen Gross, le ven. 21 mars 2025 10:31:44 +0100, a ecrit: > >>> Add a file operations fstat hook to the 9pfs fr

Re: [MINI-OS PATCH v2 1/2] 9pfs: add fstat file operation hook

2025-03-23 Thread Samuel Thibault
Jürgen Groß, le dim. 23 mars 2025 15:57:16 +0100, a ecrit: > On 23.03.25 01:01, Samuel Thibault wrote: > > Juergen Gross, le ven. 21 mars 2025 10:31:44 +0100, a ecrit: > > > Add a file operations fstat hook to the 9pfs frontend. > > > > > > Signed-off-by: Jue

Re: [MINI-OS PATCH 00/12] kexec: add kexec support to Mini-OS

2025-03-22 Thread Samuel Thibault
Hello, Juergen Gross, le ven. 21 mars 2025 10:24:39 +0100, a ecrit: > Add basic kexec support to Mini-OS for running in x86 PVH mode. I am wondering if you had considered using libxc to implement this? The original pv-grub1 is doing it (xen/stubdom/grub/kexec.c) Samuel

Re: [MINI-OS PATCH v2 2/2] 9pfs: add lseek file operation hook

2025-03-22 Thread Samuel Thibault
Juergen Gross, le ven. 21 mars 2025 10:31:45 +0100, a ecrit: > Add a file operations lseek hook to the 9pfs frontend. Just use the > lseek_default() implementation. > > Signed-off-by: Juergen Gross > Reviewed-by: Jason Andryuk Reviewed-by: Samuel Thibault > --- > 9pfr

Re: [MINI-OS PATCH v2 1/2] 9pfs: add fstat file operation hook

2025-03-22 Thread Samuel Thibault
Juergen Gross, le ven. 21 mars 2025 10:31:44 +0100, a ecrit: > Add a file operations fstat hook to the 9pfs frontend. > > Signed-off-by: Juergen Gross > Reviewed-by: Jason Andryuk > --- > V2: > - or file access mode into st_mode (Jason Andryuk) > --- > 9pfront.c | 29 +++

Re: [PATCH v2 7/7] tools/xenstored: use new stable interface instead of libxenctrl

2024-12-08 Thread Samuel Thibault
trl by Xenstore, so update > the library dependencies accordingly. > > For now only do a direct replacement without using the functionality > of obtaining information about domains having changed the state. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault >

Re: [Mini-OS PATCH] Add missing symbol exports for grub-pv

2024-10-29 Thread Samuel Thibault
Natanael Copa > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > arch/x86/mm.c| 1 + > arch/x86/setup.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index 572e762e..3ba6d917 100644 > --- a/arch/x86/m

Re: [MINI-OS PATCH] config: add support for libxenmanage

2024-10-23 Thread Samuel Thibault
s been Acked, > as otherwise it should either be dropped (in case the approach of > adding a new library is being rejected) or changed (in case the name > of the new library needs to be modified)! For the positive case, Reviewed-by: Samuel Thibault > > Config.mk | 2 ++

Re: [PATCH 3/3] stubdom: use real lib dependencies for xenstore stubdoms

2024-10-10 Thread Samuel Thibault
dencies instead. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > stubdom/Makefile | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 6ed4253b25..2a81af28a1 100644 > --- a

Re: [MINI-OS PATCH v2] add config support for each Xen library

2024-10-09 Thread Samuel Thibault
> > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - merge patches of the V1 series (Samuel Thibault) > > Note: do not apply to the tree until the related Xen series > "stubdom: prepare more fine grained Xen library usage" has

Re: [MINI-OS PATCH 2/2] drop CONFIG_XC support

2024-10-08 Thread Samuel Thibault
Hello, Jürgen Groß, le mar. 08 oct. 2024 11:22:11 +0200, a ecrit: > On 08.10.24 00:13, Samuel Thibault wrote: > > Juergen Gross, le lun. 07 oct. 2024 12:34:56 +0200, a ecrit: > > > CONFIG_XC is no longer needed with individual CONFIG_LIBXEN support. > > > > I don&#x

Re: [PATCH 2/4] stubdom: explcitly add libc and lwip Mini-OS config options

2024-10-08 Thread Samuel Thibault
, add > them to the related stubdom Mini-OS config files. > > While at it remove the CONFIG_START_NETWORK setting from config files > disabling lwip, as CONFIG_START_NETWORK requires lwip for becoming > effective. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thib

Re: [PATCH 2/4] stubdom: explcitly add libc and lwip Mini-OS config options

2024-10-08 Thread Samuel Thibault
Jürgen Groß, le mar. 08 oct. 2024 11:18:26 +0200, a ecrit: > On 07.10.24 23:50, Samuel Thibault wrote: > > > diff --git a/stubdom/grub/minios.cfg b/stubdom/grub/minios.cfg > > > index 8df49092cd..5145b357e0 100644 > > > --- a/stubdom/grub/minios.cfg >

Re: [MINI-OS PATCH 2/2] drop CONFIG_XC support

2024-10-07 Thread Samuel Thibault
Juergen Gross, le lun. 07 oct. 2024 12:34:56 +0200, a ecrit: > CONFIG_XC is no longer needed with individual CONFIG_LIBXEN support. I don't really see why in the previous patch you introduced compatibility and here you remove it? Samuel > Remove it, while disabling the CONFIG_LIBXEN items by def

Re: [PATCH 2/4] stubdom: explcitly add libc and lwip Mini-OS config options

2024-10-07 Thread Samuel Thibault
> diff --git a/stubdom/grub/minios.cfg b/stubdom/grub/minios.cfg > index 8df49092cd..5145b357e0 100644 > --- a/stubdom/grub/minios.cfg > +++ b/stubdom/grub/minios.cfg > @@ -1,3 +1,4 @@ > -CONFIG_START_NETWORK=n > +CONFIG_LIBC=y > +CONFIG_LWIP=n > CONFIG_SPARSE_BSS=n > CONFIG_TPMFRONT=y Grub does

Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function

2024-08-20 Thread Samuel Thibault
Jan Beulich, le mar. 20 août 2024 16:17:26 +0200, a ecrit: > On 20.08.2024 13:52, Samuel Thibault wrote: > > Juergen Gross, le mar. 13 août 2024 15:41:56 +0200, a ecrit: > >> In x86 mm code there are multiple instances of page table walks for > >> different purposes. &g

Re: [PATCH v2 3/3] mini-os: mm: convert set_readonly() to use walk_pt()

2024-08-20 Thread Samuel Thibault
You need to set ro->count *after* calling mmu_update. Apart from this, Reviewed-by: Samuel Thibault Samuel

Re: [PATCH v2 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

2024-08-20 Thread Samuel Thibault
Juergen Gross, le mar. 13 août 2024 15:41:57 +0200, a ecrit: > Instead of open coding a page table walk, use walk_pt() in need_pgt(). > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add comment and ASSERT() (Samuel Thibault) > ---

Re: [PATCH v2 1/3] mini-os: mm: introduce generic page table walk function

2024-08-20 Thread Samuel Thibault
, too. > > The page table walker needs some per-level data, so add a table for > that data. Merge it with the already existing pt_prot[] array. > > Rewrite get_pgt() to use the new walker. > > Signed-off-by: Juergen Gross Reviewed-by: SAmuel Thibault > --- > V2

Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

2024-08-01 Thread Samuel Thibault
Jürgen Groß, le jeu. 01 août 2024 11:25:31 +0200, a ecrit: > On 01.08.24 11:15, Samuel Thibault wrote: > > Jürgen Groß, le jeu. 01 août 2024 10:13:07 +0200, a ecrit: > > > On 01.08.24 09:39, Samuel Thibault wrote: > > > > Jürgen Groß, le jeu. 01 août 2024 07:56:3

Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

2024-08-01 Thread Samuel Thibault
Jürgen Groß, le jeu. 01 août 2024 10:13:07 +0200, a ecrit: > On 01.08.24 09:39, Samuel Thibault wrote: > > Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: > > > On 31.07.24 23:27, Samuel Thibault wrote: > > > > Hello, > > > > > > > &g

Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

2024-08-01 Thread Samuel Thibault
Jürgen Groß, le jeu. 01 août 2024 07:56:36 +0200, a ecrit: > On 31.07.24 23:27, Samuel Thibault wrote: > > Hello, > > > > Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: > > > -pgentry_t *need_pgt(unsigned long va) > > > +static int need_pgt_

Re: [PATCH 3/3] mini-os: mm: convert set_readonly() to use walk_pt()

2024-07-31 Thread Samuel Thibault
Juergen Gross, le mer. 31 juil. 2024 15:00:26 +0200, a ecrit: > +static int set_readonly_func(unsigned long va, unsigned int lvl, bool > is_leaf, > + pgentry_t *pte, void *par) > +{ > +struct set_readonly_par *ro = par; > > +mmu_updates[ro->count].ptr = virt_t

Re: [PATCH 1/3] mini-os: mm: introduce generic page table walk function

2024-07-31 Thread Samuel Thibault
Juergen Gross, le mer. 31 juil. 2024 15:00:24 +0200, a ecrit: > +ptindex[lvl] = (va >> ptdata[lvl].shift) & > + (ptdata[lvl].entries - 1); It seems that this kind of va+lvl-to-index computation happens several times? It's probably worth making it a macro. Sam

Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

2024-07-31 Thread Samuel Thibault
Hello, Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit: > -pgentry_t *need_pgt(unsigned long va) > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf, > + pgentry_t *pte, void *par) > { [...] > +if ( lvl == L1_FRAME || (*pte & _PAGE

Re: [PATCH v2] mini-os: put sanity_check() under CONFIG_TEST

2024-07-24 Thread Samuel Thibault
riodic thread of the test app, causing > a sanity check every second. > > Since any application linked with Mini-OS can't call sanity_check() > (there is no EXPORT_SYMBOL for it), there is zero chance of breaking > any use case. > > Signed-off-by: Juergen Gross Revi

Re: [PATCH 4/4] mini-os: remove sanity_check()

2024-07-24 Thread Samuel Thibault
Jürgen Groß, le jeu. 25 juil. 2024 08:25:18 +0200, a ecrit: > On 25.07.24 00:44, Samuel Thibault wrote: > > Hello, > > > > Jürgen Groß, le mar. 23 juil. 2024 08:36:13 +0200, a ecrit: > > > On 22.07.24 23:35, Samuel Thibault wrote: > > > > Juergen Gros

Re: [PATCH 4/4] mini-os: remove sanity_check()

2024-07-24 Thread Samuel Thibault
Hello, Jürgen Groß, le mar. 23 juil. 2024 08:36:13 +0200, a ecrit: > On 22.07.24 23:35, Samuel Thibault wrote: > > Juergen Gross, le lun. 22 juil. 2024 17:01:41 +0200, a ecrit: > > > Remove the sanity_check() function, as it is used nowhere. > > > > > > Since

Re: [PATCH 3/3] mini-os: simplify monotonic_clock()

2024-07-22 Thread Samuel Thibault
s into the main > function and using only a single loop. Further simplify the code by > using struct vcpu_time_info for the local instance instead of defining > a similar structure in the code. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault

Re: [PATCH 2/3] mini-os: remove some not needed stuff from arch/x86/time.c

2024-07-22 Thread Samuel Thibault
Juergen Gross, le lun. 22 juil. 2024 14:16:42 +0200, a ecrit: > Remove unused or not needed stuff from arch/x86/time.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > arch/x86/time.c | 16 > 1 file changed, 16 deletions(-) > &g

Re: [PATCH 1/3] mini-os: apply coding style to arch/x86/time.c

2024-07-22 Thread Samuel Thibault
Juergen Gross, le lun. 22 juil. 2024 14:16:41 +0200, a ecrit: > Apply the preferred coding style to arch/x86/time.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > arch/x86/time.c | 194 +++- > 1 file chan

Re: [PATCH 4/4] mini-os: remove sanity_check()

2024-07-22 Thread Samuel Thibault
Juergen Gross, le lun. 22 juil. 2024 17:01:41 +0200, a ecrit: > Remove the sanity_check() function, as it is used nowhere. > > Since any application linked with Mini-OS can't call sanity_check() > either (there is no EXPORT_SYMBOL for it), there is zero chance of > breaking any use case. Don't we

Re: [PATCH 3/4] mini-os: mm: reduce buddy allocator list administration data

2024-07-22 Thread Samuel Thibault
into one by dropping the pointer array and > using a different list end indicator. > > Add enqueue and dequeue helpers for better readability. > > Change the level member type to unsigned int. > > Signed-off-by: Juergen Gross Rev

Re: [PATCH 2/4] mini-os: mm: remove not needed struct chunk_tail_st

2024-07-22 Thread Samuel Thibault
Juergen Gross, le lun. 22 juil. 2024 17:01:39 +0200, a ecrit: > The struct chunk_tail_st isn't really used other than writing to it. > > Remove it in order to simplify the code. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > mm.c | 20

Re: [PATCH 1/4] mini-os: make mm.c coding style compliant

2024-07-22 Thread Samuel Thibault
t; n) - 1 sets all bits < n. Please keep the alignment of "sets" Apart this nitpick, Reviewed-by: Samuel Thibault Samuel

Re: [PATCH] mini-os: mm: don't have two large arrays of the same kind

2024-07-22 Thread Samuel Thibault
; > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > arch/x86/mm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index be1cf0cf..7ddf16e4 100644 > --- a/arch/x86/mm.c > +++ b/arch/x

Re: {PATCH mini-os] mman: correct m{,un}lock() definitions

2024-06-24 Thread Samuel Thibault
Jan Beulich, le lun. 24 juin 2024 15:34:53 +0200, a ecrit: > From: Charles Arnold > > gcc14 no longer (silently) accepts functions with no return type > specified. > > Signed-off-by: Charles Arnold > Signed-off-by: Jan Beulich Reviewed-by: Samuel Thibault Thanks! >

Re: [PATCH] Mini-OS: add symbol exports for xenstore stubdom

2024-02-28 Thread Samuel Thibault
Juergen Gross, le lun. 26 févr. 2024 09:39:55 +0100, a ecrit: > Xenstore stubdom needs some more symbols exported. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > xenbus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen

Re: [PATCH v8 3/8] stubdom: extend xenstore stubdom configs

2024-02-22 Thread Samuel Thibault
oss > > Reviewed-by: Jason Andryuk > > Samuel, are you fine with this patch? Yes! Acked-by: Samuel Thibault Samuel > > > Juergen > > > --- > > stubdom/xenstore-minios.cfg| 2 +- > > stubdom/xenstorepvh-minios.cfg | 2 +- > > 2 f

Re: [PATCH] Mini-OS: fix 9pfront fix

2024-02-07 Thread Samuel Thibault
Juergen Gross, le mer. 07 févr. 2024 14:49:20 +0100, a ecrit: > There was a typo in the recent 9pfront fix. > > Fixes: b119f0178fd8 ("Mini-OS: fix 9pfs frontend error path") > Reported-by: Julien Grall > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault >

Re: [PATCH] Mini-OS: x86: zero out .bss segment at boot

2024-02-07 Thread Samuel Thibault
Jürgen Groß, le mer. 07 févr. 2024 12:43:03 +0100, a ecrit: > On 07.02.24 12:34, Samuel Thibault wrote: > > Jürgen Groß, le mer. 07 févr. 2024 12:16:44 +0100, a ecrit: > > > On 07.02.24 12:00, Samuel Thibault wrote: > > > > Jürgen Groß, le mer. 07 févr

Re: [PATCH] Mini-OS: x86: zero out .bss segment at boot

2024-02-07 Thread Samuel Thibault
Jürgen Groß, le mer. 07 févr. 2024 12:16:44 +0100, a ecrit: > On 07.02.24 12:00, Samuel Thibault wrote: > > Jürgen Groß, le mer. 07 févr. 2024 11:42:20 +0100, a ecrit: > > > while implementing kexec in Mini-OS. > > > > Oh, nice :D > > > > > For tha

Re: [PATCH] Mini-OS: x86: zero out .bss segment at boot

2024-02-07 Thread Samuel Thibault
Jürgen Groß, le mer. 07 févr. 2024 11:42:20 +0100, a ecrit: > while implementing kexec in Mini-OS. Oh, nice :D > For that I need it for sure. It needs to be done by kexec itself then. Samuel

Re: [PATCH] Mini-OS: x86: zero out .bss segment at boot

2024-02-07 Thread Samuel Thibault
Juergen Gross, le mer. 07 févr. 2024 11:31:38 +0100, a ecrit: > The .bss segment should be zeroed at very early boot. Is that not done by the elf loader of Xen? > While adding the extern declaration of __bss_start for x86, make it > together with the other linker table defined section boundaries

Re: [PATCH v2] Mini-OS: fix 9pfs frontend error path

2024-02-06 Thread Samuel Thibault
> error and potentially having allocated strings. > > Reported-by: Julien Grall > Fixes: 2d1dfccd3aa3 ("Mini-OS: add read and write support to 9pfsfront") > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > V2: > - call free_sta

Re: [PATCH] Mini-OS: fix 9pfs frontend error path

2024-02-06 Thread Samuel Thibault
Jürgen Groß, le mar. 06 févr. 2024 16:37:17 +0100, a ecrit: > On 06.02.24 16:26, Samuel Thibault wrote: > > Juergen Gross, le mar. 06 févr. 2024 07:17:21 +0100, a ecrit: > > > The early error exit in p9_stat() returns without zeroing the p9_stat > > > buffer, resulting

Re: [PATCH] Mini-OS: fix 9pfs frontend error path

2024-02-06 Thread Samuel Thibault
Juergen Gross, le mar. 06 févr. 2024 07:17:21 +0100, a ecrit: > The early error exit in p9_stat() returns without zeroing the p9_stat > buffer, resulting in free() being called with an uninitialized pointer. > > Fix that by doing the zeroing first. This is not coherent with the usual conventions:

Re: [MINIOS PATCH] x86/mm: add EXPORT_SYMBOL() for `pt_base`

2024-01-17 Thread Samuel Thibault
_init': > ungetc.c:(.text+0x43533): undefined reference to `pt_base' > > Signed-off-by: Anthony PERARD Reviewed-by: Samuel Thibault > --- > arch/x86/mm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index 767a5

Re: [PATCH] MAINTAINERS: add me as Mini-OS maintainer

2023-12-13 Thread Samuel Thibault
what ./MAINTAINERS says about the file itself, I think this change > primarily wants approving by you, Samuel, as the only present maintainer. Reviewed-by: Samuel Thibault Thanks! > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -439,8 +439,8 @@ F: xen/test/livepatch/*

Re: [PATCH 3/3] Mini-OS: cleanup hypervisor.c

2023-12-12 Thread Samuel Thibault
ith smp_processor_id() as > elsewhere in the code. > - Replace "if () BUG()" with BUG_ON() in case the condition has no > side effects. > - Drop the unused cpu parameter from the active_evtchns() macro. > > Signed-off-by: Juergen Gross Reviewed-by:

Re: [PATCH 2/3] Mini-OS: drop in_callback variable

2023-12-12 Thread Samuel Thibault
rvisor_callback() that interrupts > are really disabled and crash in case this is not true. That paragraph was for the previous commit ;) > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > hypervisor.c | 6 -- > include/hypervisor.h | 2 -

Re: [PATCH 1/3] Mini-OS: call event handlers always with interrupts off

2023-12-12 Thread Samuel Thibault
place the evtchn_upcall_mask test in unmask_evtchn() with the more > appropriate irqs_disabled() test. > > As a precaution add a test to do_hypervisor_callback() that interrupts > are really disabled and crash in case this is not true. > > Signed-off-by: Juergen Gross Reviewed-by:

Re: [PATCH v3 28/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmback.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:19 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to tpmback.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > tpmback.c | 11 +++ > 1 file changed,

Re: [PATCH v3 27/32] Mini-OS: add EXPORT_SYMBOL() instances to pcifront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:18 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to pcifront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > pcifront.c | 11 ++- > 1 file c

Re: [PATCH v3 24/32] Mini-OS: add EXPORT_SYMBOL() instances to blkfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:15 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to blkfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > blkfront.c | 12 +--- > 1 file

Re: [PATCH v3 31/32] Mini-OS: add EXPORT_SYMBOL() instances to xenbus.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:22 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to xenbus.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > xenbus.c | 23 +++ > 1

Re: [PATCH v3 23/32] Mini-OS: add EXPORT_SYMBOL() instances to 9pfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:14 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to 9pfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > 9pfront.c | 2 ++ > 1 file changed, 2 inse

Re: [PATCH v3 32/32] Mini-OS: hide all symbols not exported via EXPORT_SYMBOLS()

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:23 +0100, a ecrit: > When doing the final linking of the Mini-OS kernel only keep the > symbols visible which have been marked via EXPORT_SYMBOL(). > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- >

Re: [PATCH v3 25/32] Mini-OS: add EXPORT_SYMBOL() instances to fbfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:16 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to fbfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > fbfront.c | 11 ++- > 1 file changed, 1

Re: [PATCH v3 29/32] Mini-OS: add EXPORT_SYMBOL() instances to tpmfront.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:20 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to tpmfront.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > tpmfront.c | 6 ++ > 1 file changed, 6 inse

Re: [PATCH v3 00/32] Mini-OS: hide mini-os internal symbols

2023-11-27 Thread Samuel Thibault
tpm_tis.c I didn't receive the mails for those, but I went to the list archive, and here it is for them: Reviewed-by: Samuel Thibault Samuel

Re: [PATCH v3 11/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/ctype.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:02 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/ctype.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/ctype.c | 2 ++ > 1 file changed, 2 inse

Re: [PATCH v3 20/32] Mini-OS: add EXPORT_SYMBOL() instances to lock.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:11 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lock.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lock.c | 9 - > 1 file changed,

Re: [PATCH v3 14/32] Mini-OS: add EXPORT_SYMBOL() instances to main.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:05 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to main.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > main.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH v3 13/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xs.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:04 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/xs.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/xs.c | 10 ++ > 1 file changed, 10 in

Re: [PATCH v3 21/32] Mini-OS: add EXPORT_SYMBOL() instances to time.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:12 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to time.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/arm/time.c | 1 + > arch/x86/time.c |

Re: [PATCH v3 16/32] Mini-OS: add EXPORT_SYMBOL() instances to events.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:07 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to events.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > events.c | 7 +++ > 1 file changed, 7 inse

Re: [PATCH v3 15/32] Mini-OS: add EXPORT_SYMBOL() instances to console.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:06 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to console.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > console.c | 5 + > 1 file changed, 5 inse

Re: [PATCH v3 06/32] Mini-OS: add EXPORT_SYMBOL() instances to mm.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:57 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to mm.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/arm/mm.c | 2 ++ > arch/x86/mm.c | 5 + >

Re: [PATCH v3 18/32] Mini-OS: add EXPORT_SYMBOL() instances to gnttab.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:09 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to gnttab.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > gnttab.c | 6 ++ > 1 file changed, 6 inse

Re: [PATCH v3 17/32] Mini-OS: add EXPORT_SYMBOL() instances to gntmap.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:08 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to gntmap.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > gntmap.c | 5 + > 1 file changed, 5 inse

Re: [PATCH v3 10/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/printf.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:01 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/printf.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/printf.c | 10 +- > 1 file

Re: [PATCH v3 12/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/xmalloc.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:03 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/xmalloc.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/xmalloc.c | 3 +++ > 1 file changed

Re: [PATCH v3 08/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/string.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:59 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/string.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/string.c | 18 ++ > 1

Re: [PATCH v3 09/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/math.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:25:00 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/math.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/math.c | 6 ++ > 1 file changed, 6 inse

Re: [PATCH v3 07/32] Mini-OS: add EXPORT_SYMBOL() instances to lib/sys.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:58 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to lib/sys.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > lib/sys.c | 92

Re: [PATCH v3 05/32] Mini-OS: add EXPORT_SYMBOL() instances to sched.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:56 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to sched.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > arch/x86/sched.c | 5 + > sched.c | 7

Re: [PATCH v3 04/32] Mini-OS: add EXPORT_SYMBOL() instances to hypervisor.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:55 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to hypervisor.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > hypervisor.c | 5 + > 1 file changed

Re: [PATCH v3 02/32] Mini-OS: explicitly mark symbols to be visible for apps

2023-11-27 Thread Samuel Thibault
symbol names. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > .gitignore | 1 + > Makefile | 3 ++- > include/export.h | 10 ++ > include/lib.h| 1 + > 4 files changed, 14 insertions(+)

Re: [PATCH v3 03/32] Mini-OS: add EXPORT_SYMBOL() instances to kernel.c

2023-11-27 Thread Samuel Thibault
Juergen Gross, le lun. 27 nov. 2023 11:24:54 +0100, a ecrit: > Add the needed instances of EXPORT_SYMBOL() to kernel.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V3: > - new patch > --- > kernel.c | 5 + > 1 file changed, 5 inse

Re: [RFC PATCH] Mini-OS: explicitly mark symbols to be visible for apps

2023-11-25 Thread Samuel Thibault
symbol names. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > Based on top of my previous series "Mini-OS: hide mini-os internal > symbols". > This is a RFC as an alternative to the map file containing all > visible symbol names. It would

Re: [PATCH v2 2/2] Mini-OS: keep a positive list of externally visible symbols

2023-11-25 Thread Samuel Thibault
s Reviewed-by: Samuel Thibault Thanks! > --- > V2: > - added more symbols (Samuel Thibault) > - sorted symbols in each section alphabetically > --- > Makefile| 3 +- > mini-os.map | 295 > 2 files changed, 297

Re: [PATCH v3 5/5] Mini-OS: fix 9pfs response receiving

2023-11-21 Thread Samuel Thibault
layer") > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault Thanks! > --- > V2: > - new patch > --- > 9pfront.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/9pfront.c b/9pfront.c > index 43c7409f..35c5552b 100644

Re: [PATCH v3 2/5] Mini-OS: get own domid

2023-11-21 Thread Samuel Thibault
Juergen Gross, le mar. 21 nov. 2023 10:49:50 +0100, a ecrit: > Get the own domid via creation of a temporary event channel. There is > no "official" way to read the own domid in PV guests, so use the event > channel interface to get it: > > - allocate an unbound event channel specifying DOMID_SELF

Re: [PATCH 2/2] Mini-OS: keep a positive list of externally visible symbols

2023-11-02 Thread Samuel Thibault
Hello, Juergen Gross, le mer. 01 nov. 2023 16:35:51 +0100, a ecrit: > The symbols in mini-os.map have been obtained via building all defined > and not failing stubdoms (caml-stubdom doesn't build). > > +++ b/mini-os.map > @@ -0,0 +1,187 @@ > +# Mini-OS symbols being externally visible > +# entry

Re: [PATCH 1/2] Mini-OS: link kernel separately

2023-11-02 Thread Samuel Thibault
an application. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault thanks! > --- > Makefile | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 7ee181a2..85c6db75 100644 > --- a/Makefile > +++ b/Makef

Re: [PATCH v1] stubdom: fix errors in newlib:makedoc

2023-04-26 Thread Samuel Thibault
../../../../newlib-1.16.0/newlib/doc/makedoc.c:1147 > > Signed-off-by: Olaf Hering Reviewed-by: Samuel Thibault Thanks! > --- > > Depends on newlib-cygmon-gmon.patch > > stubdom/Makefile | 1 + > stubdom/newlib-makedoc.patch | 35

Re: [PATCH v1] stubdom: fix errors in newlib:cygmon-gmon.c

2023-04-26 Thread Samuel Thibault
#include . > - Implicit *recv* functions need #include . > E: xen implicit-fortify-decl > ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:119 > > I: Program returns random data in a function > E: xen no-return-in-nonvoid-function > ../../../../newlib-1.16.0/libgloss

Re: [PATCH v3 0/7] Mini-OS: add minimal 9pfs support

2023-02-13 Thread Samuel Thibault
orting the 9P2000.u variant, > as qemu doesn't support the basic 9P2000 protocol). > > The needed fixed values of the protocol have been taken from [2]. > > [1]: http://ericvh.github.io/9p-rfc/rfc9p2000.html > [2]: https://github.com/0intro/libixp > > Changes in V2:

Re: [PATCH v3 7/7] Mini-OS: add read and write support to 9pfsfront

2023-02-13 Thread Samuel Thibault
Juergen Gross, le lun. 13 févr. 2023 09:44:12 +0100, a ecrit: > Add support to read from and write to a file handled by 9pfsfront. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add check for max message size > - return EAGAIN in case no fre

Re: [PATCH v3 6/7] Mini-OS: add open and close handling to the 9pfs frontend

2023-02-13 Thread Samuel Thibault
Juergen Gross, le lun. 13 févr. 2023 09:44:11 +0100, a ecrit: > Add the open() and close() support to the 9pfs frontend. This requires > to split the path name and to walk to the desired directory level. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- >

Re: [PATCH v2 7/7] Mini-OS: add read and write support to 9pfsfront

2023-02-10 Thread Samuel Thibault
Juergen Gross, le ven. 10 févr. 2023 11:46:28 +0100, a ecrit: > +while ( len ) > +{ > +count = len; > +if ( count > dev->msize_max - 24 ) > +count = dev->msize_max - 24; 24 should be detailed, to include e.g. sizeof(p9_header) and the sum of sizes of the fields

Re: [PATCH v2 6/7] Mini-OS: add open and close handling to the 9pfs frontend

2023-02-10 Thread Samuel Thibault
Juergen Gross, le ven. 10 févr. 2023 11:46:27 +0100, a ecrit: > +static bool path_canonical(const char *pathname) > +{ > +unsigned int len = strlen(pathname); > +const char *c; > + > +/* Empty path is allowed. */ > +if ( !len ) > +return true; > + > +/* No trailing '/'.

Re: [PATCH v2 5/7] Mini-OS: add 9pfs transport layer

2023-02-10 Thread Samuel Thibault
sts of the 9pfs > protocol when mounting a new 9pfs device. For the version use the > "9P2000.u" variant, as it is the smallest subset supported by the qemu > based backend. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add more comm

Re: [PATCH v2 4/7] Mini-OS: add 9pfs frontend

2023-02-10 Thread Samuel Thibault
ility to access files) the whole code is guarded > by "#ifdef HAVE_LIBC". > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - add better error handling to version parsing (Samuel Thibault) > --- > 9pfront.c | 28

Re: [PATCH v2 2/7] Mini-OS: add concept of mount points

2023-02-10 Thread Samuel Thibault
e/lib.h, as it is missing > today. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - pass path below mount point to open callbacks (Samuel Thibault) > --- > include/lib.h | 9 ++ > lib/sys.c | 80 +++--

Re: [PATCH v2 1/7] Mini-OS: xenbus: add support for reading node from directory

2023-02-10 Thread Samuel Thibault
: Juergen Gross Reviewed-by: Samuel Thibault > --- > V2: > - check sscanf() return value (Samuel Thibault) > --- > include/xenbus.h | 6 ++ > xenbus.c | 40 +--- > 2 files changed, 43 insertions(+), 3 deletions(-) > &g

Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts

2023-02-10 Thread Samuel Thibault
Juergen Gross, le ven. 10 févr. 2023 13:14:20 +0100, a ecrit: > On 10.02.23 12:43, Andrew Cooper wrote: > > On 10/02/2023 10:46 am, Juergen Gross wrote: > > > diff --git a/lib/sys.c b/lib/sys.c > > > index 2f33c937..dc8a8c69 100644 > > > --- a/lib/sys.c > > > +++ b/lib/sys.c > > > @@ -339,7 +339,14

Re: [PATCH 7/7] Mini-OS: add read and write support to 9pfsfront

2023-02-06 Thread Samuel Thibault
Juergen Gross, le lun. 06 févr. 2023 11:17:27 +0100, a ecrit: > On 06.02.23 11:13, Samuel Thibault wrote: > > > > Juergen Gross, le ven. 03 févr. 2023 10:18:09 +0100, a ecrit: > > > This patch is missing the limitation of read/write messages to stay > > > belo

  1   2   3   4   >