sage).
>
> Either Stefano or I can deal with the change on commit.
Thank you so much for your detailed patch review.
BR
Paran Lee
Reuse mask variables on order shift duplicated calculation.
Signed-off-by: Paran Lee
---
xen/arch/arm/p2m.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1d1059f7d2..cdb3b56aa1 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen
0x1
1c30: 9a941034cselx20, x1, x20, ne // ne = any
while ( nr )
1c34: eb1302b5subsx21, x21, x19
1c38: 540001e0b.eq1c74 // b.none
I'll send you a follow-up patch I've been working on.
BR
Paran Lee
2022-04-25 오전 1:17에
It doesn't seem necessary to do that
duplicated calculation of mfn to addr and l4 table index
in the copy_mapping loop.
Signed-off-by: Paran Lee
---
xen/common/efi/boot.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/xen/common/efi/boot.c b/xen/common/efi/b
ables is unsigned long.
Signed-off-by: Paran Lee
---
xen/common/page_alloc.c | 51 ++---
1 file changed, 27 insertions(+), 24 deletions(-)
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 319029140f..9a955ce84e 100644
--- a/xen/common/page_al
It doesn't seem necessary to do duplicate ternary operation and calculation
of order shift using fdt32_to_cpu macro.
Signed-off-by: Paran Lee
---
xen/arch/arm/bootfdt.c | 12 ++--
xen/common/libfdt/fdt.c | 10 +-
2 files changed, 15 insertions(+), 7 deletions(-)
diff --
It doesn't seem necessary to do that calculation of order shift again.
Signed-off-by: Paran Lee
---
xen/arch/arm/p2m.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 1d1059f7d2..533afc830a 100644
--- a/xen/arc
symbol
information.
BR,
Paran Lee
2022-04-20 오전 2:31에 Julien Grall 이(가) 쓴 글:
> Hi,
>
> On Tue, 19 Apr 2022, 17:09 Paran Lee, wrote:
>
>> Debugging with GDB from head.S with QEMU runtime was very convenient for
>> analysis(linux). so I have trying it in Xen. As I built
Debugging with GDB from head.S with QEMU runtime was very convenient for
analysis(linux). so I have trying it in Xen. As I built it.
Wouldn't it be helpful if I fixed the code little by little?
2022-04-20 오전 1:31에 Paran Lee 이(가) 쓴 글:
> Hi, Julien Grall.
>
> Thank you for checki
^~~~
arch/arm/setup.c:989:5: note: in expansion of macro ‘for_each_present_cpu’
989 | for_each_present_cpu ( i )
| ^~~~ ^
Thank you!
2022-04-20 오전 12:50에 Julien Grall 이(가) 쓴 글:
> Hi,
>
> On Tue, 19 Apr 2022, 15:41 Paran Lee, wro
GCC with "-g -Wall -Wextra" option throws warning message as below:
error: comparison of integer expressions of different signedness:
‘int’ and ‘unsigned int’ [-Werror=sign-compare]
Silence the warning by correcting the integer type.
Signed-off-by: Paran Lee
---
xen/common/device_t
GCC with "-g -Wall -Wextra" option throws warning message as below:
error: comparison of integer expressions of different signedness:
‘int’ and ‘unsigned int’ [-Werror=sign-compare]
Silence the warning by correcting the integer type.
Signed-off-by: Paran Lee
---
xen/arch/arm/gi
12 matches
Mail list logo
