Re: [Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-12 Thread Nicholas Tsirakis
oned memory page). Got it, thanks for that clarification and for all your help! --Niko On Thu, Dec 12, 2019 at 9:21 AM Jürgen Groß wrote: > > On 12.12.19 15:10, Nicholas Tsirakis wrote: > >> And I think this is the problem. W

Re: [Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-12 Thread Nicholas Tsirakis
ith me. Do you happen to know the answer to my second question? It's not as important, but it does confuse me as I wouldn't expect the total memory to be balloon-able at all with the hotplugging configs disabled. --Niko On Thu, Dec 12, 2019 at 2:18 AM Jürgen Groß wrote: > > On 1

[Xen-devel] [BUG] Xen-ballooned memory never returned to domain after partial-free

2019-12-11 Thread Nicholas Tsirakis
Hello, The issue I'm seeing is that pages of previously-xenballooned memory are getting trapped in the balloon on free, specifically when they are free'd in batches (i.e. not all at once). The first batch is restored to the domain properly, but subsequent frees are not. Truthfully I'm not sure if

[Xen-devel] [PATCH] argo: suppress select logging messages

2019-06-18 Thread Nicholas Tsirakis
Some logging messages made more sense as argo debug logs rather than standard Xen logs. Use argo_dprintk to only print this info if argo DEBUG is enabled. Signed-off-by: Nicholas Tsirakis --- xen/common/argo.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/xen

Re: [Xen-devel] [PATCH v3 2/2] argo: correctly report pending message length

2019-06-12 Thread Nicholas Tsirakis
On Wed, Jun 12, 2019 at 8:47 AM Andrew Cooper wrote: > > On 12/06/2019 13:34, Nicholas Tsirakis wrote: > > When a message is requeue'd in Xen's internal queue, the queue > > entry contains the length of the message so that Xen knows to > > send a VIRQ to the r

[Xen-devel] [PATCH v3 2/2] argo: correctly report pending message length

2019-06-12 Thread Nicholas Tsirakis
ven write fails, so this length is always reported as zero. This causes Xen to spurriously wake up a domain even when the ring doesn't have enough space. This patch makes sure that the msg len is properly reported by populating it in the event of a write failure. Signed-off-by: Nicholas Tsira

[Xen-devel] [PATCH v2 2/2] argo: correctly report pending message length

2019-06-11 Thread Nicholas Tsirakis
ven write fails, so this length is always reported as zero. This causes Xen to spurriously wake up a domain even when the ring doesn't have enough space. This patch makes sure that the msg len is properly reported by populating it in the event of a write failure. Signed-off-by: Nicholas Tsira

[Xen-devel] [PATCH v2 1/2] argo: warn sendv() caller when ring is full

2019-06-11 Thread Nicholas Tsirakis
time. Instead, capture the -EAGAIN value returned from ringbuf_insert() and *only* overwrite it if the rc of pending_requeue() is non-zero. This allows the caller to make intelligent decisions on -EAGAIN and still be alerted if the pending message fails to requeue. Signed-off-by: Nicholas Tsirakis

Re: [Xen-devel] [PATCH 2/2] argo: correctly report pending message length

2019-06-11 Thread Nicholas Tsirakis
On Tue, Jun 11, 2019 at 2:49 PM Christopher Clark wrote: > > On Tue, Jun 11, 2019 at 10:11 AM Nicholas Tsirakis > wrote: > > > > When a message is requeue'd in Xen's internal queue, the queue > > entry contains the length of the message so that Xen knows

[Xen-devel] [PATCH 2/2] argo: correctly report pending message length

2019-06-11 Thread Nicholas Tsirakis
ven write fails, so this length is always reported as zero. This causes Xen to spurriously wake up a domain even when the ring doesn't have enough space. This patch makes sure that the msg len is properly reported by populating it in the event of a write failure. Signed-off-by: Nicholas Tsira

[Xen-devel] [PATCH 1/2] argo: warn sendv() caller when ring is full

2019-06-11 Thread Nicholas Tsirakis
time. Instead, capture the -EAGAIN value returned from ringbuf_insert() and *only* overwrite it if the rc of pending_requeue() is non-zero. This allows the caller to make intelligent decisions on -EAGAIN and still be alerted if the pending message fails to requeue. Signed-off-by: Nicholas Tsirakis