Re: [PATCH 12/26] block: remove blk_flush_policy

Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

ristoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Damien Le Moal > Reviewed-by: Hannes Reinecke Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 09/26] virtio_blk: remove virtblk_update_cache_mode

sche > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Damien Le Moal > Reviewed-by: Hannes Reinecke > Reviewed-by: Johannes Thumshirn Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 02/26] sd: remove sd_is_zoned

inecke > Reviewed-by: Johannes Thumshirn Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 09/11] nvme: remove a spurious clear of discard_alignment

On 4/17/22 21:53, Christoph Hellwig wrote: > The nvme driver never sets a discard_alignment, so it also doens't need > to clear it to zero. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 03/11] null_blk: don't set the discard_alignment queue limit

> > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 08/11] loop: remove a spurious clear of discard_alignment

On 4/17/22 21:53, Christoph Hellwig wrote: > The loop driver never sets a discard_alignment, so it also doens't need s/doens't/doesn't/ > to clear it to zero. > > Signed-off-by: Christoph Hellwig Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

> Reviewed-by: Martin K. Petersen > Acked-by: Christoph Böhmwalder [drbd] > Acked-by: Ryusuke Konishi [nifs2] > Acked-by: Jaegeuk Kim [f2fs] > Acked-by: Coly Li [bcache] > Acked-by: David Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

avid Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 23/27] block: add a bdev_max_discard_sectors helper

mirrors what is done e.g. for write zeroes as well. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Christoph Böhmwalder [drbd] > Acked-by: Coly Li [bcache] > Acked-by: David Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 22/27] block: refactor discard bio size limiting

On 4/14/22 21:52, Christoph Hellwig wrote: > Move all the logic to limit the discard bio size into a common helper > so that it is better documented. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > Acked-by: Coly Li > --- Looks good. Reviewed-b

Re: [PATCH 16/27] block: use bdev_alignment_offset in part_alignment_offset_show

> > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen > --- Neat! Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 15/27] block: add a bdev_max_zone_append_sectors helper

; Reviewed-by: Martin K. Petersen > Reviewed-by: Johannes Thumshirn > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 14/27] block: add a bdev_stable_writes helper

good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 13/27] block: add a bdev_fua helper

On 4/14/22 21:52, Christoph Hellwig wrote: > Add a helper to check the FUA flag based on the block_device instead of > having to poke into the block layer internal request_queue. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen Looks good. Reviewed-by: Cha

Re: [PATCH 12/27] block: add a bdev_write_cache helper

vid Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 11/27] block: add a bdev_nonrot helper

vid Sterba [btrfs] > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile

On 4/14/22 21:52, Christoph Hellwig wrote: > Use the bdev based helper instead of poking into the queue. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 08/27] btrfs: use bdev_max_active_zones instead of open coding it

On 4/14/22 21:52, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > Reviewed-by: Johannes Thumshirn > Acked-by: David Sterba > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 03/27] target: fix discard alignment on partitions

Petersen > --- Helper does handle the case for of partition. Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 02/27] target: pass a block_device to target_configure_unmap_from_queue

looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 01/27] target: remove an incorrect unmap zeroes data deduction

> fallocate to punch holes. > > Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to > blkdev_issue_zeroout") > Signed-off-by: Christoph Hellwig > Reviewed-by: Martin K. Petersen Not a good assumption to have for sure. Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

by: Dongli Zhang > --- Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH] xen-blkback: remove redundant assignment to variable i

.c:934:14: warning: Although the value > stored to 'i' is used in the enclosing expression, the value is never > actually read from 'i' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Looks good. Reviewed-by: Chaitanya Kulkarni -ck

Re: [PATCH 19/19] block: pass a block_device and opf to bio_reset

ctoring some nasty code. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 18/19] block: pass a block_device and opf to bio_init

uest_queue and > to temporarily avoid refactoring some nasty code. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 17/19] block: pass a block_device and opf to bio_alloc

o temporarily avoid > refactoring some nasty code. > > Also move the gfp_mask argument after the nr_vecs argument for a much > more logical calling convention matching what most of the kernel does. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 16/19] block: pass a block_device and opf to bio_alloc_kiocb

On 1/17/22 11:19 PM, Christoph Hellwig wrote: > Pass the block_device and operation that we plan to use this bio for to > bio_alloc_kiocb to optimize the assigment. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 15/19] block: pass a block_device and opf to bio_alloc_bioset

e nasty code. > > Also move the gfp_mask argument after the nr_vecs argument for a much > more logical calling convention matching what most of the kernel does. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 14/19] block: pass a block_device and opf to blk_next_bio

On 1/17/22 11:19 PM, Christoph Hellwig wrote: > All callers need to set the block_device and operation, so lift that into > the common code. > > Signed-off-by: Christoph Hellwig > --- I sent out the exact patch for this one, anyways looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 13/19] block: move blk_next_bio to bio.c

On 1/17/22 11:19 PM, Christoph Hellwig wrote: > Keep blk_next_bio next to the core bio infrastructure. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 5/7] fat: use sync_blockdev_nowait

On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > Use sync_blockdev_nowait instead of opencoding it. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 1/7] fs: remove __sync_filesystem

On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > There is no clear benefit in having this helper vs just open coding it. > > Signed-off-by: Christoph Hellwig Especially if there is only one caller. Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 6/7] ntfs3: use sync_blockdev_nowait

On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > Use sync_blockdev_nowait instead of opencoding it. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 4/7] btrfs: use sync_blockdev

On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > Use sync_blockdev instead of opencoding it. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 3/7] xen-blkback: use sync_blockdev

On 10/18/2021 11:25 PM, Christoph Hellwig wrote: > Use sync_blockdev instead of opencoding it. > > Signed-off-by: Christoph Hellwig > --- Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 20/30] nullb: use blk_mq_alloc_disk

On 6/1/21 23:56, Christoph Hellwig wrote: > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/null_blk/main.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --

Re: [PATCH 18/30] loop: use blk_mq_alloc_disk and blk_cleanup_disk

On 6/1/21 23:56, Christoph Hellwig wrote: > Use blk_mq_alloc_disk and blk_cleanup_disk to simplify the gendisk and > request_queue allocation. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 15/30] blk-mq: remove blk_mq_init_sq_queue

On 6/1/21 23:55, Christoph Hellwig wrote: > All users are gone now. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [PATCH 03/30] blk-mq: add the blk_mq_alloc_disk APIs

itialization calls and respective error handling in each blk-mq based drivers. Looks good. Reviewed-by: Chaitanya Kulkarni

Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

On 2/17/21 14:03, Pavel Machek wrote: > Hi! >> diff --git a/kernel/power/swap.c b/kernel/power/swap.c >> index c73f2e295167..e92e36c053a6 100644 >> --- a/kernel/power/swap.c >> +++ b/kernel/power/swap.c >> @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t >> page_off, vo

Re: [RFC PATCH 02/34] block: introduce and use bio_new

On 1/27/21 11:27 PM, Damien Le Moal wrote: + + bio_set_dev(bio, bdev); + bio->bi_iter.bi_sector = sector; + bio_set_op_attrs(bio, op, op_flags); This function is obsolete. Open code this. And that also mean that you could remove one argument to bio_new(): combine op and op_fl

Re: [RFC PATCH 02/34] block: introduce and use bio_new

On 1/27/21 11:21 PM, Damien Le Moal wrote: On 2021/01/28 16:12, Chaitanya Kulkarni wrote: Introduce bio_new() helper and use it in blk-lib.c to allocate and initialize various non-optional or semi-optional members of the bio along with bio allocation done with bio_alloc(). Here we also calmp

[RFC PATCH 34/34] mm: add swap_bio_new common bio helper

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 7579485ccb5e..cc30c9a0b0a7 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -287,6 +287,17 @@ static void

[RFC PATCH 31/34] iomap: use bio_new in iomap_readpage_actor

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/buffered-io.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 16a1e82e3aeb..08d119b62cf5 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c

[RFC PATCH 33/34] mm: use bio_new in swap_readpage

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 25b321489703..7579485ccb5e 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -342,7 +342,7 @@ int __swap_writepage(struct page *page

[RFC PATCH 19/34] fs/jfs/jfs_logmgr.c: use bio_new in lbmRead

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 9330eff210e0..4481f3e33a3f 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1979,17 +1979,14

[RFC PATCH 32/34] mm: use bio_new in __swap_writepage

Signed-off-by: Chaitanya Kulkarni --- mm/page_io.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 92f7941c6d01..25b321489703 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -342,10 +342,8 @@ int __swap_writepage(struct page *page

[RFC PATCH 30/34] hfsplus: use bio_new in hfsplus_submit_bio()

Signed-off-by: Chaitanya Kulkarni --- fs/hfsplus/wrapper.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c index 0350dc7821bf..8341ee6c9b31 100644 --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus/wrapper.c @@ -64,10 +64,7 @@ int

[RFC PATCH 28/34] zonefs: use bio_new

Signed-off-by: Chaitanya Kulkarni --- fs/zonefs/super.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index ab68e27bb322..620d67965a22 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -661,6 +661,7 @@ static const struct

[RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io

Signed-off-by: Chaitanya Kulkarni --- kernel/power/swap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kernel/power/swap.c b/kernel/power/swap.c index c73f2e295167..e92e36c053a6 100644 --- a/kernel/power/swap.c +++ b/kernel/power/swap.c @@ -271,13 +271,12 @@ static

[RFC PATCH 27/34] xfs: use bio_new in xfs_buf_ioapply_map

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_buf.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index f8400bbd6473..3ff6235e4f94 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map

[RFC PATCH 26/34] xfs: use bio_new in xfs_rw_bdev

Signed-off-by: Chaitanya Kulkarni --- fs/xfs/xfs_bio_io.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c index e2148f2d5d6b..e4644f22ebe6 100644 --- a/fs/xfs/xfs_bio_io.c +++ b/fs/xfs/xfs_bio_io.c @@ -26,11 +26,8

[RFC PATCH 25/34] ocfs/cluster: use bio_new in dm-log-writes

Signed-off-by: Chaitanya Kulkarni --- fs/ocfs2/cluster/heartbeat.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 0179a73a3fa2..b34518036446 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2

[RFC PATCH 24/34] fs/nilfs: use bio_new nilfs_alloc_seg_bio

Signed-off-by: Chaitanya Kulkarni --- fs/nilfs2/segbuf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c index 1e75417bfe6e..df352cab7a93 100644 --- a/fs/nilfs2/segbuf.c +++ b/fs/nilfs2/segbuf.c @@ -383,15 +383,9 @@ static

[RFC PATCH 23/34] fs/mpage.c: use bio_new mpage_alloc

Signed-off-by: Chaitanya Kulkarni --- fs/mpage.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/mpage.c b/fs/mpage.c index 830e6cc2a9e7..01725126e81f 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -68,25 +68,21 @@ static struct bio *mpage_bio_submit(int

[RFC PATCH 22/34] fs/jfs/jfs_metapage.c: use bio_new in metapage_readpage

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_metapage.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 3fa09d9a0b94..c7be3a2773bf 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -495,13 +495,11

[RFC PATCH 21/34] fs/jfs/jfs_metapage.c: use bio_new in metapage_writepage

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_metapage.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index 176580f54af9..3fa09d9a0b94 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -416,12 +416,11

[RFC PATCH 20/34] fs/jfs/jfs_logmgr.c: use bio_new in lbmStartIO

Signed-off-by: Chaitanya Kulkarni --- fs/jfs/jfs_logmgr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 4481f3e33a3f..bb25737d52f6 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -2121,16 +2121,14 @@ static

[RFC PATCH 18/34] iomap: use bio_new in iomap_dio_bio_actor

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/direct-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f6c557a1bd25..0737192f7e5c 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -267,9 +267,8

[RFC PATCH 17/34] iomap: use bio_new in iomap_dio_zero

Signed-off-by: Chaitanya Kulkarni --- fs/iomap/direct-io.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index ea1e8f696076..f6c557a1bd25 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -189,15 +189,13

[RFC PATCH 16/34] fs/direct-io: use bio_new in dio_bio_alloc

Signed-off-by: Chaitanya Kulkarni --- fs/crypto/bio.c | 2 +- fs/direct-io.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c index 20dab9bdf098..28cd62ce853e 100644 --- a/fs/crypto/bio.c +++ b/fs/crypto/bio.c @@ -148,7 +148,7 @@ int

[RFC PATCH 15/34] fscrypt: use bio_new in fscrypt_zeroout_range

Signed-off-by: Chaitanya Kulkarni --- fs/crypto/bio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c index b048a0e38516..20dab9bdf098 100644 --- a/fs/crypto/bio.c +++ b/fs/crypto/bio.c @@ -148,12 +148,11 @@ int fscrypt_zeroout_range

[RFC PATCH 14/34] fs/buffer: use bio_new in submit_bh_wbc

Signed-off-by: Chaitanya Kulkarni --- fs/buffer.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 32647d2011df..fcbea667fa04 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -3023,12 +3023,16 @@ static int submit_bh_wbc(int op

[RFC PATCH 13/34] block: use bio_new in __blkdev_direct_IO

Signed-off-by: Chaitanya Kulkarni --- fs/block_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 9d4b1a884d76..f3e3247894d7 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -367,6 +367,8 @@ __blkdev_direct_IO(struct kiocb

[RFC PATCH 12/34] scsi: target/iblock: use bio_new

Signed-off-by: Chaitanya Kulkarni --- drivers/target/target_core_iblock.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 8ed93fd205c7..f1264918aee1 100644 --- a/drivers/target

[RFC PATCH 11/34] nvmet: use bio_new in nvmet_bdev_execute_rw

Signed-off-by: Chaitanya Kulkarni --- drivers/nvme/target/io-cmd-bdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index bf6e0ac9ad28..f5fd93a796a6 100644 --- a/drivers/nvme/target/io-cmd

[RFC PATCH 10/34] dm-zoned: use bio_new in dmz_rdwr_block

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index fa0ee732c6e9..5b5ed5fce2ed 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b

[RFC PATCH 09/34] dm-zoned: use bio_new in dmz_write_mblock

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index e6252f48a49c..fa0ee732c6e9 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b

[RFC PATCH 07/34] dm: use bio_new in dm-log-writes

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-log-writes.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index e3d35c6c9f71..7ca9af407647 100644 --- a/drivers/md/dm-log-writes.c

[RFC PATCH 08/34] dm-zoned: use bio_new in get_mblock_slow

Signed-off-by: Chaitanya Kulkarni --- drivers/md/dm-zoned-metadata.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 039d17b28938..e6252f48a49c 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b

[RFC PATCH 06/34] zram: use bio_new

Signed-off-by: Chaitanya Kulkarni --- drivers/block/zram/zram_drv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index d7018543842e..5d744e528d4f 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers

[RFC PATCH 05/34] xen-blkback: use bio_new

Create a wrapper on the tio of the bio_new() named get_new_bio() & use it in the dispatch_rw_block_io(). p Signed-off-by: Chaitanya Kulkarni --- drivers/block/xen-blkback/blkback.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/block/xen-blk

[RFC PATCH 04/34] drdb: use bio_new() in submit_one_flush

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index e1cd3427b28b..b86bbf725cbd 100644 --- a/drivers/block/drbd

[RFC PATCH 03/34] drdb: use bio_new in drdb

Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 09c86ef3f0fd..e1cd3427b28b 100644 --- a/drivers/block/drbd

[RFC PATCH 02/34] block: introduce and use bio_new

: Chaitanya Kulkarni --- block/blk-lib.c | 6 +- include/linux/bio.h | 25 + 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index fb486a0bdb58..ec29415f00dd 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -14,17

[RFC PATCH 01/34] block: move common code into blk_next_bio()

blk_next_bio() to reduce the duplication. In the next patch we introduce bio_new(), this prepration patch allows us to call it inside blk_next_bio(). Signed-off-by: Chaitanya Kulkarni --- block/blk-lib.c | 36 +++- block/blk-zoned.c | 4 +--- block/blk.h | 5

[RFC PATCH 00/34] block: introduce bio_new()

and gfp_mask by encapsulating new bio allocation with bio alloc with initialization at one place. The objective of this RFC is to only start a discussion, this it not completely tested at all. -ck Chaitanya Kulkarni (34): block: move common code into blk_next_bio

[Xen-devel] [COMPILE TESTED PATCH V5 9/9] xen/blkback: use helper in vbd_sz()

This patch updates the vbd_sz() macro with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Acked-by: Roger Pau Monné Signed-off-by: Chaitanya Kulkarni --- drivers/block/xen-blkback/common.h | 2 +- 1 file chang

[Xen-devel] [PATCH V5 6/9] f2fs: use helper in init_blkz_info()

This patch updates the init_blkz_info() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Xen-devel] [COMPILE TESTED PATCH V5 8/9] target/pscsi: use helper in pscsi_get_blocks()

This patch updates the pscsi_get_blocks() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- drivers/target/target_core_pscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Xen-devel] [PATCH V5 7/9] blktrace: use helper in blk_trace_setup_lba()

This patch updates the blk_trace_setup_lba() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- kernel/trace/blktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Xen-devel] [PATCH V5 4/9] blk-zoned: update blkdev_reset_zones() with helper

This patch updates the blkdev_reset_zones() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Reviewed-by: Minwoo Im Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 4 ++-- 1 file changed, 2 insertions(

[Xen-devel] [PATCH V5 5/9] bcache: update cached_dev_init() with helper

he help of part_nr_sects_read(). Acked-by: Coly Li Signed-off-by: Chaitanya Kulkarni --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 20ed838e9413..79c848fa5912 100644 --- a/drivers/md/bcache/sup

[Xen-devel] [PATCH V5 2/9] blk-zoned: update blkdev_nr_zones() with helper

This patch updates the blkdev_nr_zones() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help if part_nr_sects_read(). Reviewed-by: Minwoo Im Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 2 +- 1 file changed, 1 insertion(

[Xen-devel] [PATCH V5 0/9] block: use right accessor to read nr_sects

t_nr_sects_read() and removes the all direct accesses to the bdev->hd_part->nr_sects. This series is based on :- 1. Repo :- git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git. 2. Branch :- for-next. Changes from V4:- 1. Adjust code for latest branch. Chaitanya Kulkarn

[Xen-devel] [PATCH V5 1/9] block: add a helper function to read nr_setcs

This patch introduces helper function to read the number of sectors from struct block_device->bd_part member. For more details Please refer to the comment in the include/linux/genhd.h for part_nr_sects_read(). Reviewed-by: Minwoo Im Reviewed-by: Martin K. Petersen Signed-off-by: Chaita

[Xen-devel] [PATCH V5 3/9] blk-zoned: update blkdev_report_zone() with helper

This patch updates the blkdev_report_zone(s)() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Reviewed-by: Minwoo Im Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 6 +++--- 1 file changed, 3 inser

Re: [Xen-devel] [PATCH V4 1/9] block: add a helper function to read nr_setcs

On 7/11/19 6:59 PM, Martin K. Petersen wrote: > Hi Chaitanya, > >> +static inline sector_t bdev_nr_sects(struct block_device *bdev) >> +{ >> +return part_nr_sects_read(bdev->bd_part); >> +} > Can bdev end up being NULL in any of the call sites? > > Otherwise no objections. > Thanks for mentioni

[Xen-devel] [PATCH V4 8/9] target/pscsi: use helper in pscsi_get_blocks()

This patch updates the pscsi_get_blocks() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- drivers/target/target_core_pscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Xen-devel] [PATCH V4 9/9] xen/blkback: use helper in vbd_sz()

This patch updates the vbd_sz() macro with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- drivers/block/xen-blkback/common.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[Xen-devel] [PATCH V4 4/9] blk-zoned: update blkdev_reset_zones() with helper

This patch updates the blkdev_reset_zones() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Xen-devel] [PATCH V4 5/9] bcache: update cached_dev_init() with helper

he help of part_nr_sects_read(). Acked-by: Coly Li Signed-off-by: Chaitanya Kulkarni --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 26e374fbf57c..024c52d11b0f 100644 --- a/drivers/md/bcache/sup

[Xen-devel] [PATCH V4 6/9] f2fs: use helper in init_blkz_info()

This patch updates the init_blkz_info() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Xen-devel] [PATCH V4 0/9] block: use right accessor to read nr_sects

in the 1st patch for helper. (Bart) Chaitanya Kulkarni (9): block: add a helper function to read nr_setcs blk-zoned: update blkdev_nr_zones() with helper blk-zoned: update blkdev_report_zone() with helper blk-zoned: update blkdev_reset_zones() with helper bcache: update cached_dev_init

[Xen-devel] [PATCH V4 7/9] blktrace: use helper in blk_trace_setup_lba()

This patch updates the blk_trace_setup_lba() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- kernel/trace/blktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Xen-devel] [PATCH V4 1/9] block: add a helper function to read nr_setcs

This patch introduces helper function to read the number of sectors from struct block_device->bd_part member. For more details Please refer to the comment in the include/linux/genhd.h for part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- include/linux/blkdev.h | 5 + 1 f

[Xen-devel] [PATCH V4 3/9] blk-zoned: update blkdev_report_zone() with helper

This patch updates the blkdev_report_zone(s)() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help of part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Xen-devel] [PATCH V4 2/9] blk-zoned: update blkdev_nr_zones() with helper

This patch updates the blkdev_nr_zones() with newly introduced helper function to read the nr_sects from block device's hd_parts with the help if part_nr_sects_read(). Signed-off-by: Chaitanya Kulkarni --- block/blk-zoned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Xen-devel] [PATCH V3 1/9] block: add a helper function to read nr_setcs

On 7/3/19 8:03 AM, Bart Van Assche wrote: +} Is the comment above bdev_nr_sects() really useful or should it be left out? Thanks, Bart. Sure, let me send V4 without the comment. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lis

  1   2   >