On 4/14/22 21:52, Christoph Hellwig wrote: > For block devices, the SCSI target drivers implements UNMAP as calls to > blkdev_issue_discard, which does not guarantee zeroing just because > Write Zeroes is supported. > > Note that this does not affect the file backed path which uses > fallocate to punch holes. > > Fixes: 2237498f0b5c ("target/iblock: Convert WRITE_SAME to > blkdev_issue_zeroout") > Signed-off-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>
Not a good assumption to have for sure. Looks good. Reviewed-by: Chaitanya Kulkarni <k...@nvidia.com> -ck