On Fri, Mar 07, 2025 at 01:33:42PM +, Andrew Cooper wrote:
> A few blank lines go a very long way.
>
> Signed-off-by: Andrew Cooper
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
ed-by: Edgar E. Iglesias
> Signed-off-by: Stefano Stabellini
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Feb 07, 2025 at 02:37:24PM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Block devices don't work in PV Grub (0.9x) if there is no mode specified. It
> complains: "Error ENOENT when reading the mode"
>
> Signed-off-by: David Woodhouse
Rev
On Thu, Feb 27, 2025 at 04:10:25PM +0100, Jürgen Groß wrote:
> On 26.02.25 16:55, Anthony PERARD wrote:
> > On Tue, Feb 25, 2025 at 08:30:33AM +0100, Juergen Gross wrote:
> > > Channels work differently than other device types: their devid should
> > > be -1 initially i
#x27;'''''''''''''''''''''''''''''''''''''
> +
> +Untested for more than 4 years.
Well, not quite, we used to have some test of Xen on armhf hosts
(one of arndale or cubietrunk, I don't remember which one we had to stop
and never start testing again) until last year, and that included tests
with qcow2 disk, so using QEMU.
But that testing infra is gone so the patch is fine:
Reviewed-by: Anthony PERARD
Cheers,
--
Anthony PERARD
On Tue, Feb 18, 2025 at 05:26:17PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Tue, Feb 18, 2025 at 05:26:16PM +0100, Philippe Mathieu-Daudé wrote:
> Have "hw/xen/xen-bus" include the bare minimal set of headers.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
> hw/i386/xen/xen-hvm.c:492:15: error: ‘R_EAX’ undeclared (first use in this
> function)
> 492 | env->regs[R_EAX] = req->data;
> | ^
> | REG_RAX
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
d set by `xl` was probably ignored. I think before,
the console devid would be taken from libxl__init_console_from_channel()
parametters, so the first devnum would be `0+1`, so never 0.
Do you agree?
In anycase:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP
-1;
> +
You can use ARRAY_EXTEND_INIT_NODEVID() instead which doesn't touch
`devid` and let the value set by libxl_device_channel_init().
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
make reviewing the new style harder).
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
trl by Xenstore, so update
> the library dependencies accordingly.
>
> For now only do a direct replacement without using the functionality
> of obtaining information about domains having changed the state.
>
> Signed-off-by: Juergen Gross
> Reviewed-by: Samuel Thibault
gt; Coverity-ID: 1638727
> Coverity-ID: 1638728
> Fixes: c458c404da16 ("xl: use libxl_domain_info to get the uuid in
> printf_info")
> Fixes: 48dab9767d2e ("tools/xl: use libxl_domain_info to get domain type for
> vcpu-pin")
> Signed-off-by: Jan Beulich
> Rele
ot;)
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
s: e4ad2836842a ("xentrace: Implement cpu mask range parsing of human
> values (-c)")
> Signed-off-by: Jan Beulich
Acked-by: Anthony PERARD
Thanks,
--
| Vates
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
check, with ERRP_GUARD() macro `errp` is
never NULL.
> +error_free(*errp);
After this, I think you still need
*errp = NULL;
> +}
> +if (number) {
> +cd = serial_hd(number);
> +if (!cd) {
> +error_setg(errp,
ce-s...')
> Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> Signed-off-by: Roger Pau Monné
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
aving to do so for themselves (and
> from using xs_node_scanf() with the non-portable %ms format string.
>
> Signed-off-by: David Woodhouse
> [remove double newline and constify trace parameters]
> Signed-off-by: Roger Pau Monné
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:24AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Now that xs_node_read() can construct a node path, no need to open-code it.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:26AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:25AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Now that xs_node_read() can construct a node path, no need to open-code it.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:23AM +, David Woodhouse wrote:
> From: David Woodhouse
>
> Reduce some duplication.
>
> Signed-off-by: David Woodhouse
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony PERARD
or_prepend()` and use
`error_setg` instead when `serial_hd()` fails.
> +if (output) {
> /*
> * FIXME: sure we want to support implicit
> * muxed monitors here?
Thanks,
--
Anthony PERARD
very other function use "${node}/${key}" (As explain in the
comment above xs_node_vscanf()), but this one uses a printf format in
`node_fmt` (which could probably better be named `path_fmt` instead).
Otherwise, patch looks fine to me.
Cheers,
--
Anthony PERARD
On Thu, Jan 09, 2025 at 03:39:20PM +, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
"type", errp, "%ms", &type) != 1) {
> +node_path = g_strdup_printf("%s/type", fe);
> +type = qemu_xen_xs_read(xsh, XBT_NULL, node_path, NULL);
> +g_free(node_path);
I feel like we want "xs_node_read()" which would be similair to
xs_node_vscanf() but would simply return the result of
qemu_xen_xs_read(). This would avoid the need format of the node path in
several place in the code. But it's OK like that as well.
Cheers,
--
Anthony PERARD
ber) {
> cd = serial_hd(number);
> if (!cd) {
> -error_prepend(errp, "console: No serial device #%ld found: ",
> +error_setg(errp, "console: No serial device #%ld found: ",
>number);
This change looks correct, ableit we could remove ": " from the end of
the string since they shouldn't be anything after it.
Cheers,
--
Anthony PERARD
On Wed, Jan 08, 2025 at 12:43:16PM +, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
_device.c
> @@ -392,7 +392,6 @@ static int disk_try_backend(disk_try_backend_args *a,
> return 0;
>
> }
> -abort(); /* notreached */
>
> bad_format:
> LOG(DEBUG, "Disk vdev=%s, backend %s unsuitable due to format %s",
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
pository was not applied from
> qemu-xen-4.18.0.
>
> Signed-off-by: James Dingwall
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
And remove the
> > misleading comment (from lack of better ideas).
> >
> > Signed-off-by: Marek Marczykowski-Górecki
>
> Reviewed-by: Roger Pau Monné
>
> I assumed I already RB this, but it seems not.
>
> Could we get an Ack from the tools or libs maintainer for this to go
> in? It's not the best solution, but we need to get this sorted in
> time for 4.20, and backport to stable branches.
Acked-by: Anthony PERARD
Thanks,
--
| Vates
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
loc_autofree() it seems,
which is called by atexit().
So, shouldn't `xm_handle` by handle with talloc like the others?
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
ssary? Isn't xencall_alloc_buffer() going to set `errno`? Or
is it to overwrite `errno` set by system calls which could be other than
ENOMEM?
> + return -1;
> +}
Otherwise, patch looks fine to me: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
ense-Identifier: LGPL-2.1 */
That's a deprecated SPDX identifier, it should be written
"LGPL-2.1-only" instead.
With that fixed: Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
On Tue, Dec 10, 2024 at 07:17:30AM +, Chen, Jiqian wrote:
> On 2024/11/19 00:05, Anthony PERARD wrote:
> > On Wed, Nov 06, 2024 at 02:14:18PM +0800, Jiqian Chen wrote:
> >> In PVH dom0, when passthrough a device to domU, QEMU code
> >> xen_pt_realize->xc_physdev_
llini
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 026aa25a53..34ad49bc39 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -662,8 +662,11 @@ K: \b(xsm|XSM)\b
>
> THE REST
> M: Andrew Cooper
> +M: Anthony PERARD
> +M: Michal Orzel
> M: J
d equivalent of "sleep"-ing a host, it's better to
> suspend/resume than to pause/unpause a domain.
>
> Suggested-by: Andrew Cooper
> Suggested-by: Marek Marczykowski-Górecki
> Signed-off-by: Cyril Rébert (zithro)
> Signed-off-by: Jason Andryuk
Reviewed-b
; documentation.
> The parameter is defined as a list of strings that represent the color
> ranges.
>
> Documentation is also added.
>
> Based on original work from: Luca Miccio
>
> Signed-off-by: Carlo Nonato
> Signed-off-by: Marco Solieri
Reviewed-by: Anthony PER
ing toolchain, I don't think $(llvm) or $(clang) should be
used in the build system, and instead rely on autodetection for
arguments. (There's already $(CONFIG_CC_IS_CLANG) and
$(CONFIG_LD_IS_LLVM) in the hypervisor's build system, via Kconfig)
At least for the hypervisor. For t
ykowski-Górecki
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
y() is going to work.
It looks like it only depends on the hypervisor. I can't find any logic
that would treat Arm differently, besides the presence of
LIBXL_HAVE_NO_SUSPEND_RESUME.
But best bet would be to hide those four functions when
LIBXL_HAVE_NO_SUSPEND_RESUME is defined.
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
our suspended domain which
> will end up continuously re-triggering.
>
> Signed-off-by: Jason Andryuk
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
gt; + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; If not, see
> <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef XENBARRIER_H
> +#define XENBARRIER_H
With an extra '_' for the '-' in the header f
On Fri, Nov 22, 2024 at 04:12:25PM +0100, Jürgen Groß wrote:
> On 22.11.24 14:55, Anthony PERARD wrote:
> > On Wed, Oct 23, 2024 at 03:10:03PM +0200, Juergen Gross wrote:
> > > diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h
> > > new file mode 10
gger that 64, but
it would probably not work well anyway seen how `config.rsdp` is used
here.
Reviewed-by: Anthony PERARD
> ---
> Similarly bounding the info "page" allocation would be nice, but would
> require knowing libacpi's struct acpi_info size here.
Or reg
27;t if the
explanation is correct, but at least now the same value is used for both
zmalloc() and .lenght.
> Fixes: 14c0d328da2b ("libxl/acpi: Build ACPI tables for HVMlite guests")
> Signed-off-by: Jan Beulich
Reviewed-by: Anthony PERARD
> ---
> Yet better might be to limit
On Fri, Nov 22, 2024 at 01:12:24PM +, Alejandro Vallejo wrote:
> On Thu Nov 21, 2024 at 5:47 PM GMT, Anthony PERARD wrote:
> > On Fri, Nov 15, 2024 at 11:51:29AM +, Alejandro Vallejo wrote:
> > > This series is the result of my "Interfacing Rust with Xen&quo
t; +ret = xencall1(hdl->xcall, __HYPERVISOR_domctl, (unsigned long)buf);
> + saved_errno = errno;
> +if ( !ret )
> +{
> +st = &buf->u.get_domain_state;
You could define *st here.
struct xen_domctl_get_domain_state *st = &...;
Or even with ".. *const st" but maybe that's not common enough in C
code.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
rated versions
> Patch 15. xen/arm: Replace hand-crafted xen_arch_domainconfig with
> autogenerated one
I feel like you write "hand-crafted" in those patch description as if it
is a bad thing. Yet, you replace the hand-crafted C headers by
hand-crafted IDL. I think a better title could be "Translate
xen_arch_domainconfig into IDL" to avoid what I feel like is a
pejorative term.
Also, would it be possible to separate changes to the existing API from
the patch that introduce the newly generated headers? I think it would
be much easier to review that the generated headers don't introduce
any changes over the current one.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
s/golang/xenlight/types.gen.go
Running this following command should be enough, even if you don't have
golang installed.
make -C tools/golang/xenlight helpers.gen.go types.gen.go
If you send an update of the patch series, it would be nice to include
the regenerated files.
Cheers,
--
A
ffer_alloc() should
already have set `errno`, and PERROR() preserves it.
> +goto out;
> +}
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
On Tue, Nov 19, 2024 at 01:47:16PM -0800, Stefano Stabellini wrote:
> On Tue, 19 Nov 2024, Anthony PERARD wrote:
> > Rebuild rolling release containers when XEN_CI_REBUILD_CONTAINERS is
> > set. This is to be use with a scheduled pipeline.
> >
> > Signed-off-by: Antho
This allow to change the registry used for container in a single
place, and could be controlled via other mean.
Signed-off-by: Anthony PERARD
Reviewed-by: Stefano Stabellini
---
.gitlab-ci.yml | 3 +++
automation/gitlab-ci/build.yaml | 4 ++--
automation/gitlab-ci/test.yaml
Also, this prevent using "rules", like in the ".test-jobs-common"
template.
https://docs.gitlab.com/ee/ci/yaml/#only--except
Signed-off-by: Anthony PERARD
Reviewed-by: Stefano Stabellini
---
automation/gitlab-ci/test.yaml | 15 ++-
1 file changed, 6 insert
setup a scheduled pipeline on GitLab which
would rebuild containers.
To enable this, just running a pipeline with XEN_CI_REBUILD_CONTAINERS=1 will
do.
I intend to add a scheduled pipeline to run once a month.
Thanks,
Anthony PERARD (3):
CI: Remove deprecated "only:variables" i
Rebuild rolling release containers when XEN_CI_REBUILD_CONTAINERS is
set. This is to be use with a scheduled pipeline.
Signed-off-by: Anthony PERARD
---
Notes:
v2:
- remove the logic to test containers once rebuilt.
- only include the config with jobs for the "containers"
: Huang Rui
> Signed-off-by: Jiqian Chen
Acked-by: Anthony PERARD
But, this following change probably needs an ack from PCI maintaners,
CCed.
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index eb26cac81098..07805aa8a5f3 100644
> --- a/include/hw/pci/pci.h
> +++
On Fri, Nov 15, 2024 at 04:34:21PM -0800, Stefano Stabellini wrote:
> On Fri, 15 Nov 2024, Anthony PERARD wrote:
> > Rebuild rolling release containers when XEN_CI_REBUILD_CONTAINERS is
> > set. This is to be use with a scheduled pipeline.
> >
> > When $XEN_CI_REBU
On Fri, Nov 15, 2024 at 05:13:13PM +, Andrew Cooper wrote:
> On 15/11/2024 5:07 pm, Anthony PERARD wrote:
> > Patch series available in this git branch:
> > https://xenbits.xenproject.org/git-http/people/aperard/xen-unstable.git
> > br.gitlab-ci-rebuild-arch-co
Also, this prevent using "rules", like in the ".test-jobs-common"
template.
https://docs.gitlab.com/ee/ci/yaml/#only--except
Signed-off-by: Anthony PERARD
---
automation/gitlab-ci/test.yaml | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/
should
wait for the container to be rebuild. If it's a normal pipeline, those
dependency are simply ignored.
Signed-off-by: Anthony PERARD
---
.gitlab-ci.yml | 2 +
automation/gitlab-ci/build.yaml | 57 ++--
automation/gitlab-ci/containers
This allow to change the registry used for container in a single
place, and could be controlled via other mean.
Signed-off-by: Anthony PERARD
---
.gitlab-ci.yml | 3 +++
automation/gitlab-ci/build.yaml | 4 ++--
automation/gitlab-ci/test.yaml | 2 +-
3 files changed, 6
(the container is
updated even if the test fail, but at least we can find out about it sooner
rather than later).
To enable this, just running a pipeline with XEN_CI_REBUILD_CONTAINERS=1 will
do.
I intend to add a scheduled pipeline to run once a month.
Thanks,
Anthony PERARD (3):
CI: Remove
bout it:
https://lists.xenproject.org/mailman/listinfo/wg-toolstack
wg-toolst...@lists.xenproject.org
And I've created a GitLab project where we can share more, use issue
or other features:
https://gitlab.com/xen-project/collab/wg-toolstack-refactoring
And at some point, we should have regular mee
ow over the weekend or explore Grenoble's
local culture.
Please don't hesitate to reach out for any additional information.
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
nprintf(path, sizeof(path), "/local/pool/%d/name", poolid);
>
> Acked-by: Andrew Cooper
>
> Although I have a minor preference for sizeof() as suggested by Frediano.
I have a preference for sizeof() too, we even used it this way (more or
less) in libxl before, for `eom`
uot;ENV VAR value" is supported, it's been discouraged by
docker's doc (https://docs.docker.com/reference/dockerfile/#env). Also,
here we have two ENV instructions with two different syntax, could you
use the = for declaring CROSS_COMPILE as well?
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
ere's a few option in Make and shell:
$(if $(filter y,$(debug)),y,n)
$$([ "$(debug)" = y ] && echo y || echo n)
$$(case "$(debug)" in y) echo y;; *) echo n;; esac)
For the $(filter ) option, if one does `debug='y no' make` the $(if )
will expand t
07:00 then 08:00 UTC)
and will take a few hours on those dates:
- 2024-10-23: mail.xenproject.org
- 2024-10-24: wiki.xenproject.org
- 2024-10-28: xenbits.xenproject.org
Cheers,
--
Anthony PERARD
to the new naming scheme.
>
> Signed-off-by: Andrew Cooper
> Signed-off-by: Javi Merino
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
-by: Javi Merino
The patch description could be removed, so:
Reviewed-by: Anthony PERARD
Thanks,
> ---
> automation/build/README.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/automation/build/README.md b/automation/build/README.md
> index bd0c0e
ot; and "offset" to be the other way around,
but that's fine. And by the way, -DFINAL cancel changes to GAP and
TEXT_DIFF ;-).
But overall, the changes looks nice as is,
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
On Wed, Oct 16, 2024 at 04:05:00PM +0100, Frediano Ziglio wrote:
> On Wed, Oct 16, 2024 at 12:25 PM Anthony PERARD >
> wrote:
> > On Wed, Oct 16, 2024 at 09:33:32AM +0100, Frediano Ziglio wrote:
> > > On Tue, Oct 15, 2024 at 2:51 PM Anthony PERARD
> > >
On Wed, Oct 16, 2024 at 09:33:32AM +0100, Frediano Ziglio wrote:
> On Tue, Oct 15, 2024 at 2:51 PM Anthony PERARD
> wrote:
> > On Mon, Oct 14, 2024 at 05:32:26PM +0100, Frediano Ziglio wrote:
> > > On Mon, Oct 14, 2024 at 4:31 PM Anthony PERARD
> > > wrote:
>
.o
> +
> +nocov-y += $(obj32) $(obj64)
> +noubsan-y += $(obj32) $(obj64)
> +targets += $(obj32) $(obj64)
Technically, the change to $(targets) isn't necessary, $(obj-bin-y)
should already be added to it.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
On Mon, Oct 14, 2024 at 05:32:26PM +0100, Frediano Ziglio wrote:
> On Mon, Oct 14, 2024 at 4:31 PM Anthony PERARD
> wrote:
> >
> > On Mon, Oct 14, 2024 at 09:53:28AM +0100, Frediano Ziglio wrote:
> > > diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Make
his program. If not, see <http://www.gnu.org/licenses/>.
> */
>
> -ENTRY(_start)
> +#ifdef FINAL
> +# define GAP 0
> +# define MULT 0
> +# define TEXT_START
> +#else
> +# define GAP 0x010200
> +# define MULT 1
> +# define TEXT_START 0x408020
> +#endif
> +# define DECLARE_IMPORT(name) name = . + (__LINE__ * MULT)
Is ^ this a stray space?
Overall, it's kind of mostly style comment that I had, so feel free to
ignore most of them.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
On Thu, Oct 10, 2024 at 05:54:58PM +0200, Juergen Gross wrote:
> Today the xenstored Makefile contains an unneeded reference to the
> not used libxenguest library.
>
> Remove it.
>
> Signed-off-by: Juergen Gross
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Per
pull in others, the config files need to be
> extended at build time to reflect those indirect library uses.
>
> Signed-off-by: Juergen Gross
> ---
> V2:
> - rename BUILD_config to GEN_CONFIG (Anthony PERARD)
> - rename generated config files to *.gen.cfg (Anthony PERARD)
&g
ore a path to a QEMU to use.
We don't really have a name space for CI variable, but maybe
BUILD_QEMU or BUILD_QEMU_XEN would be less likely to clash with other
usages.
Otherwise patch looks fine.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
Reviewed-by: Roger Pau Monné
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
quot; is more common for the kind of file that are
automatically generated by the build system for it's own use.
BTW, in the first prerequisite, $(CURDIR) isn't necessary anymore, it
was only to be used in "MINIOS_CONFIG" just below.
> + $(BUILD_config)
> +
> +ioemu-mi
;
> Signed-off-by: Juergen Gross
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
mmit in its description in the Xen repo.
> Signed-off-by: Juergen Gross
In any case all looks fine:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
can fit in build's oneliner, so break it
> out into a proper script.
>
> Signed-off-by: Andrew Cooper
The changes on the gitlab side look fine. I don't know if the changes on
the cirrus side are ok, but at least the seems to work, after looking at
the build logs. So:
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
gering -Wstrict-prototypes.
>
> Link: https://build.opensuse.org/request/show/1178775
> Signed-off-by: Andrew Cooper
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
221f2748e8da ("blkif: reconcile protocol specification with in-use
implementations")
Signed-off-by: Anthony PERARD
---
xen/include/public/io/blkif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 9b00d
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
br.blkif-wording-fix-v1
Cheers,
Anthony PERARD (2):
blkif: Fix alignment description for discard request
blkif: Fix a couple of typos
xen/include/public/io/blkif.h | 6 +++---
1
Those where fixed in OVMF's copy. (And one of them fixed in QEMU's
copy but later discarded by an update.)
Signed-off-by: Anthony PERARD
---
xen/include/public/io/blkif.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/include/public/io/blkif.h b/xen/incl
Signed-off-by: Anthony PERARD
---
include/hw/xen/interface/io/blkif.h | 52 +
1 file changed, 39 insertions(+), 13 deletions(-)
diff --git a/include/hw/xen/interface/io/blkif.h
b/include/hw/xen/interface/io/blkif.h
index 22f1eef0c0..9b00d633d3 100644
--- a/include
org/gitweb/?p=xen.git;a=commit;h=221f2748e8dabe8361b8cdfcffbeab9102c4c899
This update the header and the backend.
Thanks,
Anthony PERARD (2):
include: update Xen public headers io/blkif.h
hw/block/xen-block: Update sector-size handling
hw/block/dataplane/xen-block.c | 31 +
02c4c899
So change QEMU to follow the updated specification.
Frontends that exposes "feature-large-sector-size" will most certainly
misbehave if "sector-size" is different than 512, so don't even try.
(Windows driver is likely to be the only one having impl
hould be aligned to it. See "discard-granularity" and
note 4.
> */
> struct blkif_request_discard {
> uint8_toperation;/* BLKIF_OP_DISCARD */
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
nused since 2018's
> 6d7c06c213 ("Remove broken Xen PV domain builder")
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert
Acked-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
* based despite the logical sector size exposed in 'sector-size'.
> > > > *
> > > > * physical-sector-size
> > > > * Values:
> > > > @@ -254,8 +258,8 @@
> > > > * sectors
> > > > * Valu
his issue, use the another hypercall
> XEN_DOMCTL_gsi_permission to grant the permission of irq(
> translate from gsi) to dumU when dom0 has no PIRQs.
>
> Signed-off-by: Jiqian Chen
> Signed-off-by: Huang Rui
> Signed-off-by: Chen Jiqian
Reviewed-by: Anthony PERARD
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
be written in leaf makefile
(probably for the best). Since there's nothing to install for
x86_emulate, it doesn't depends on the "all" rule. So only "osstest" is
going to build the tests.
Cheers,
--
Anthony PERARD
; xenstore node, see 'Backend
> Device
> + * Properties' section.
> */
> struct blkif_request_segment {
Textually (that is without reading it) this comment seems to only apply
to `struct blkif_request_segment`. There is an other comment that
separate it from `struct blkif_request` (and it is far away from
blkif_request_discard and blkif_request_indirect). For `struct
blkif_request.sector_number`, the only comment is "start sector idx on
disk" but it's really hard to tell how to interpret it, it could be
interpreted as a "sector-size" quantity because that the size of a
sector on the disk, the underlying storage.
So, I think we need to change the comment of
`blkif_request.sector_number`.
Another thing, there's a "type" `blkif_sector_t` defined at the beginning
of the file, would it be worth it to add a description to it?
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
ader have a different definition for "sectors" ...
Well, the specification doesn't match with the specification ... and the
only possible way to implement the specification is to only ever set
"sector-size" to 512...
No wonder that they are so many different interpretation of the
protocol.
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
q_gsi(CTX->xch, domid, gsi, &pirq);
> +if (r < 0) {
> +LOGED(ERROR, domid, "xc_physdev_map_pirq_gsi gsi=%d ret=%d", gsi, r);
`r` should be -1, I don't think loggin it is useful..
> +return ERROR_FAIL;
> +}
> +
> +r = xc_domain_g
1 - 100 of 2155 matches
Mail list logo
