On Mon, Oct 14, 2024 at 09:53:29AM +0100, Frediano Ziglio wrote: > diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile > index 23ad274c89..ca258a9729 100644 > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -1,12 +1,16 @@ > obj-bin-y += head.o > obj-bin-y += built_in_32.o > +obj-bin-y += $(obj64)
Could you move this so $(obj64) is fully set when added to $(obj-bin-y)? There's no garanties that this is going to keep working. We already have "obj-y :=", so it is possible we will have "obj-bin-y :=" one day. (Or that we get rid of $(obj-bin-y) because it becomes unnecessary.) > obj32 := cmdline.32.o > obj32 += reloc.32.o > +obj32 += reloc-trampoline.32.o > > -nocov-y += $(obj32) > -noubsan-y += $(obj32) > -targets += $(obj32) > +obj64 := reloc-trampoline.o > + > +nocov-y += $(obj32) $(obj64) > +noubsan-y += $(obj32) $(obj64) > +targets += $(obj32) $(obj64) Technically, the change to $(targets) isn't necessary, $(obj-bin-y) should already be added to it. Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech
