Re: [PATCH] xen: Don't cast away const-ness in vcpu_show_registers()

2025-03-04 Thread Jan Beulich
On 03.03.2025 17:52, Andrew Cooper wrote: > On 26/02/2025 7:33 am, Jan Beulich wrote: >> On 26.02.2025 00:02, Andrew Cooper wrote: >>> The final hunk is `(struct vcpu *)v` in disguise, expressed using a runtime >>> pointer chase through memory and a technicality of the C type system to work >>> aro

Re: [PATCH] RISCV/bitops: Use Zbb to provide arch-optimised bitops

2025-03-04 Thread Jan Beulich
On 28.02.2025 17:24, Andrew Cooper wrote: > On 27/02/2025 8:11 am, Jan Beulich wrote: >> On 26.02.2025 18:20, Andrew Cooper wrote: >>> --- a/xen/arch/riscv/include/asm/bitops.h >>> +++ b/xen/arch/riscv/include/asm/bitops.h >>> @@ -125,6 +125,13 @@ static inline void clear_bit(int nr, volatile void

Re: [PATCH v2 2/2] xen/arm: mpu: Ensure that the page size is 4KB

2025-03-04 Thread Orzel, Michal
On 04/03/2025 18:57, Ayan Kumar Halder wrote: > Similar to commit (d736b6eb451b, "xen/arm: mpu: Define Xen start address for > MPU systems"), one needs to add a build assertion to ensure that the page size > is 4KB on arm32 based systems as well. > The existing build assertion is moved under "xe

Re: [PATCH v2 1/2] xen/arm: mpu: Move some of the definitions to common file

2025-03-04 Thread Orzel, Michal
On 04/03/2025 18:57, Ayan Kumar Halder wrote: > For AArch32, refer to ARM DDI 0568A.c ID110520. > MPU_REGION_SHIFT is same between AArch32 and AArch64 (HPRBAR). > Also, NUM_MPU_REGIONS_SHIFT is same between AArch32 and AArch64 > (HMPUIR). > > Signed-off-by: Ayan Kumar Halder > Reviewed-by: Luc

[PATCH v2 0/5] x86/IDT: Generate the IDT at build time

2025-03-04 Thread Andrew Cooper
This is a chunk of the FRED work split out because it's pretty self contained. It's mostly cleanup/refactoring, although patch traps.c is already overly large and going to get larger with FRED, so I'm splitting traps-setup.c out of it, as the two have reasonably-different logic. That's implemente

Re: [PATCH] xen/console: make console buffer size configurable

2025-03-04 Thread Denis Mukhin
On Friday, February 21st, 2025 at 2:13 PM, Marek Marczykowski-Górecki wrote: > > > On Fri, Feb 21, 2025 at 08:52:47PM +, Denis Mukhin wrote: > > > Also, since there's a build-time configuration parameter along with the > > boot-time > > configuration, perhaps it makes sense to retire boo

Re: [PATCH] xen/console: make console buffer size configurable

2025-03-04 Thread Denis Mukhin
On Monday, February 24th, 2025 at 2:44 AM, Jan Beulich wrote: > > > On 21.02.2025 21:52, Denis Mukhin wrote: > > > On Tuesday, February 18th, 2025 at 8:05 AM, Jan Beulich jbeul...@suse.com > > wrote: > > > > > On 12.02.2025 23:31, dm...@proton.me wrote: > > > > > > > --- a/xen/drivers/char

[PATCH v2] xen/console: make console buffer size configurable

2025-03-04 Thread dmkhn
Add new CONRING_SHIFT Kconfig parameter to specify the boot console buffer size as a power of 2. The supported range is [14..27] -> [16KiB..128MiB]. Set default to 15 (32 KiB). Link: https://gitlab.com/xen-project/xen/-/issues/185 Signed-off-by: Denis Mukhin --- Changes v1->v2: - Switched to us

Re: [PATCH] xen/console: make console buffer size configurable

2025-03-04 Thread Denis Mukhin
On Monday, February 24th, 2025 at 11:23 PM, Jan Beulich wrote: > > > On 25.02.2025 03:45, Denis Mukhin wrote: > > > On Monday, February 24th, 2025 at 2:44 AM, Jan Beulich jbeul...@suse.com > > wrote: > > > > > On 21.02.2025 21:52, Denis Mukhin wrote: > > > > > > > On Tuesday, February 18th

Re: [PATCH] MISRA: Rephrase the deviation for Directive 4.10

2025-03-04 Thread Stefano Stabellini
On Tue, 4 Mar 2025, Andrew Cooper wrote: > The use of "legitimately" mixes the concepts of "it was designed to do this" > and "it was correct to do this". > > The latter in particular can go stale. "intended" is a better way of phrasing > this. > > No functional change. > > Signed-off-by: Andre

[PATCH v2 5/5] x86/traps: Convert pv_trap_init() to being an initcall

2025-03-04 Thread Andrew Cooper
With most of pv_trap_init() being done at build time, opening of NMI_SOFTIRQ can be a regular initcall, simplifying trap_init(). No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné For Branch: https://gitlab.com/xen-project/p

[PATCH] MISRA: Rephrase the deviation for Directive 4.10

2025-03-04 Thread Andrew Cooper
The use of "legitimately" mixes the concepts of "it was designed to do this" and "it was correct to do this". The latter in particular can go stale. "intended" is a better way of phrasing this. No functional change. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Michal Orzel CC: Jan

[PATCH v2 1/5] x86/IDT: Rename idt_table[] to bsp_idt[]

2025-03-04 Thread Andrew Cooper
Having variables named idt_table[] and idt_tables[] is not ideal. Use X86_IDT_VECTORS and remove IDT_ENTRIES. State the size of bsp_idt[] in idt.h so that load_system_tables() and cpu_smpboot_alloc() can use sizeof() rather than opencoding the calculation. Move the variable into a new traps-setu

[PATCH v2 3/5] x86/IDT: Generate bsp_idt[] at build time

2025-03-04 Thread Andrew Cooper
... rather than dynamically at boot time. Aside from less runtime overhead, this approach is less fragile than the preexisting autogen stubs mechanism. We can manage this with some linker calculations. See patch comments for full details. For simplicity, we create a new set of entry stubs here,

[PATCH v2 4/5] x86/IDT: Don't rewrite bsp_idt[] at boot time

2025-03-04 Thread Andrew Cooper
Now that bsp_idt[] is constructed at build time, we do not need to manually initialise it in init_idt_traps() and trap_init(). When swapping the early pagefault handler for the normal one, switch to using _update_gate_addr_lower() as we do on the kexec path for NMI and #MC. This in turn allows us

Re: [XEN PATCH] automation/eclair: Reduce verbosity of ECLAIR logs.

2025-03-04 Thread Stefano Stabellini
On Tue, 4 Mar 2025, Nicola Vetrini wrote: > While activating verbose logging simplifies debugging, this causes > GitLab logs to be truncated, preventing the links to the ECLAIR > analysis database to be shown. > > No functional change. > > Fixes: c4392ec83244 ("automation: Add ECLAIR utilities an

Re: [PATCH v2 2/2] xen/watchdog: Identify which domain watchdog fired

2025-03-04 Thread Andrew Cooper
On 04/03/2025 10:47 pm, Stefano Stabellini wrote: > On Mon, 3 Mar 2025, Andrew Cooper wrote: >> When a watchdog fires, the domain is crashed and can't dump any state. >> >> Xen allows a domain to have two separate watchdogs. Therefore, for a >> domain running multiple watchdogs (e.g. one based aro

[PATCH v3] x86/vmx: Rewrite vmx_sync_pir_to_irr() to be more efficient

2025-03-04 Thread Andrew Cooper
There are two issues. First, pi_test_and_clear_on() pulls the cache-line to the CPU and dirties it even if there's nothing outstanding, but the final bitmap_for_each() is O(256) when O(8) would do, and would avoid multiple atomic updates to the same IRR word. Rewrite it from scratch, explaining w

Re: [PATCH v2 2/2] xen/watchdog: Identify which domain watchdog fired

2025-03-04 Thread Stefano Stabellini
On Mon, 3 Mar 2025, Andrew Cooper wrote: > When a watchdog fires, the domain is crashed and can't dump any state. > > Xen allows a domain to have two separate watchdogs. Therefore, for a > domain running multiple watchdogs (e.g. one based around network, one > for disk), it is important for diagn

Re: [PATCH v2 1/2] xen/domain: Annotate struct domain as page aligned

2025-03-04 Thread Stefano Stabellini
On Mon, 3 Mar 2025, Andrew Cooper wrote: > struct domain is always a page aligned allocation. Update it's type to > reflect this, so we can safely reuse the lower bits in the pointer for > auxiliary information. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano St

Re: [PATCH 0/4] clang-format with examples

2025-03-04 Thread Stefano Stabellini
Hi Oleksandr, I really appreciate the examples you provided; they were very enlightening regarding the way forward. Today we discussed the topic with the maintainers again, and I believe we have identified the best approach to take. Since it is not feasible to use clang-format to make changes to

[PATCH v1] xen: fusa: arch_specs: Definition of the Virtual Machines' roles

2025-03-04 Thread Ayan Kumar Halder
From: Stefano Stabellini Define "Hardware Domain", "Control Domain", "DomUs", "SafeVMs" and "UnsafeVMs". Explain the limitations that VirtIO introduces and the way they affect the defined roles. Signed-off-by: Stefano Stabellini Signed-off-by: Ayan Kumar Halder --- docs/fusa/arch_specs/roles

Re: [PATCH v2 08/38] clocksource: hyper-v: Register sched_clock save/restore iff it's necessary

2025-03-04 Thread Sean Christopherson
On Tue, Mar 04, 2025, Michael Kelley wrote: > From: Sean Christopherson Sent: Wednesday, February 26, > 2025 6:18 PM > > > > Register the Hyper-V timer callbacks or saving/restoring its PV sched_clock > > s/or/for/ > > > if and only if the timer is actually being used for sched_clock. > > Curr

Re: [PATCH v3 2/2] xen/mm: Introduce per-arch pte_attr_t type for PTE flags

2025-03-04 Thread Shawn Anastasio
On 2/26/25 7:26 AM, Jan Beulich wrote: > On 21.02.2025 21:10, Shawn Anastasio wrote: >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -69,6 +69,7 @@ >> #include >> #include >> #include >> +#include >> >> struct page_info; >> >> @@ -113,9 +114,9 @@ int map_pages_to_xen( >>

Re: [PATCH 1/4] Add .clang-format files to enable manual coding style checks

2025-03-04 Thread Oleksandr Andrushchenko
Hello, Roger! On 04.03.25 10:17, Roger Pau Monné wrote: On Mon, Mar 03, 2025 at 09:23:57PM +0200, Oleksandr Andrushchenko wrote: Hello, Roger! On 03.03.25 17:05, Roger Pau Monné wrote: On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote: Disable coding style checks for th

Re: [PATCH v3 1/2] xen/passthrough: Provide stub functions when !HAS_PASSTHROUGH

2025-03-04 Thread Stefano Stabellini
On Wed, 19 Feb 2025, Jan Beulich wrote: > On 19.02.2025 16:25, Luca Fancellu wrote: > >> On 19 Feb 2025, at 13:30, Jan Beulich wrote: > >> On 19.02.2025 14:06, Luca Fancellu wrote: > On 19 Feb 2025, at 12:45, Jan Beulich wrote: > As per the > respective revlog entry, this change lo

Re: [PATCH v3 2/2] xen/arm: Restrict Kconfig configuration for LLC coloring

2025-03-04 Thread Stefano Stabellini
On Tue, 4 Mar 2025, Luca Fancellu wrote: > Hi, > > > On 18 Feb 2025, at 15:06, Jan Beulich wrote: > > > > On 18.02.2025 16:01, Orzel, Michal wrote: > >> On 18/02/2025 14:44, Jan Beulich wrote: > >>> On 18.02.2025 10:51, Luca Fancellu wrote: > LLC coloring can be used only on MMU system, > >

[PATCH v2 2/2] xen/arm: mpu: Ensure that the page size is 4KB

2025-03-04 Thread Ayan Kumar Halder
Similar to commit (d736b6eb451b, "xen/arm: mpu: Define Xen start address for MPU systems"), one needs to add a build assertion to ensure that the page size is 4KB on arm32 based systems as well. The existing build assertion is moved under "xen/arch/arm/mpu" as it applies for both arm64 and arm32 ba

[PATCH v2 1/2] xen/arm: mpu: Move some of the definitions to common file

2025-03-04 Thread Ayan Kumar Halder
For AArch32, refer to ARM DDI 0568A.c ID110520. MPU_REGION_SHIFT is same between AArch32 and AArch64 (HPRBAR). Also, NUM_MPU_REGIONS_SHIFT is same between AArch32 and AArch64 (HMPUIR). Signed-off-by: Ayan Kumar Halder Reviewed-by: Luca Fancellu --- Changes from v1 - 1. Add the R-b. xen/arch/

[PATCH v2 0/2] Enable early bootup of AArch32 MPU systems (pre-requisite patches)

2025-03-04 Thread Ayan Kumar Halder
Hi, I have extracted patches 1, 2 from "https://patchew.org/Xen/20250204192357.1862264-1-ayan.kumar.hal...@amd.com/"; as it will introduce the common files on which the following can be based :- 1. "[PATCH 0/9] First chunk for Arm R82 and MPU support" 2. "Enable early bootup of AArch32 MPU systems

[XEN PATCH] automation/eclair: Reduce verbosity of ECLAIR logs.

2025-03-04 Thread Nicola Vetrini
While activating verbose logging simplifies debugging, this causes GitLab logs to be truncated, preventing the links to the ECLAIR analysis database to be shown. No functional change. Fixes: c4392ec83244 ("automation: Add ECLAIR utilities and settings") Signed-off-by: Nicola Vetrini --- automat

Re: [RFC PATCH] xen/amd-iommu: Add interrupt remapping quirk for ath11k

2025-03-04 Thread Roger Pau Monné
On Tue, Mar 04, 2025 at 10:15:21AM -0500, Jason Andryuk wrote: > On 2025-03-04 05:23, Roger Pau Monné wrote: > > On Fri, Feb 28, 2025 at 03:25:52PM -0500, Jason Andryuk wrote: > > > On 2025-02-28 04:36, Roger Pau Monné wrote: > > > > On Thu, Feb 27, 2025 at 01:28:11PM -0500, Jason Andryuk wrote: >

Re: [PATCH] xen/riscv: copy_to_guest/copy_from_guest functionality.

2025-03-04 Thread Andrew Cooper
On 04/03/2025 11:59 am, Milan Đokić wrote: > Hello Andrew, > On Fri, Feb 28, 2025 at 4:47 PM Andrew Cooper > wrote: >> On 28/02/2025 2:59 pm, Milan Djokic wrote: >>> From: Slavisa Petrovic >>> >>> This patch implements copy_to_guest/copy_from_guest functions for RISC-V. >>> These functions are d

Re: [RFC PATCH] xen/amd-iommu: Add interrupt remapping quirk for ath11k

2025-03-04 Thread Jason Andryuk
On 2025-03-04 05:23, Roger Pau Monné wrote: On Fri, Feb 28, 2025 at 03:25:52PM -0500, Jason Andryuk wrote: On 2025-02-28 04:36, Roger Pau Monné wrote: On Thu, Feb 27, 2025 at 01:28:11PM -0500, Jason Andryuk wrote: On 2025-02-27 05:23, Roger Pau Monné wrote: On Wed, Feb 26, 2025 at 04:11:25PM

Re: [PATCH v2] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Alejandro Vallejo
On Tue Mar 4, 2025 at 1:22 PM GMT, Frediano Ziglio wrote: > Describe the usage of devices 5853:0002 and 5853:C000. > > Signed-off-by: Frediano Ziglio > --- > Changes since v1: > - address minor comments > --- > docs/man/xen-pci-device-reservations.7.pod | 7 +++ > 1 file changed, 7 insertions

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Alejandro Vallejo
For the record, my remarks are fairly inconsequential. This patch is a net positive addition to the man page and I think it should go in. On Tue Mar 4, 2025 at 12:29 PM GMT, Roger Pau Monné wrote: > On Tue, Mar 04, 2025 at 11:17:42AM +, Frediano Ziglio wrote: > > On Tue, Mar 4, 2025 at 11:08 A

Re: [PATCH 5/8] x86/IDT: Make idt_tables[] be per_cpu(idt)

2025-03-04 Thread Andrew Cooper
On 25/02/2025 4:33 pm, Jan Beulich wrote: > On 25.02.2025 16:40, Andrew Cooper wrote: >> On 25/02/2025 9:07 am, Jan Beulich wrote: >>> On 24.02.2025 17:05, Andrew Cooper wrote: --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -819,6 +819,7 @@ void load_system_tables

[PATCH v2] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Frediano Ziglio
Describe the usage of devices 5853:0002 and 5853:C000. Signed-off-by: Frediano Ziglio --- Changes since v1: - address minor comments --- docs/man/xen-pci-device-reservations.7.pod | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/man/xen-pci-device-reservations.7.pod b/docs/man/xe

Re: [XEN PATCH v2 3/6] CI: Refresh the Debian 12 arm64 container

2025-03-04 Thread Andrew Cooper
On 06/11/2024 4:23 pm, Stefano Stabellini wrote: > On Wed, 6 Nov 2024, Javi Merino wrote: >> Rework the container to use heredocs for readability and use >> apt-get --no-install-recommends to keep the size down. Rename the job >> to debian-12-arm64-* to follow the naming scheme of all the other CI

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Frediano Ziglio
On Tue, Mar 4, 2025 at 12:30 PM Roger Pau Monné wrote: > > On Tue, Mar 04, 2025 at 11:17:42AM +, Frediano Ziglio wrote: > > On Tue, Mar 4, 2025 at 11:08 AM Roger Pau Monné > > wrote: > > > > > > On Tue, Mar 04, 2025 at 10:21:52AM +, Alejandro Vallejo wrote: > > > > Hi, > > > > > > > > On

Re: [PATCH 3/9] arm/mpu: Introduce MPU memory region map structure

2025-03-04 Thread Luca Fancellu
Hi Ayan, > On 4 Mar 2025, at 10:53, Ayan Kumar Halder wrote: > > Hi Luca, > > On 28/02/2025 16:18, Luca Fancellu wrote: >> CAUTION: This message has originated from an External Source. Please use >> proper judgment and caution when opening attachments, clicking links, or >> responding to this

Re: [PATCH 3/5] xen/arm: mpu: Move some of the definitions to common file

2025-03-04 Thread Luca Fancellu
> On 28 Feb 2025, at 10:34, Ayan Kumar Halder wrote: > > Hi Julien/Luca, > > On 28/02/2025 09:22, Julien Grall wrote: >> >> >> On 26/02/2025 08:28, Luca Fancellu wrote: >>> Hi Julien, >> >> Hi Luca, >> >>> >> >> #ifdef CONFIG_EARLY_PRINTK >> diff --git a/xen/arch/arm/include

Re: [PATCH v6 1/4] common: remove -fno-stack-protector from EMBEDDED_EXTRA_CFLAGS

2025-03-04 Thread Andrew Cooper
On 17/02/2025 2:49 am, Volodymyr Babchuk wrote: > This patch is preparation for making stack protector > configurable. First step is to remove -fno-stack-protector flag from > EMBEDDED_EXTRA_CFLAGS so separate components (Hypervisor in this case) > can enable/disable this feature by themselves. > >

Re: [PATCH 8/9] arm/mpu: Implement early_fdt_map support in MPU systems

2025-03-04 Thread Luca Fancellu
Hi Ayan, > On 4 Mar 2025, at 12:13, Ayan Kumar Halder wrote: > > Hi Luca, > > On 28/02/2025 16:18, Luca Fancellu wrote: >> CAUTION: This message has originated from an External Source. Please use >> proper judgment and caution when opening attachments, clicking links, or >> responding to this

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Roger Pau Monné
On Tue, Mar 04, 2025 at 11:17:42AM +, Frediano Ziglio wrote: > On Tue, Mar 4, 2025 at 11:08 AM Roger Pau Monné wrote: > > > > On Tue, Mar 04, 2025 at 10:21:52AM +, Alejandro Vallejo wrote: > > > Hi, > > > > > > On Fri Feb 28, 2025 at 3:21 PM GMT, Frediano Ziglio wrote: > > > > Describe the

Re: [PATCH 7/9] arm/mpu: Introduce MPU memory mapping flags

2025-03-04 Thread Luca Fancellu
Hi Ayan, > On 4 Mar 2025, at 11:55, Ayan Kumar Halder wrote: > > Hi Luca, > > On 28/02/2025 16:18, Luca Fancellu wrote: >> CAUTION: This message has originated from an External Source. Please use >> proper judgment and caution when opening attachments, clicking links, or >> responding to thi

Re: [PATCH 6/9] arm/mpu: Provide a constructor for pr_t type

2025-03-04 Thread Luca Fancellu
> On 4 Mar 2025, at 11:45, Ayan Kumar Halder wrote: > > Hi Luca, > > On 28/02/2025 16:18, Luca Fancellu wrote: >> CAUTION: This message has originated from an External Source. Please use >> proper judgment and caution when opening attachments, clicking links, or >> responding to this email.

Re: [PATCH 8/9] arm/mpu: Implement early_fdt_map support in MPU systems

2025-03-04 Thread Ayan Kumar Halder
Hi Luca, On 28/02/2025 16:18, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Implement early_fdt_map() function, that is responsible to map the de

Re: [PATCH] xen/riscv: copy_to_guest/copy_from_guest functionality.

2025-03-04 Thread Milan Đokić
Hello Oleksii, On Fri, Feb 28, 2025 at 5:03 PM Oleksii Kurochko wrote: > > > On 2/28/25 3:59 PM, Milan Djokic wrote: > > From: Slavisa Petrovic > > This patch implements copy_to_guest/copy_from_guest functions for RISC-V. > These functions are designed to facilitate data exchange between guest an

Re: [PATCH] xen/riscv: copy_to_guest/copy_from_guest functionality.

2025-03-04 Thread Milan Đokić
Hello Andrew, On Fri, Feb 28, 2025 at 4:47 PM Andrew Cooper wrote: > > On 28/02/2025 2:59 pm, Milan Djokic wrote: > > From: Slavisa Petrovic > > > > This patch implements copy_to_guest/copy_from_guest functions for RISC-V. > > These functions are designed to facilitate data exchange between guest

Re: [PATCH 7/9] arm/mpu: Introduce MPU memory mapping flags

2025-03-04 Thread Ayan Kumar Halder
Hi Luca, On 28/02/2025 16:18, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Introduce the MPU memory mapping flags in asm/page.h. Signed-off-by:

Re: [PATCH 6/9] arm/mpu: Provide a constructor for pr_t type

2025-03-04 Thread Ayan Kumar Halder
Hi Luca, On 28/02/2025 16:18, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Provide a function that creates a pr_t object from a memory range and

Re: [PATCH v3 2/2] xen/arm: Restrict Kconfig configuration for LLC coloring

2025-03-04 Thread Luca Fancellu
Hi, > On 18 Feb 2025, at 15:06, Jan Beulich wrote: > > On 18.02.2025 16:01, Orzel, Michal wrote: >> On 18/02/2025 14:44, Jan Beulich wrote: >>> On 18.02.2025 10:51, Luca Fancellu wrote: LLC coloring can be used only on MMU system, >>> >>> Just for my own education: Why is this? >> I read t

Re: [PATCH 5/9] arm/mpu: Introduce utility functions for the pr_t type

2025-03-04 Thread Ayan Kumar Halder
Hi Luca, On 28/02/2025 16:18, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Introduce few utility function to manipulate and handle the pr_t type

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Frediano Ziglio
On Tue, Mar 4, 2025 at 11:08 AM Roger Pau Monné wrote: > > On Tue, Mar 04, 2025 at 10:21:52AM +, Alejandro Vallejo wrote: > > Hi, > > > > On Fri Feb 28, 2025 at 3:21 PM GMT, Frediano Ziglio wrote: > > > Describe the usage of devices 5853:0002 and 5853:C000. > > > > > > Signed-off-by: Frediano

[PATCH v2] xen/page_alloc: Simplify domain_adjust_tot_pages

2025-03-04 Thread Alejandro Vallejo
The logic has too many levels of indirection and it's very hard to understand it its current form. Split it between the corner case where the adjustment is bigger than the current claim and the rest to avoid 5 auxiliary variables. Add a functional change to prevent negative adjustments from re-inc

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Roger Pau Monné
On Tue, Mar 04, 2025 at 10:21:52AM +, Alejandro Vallejo wrote: > Hi, > > On Fri Feb 28, 2025 at 3:21 PM GMT, Frediano Ziglio wrote: > > Describe the usage of devices 5853:0002 and 5853:C000. > > > > Signed-off-by: Frediano Ziglio > > --- > > docs/man/xen-pci-device-reservations.7.pod | 9 +++

Re: [PATCH 3/9] arm/mpu: Introduce MPU memory region map structure

2025-03-04 Thread Ayan Kumar Halder
Hi Luca, On 28/02/2025 16:18, Luca Fancellu wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Penny Zheng Introduce pr_t typedef which is a structure havin

Re: [PATCH v8 0/6] (mostly) Arm32: add/convert entry point annotations

2025-03-04 Thread Luca Fancellu
Hi, > On 26 Feb 2025, at 15:58, Jan Beulich wrote: > > Besides the (now) last patch only Arm32 adjustments are left in this > series. > > 1: Arm32: use new-style entry annotations for library code > 2: Arm32: use new-style entry annotations for MMU code > 3: Arm32: use new-style entry annotatio

Re: [RFC PATCH] xen/amd-iommu: Add interrupt remapping quirk for ath11k

2025-03-04 Thread Roger Pau Monné
On Fri, Feb 28, 2025 at 03:25:52PM -0500, Jason Andryuk wrote: > On 2025-02-28 04:36, Roger Pau Monné wrote: > > On Thu, Feb 27, 2025 at 01:28:11PM -0500, Jason Andryuk wrote: > > > On 2025-02-27 05:23, Roger Pau Monné wrote: > > > > On Wed, Feb 26, 2025 at 04:11:25PM -0500, Jason Andryuk wrote: >

Re: [PATCH] docs: Add some details on XenServer PCI devices

2025-03-04 Thread Alejandro Vallejo
Hi, On Fri Feb 28, 2025 at 3:21 PM GMT, Frediano Ziglio wrote: > Describe the usage of devices 5853:0002 and 5853:C000. > > Signed-off-by: Frediano Ziglio > --- > docs/man/xen-pci-device-reservations.7.pod | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/man/xen-pci-device-

Re: [PATCH] IOMMU/VT-d: Fix comment

2025-03-04 Thread Roger Pau Monné
On Mon, Mar 03, 2025 at 10:14:38PM +, Andrew Cooper wrote: > "find upstream bridge" is surprisingly jarring in context, considering that's > the name of the function who's return value we're testing. > > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v3] xen/arm: Don't use copy_from_paddr for DTB relocation

2025-03-04 Thread Orzel, Michal
On 26/02/2025 22:52, Luca Fancellu wrote: > > > Currently the early stage of the Arm boot maps the DTB using > early_fdt_map() using PAGE_HYPERVISOR_RO which is cacheable > read-only memory, later during DTB relocation the function > copy_from_paddr() is used to map pages in the same range on

Re: [PATCH 1/4] Add .clang-format files to enable manual coding style checks

2025-03-04 Thread Roger Pau Monné
On Mon, Mar 03, 2025 at 09:23:57PM +0200, Oleksandr Andrushchenko wrote: > Hello, Roger! > > On 03.03.25 17:05, Roger Pau Monné wrote: > > On Sat, Mar 01, 2025 at 01:42:39PM +0200, Oleksandr Andrushchenko wrote: > > > Disable coding style checks for the project, but xen/ folder: > > > this is done