Re: [PATCH] xen: add privcmd ioctl to get p2pdma_distance

2024-12-16 Thread Zhang, Julia
On 2024/12/16 17:19, Jan Beulich wrote: > On 16.12.2024 09:18, Zhang, Julia wrote: >> On 2024/12/9 15:47, Jan Beulich wrote: >> On 07.12.2024 11:59, Julia Zhang wrote: > > Yet another formality, sorry: Please send plain text emails. You'll note that > what > I said and why you said is indisting

[PATCH v2 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili
iasl complains _HID and _ADR cannot be used at the same time: ``` /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc tools/firmware/hvmloader/dsdt_anycpu.asl 2>&1 | grep -B10 HID tools/firmware/hvmloader/dsdt_anycpu.asl 40:Device (PCI0) Warning 3073 -

[PATCH v2 0/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili
Hello, This patch clears out an ASL warning; below is listed my configuration. Your feedback is much appreciated. Thank you, ``` $ iasl -v Intel ACPI Component Architecture ASL+ Optimizing Compiler/Disassembler version 20240927 Copyright (c) 2000 - 2023 Intel Corporation $ gcc --version gcc

[PATCH v2 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili
* since 3.12 invalid escape sequences generate SyntaxWarning * in the future, these invalid sequences will generate SyntaxError * therefore changed syntax to raw string notation. Link: https://docs.python.org/3/whatsnew/3.12.html#other-language-changes Fixes: d8f3a67bf98 ("pygrub: further improve

[PATCH v2 0/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili
Hello, The series clears out Python syntax warnings. In all occurrences of the re methods, ``` $ git grep -Pn '[^\w_]re\.[a-z]+' | wc -l 69 ``` Where it was needed, the strings have been quoted as raw. Thank you, -- v2: * tools/misc/xensymoops got removed (2e955d2554, "tools/misc: Drop xensym

Re: [PATCH v3 04/10] xen/arm: ffa: Fine granular call support

2024-12-16 Thread Julien Grall
On 16/12/2024 08:06, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 13 Dec 2024, at 23:57, Julien Grall wrote: Hi Bertrand, On 27/11/2024 16:07, Bertrand Marquis wrote: Create a bitmap to store which feature is supported or not by the firmware and use it to filter which calls are d

Re: [PATCH v5 3/3] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-12-16 Thread Shawn Anastasio
Hi Jan, On 9/30/24 10:20 AM, Jan Beulich wrote: > On 27.09.2024 00:24, Shawn Anastasio wrote: >> In the initial mm-radix implementation, the in-memory partition and >> process tables required to configure the MMU, as well as the page tables >> themselves were all allocated statically since the boo

Re: [PATCH v2] xen/device-tree: Allow region overlapping with /memreserve/ ranges

2024-12-16 Thread Shawn Anastasio
Hi Luca, On 11/14/24 4:28 AM, Luca Fancellu wrote: > There are some cases where the device tree exposes a memory range > in both /memreserve/ and reserved-memory node, in this case the > current code will stop Xen to boot since it will find that the > latter range is clashing with the already reco

Re: [PATCH v2 5/7] xen/riscv: implement data and instruction cache operations

2024-12-16 Thread Oleksii Kurochko
On 12/16/24 3:23 PM, Jan Beulich wrote: On 11.12.2024 18:27, Oleksii Kurochko wrote: --- a/xen/arch/riscv/include/asm/page.h +++ b/xen/arch/riscv/include/asm/page.h @@ -7,6 +7,7 @@ #include #include +#include #include #include @@ -148,9 +149,27 @@ static inline bool pte_is_m

Re: [PATCH v12 03/12] xen/arm: permit non direct-mapped Dom0 construction

2024-12-16 Thread Michal Orzel
On 16/12/2024 16:51, Carlo Nonato wrote: > > > Hi Michal, > > On Mon, Dec 16, 2024 at 1:08 PM Michal Orzel wrote: >> >> On 13/12/2024 17:28, Carlo Nonato wrote: >>> >>> Cache coloring requires Dom0 not to be direct-mapped because of its non >>> contiguous mapping nature, so allocate_memory()

[PATCH] misra: add deviation for MISRA C Rule R11.8.

2024-12-16 Thread Alessandro Zucchelli
Rule 11.8 states as following: "A cast shall not remove any `const' or `volatile' qualification from the type pointed to by a pointer". Function `__hvm_copy' in `xen/arch/x86/hvm/hvm.c' is a double-use function, where the parameter needs to not be const because it can be set for write or not. As i

Re: [PATCH 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:34 CET, Andrew Cooper wrote: > On 14/12/2024 4:09 pm, Ariel Otilibili wrote: > > * since 3.12 invalid escape sequences generate SyntaxWarning > > * in the future, these invalid sequences will generate SyntaxError > > * therefore changed syntax to raw string notati

Re: [PATCH v12 01/12] xen/common: add cache coloring common code

2024-12-16 Thread Carlo Nonato
Hi Jan, On Mon, Dec 16, 2024 at 11:51 AM Jan Beulich wrote: > > On 13.12.2024 17:28, Carlo Nonato wrote: > > Last Level Cache (LLC) coloring allows to partition the cache in smaller > > chunks called cache colors. > > > > Since not all architectures can actually implement it, add a > > HAS_LLC_C

Re: [PATCH V4 01/15] x86: Create per-domain mapping for guest_root_pt

2024-12-16 Thread Alejandro Vallejo
On Mon Nov 11, 2024 at 1:11 PM GMT, Elias El Yandouzi wrote: > From: Hongyan Xia > > This patch introduces a per-domain mapping for the `guest_root_pt` in PV > guests as part of the effort to remove the direct map in Xen. > > For the time being, the `root_pgt` is not mapped or unmapped, as it rema

Re: [PATCH v12 03/12] xen/arm: permit non direct-mapped Dom0 construction

2024-12-16 Thread Carlo Nonato
Hi Michal, On Mon, Dec 16, 2024 at 1:08 PM Michal Orzel wrote: > > On 13/12/2024 17:28, Carlo Nonato wrote: > > > > Cache coloring requires Dom0 not to be direct-mapped because of its non > > contiguous mapping nature, so allocate_memory() is needed in this case. > > 8d2c3ab18cc1 ("arm/dom0less:

Re: [PATCH v3 5/7] xen: add new domctl get_changed_domain

2024-12-16 Thread Jürgen Groß
On 16.12.24 16:18, Jan Beulich wrote: On 16.12.2024 16:03, Juergen Gross wrote: On 16.12.24 11:41, Jan Beulich wrote: On 13.12.2024 17:24, Juergen Gross wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -193,6 +193,57 @@ static void domain_changed_state(const struct domain *d)

Re: [PATCH v3 5/7] xen: add new domctl get_changed_domain

2024-12-16 Thread Jan Beulich
On 16.12.2024 16:03, Juergen Gross wrote: > On 16.12.24 11:41, Jan Beulich wrote: >> On 13.12.2024 17:24, Juergen Gross wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -193,6 +193,57 @@ static void domain_changed_state(const struct domain >>> *d) >>> spin_unlock(&do

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 13:39 CET, Jan Beulich wrote: > On 16.12.2024 13:19, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 12:38 CET, Jan Beulich > > wrote: > > > >> On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: > >>> On Monday, December 16, 2024 12:01 CET, Jan Beuli

Re: [PATCH v3 6/7] tools/libs: add a new libxenmanage library

2024-12-16 Thread Juergen Gross
On 16.12.24 15:49, Anthony PERARD wrote: On Fri, Dec 13, 2024 at 05:24:20PM +0100, Juergen Gross wrote: diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h new file mode 100644 index 00..5d169693b0 --- /dev/null +++ b/tools/include/xenmanage.h @@ -0,0 +1,92 @@ +/* SPDX-Lic

Re: [PATCH v2 33/35] x86/domain: implement domain_has_vuart()

2024-12-16 Thread Jan Beulich
On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote: > --- a/tools/libs/light/libxl_x86.c > +++ b/tools/libs/light/libxl_x86.c > @@ -8,7 +8,11 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > { > switch(d_config->c_info.type) { > case LIBXL_DOMAIN_TYPE_HVM: > -config->a

Re: [PATCH v2 32/35] x86/hvm: add debugging facility to NS8250 UART emulator

2024-12-16 Thread Jan Beulich
On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote: > +static void ns8250_keyhandler_init(void) > +{ > +register_keyhandler('1', ns8250_keyhandler_show, > +"dump virtual NS8250 state", 0); > +register_keyhandler('2', ns8250_keyhandler_irq, > +

Re: [PATCH v2 31/35] x86/hvm: introduce NS8250 UART emulator

2024-12-16 Thread Jan Beulich
On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote: > From: Denis Mukhin > > Add initial in-hypervisor emulator for NS8250/NS16x50-compatible UARTs under > CONFIG_HAS_VUART_NS8250. > > In parallel domain creation scenario (hyperlaunch), NS8520 emulator helps > early guest OS bringup debugging,

Re: [PATCH v3 5/7] xen: add new domctl get_changed_domain

2024-12-16 Thread Juergen Gross
On 16.12.24 11:41, Jan Beulich wrote: On 13.12.2024 17:24, Juergen Gross wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -193,6 +193,57 @@ static void domain_changed_state(const struct domain *d) spin_unlock(&dom_state_changed_lock); } +static void set_domain_state_info(

Re: [PATCH v3 6/7] tools/libs: add a new libxenmanage library

2024-12-16 Thread Anthony PERARD
On Fri, Dec 13, 2024 at 05:24:20PM +0100, Juergen Gross wrote: > diff --git a/tools/include/xenmanage.h b/tools/include/xenmanage.h > new file mode 100644 > index 00..5d169693b0 > --- /dev/null > +++ b/tools/include/xenmanage.h > @@ -0,0 +1,92 @@ > +/* SPDX-License-Identifier: LGPL-2.1 */

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Michal Orzel
On 16/12/2024 15:28, Carlo Nonato wrote: > > > Hi Michal, > > On Mon, Dec 16, 2024 at 2:56 PM Michal Orzel wrote: >> >> On 13/12/2024 17:28, Carlo Nonato wrote: >>> >>> Xen image is relocated to a new colored physical space. Some relocation >>> functionalities must be brought back: >>> - the

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Carlo Nonato
Hi Jan, On Mon, Dec 16, 2024 at 3:36 PM Jan Beulich wrote: > > On 16.12.2024 15:28, Carlo Nonato wrote: > > On Mon, Dec 16, 2024 at 2:56 PM Michal Orzel wrote: > >> On 13/12/2024 17:28, Carlo Nonato wrote: > >>> --- a/xen/arch/arm/arm64/mmu/mm.c > >>> +++ b/xen/arch/arm/arm64/mmu/mm.c > >>> @@ -

Re: [PATCH v2 09/13] x86/emulator: Refactor FXSAVE_AREA to use wrappers

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 16, 2024 at 12:01 PM GMT, Jan Beulich wrote: > On 16.12.2024 12:58, Alejandro Vallejo wrote: > > On Mon Dec 9, 2024 at 4:26 PM GMT, Jan Beulich wrote: > >> On 05.11.2024 15:33, Alejandro Vallejo wrote: > >>> --- a/xen/arch/x86/x86_emulate/blk.c > >>> +++ b/xen/arch/x86/x86_emulate/blk.c

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Jan Beulich
On 16.12.2024 15:28, Carlo Nonato wrote: > On Mon, Dec 16, 2024 at 2:56 PM Michal Orzel wrote: >> On 13/12/2024 17:28, Carlo Nonato wrote: >>> --- a/xen/arch/arm/arm64/mmu/mm.c >>> +++ b/xen/arch/arm/arm64/mmu/mm.c >>> @@ -1,6 +1,7 @@ >>> /* SPDX-License-Identifier: GPL-2.0-only */ >>> >>> #incl

Re: [PATCH v2 7/7] xen/riscv: relocating and unflattening host device tree

2024-12-16 Thread Jan Beulich
On 11.12.2024 18:27, Oleksii Kurochko wrote: > Introduce relocate_fdt() and call it to relocate FDT to Xen heap > instead of using early mapping as it is expected that > discard_initial_modules() > ( is supposed to call in the future ) discards the FDT boot module and > remove_early_mappings() des

Re: [PATCH v2 6/7] xen/riscv: implement prereq for DTB relocation

2024-12-16 Thread Jan Beulich
On 11.12.2024 18:27, Oleksii Kurochko wrote: > @@ -175,10 +176,16 @@ static inline void invalidate_icache(void) > #define clear_page(page) memset((void *)(page), 0, PAGE_SIZE) > #define copy_page(dp, sp) memcpy(dp, sp, PAGE_SIZE) > > -/* TODO: Flush the dcache for an entire page. */ > static i

Re: [PATCH v2 5/7] xen/riscv: implement data and instruction cache operations

2024-12-16 Thread Jan Beulich
On 11.12.2024 18:27, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/page.h > +++ b/xen/arch/riscv/include/asm/page.h > @@ -7,6 +7,7 @@ > > #include > #include > +#include > #include > > #include > @@ -148,9 +149,27 @@ static inline bool pte_is_mapping(pte_t p) > return

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Carlo Nonato
Hi Michal, On Mon, Dec 16, 2024 at 2:56 PM Michal Orzel wrote: > > On 13/12/2024 17:28, Carlo Nonato wrote: > > > > Xen image is relocated to a new colored physical space. Some relocation > > functionalities must be brought back: > > - the virtual address of the new space is taken from 0c18fb7632

Re: [PATCH v3 2/7] tools: add a dedicated header file for barrier definitions

2024-12-16 Thread Anthony PERARD
On Fri, Dec 13, 2024 at 05:24:16PM +0100, Juergen Gross wrote: > diff --git a/tools/include/xen-barrier.h b/tools/include/xen-barrier.h > new file mode 100644 > index 00..a716fb93cc > --- /dev/null > +++ b/tools/include/xen-barrier.h > @@ -0,0 +1,39 @@ > +/* SPDX-License-Identifier: LGPL-2.

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Jan Beulich
On 16.12.2024 14:56, Michal Orzel wrote: > On 13/12/2024 17:28, Carlo Nonato wrote: >> @@ -30,6 +31,17 @@ static inline void domain_dump_llc_colors(const struct >> domain *d) {} >> static inline void domain_llc_coloring_free(struct domain *d) {} >> #endif >> >> +/** >> + * Iterate over each Xen

Re: [PATCH 29/71] hw/i386: Constify all Property

2024-12-16 Thread Richard Henderson
On 12/16/24 00:14, CLEMENT MATHIEU--DRIF wrote: Hi Rihard. Good idea, LGTM. Just out of curiosity, what was the motivation for such a patch? It it simply about cleaning the code or is it intended to solve a deeper problem. Simply cleaning the code, prompted by a change to core QAPI code for R

Re: [PATCH v2 10/13] x86/mpx: Map/unmap xsave area in in read_bndcfgu()

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 16, 2024 at 12:03 PM GMT, Jan Beulich wrote: > On 16.12.2024 13:00, Alejandro Vallejo wrote: > > On Mon Dec 9, 2024 at 4:30 PM GMT, Jan Beulich wrote: > >> On 05.11.2024 15:33, Alejandro Vallejo wrote: > >>> --- a/xen/arch/x86/xstate.c > >>> +++ b/xen/arch/x86/xstate.c > >>> @@ -1022,9 +

Re: [PATCH v3 5/7] xen: add new domctl get_changed_domain

2024-12-16 Thread Jürgen Groß
On 16.12.24 11:41, Jan Beulich wrote: On 13.12.2024 17:24, Juergen Gross wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -193,6 +193,57 @@ static void domain_changed_state(const struct domain *d) spin_unlock(&dom_state_changed_lock); } +static void set_domain_state_info(

Re: [PATCH v12 12/12] xen/arm: add cache coloring support for Xen image

2024-12-16 Thread Michal Orzel
On 13/12/2024 17:28, Carlo Nonato wrote: > > > Xen image is relocated to a new colored physical space. Some relocation > functionalities must be brought back: > - the virtual address of the new space is taken from 0c18fb76323b > ("xen/arm: Remove unused BOOT_RELOC_VIRT_START"). > - relocate_

Re: [PATCH v3 4/7] xen: add bitmap to indicate per-domain state changes

2024-12-16 Thread Jürgen Groß
On 16.12.24 11:21, Jan Beulich wrote: On 13.12.2024 17:24, Juergen Gross wrote: @@ -138,6 +139,60 @@ bool __read_mostly vmtrace_available; bool __read_mostly vpmu_is_available; +static DEFINE_SPINLOCK(dom_state_changed_lock); +static unsigned long *dom_state_changed; __read_mostly?

Re: [PATCH v12 08/12] xen/page_alloc: introduce preserved page flags macro

2024-12-16 Thread Carlo Nonato
Hi Jan, On Mon, Dec 16, 2024 at 1:42 PM Jan Beulich wrote: > > On 13.12.2024 17:28, Carlo Nonato wrote: > > PGC_static and PGC_extra need to be preserved when assigning a page. > > Define a new macro that groups those flags and use it instead of or'ing > > every time. > > > > Signed-off-by: Carlo

Re: [PATCH v12 09/12] xen: add cache coloring allocator for domains

2024-12-16 Thread Michal Orzel
On 13/12/2024 17:28, Carlo Nonato wrote: > > > Add a new memory page allocator that implements the cache coloring mechanism. > The allocation algorithm enforces equal frequency distribution of cache > partitions, following the coloring configuration of a domain. This allows > for an even utili

Re: [PATCH v12 08/12] xen/page_alloc: introduce preserved page flags macro

2024-12-16 Thread Jan Beulich
On 13.12.2024 17:28, Carlo Nonato wrote: > PGC_static and PGC_extra need to be preserved when assigning a page. > Define a new macro that groups those flags and use it instead of or'ing > every time. > > Signed-off-by: Carlo Nonato Reviewed-by: Jan Beulich Aiui this is independent of 1-7 and h

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Jan Beulich
On 16.12.2024 13:19, Ariel Otilibili-Anieli wrote: > On Monday, December 16, 2024 12:38 CET, Jan Beulich wrote: > >> On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: >>> On Monday, December 16, 2024 12:01 CET, Jan Beulich >>> wrote: >>> On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote:

Re: [PATCH] tools/misc: Drop xensymoops

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 13:09 CET, Jan Beulich wrote: > On 16.12.2024 13:03, Andrew Cooper wrote: > > This script is not referenced by the build system, and has escaped all > > Python > > compatibility work; it's still using print statements. > > > > Also, the regex it uses ties it to a 32

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:38 CET, Jan Beulich wrote: > On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 12:01 CET, Jan Beulich > > wrote: > > > >> On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: > >>> On Monday, December 16, 2024 10:53 CET, Jan Beuli

Re: [PATCH v12 03/12] xen/arm: permit non direct-mapped Dom0 construction

2024-12-16 Thread Jan Beulich
On 16.12.2024 13:08, Michal Orzel wrote: > On 13/12/2024 17:28, Carlo Nonato wrote: >> @@ -977,6 +1022,108 @@ out: >> return res; >> } >> >> +void __init allocate_memory(struct domain *d, struct kernel_info *kinfo) >> +{ >> +struct membanks *mem = kernel_info_get_mem(kinfo); >> +unsig

Re: [PATCH] tools/misc: Drop xensymoops

2024-12-16 Thread Jan Beulich
On 16.12.2024 13:03, Andrew Cooper wrote: > This script is not referenced by the build system, and has escaped all Python > compatibility work; it's still using print statements. > > Also, the regex it uses ties it to a 32bit build of Xen, which was dropped in > Xen 4.3, 11 years ago. > > Signed-

Re: [PATCH v12 03/12] xen/arm: permit non direct-mapped Dom0 construction

2024-12-16 Thread Michal Orzel
On 13/12/2024 17:28, Carlo Nonato wrote: > > > Cache coloring requires Dom0 not to be direct-mapped because of its non > contiguous mapping nature, so allocate_memory() is needed in this case. > 8d2c3ab18cc1 ("arm/dom0less: put dom0less feature code in a separate module") > moved allocate_memo

[PATCH] tools/misc: Drop xensymoops

2024-12-16 Thread Andrew Cooper
This script is not referenced by the build system, and has escaped all Python compatibility work; it's still using print statements. Also, the regex it uses ties it to a 32bit build of Xen, which was dropped in Xen 4.3, 11 years ago. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Micha

Re: [PATCH v2 10/13] x86/mpx: Map/unmap xsave area in in read_bndcfgu()

2024-12-16 Thread Jan Beulich
On 16.12.2024 13:00, Alejandro Vallejo wrote: > On Mon Dec 9, 2024 at 4:30 PM GMT, Jan Beulich wrote: >> On 05.11.2024 15:33, Alejandro Vallejo wrote: >>> --- a/xen/arch/x86/xstate.c >>> +++ b/xen/arch/x86/xstate.c >>> @@ -1022,9 +1022,10 @@ int handle_xsetbv(u32 index, u64 new_bv) >>> >>> uint6

Re: [PATCH v2 09/13] x86/emulator: Refactor FXSAVE_AREA to use wrappers

2024-12-16 Thread Jan Beulich
On 16.12.2024 12:58, Alejandro Vallejo wrote: > On Mon Dec 9, 2024 at 4:26 PM GMT, Jan Beulich wrote: >> On 05.11.2024 15:33, Alejandro Vallejo wrote: >>> --- a/xen/arch/x86/x86_emulate/blk.c >>> +++ b/xen/arch/x86/x86_emulate/blk.c >>> @@ -11,9 +11,12 @@ >>> !defined(X86EMUL_NO_SIMD) >>> # i

Re: [PATCH v2 10/13] x86/mpx: Map/unmap xsave area in in read_bndcfgu()

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 4:30 PM GMT, Jan Beulich wrote: > On 05.11.2024 15:33, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/xstate.c > > +++ b/xen/arch/x86/xstate.c > > @@ -1022,9 +1022,10 @@ int handle_xsetbv(u32 index, u64 new_bv) > > > > uint64_t read_bndcfgu(void) > > { > > +uint64_t b

Re: [PATCH v2 09/13] x86/emulator: Refactor FXSAVE_AREA to use wrappers

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 4:26 PM GMT, Jan Beulich wrote: > On 05.11.2024 15:33, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/x86_emulate/blk.c > > +++ b/xen/arch/x86/x86_emulate/blk.c > > @@ -11,9 +11,12 @@ > > !defined(X86EMUL_NO_SIMD) > > # ifdef __XEN__ > > # include > > -# define FXSA

[XEN PATCH v1] arm: introduce kconfig options to disable hypercalls

2024-12-16 Thread Sergiy Kibrik
From: Stefano Stabellini It can be beneficial for some dom0less systems to further reduce Xen footprint and disable some hypercalls handling code, which may not to be used & required in such systems. Each hypercall has a separate option to keep configuration flexible. Options to disable hypercal

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Jan Beulich
On 16.12.2024 12:31, Ariel Otilibili-Anieli wrote: > On Monday, December 16, 2024 12:01 CET, Jan Beulich wrote: > >> On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: >>> On Monday, December 16, 2024 10:53 CET, Jan Beulich >>> wrote: >>> On 15.12.2024 16:40, Ariel Otilibili wrote: > *

Re: [PATCH v2 08/13] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states()

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 4:20 PM GMT, Jan Beulich wrote: > On 05.11.2024 15:33, Alejandro Vallejo wrote: > > No functional change. > > > > Signed-off-by: Alejandro Vallejo > > --- > > v2: > > * No change > > --- > > xen/arch/x86/xstate.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deleti

Re: [PATCH] tools/xg: increase LZMA_BLOCK_SIZE for uncompressing the kernel

2024-12-16 Thread Marek Marczykowski-Górecki
On Mon, Dec 16, 2024 at 09:35:37AM +0100, Roger Pau Monné wrote: > Adding Oleksii, as this IMO wants to be a blocker for 4.20. > > On Wed, Oct 09, 2024 at 03:03:28PM +0200, Marek Marczykowski-Górecki wrote: > > On Wed, Oct 09, 2024 at 01:38:32PM +0200, Jürgen Groß wrote: > > > On 09.10.24 13:15, J

Re: [PATCH 1/1] tools, xen/scripts: clear out Python syntax warnings

2024-12-16 Thread Andrew Cooper
On 14/12/2024 4:09 pm, Ariel Otilibili wrote: > * since 3.12 invalid escape sequences generate SyntaxWarning > * in the future, these invalid sequences will generate SyntaxError > * therefore changed syntax to raw string notation. > > Link: https://docs.python.org/3/whatsnew/3.12.html#other-languag

Re: [PATCH v3] vpci: Add resizable bar support

2024-12-16 Thread Jan Beulich
On 13.12.2024 06:42, Jiqian Chen wrote: > --- /dev/null > +++ b/xen/drivers/vpci/rebar.c > @@ -0,0 +1,130 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2024 Advanced Micro Devices, Inc. All Rights Reserved. > + * > + * Author: Jiqian Chen > + */ > + > +#include > +#i

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 12:01 CET, Jan Beulich wrote: > On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: > > On Monday, December 16, 2024 10:53 CET, Jan Beulich > > wrote: > > > >> On 15.12.2024 16:40, Ariel Otilibili wrote: > >>> * iasl complains _HID and _ADR cannot be used at the sam

Re: [PATCH v2 1/7] xen/riscv: update layout table in config.h

2024-12-16 Thread Jan Beulich
On 11.12.2024 18:27, Oleksii Kurochko wrote: > Make all upper bounds (end addresses) for areas inclusive to align > with the corresponding definitions. > > Signed-off-by: Oleksii Kurochko I expected this would be straightforward to ack, but ... > --- a/xen/arch/riscv/include/asm/config.h > +++

Re: [PATCH v2 05/13] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv()

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 4:16 PM GMT, Jan Beulich wrote: > On 05.11.2024 15:33, Alejandro Vallejo wrote: > > No functional change. > > > > Signed-off-by: Alejandro Vallejo > > Acked-by: Jan Beulich Thanks (for this one and the others). > with ... > > > --- a/xen/arch/x86/xstate.c > > +++ b/xen/ar

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Jan Beulich
On 16.12.2024 11:36, Ariel Otilibili-Anieli wrote: > On Monday, December 16, 2024 10:53 CET, Jan Beulich wrote: > >> On 15.12.2024 16:40, Ariel Otilibili wrote: >>> * iasl complains _HID and _ADR cannot be used at the same time >>> >>> ``` >>> /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_an

Re: [PATCH v2 02/13] x86/xstate: Create map/unmap primitives for xsave areas

2024-12-16 Thread Alejandro Vallejo
On Mon Dec 9, 2024 at 4:11 PM GMT, Jan Beulich wrote: > On 05.11.2024 15:32, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/include/asm/xstate.h > > +++ b/xen/arch/x86/include/asm/xstate.h > > @@ -143,4 +143,46 @@ static inline bool xstate_all(const struct vcpu *v) > > (v->arch.xcr0_ac

Re: [PATCH v12 01/12] xen/common: add cache coloring common code

2024-12-16 Thread Jan Beulich
On 13.12.2024 17:28, Carlo Nonato wrote: > Last Level Cache (LLC) coloring allows to partition the cache in smaller > chunks called cache colors. > > Since not all architectures can actually implement it, add a HAS_LLC_COLORING > Kconfig option. > LLC_COLORS_ORDER Kconfig option has a range maximu

Re: [PATCH v3 5/7] xen: add new domctl get_changed_domain

2024-12-16 Thread Jan Beulich
On 13.12.2024 17:24, Juergen Gross wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -193,6 +193,57 @@ static void domain_changed_state(const struct domain *d) > spin_unlock(&dom_state_changed_lock); > } > > +static void set_domain_state_info(struct xen_domctl_get_domain_s

Re: [PATCH v3] vpci: Add resizable bar support

2024-12-16 Thread Roger Pau Monné
On Mon, Dec 16, 2024 at 11:30:22AM +0100, Jan Beulich wrote: > On 16.12.2024 11:24, Roger Pau Monné wrote: > > On Fri, Dec 13, 2024 at 01:42:32PM +0800, Jiqian Chen wrote: > >> +static int cf_check init_rebar(struct pci_dev *pdev) > >> +{ > >> +uint32_t ctrl; > >> +unsigned int rebar_offset

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Ariel Otilibili-Anieli
On Monday, December 16, 2024 10:53 CET, Jan Beulich wrote: > On 15.12.2024 16:40, Ariel Otilibili wrote: > > * iasl complains _HID and _ADR cannot be used at the same time > > > > ``` > > /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc > > tools/firmware/hvmloader/dsdt_anycpu.

Re: [PATCH v3] vpci: Add resizable bar support

2024-12-16 Thread Jan Beulich
On 16.12.2024 11:24, Roger Pau Monné wrote: > On Fri, Dec 13, 2024 at 01:42:32PM +0800, Jiqian Chen wrote: >> +static int cf_check init_rebar(struct pci_dev *pdev) >> +{ >> +uint32_t ctrl; >> +unsigned int rebar_offset, nbars; >> + >> +rebar_offset = pci_find_ext_capability(pdev->sbdf,

Re: [PATCH v3] vpci: Add resizable bar support

2024-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2024 at 01:42:32PM +0800, Jiqian Chen wrote: > Some devices, like discrete GPU of amd, support resizable bar > capability, but vpci of Xen doesn't support this feature, so > they fail to resize bars and then cause probing failure. > > According to PCIe spec, each bar that supports

Re: [PATCH v3 4/7] xen: add bitmap to indicate per-domain state changes

2024-12-16 Thread Jan Beulich
On 13.12.2024 17:24, Juergen Gross wrote: > @@ -138,6 +139,60 @@ bool __read_mostly vmtrace_available; > > bool __read_mostly vpmu_is_available; > > +static DEFINE_SPINLOCK(dom_state_changed_lock); > +static unsigned long *dom_state_changed; __read_mostly? > +int domain_init_states(void) > +

Re: [PATCH 1/2] ARM: ITS: implement quirks and add support for Renesas Gen4 ITS

2024-12-16 Thread Jan Beulich
On 13.12.2024 14:43, Mykyta Poturai wrote: > From: Oleksandr Andrushchenko > > There are number of ITS implementations exist which are different from > the base one which have number of functionalities defined as is > "IMPLEMENTATION DEFINED", e.g. there may exist differences in cacheability, > s

Re: [PATCH 1/1] tools/libacpi: clear ASL warning about PCI0

2024-12-16 Thread Jan Beulich
On 15.12.2024 16:40, Ariel Otilibili wrote: > * iasl complains _HID and _ADR cannot be used at the same time > > ``` > /usr/bin/iasl -vs -p tools/firmware/hvmloader/dsdt_anycpu.tmp -tc > tools/firmware/hvmloader/dsdt_anycpu.asl 2>&1 | grep -B10 HID > tools/firmware/hvmloader/dsdt_anycpu.asl 4

Re: [PATCH] xen: add privcmd ioctl to get p2pdma_distance

2024-12-16 Thread Jan Beulich
On 16.12.2024 09:18, Zhang, Julia wrote: > On 2024/12/9 15:47, Jan Beulich wrote: > On 07.12.2024 11:59, Julia Zhang wrote: Yet another formality, sorry: Please send plain text emails. You'll note that what I said and why you said is indistinguishably intermixed below. > --- a/tools/include/xen-

Re: [PATCH v2 00/35] Introduce NS8250 UART emulator

2024-12-16 Thread Roger Pau Monné
On Sat, Dec 14, 2024 at 07:05:15PM +0100, Marek Marczykowski-Górecki wrote: > On Thu, Dec 05, 2024 at 08:41:30PM -0800, Denis Mukhin via B4 Relay wrote: > > The patch series introduces initial in-hypervisor emulator for > > NS8250/NS16x50-compatible UARTs under CONFIG_HAS_VUART_NS8250. > > > > In

Re: [PATCH v2 33/35] x86/domain: implement domain_has_vuart()

2024-12-16 Thread Roger Pau Monné
On Fri, Dec 13, 2024 at 12:45:34PM -0800, Stefano Stabellini wrote: > On Fri, 13 Dec 2024, Roger Pau Monné wrote: > > On Thu, Dec 05, 2024 at 08:42:03PM -0800, Denis Mukhin via B4 Relay wrote: > > > From: Denis Mukhin > > > > > > Add new emulation flag for virtual UART on x86 and plumb it through

Re: [PATCH] tools/xg: increase LZMA_BLOCK_SIZE for uncompressing the kernel

2024-12-16 Thread Roger Pau Monné
Adding Oleksii, as this IMO wants to be a blocker for 4.20. On Wed, Oct 09, 2024 at 03:03:28PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Oct 09, 2024 at 01:38:32PM +0200, Jürgen Groß wrote: > > On 09.10.24 13:15, Jan Beulich wrote: > > > On 09.10.2024 13:08, Andrew Cooper wrote: > > > > O

Re: [PATCH] xen: add privcmd ioctl to get p2pdma_distance

2024-12-16 Thread Zhang, Julia
On 2024/12/9 15:47, Jan Beulich wrote: On 07.12.2024 11:59, Julia Zhang wrote: To implement dGPU prime feature, virtgpu driver need to get p2pdma_distance of two GPU from host side. This adds a new privcmd ioctl to get the real p2pdma_distance of two pci devices in the host with pci notatio

Re: [PATCH v3 04/10] xen/arm: ffa: Fine granular call support

2024-12-16 Thread Bertrand Marquis
Hi Julien, > On 13 Dec 2024, at 23:57, Julien Grall wrote: > > Hi Bertrand, > > On 27/11/2024 16:07, Bertrand Marquis wrote: >> Create a bitmap to store which feature is supported or not by the >> firmware and use it to filter which calls are done to the firmware. >> While there reoder ABI defi