On 06.12.2024 05:42, Denis Mukhin via B4 Relay wrote:
> +static void ns8250_keyhandler_init(void)
> +{
> + register_keyhandler('1', ns8250_keyhandler_show,
> + "dump virtual NS8250 state", 0);
> + register_keyhandler('2', ns8250_keyhandler_irq,
> + "trigger IRQ from virtual NS8250", 0);
Characters for key handlers are a pretty scarce resource. I'm afraid I
wouldn't want to see this committed, even if it may be helpful during
(initial) debugging. Even more so when both handlers only ever act on
a single domain. Imo both want to be domctl-s instead.
Jan
