[xen-unstable test] 186448: tolerable FAIL - PUSHED

flight 186448 xen-unstable real [real] flight 186452 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186448/ http://logs.test-lab.xenproject.org/osstest/logs/186452/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[linux-6.1 test] 186445: tolerable FAIL - PUSHED

flight 186445 linux-6.1 real [real] flight 186450 linux-6.1 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186445/ http://logs.test-lab.xenproject.org/osstest/logs/186450/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd6

[PATCH v2] docs/misra: rules for mass adoption

From: Stefano Stabellini This patch adds a bunch of rules to rules.rst that are uncontroversial and have zero violations in Xen. As such, they have been approved for adoption. All the ones that regard the standard library have the link to the existing footnote in the notes. Signed-off-by: Stefa

Re: [PATCH] docs/misra: rules for mass adoption

On Thu, 23 May 2024, Jan Beulich wrote: > On 23.05.2024 03:26, Stefano Stabellini wrote: > > @@ -725,12 +787,25 @@ maintainers if you want to suggest a change. > > - The Standard Library function system of shall not be used > > - > > > > + * - `Rule 22.1 > >

Re: [RFC PATCH v2] iommu/xen: Add Xen PV-IOMMU driver

On 2024-06-21 5:08 pm, TSnake41 wrote: From: Teddy Astie In the context of Xen, Linux runs as Dom0 and doesn't have access to the machine IOMMU. Although, a IOMMU is mandatory to use some kernel features such as VFIO or DMA protection. In Xen, we added a paravirtualized IOMMU with iommu_op hyp

Re: [PATCH 1/2] automation/eclair_analysis: deviate MISRA C Rule 21.2

On Fri, 21 Jun 2024, Jan Beulich wrote: > On 21.06.2024 03:02, Stefano Stabellini wrote: > > On Thu, 20 Jun 2024, Jan Beulich wrote: > >> On 19.06.2024 19:09, Alessandro Zucchelli wrote: > >>> Rule 21.2 reports identifiers reserved for the C and POSIX standard > >>> libraries: all xen's translation

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

On Fri, 21 Jun 2024, Federico Serafini wrote: > On 21/06/24 03:13, Stefano Stabellini wrote: > > On Thu, 20 Jun 2024, Federico Serafini wrote: > > > On 19/06/24 13:17, Julien Grall wrote: > > > > Hi Federico, > > > > > > > > On 19/06/2024 10:29, Federico Serafini wrote: > > > > > MISRA C Rule 16.4

Re: [XEN PATCH v3] automation/eclair: add deviation for MISRA C Rule 17.7

On Wed, 19 Jun 2024, Stefano Stabellini wrote: > On Fri, 14 Jun 2024, Federico Serafini wrote: > > Update ECLAIR configuration to deviate some cases where not using > > the return value of a function is not dangerous. > > > > Signed-off-by: Federico Serafini > > Acked-by: Stefano Stabellini I

Re: [XEN PATCH] automation/eclair: add deviations of MISRA C Rule 5.5

On Thu, 20 Jun 2024, Stefano Stabellini wrote: > On Thu, 20 Jun 2024, Federico Serafini wrote: > > MISRA C Rule 5.5 states that "Identifiers shall be distinct from macro > > names". > > > > Update ECLAIR configuration to deviate: > > - macros expanding to their own name; > > - clashes between macr

Re: [PATCH v2] automation/eclair_analysis: deviate and|or|xor|not for MISRA C Rule 21.2

On Fri, 21 Jun 2024, Alessandro Zucchelli wrote: > Rule 21.2 reports identifiers reserved for the C and POSIX standard > libraries: or, and, not and xor are reserved identifiers because they > constitute alternate spellings for the corresponding operators (they are > defined as macros by iso646.h);

Re: [PATCH 2/2] xen/multicall: Change nr_calls to uniformly be unsigned long

On Fri, 21 Jun 2024, Andrew Cooper wrote: > Right now, the non-compat declaration and definition of do_multicall() > differing types for the nr_calls parameter. > > This is a MISRA rule 8.3 violation, but it's also time-bomb waiting for the > first 128bit architecture (RISC-V looks as if it might

Re: [PATCH for-4.19 v2] tools/xl: Open xldevd.log with O_CLOEXEC

On Fri, Jun 21, 2024 at 05:16:56PM +0100, Andrew Cooper wrote: > `xl devd` has been observed leaking /var/log/xldevd.log into children. > > Note this is specifically safe; dup2() leaves O_CLOEXEC disabled on newfd, so > after setting up stdout/stderr, it's only the logfile fd which will close on >

Re: [PATCH 1/2] x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables()

On Fri, 21 Jun 2024, Andrew Cooper wrote: > Commit 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker") > intentionally renamed guest_walk_tables()'s 'pfec' parameter to 'walk' because > it's not a PageFault Error Code, despite the name of some of the constants > passed in. Sadly the c

Re: [XEN PATCH] automation/eclair: add more guidelines to the monitored set

On Fri, 21 Jun 2024, Federico Serafini wrote: > Add more accepted guidelines to the monitored set to check them at each > commit. > > Signed-off-by: Federico Serafini Acked-by: Stefano Stabellini Asking for a release ack: this allows us to see more violations in the regular ECLAIR scanning res

Re: [PATCH v2] common/unlzo: address violation of MISRA C Rule 7.3

On Fri, 21 Jun 2024, Alessandro Zucchelli wrote: > This addresses violations of MISRA C:2012 Rule 7.3 which states as > following: the lowercase character `l' shall not be used in a literal > suffix. > > The file common/unlzo.c defines the non-compliant constant LZO_BLOCK_SIZE with > having a lowe

Re: [XEN PATCH v2] common/sched: address a violation of MISRA C Rule 8.8

Hi, On 21/06/24 21:59, victorm.l...@amd.com wrote: From: Victor Lira Rule 8.8: "The static storage class specifier shall be used in all declarations of objects and functions that have internal linkage" What you are addressing with this patch seems to be a violation of Rule 8.7: "Functions an

[PATCH for-4.19 0/2] Xen: Final MISRA R8.3 fixes

This gets Xen clean to R8.3 and marks it as blocking in Gitlab. https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1342755199 Andrew Cooper (2): x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables() xen/multicall: Change nr_calls to uniformly be unsigned long automati

[PATCH 2/2] xen/multicall: Change nr_calls to uniformly be unsigned long

Right now, the non-compat declaration and definition of do_multicall() differing types for the nr_calls parameter. This is a MISRA rule 8.3 violation, but it's also time-bomb waiting for the first 128bit architecture (RISC-V looks as if it might get there first). Worse, the type chosen here has a

[PATCH 1/2] x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables()

Commit 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker") intentionally renamed guest_walk_tables()'s 'pfec' parameter to 'walk' because it's not a PageFault Error Code, despite the name of some of the constants passed in. Sadly the constants-cleanup I've been meaning to do since the

[PATCH 1/3] xen/riscv: Drop legacy __ro_after_init definition

Hide the legacy __ro_after_init definition in xen/cache.h for RISC-V, to avoid its use creeping in. Only mm.c needs adjusting as a consequence No functional change. Signed-off-by: Andrew Cooper --- CC: Shawn Anastasio CC: Oleksii Kurochko CC: George Dunlap CC: Jan Beulich CC: Stefano Stabel

[PATCH 3/3] xen/ppc: Avoid using the legacy __read_mostly/__ro_after_init definitions

RISC-V wants to introduce a full build of Xen without using the legacy definitions. PPC64 has the most minimal full build of Xen right now, so make it compile without the legacy definitions. Mostly this is just including xen/sections.h in a variety of common files. In a couple of cases, we can d

[PATCH 2/3] xen/ppc: Adjust ppc64_defconfig

All of CONFIG_SCHED_*, and CONFIG_HYPFS build fine. Add a stub for share_xen_page_with_guest(), which is all that is necessary to make CONFIG_TRACEBUFFER build. No functional change. Signed-off-by: Andrew Cooper --- CC: Shawn Anastasio CC: Oleksii Kurochko CC: George Dunlap CC: Jan Beulich

[PATCH for-4.19? 0/3] xen: build adjustments for __read_mostly/__ro_after_init

In aid of getting the RISC-V build working without introducing more technical debt. It's done by making PPC shed it's copy of said technical debt. Build tested quite thoroughly, including in Gitlab. Andrew Cooper (3): xen/riscv: Drop legacy __ro_after_init definition xen/ppc: Adjust ppc64_de

[XEN PATCH v2] common/sched: address a violation of MISRA C Rule 8.8

From: Victor Lira Rule 8.8: "The static storage class specifier shall be used in all declarations of objects and functions that have internal linkage" This patch fixes this by adding the static specifier. No functional changes. Reported-by: Stewart Hildebrand stewart.hildebr...@amd.com Signed-o

[PATCH 1/2] Add libfuzzer target to fuzz/x86_instruction_emulator

This target enables integration into oss-fuzz. Signed-off-by: Tamas K Lengyel --- tools/fuzz/x86_instruction_emulator/Makefile| 10 -- tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 6 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tools/fuzz/x86_instructi

[PATCH 2/2] Add scripts/oss-fuzz/build.sh

The build integration script for oss-fuzz targets. Signed-off-by: Tamas K Lengyel --- scripts/oss-fuzz/build.sh | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 scripts/oss-fuzz/build.sh diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh new file

[xen-unstable-smoke test] 186447: tolerable all pass - PUSHED

flight 186447 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186447/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH for-4.19 v3 3/4] x86/shadow: Rework trace_shadow_emulate_other() as sh_trace_gfn_va()

sh_trace_gfn_va() is very similar to sh_trace_gl1e_va(), and a rather shorter name than trace_shadow_emulate_other(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: George Dunlap CC: Oleksii Kurochko v2: * New v3: * Retain __packed. --- xen

[PATCH for-4.19 v3 0/4] x86/shadow: Trace fixes and cleanup

Patches 1-3 were my review feedback to Jan's patch 4. For 4.19. Patch 4 (the bugfix) was Release-Acked after I posted the series (cleanup and rebased bugfix), which suggests your happy for it in principle, but I can't treat that as an implict release ack on the whole series. It's a tracing fix,

[PATCH for-4.19 v3 2/4] x86/shadow: Introduce sh_trace_gl1e_va()

trace_shadow_fixup() and trace_not_shadow_fault() both write out identical trace records. Reimplement them in terms of a common sh_trace_gl1e_va(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: George Dunlap CC: Oleksii Kurochko v2: * New v

[PATCH for-4.19 v3 1/4] x86/shadow: Rework trace_shadow_gen() into sh_trace_va()

The ((GUEST_PAGING_LEVELS - 2) << 8) expression in the event field is common to all shadow trace events, so introduce sh_trace() as a very thin wrapper around trace(). Then, rename trace_shadow_gen() to sh_trace_va() to better describe what it is doing, and to be more consistent with later cleanup

[PATCH for-4.19 v3 4/4] x86/shadow: Don't leave trace record field uninitialized

From: Jan Beulich The emulation_count field is set only conditionally right now. Convert all field setting to an initializer, thus guaranteeing that field to be set to 0 (default initialized) when GUEST_PAGING_LEVELS != 3. Rework trace_shadow_emulate() to be consistent with the other trace helpe

Re: [PATCH for-4.19 v2] tools/xl: Open xldevd.log with O_CLOEXEC

On 21/06/2024 5:55 pm, Anthony PERARD wrote: > On Fri, Jun 21, 2024 at 05:16:56PM +0100, Andrew Cooper wrote: >> `xl devd` has been observed leaking /var/log/xldevd.log into children. >> >> Note this is specifically safe; dup2() leaves O_CLOEXEC disabled on newfd, so >> after setting up stdout/stde

Re: [PATCH for-4.19 v2] tools/xl: Open xldevd.log with O_CLOEXEC

On Fri, Jun 21, 2024 at 05:16:56PM +0100, Andrew Cooper wrote: > `xl devd` has been observed leaking /var/log/xldevd.log into children. > > Note this is specifically safe; dup2() leaves O_CLOEXEC disabled on newfd, so > after setting up stdout/stderr, it's only the logfile fd which will close on >

Re: [PATCH for-4.19 0/4] xen/xlat: Improvements to compat hypercall checking

On 15/04/2024 4:41 pm, Andrew Cooper wrote: > This started off as patch 3, and grew somewhat. > > Patches 1-3 are simple and hopefully non-controversial. > > Patch 4 is an attempt to make the headers less fragile, but came with an > unexpected complication. Details in the patch. > > Andrew Cooper

Re: [PATCH for-4.19 v2] tools/xl: Open xldevd.log with O_CLOEXEC

On Fri, Jun 21, 2024 at 05:16:56PM +0100, Andrew Cooper wrote: > `xl devd` has been observed leaking /var/log/xldevd.log into children. > > Note this is specifically safe; dup2() leaves O_CLOEXEC disabled on newfd, so > after setting up stdout/stderr, it's only the logfile fd which will close on >

[PATCH for-4.19 v2] tools/xl: Open xldevd.log with O_CLOEXEC

`xl devd` has been observed leaking /var/log/xldevd.log into children. Note this is specifically safe; dup2() leaves O_CLOEXEC disabled on newfd, so after setting up stdout/stderr, it's only the logfile fd which will close on exec(). Link: https://github.com/QubesOS/qubes-issues/issues/8292 Repor

[RFC PATCH v2] iommu/xen: Add Xen PV-IOMMU driver

From: Teddy Astie In the context of Xen, Linux runs as Dom0 and doesn't have access to the machine IOMMU. Although, a IOMMU is mandatory to use some kernel features such as VFIO or DMA protection. In Xen, we added a paravirtualized IOMMU with iommu_op hypercall in order to allow Dom0 to implemen

Re: [XEN PATCH] tools/misc: xen-hvmcrash: Inject #DF instead of overwriting RIP

On Mon, Jun 03, 2024 at 03:59:18PM +0100, Matthew Barnes wrote: > diff --git a/tools/misc/xen-hvmcrash.c b/tools/misc/xen-hvmcrash.c > index 1d058fa40a47..8ef1beb388f8 100644 > --- a/tools/misc/xen-hvmcrash.c > +++ b/tools/misc/xen-hvmcrash.c > @@ -38,22 +38,21 @@ > #include > #include > > +#de

[XEN PATCH] automation/eclair: add more guidelines to the monitored set

Add more accepted guidelines to the monitored set to check them at each commit. Signed-off-by: Federico Serafini --- automation/eclair_analysis/ECLAIR/monitored.ecl | 5 + 1 file changed, 5 insertions(+) diff --git a/automation/eclair_analysis/ECLAIR/monitored.ecl b/automation/eclair_analy

Check out our Xen Summit highlights video!

Hi everyone, Check out our Xen Summit highlights video on YouTube: https://www.youtube.com/watch?v=qZcCCm_PaHs&ab_channel=TheXenProject What a great reminder of how important our summits are, and the community behind it! Many thanks, Kelly Choi Community Manager Xen Project

Re: [RFC PATCH] iommu/xen: Add Xen PV-IOMMU driver

Hello Jason, Le 19/06/2024 à 18:30, Jason Gunthorpe a écrit : > On Thu, Jun 13, 2024 at 01:50:22PM +, Teddy Astie wrote: > >> +struct iommu_domain *xen_iommu_domain_alloc(unsigned type) >> +{ >> +struct xen_iommu_domain *domain; >> +u16 ctx_no; >> +int ret; >> + >> +if (type &

[xen-unstable test] 186444: tolerable FAIL

flight 186444 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186444/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-raw 8 xen-boot fail in 186438 pass in 186444 test-armhf-armhf-libvirt-vhd 17

[PATCH v2] common/unlzo: address violation of MISRA C Rule 7.3

This addresses violations of MISRA C:2012 Rule 7.3 which states as following: the lowercase character `l' shall not be used in a literal suffix. The file common/unlzo.c defines the non-compliant constant LZO_BLOCK_SIZE with having a lowercase 'l'. It is now defined as '256*1024L'. No functional c

Re: [PATCH for-4.19? v6 6/9] xen: Make the maximum number of altp2m views configurable for x86

On Thu, Jun 20, 2024 at 9:25 AM Jan Beulich wrote: > Not exactly. You may not assert on idx. The assertion, if any, wants to > check d->nr_altp2m against MAX_EPTP. In addition to the check in arch_sanitize_domain? As a safeguard? > You're again comparing cases where we control the index (in the

[PATCH v2] automation/eclair_analysis: deviate and|or|xor|not for MISRA C Rule 21.2

Rule 21.2 reports identifiers reserved for the C and POSIX standard libraries: or, and, not and xor are reserved identifiers because they constitute alternate spellings for the corresponding operators (they are defined as macros by iso646.h); however Xen doesn't use standard library headers, so the

Re: [XEN PATCH v2] xen: add explicit comment to identify notifier patterns

On 21/06/24 03:13, Stefano Stabellini wrote: On Thu, 20 Jun 2024, Federico Serafini wrote: On 19/06/24 13:17, Julien Grall wrote: Hi Federico, On 19/06/2024 10:29, Federico Serafini wrote: MISRA C Rule 16.4 states that every `switch' statement shall have a `default' label" and a statement or

[RFC XEN PATCH] x86/mctelem: address violations of MISRA C: 2012 Rule 5.3

From: Alessandro Zucchelli This addresses violations of MISRA C:2012 Rule 5.3 which states as following: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope. In this case the shadowing is between local variables "mctctl" and the file-scope static struc

Re: [PATCH for-4.19] xen/arm: static-shmem: request host address to be specified for 1:1 domains

On Fri, 2024-06-21 at 11:22 +0200, Michal Orzel wrote: > As a follow up to commit cb1ddafdc573 ("xen/arm/static-shmem: Static- > shmem > should be direct-mapped for direct-mapped domains") add a check to > request that both host and guest physical address must be supplied > for > direct mapped doma

[libvirt test] 186441: tolerable all pass - PUSHED

flight 186441 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/186441/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186427 test-amd64-amd64-libvirt 15 migrate-s

Re: [PATCH for-4.19?] libelf: avoid UB in elf_xen_feature_{get,set}()

On Thu, 2024-06-20 at 17:07 +0100, Andrew Cooper wrote: > On 20/06/2024 4:34 pm, Jan Beulich wrote: > > When the left shift amount is up to 31, the shifted quantity wants > > to be > > of unsigned int (or wider) type. > > > > While there also adjust types: get doesn't alter the array and > > retur

Re: [XEN for-4.19 PATCH] x86/apic: Fix signing in left bitshift

On Thu, 2024-06-20 at 16:16 +0100, Andrew Cooper wrote: > On 20/06/2024 3:31 pm, Matthew Barnes wrote: > > There exists a bitshift in the IOAPIC code where a signed integer > > is > > shifted to the left by at most 31 bits. This is undefined > > behaviour, > > and can cause faults in xtf tests such

[PATCH for-4.19] xen/arm: static-shmem: request host address to be specified for 1:1 domains

As a follow up to commit cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains") add a check to request that both host and guest physical address must be supplied for direct mapped domains. Otherwise return an error to prevent unwanted behavior. Signed

[ovmf test] 186443: all pass - PUSHED

flight 186443 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186443/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf be38c01da2dd949e0a6f8bceeb88d2e19c8c65f7 baseline version: ovmf d512bd31293c7f2aeef9b

Re: [XEN PATCH] common/sched: address a violation of MISRA C Rule 8.8

On Fri, Jun 21, 2024 at 1:21 AM wrote: > > From: Victor Lira > > Rule 8.8: "The static storage class specifier shall be used in all > declarations of objects and functions that have internal linkage" > > This patch fixes this by adding the static specifier. > No functional changes. > > Reported-b

Re: [XEN PATCH v10 4/5] tools: Add new function to get gsi from dev

On 2024/6/20 22:38, Anthony PERARD wrote: > On Mon, Jun 17, 2024 at 05:00:34PM +0800, Jiqian Chen wrote: >> diff --git a/tools/include/xencall.h b/tools/include/xencall.h >> index fc95ed0fe58e..750aab070323 100644 >> --- a/tools/include/xencall.h >> +++ b/tools/include/xencall.h >> @@ -113,6 +113,8

Re: [XEN PATCH v10 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi

On 2024/6/20 18:42, Jan Beulich wrote: > On 20.06.2024 11:40, Chen, Jiqian wrote: >> On 2024/6/18 17:23, Jan Beulich wrote: >>> On 18.06.2024 10:23, Chen, Jiqian wrote: On 2024/6/17 23:32, Jan Beulich wrote: > On 17.06.2024 11:00, Jiqian Chen wrote: >> @@ -1516,14 +1519,39 @@ static vo

Re: [XEN PATCH v10 4/5] tools: Add new function to get gsi from dev

On 2024/6/20 18:37, Jan Beulich wrote: > On 20.06.2024 12:23, Chen, Jiqian wrote: >> On 2024/6/20 15:43, Jan Beulich wrote: >>> On 20.06.2024 09:03, Chen, Jiqian wrote: On 2024/6/18 17:13, Jan Beulich wrote: > On 18.06.2024 10:10, Chen, Jiqian wrote: >> On 2024/6/17 23:10, Jan Beulich

[xen-unstable test] 186438: tolerable FAIL - PUSHED

flight 186438 xen-unstable real [real] flight 186442 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186438/ http://logs.test-lab.xenproject.org/osstest/logs/186442/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh