[xen-unstable test] 186225: tolerable FAIL - PUSHED

2024-06-01 Thread osstest service owner
flight 186225 xen-unstable real [real] flight 186228 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186225/ http://logs.test-lab.xenproject.org/osstest/logs/186228/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

[ovmf test] 186227: all pass - PUSHED

2024-06-01 Thread osstest service owner
flight 186227 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186227/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf de2330450ff71df5a609fe48e2153eb4854d9359 baseline version: ovmf 7339bfeffa3fa30b18dce

[linux-linus test] 186221: FAIL

2024-06-01 Thread osstest service owner
flight 186221 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186221/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-rtds broken in 186217 Tests whic

[PATCH] ALSA: xen-front: remove unused struct 'alsa_sndif_hw_param'

2024-06-01 Thread linux
From: "Dr. David Alan Gilbert" 'alsa_sndif_hw_param' has been unused since the original commit 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver"). Remove it. Signed-off-by: Dr. David Alan Gilbert --- sound/xen/xen_snd_front_alsa.c | 5 - 1 file changed, 5 deletions(-)

[xen-unstable test] 186220: tolerable FAIL - PUSHED

2024-06-01 Thread osstest service owner
flight 186220 xen-unstable real [real] flight 186224 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186220/ http://logs.test-lab.xenproject.org/osstest/logs/186224/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines

2024-06-01 Thread Nicola Vetrini
Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are added to the list of clean guidelines. Some guidelines listed in the additional clean section for ARM are also clean on x86, so they can be removed from there. No functional change. Signed-off-by: Nicola Vetrini --- +Cc Oleksi

vcpumask_to_pcpumask() case study

2024-06-01 Thread Andrew Cooper
One of the followon items I had from the bitops clean-up is this: diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 648d6dd475ba..9c3a017606ed 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3425,7 +3425,7 @@ static int vcpumask_to_pcpumask( unsigned int cpu;    

[xen-unstable-smoke test] 186223: tolerable all pass - PUSHED

2024-06-01 Thread osstest service owner
flight 186223 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/186223/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH 0/5] address violations of MISRA C rules

2024-06-01 Thread Andrew Cooper
On 01/06/2024 6:19 pm, Nicola Vetrini wrote: > On 2024-06-01 16:37, Andrew Cooper wrote: >> On 01/06/2024 11:16 am, Nicola Vetrini wrote: >>> Patches 1 to 4 address violations of MISRA C Rule 20.12 by deviating >>> certain >>> uses of some macros, while the last patch addresses some regressions >>>

Re: [XEN PATCH 0/5] address violations of MISRA C rules

2024-06-01 Thread Nicola Vetrini
On 2024-06-01 16:37, Andrew Cooper wrote: On 01/06/2024 11:16 am, Nicola Vetrini wrote: Patches 1 to 4 address violations of MISRA C Rule 20.12 by deviating certain uses of some macros, while the last patch addresses some regressions introduced by the latest bitops series Nicola Vetrini (5):

[libvirt test] 186218: tolerable FAIL - PUSHED

2024-06-01 Thread osstest service owner
flight 186218 libvirt real [real] flight 186222 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/186218/ http://logs.test-lab.xenproject.org/osstest/logs/186222/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-li

Re: [XEN PATCH 0/5] address violations of MISRA C rules

2024-06-01 Thread Andrew Cooper
On 01/06/2024 11:16 am, Nicola Vetrini wrote: > Patches 1 to 4 address violations of MISRA C Rule 20.12 by deviating certain > uses of some macros, while the last patch addresses some regressions > introduced > by the latest bitops series > > Nicola Vetrini (5): > xen/domain: deviate violation o

Re: [XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Andrew Cooper
On 01/06/2024 2:52 pm, Nicola Vetrini wrote: > On 2024-06-01 15:08, Andrew Cooper wrote: >> On 01/06/2024 1:58 pm, Nicola Vetrini wrote: >>> On 2024-06-01 14:47, Andrew Cooper wrote: On 01/06/2024 11:16 am, Nicola Vetrini wrote: > ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure a

Re: [XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Nicola Vetrini
On 2024-06-01 15:08, Andrew Cooper wrote: On 01/06/2024 1:58 pm, Nicola Vetrini wrote: On 2024-06-01 14:47, Andrew Cooper wrote: On 01/06/2024 11:16 am, Nicola Vetrini wrote: ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure ahead of rearrangements") introduced new violations on previo

Re: [XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Andrew Cooper
On 01/06/2024 1:58 pm, Nicola Vetrini wrote: > On 2024-06-01 14:47, Andrew Cooper wrote: >> On 01/06/2024 11:16 am, Nicola Vetrini wrote: >>> ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure ahead of >>> rearrangements") >>> introduced new violations on previously clean rules 20.9 and 20.1

Re: [XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Nicola Vetrini
On 2024-06-01 14:47, Andrew Cooper wrote: On 01/06/2024 11:16 am, Nicola Vetrini wrote: ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure ahead of rearrangements") introduced new violations on previously clean rules 20.9 and 20.12. The first is introduced because CONFIG_CC_IS_CLANG in

Re: [PATCH v2 12/13] xen/bitops: Clean up ffs64()/fls64() definitions

2024-06-01 Thread Andrew Cooper
On 27/05/2024 2:44 pm, Jan Beulich wrote: >> --- a/xen/include/xen/bitops.h >> +++ b/xen/include/xen/bitops.h >> @@ -60,6 +60,14 @@ static always_inline __pure unsigned int ffsl(unsigned >> long x) >> #endif >> } >> >> +static always_inline __pure unsigned int ffs64(uint64_t x) >> +{ >> +i

Re: [XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Andrew Cooper
On 01/06/2024 11:16 am, Nicola Vetrini wrote: > ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure ahead of > rearrangements") > introduced new violations on previously clean rules 20.9 and 20.12. > > The first is introduced because CONFIG_CC_IS_CLANG in xen/self-tests.h is not > defined in

[linux-linus test] 186217: regressions - trouble: broken/fail/pass

2024-06-01 Thread osstest service owner
flight 186217 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/186217/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-rtds broken test-armhf-armhf-examine 8 reboot

[XEN PATCH 1/5] xen/domain: deviate violation of MISRA C Rule 20.12

2024-06-01 Thread Nicola Vetrini
MISRA C Rule 20.12 states: "A macro parameter used as an operand to the # or ## operators, which is itself subject to further macro replacement, shall only be used as an operand to these operators". In this case, builds where CONFIG_DEBUG_LOCK_PROFILE=y the domain_lock macro is used both as a regu

[XEN PATCH 2/5] x86/domain: deviate violation of MISRA C Rule 20.12

2024-06-01 Thread Nicola Vetrini
MISRA C Rule 20.12 states: "A macro parameter used as an operand to the # or ## operators, which is itself subject to further macro replacement, shall only be used as an operand to these operators". In this case, builds where CONFIG_COMPAT=y the fpu_ctxt macro is used both as a regular macro argum

[XEN PATCH 5/5] xen: fix MISRA regressions on rule 20.9 and 20.12

2024-06-01 Thread Nicola Vetrini
ea59e7d780d9 ("xen/bitops: Cleanup and new infrastructure ahead of rearrangements") introduced new violations on previously clean rules 20.9 and 20.12. The first is introduced because CONFIG_CC_IS_CLANG in xen/self-tests.h is not defined in the configuration under analysis. Using "defined()" inst

[XEN PATCH 4/5] automation/eclair_analysis: address remaining violations of MISRA C Rule 20.12

2024-06-01 Thread Nicola Vetrini
The DEFINE macro in asm-offsets.c (for all architectures) still generates violations despite the file(s) being excluded from compliance, due to the fact that in its expansion it sometimes refers entities in non-excluded files. These corner cases are deviated by the configuration. No functional cha

[XEN PATCH 3/5] x86: deviate violation of MISRA C Rule 20.12

2024-06-01 Thread Nicola Vetrini
MISRA C Rule 20.12 states: "A macro parameter used as an operand to the # or ## operators, which is itself subject to further macro replacement, shall only be used as an operand to these operators". When the second parameter of GET_SET_SHARED is a macro and is used as both a regular parameter and

[XEN PATCH 0/5] address violations of MISRA C rules

2024-06-01 Thread Nicola Vetrini
Patches 1 to 4 address violations of MISRA C Rule 20.12 by deviating certain uses of some macros, while the last patch addresses some regressions introduced by the latest bitops series Nicola Vetrini (5): xen/domain: deviate violation of MISRA C Rule 20.12 x86/domain: deviate violation of MISR

[xen-unstable test] 186214: tolerable FAIL - PUSHED

2024-06-01 Thread osstest service owner
flight 186214 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/186214/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186208 test-amd64-amd64-xl-qemut-win7-amd64

[ovmf test] 186219: all pass - PUSHED

2024-06-01 Thread osstest service owner
flight 186219 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/186219/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7339bfeffa3fa30b18dce86409c0112039bacec5 baseline version: ovmf 3b36aa96de1d5f7a4660b

Re: [PATCH v2 06/13] xen/bitops: Implement ffs() in common logic

2024-06-01 Thread Nicola Vetrini
On 2024-05-31 10:48, Andrew Cooper wrote: On 31/05/2024 9:34 am, Andrew Cooper wrote: On 31/05/2024 7:56 am, Nicola Vetrini wrote: On 2024-05-31 03:14, Stefano Stabellini wrote: On Fri, 24 May 2024, Andrew Cooper wrote: Perform constant-folding unconditionally, rather than having it implement