[PATCH v2] MAINTAINERS: consolidate vm-event/monitor entry

If the F: description is to be trusted, the two xen/arch/x86/hvm/ lines were fully redundant with the earlier wildcard ones. Arch header files, otoh, were no longer covered by anything as of the move from include/asm-*/ to arch/*/include/asm/. Further also generalize (by folding) the x86- and Arm-s

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30.08.2023 19:02, Andrew Cooper wrote: > On 30/08/2023 5:13 pm, Jan Beulich wrote: >> On 30.08.2023 17:28, Andrew Cooper wrote: >>> On 30/08/2023 4:12 pm, Jan Beulich wrote: On 30.08.2023 16:35, Andrew Cooper wrote: > On 29/08/2023 3:08 pm, Jan Beulich wrote: >> On 29.08.2023 15:43,

[qemu-mainline test] 182570: tolerable FAIL - PUSHED

flight 182570 qemu-mainline real [real] flight 182578 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182570/ http://logs.test-lab.xenproject.org/osstest/logs/182578/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [XEN PATCH 05/13] automation/eclair: add deviation for usercopy.c

On Wed, 30 Aug 2023, Simone Ballarin wrote: > On 29/08/23 00:27, Stefano Stabellini wrote: > > +Nicola, Luca > > > > On Mon, 28 Aug 2023, Simone Ballarin wrote: > > > xen/arch/x86/usercopy.c includes itself, so it is not supposed to > > > comply with Directive 4.10: > > > "Precautions shall be tak

[PATCH v2] docs/misra: add 14.3

From: Stefano Stabellini Add 14.3, with project-wide deviations. Also take the opportunity to clarify that parameters of function pointer types are expected to have names (Rule 8.2). Signed-off-by: Stefano Stabellini --- v2: - remove 14.4 - better wording for the 8.2 clarification - add while(

Re: [PATCH] xen/scsifront: shost_priv() can never return NULL

On Tue, 22 Aug 2023 08:48:17 +0200, Juergen Gross wrote: > There is no need to check whether shost_priv() returns a non-NULL > value, as the pointer returned is just an offset to the passed in > parameter. > > While at it replace an open coded shost_priv() instance. > > > [...] Applied to 6.6/

Re: [PATCH] docs/misra: add 14.3 and 14.4

On Wed, 30 Aug 2023, Bertrand Marquis wrote: > > On 30 Aug 2023, at 09:58, Jan Beulich wrote: > > > > On 30.08.2023 09:54, Bertrand Marquis wrote: > >>> On 30 Aug 2023, at 02:59, Stefano Stabellini > >>> wrote: > >>> + * - `Rule 14.4 > >>>

Re: [PATCH] docs/misra: add 14.3 and 14.4

On Wed, 30 Aug 2023, Bertrand Marquis wrote: > Hi Stefano, > > > On 30 Aug 2023, at 02:59, Stefano Stabellini wrote: > > > > From: Stefano Stabellini > > > > Add 14.3, with a project-wide deviations on if statements. > > Add 14.4, clarifying that implicit conversions of integers, chars and > >

Re: [PATCH] docs/misra: add 14.3 and 14.4

On Wed, 30 Aug 2023, Jan Beulich wrote: > On 30.08.2023 02:59, Stefano Stabellini wrote: > > --- a/docs/misra/rules.rst > > +++ b/docs/misra/rules.rst > > @@ -234,7 +234,7 @@ maintainers if you want to suggest a change. > > * - `Rule 8.2 > >

RE: [EXT] Re: xen arm64 low power sleep support

On Wed, 30 Aug 2023, Anthony Chan wrote: > On Tue, 29 Aug 2023, Stefano Stabellini wrote: > > On Tue, 29 Aug 2023, Anthony Chan wrote: > > > Hi all, > > > > > > My name is Tony and I've been researching/developing using Xen for > > potential upcoming uses in our embedded systems. I started with Xe

Re: QEMU features useful for Xen development?

Hi Alex, Thanks for reaching out. QEMU is an important development tool for the Xen community and we are using QEMU as part of our upstream gitlab-ci testing, see automation/scripts/qemu-*. As Xen is gaining R52 and R82 support, it would be great to be able to use QEMU for development and testing

Re: [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

On Wed, 30 Aug 2023, Vikram Garhwal wrote: > Hi Michal, > On Tue, Aug 29, 2023 at 10:23:30AM +0200, Michal Orzel wrote: > > > > > > On 25/08/2023 10:02, Vikram Garhwal wrote: > > > Remove master device from the IOMMU. This will be helpful when removing > > > the > > > overlay nodes using dynamic

[ovmf test] 182573: all pass - PUSHED

flight 182573 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182573/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c5753c3e38f3fde23eec9641cb3c433f443ff99e baseline version: ovmf 0c4d0b6c8a05a6a62c0dc

[linux-linus test] 182566: regressions - FAIL

flight 182566 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182566/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

[linux-5.4 test] 182569: regressions - trouble: fail/pass/starved

flight 182569 linux-5.4 real [real] flight 182572 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182569/ http://logs.test-lab.xenproject.org/osstest/logs/182572/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [PATCH v2 6/8] xen/ppc: Define bug frames table in linker script

On 8/30/23 8:03 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> Define the bug frames table in ppc's linker script as is done by other >> architectures. >> >> Signed-off-by: Shawn Anastasio >> Acked-by: Jan Beulich > > If I'm not mistaken this change is independent of the

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

On 30/08/2023 3:30 pm, Roger Pau Monné wrote: > On Wed, Sep 12, 2018 at 03:09:35AM -0600, Jan Beulich wrote: >> The function does two translations in one go for a single guest access. >> Any failure of the first translation step (guest linear -> guest >> physical), resulting in #PF, ought to take p

Re: [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

Hi Michal, On Tue, Aug 29, 2023 at 10:23:30AM +0200, Michal Orzel wrote: > > > On 25/08/2023 10:02, Vikram Garhwal wrote: > > Remove master device from the IOMMU. This will be helpful when removing the > > overlay nodes using dynamic programming during run time. > > > > Signed-off-by: Vikram Gar

Re: [XEN][PATCH v10 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

Hi Michal, On Tue, Aug 29, 2023 at 10:05:55AM +0200, Michal Orzel wrote: > > > On 25/08/2023 10:02, Vikram Garhwal wrote: > > Rename iommu_dt_device_is_assigned() to > > iommu_dt_device_is_assigned_locked(). > > > > Moving spin_lock to caller was done to prevent the concurrent access to > > iom

Re: [XEN][PATCH v10 05/20] xen/arm: Add CONFIG_OVERLAY_DTB

On Tue, Aug 29, 2023 at 09:23:55AM +0200, Michal Orzel wrote: > > > On 25/08/2023 10:02, Vikram Garhwal wrote: > > > > > > Introduce a config option where the user can enable support for > > adding/removing > > device tree nodes using a device tree binary overlay. > > > > Update SUPPORT.md an

Re: [XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type

Hi Michal, On Tue, Aug 29, 2023 at 09:17:37AM +0200, Michal Orzel wrote: > > > On 25/08/2023 10:02, Vikram Garhwal wrote: > > Remove __init from following function to access during runtime: > > 1. map_irq_to_domain() > > 2. handle_device_interrupts() > > 3. map_range_to_domain() > >

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30/08/2023 5:13 pm, Jan Beulich wrote: > On 30.08.2023 17:28, Andrew Cooper wrote: >> On 30/08/2023 4:12 pm, Jan Beulich wrote: >>> On 30.08.2023 16:35, Andrew Cooper wrote: On 29/08/2023 3:08 pm, Jan Beulich wrote: > On 29.08.2023 15:43, Andrew Cooper wrote: >> --- a/xen/arch/x86/d

[PATCH v3 0/2] introduce stub directory to storing empty/stub headers

A lot of empty/stub headers should be introduced during the early steps of adding support of new architecture. An example can be found here: 1. https://lore.kernel.org/xen-devel/cover.1692181079.git.oleksii.kuroc...@gmail.com/ 2. https://lore.kernel.org/xen-devel/a92f99e8f697da99d77bfde562a549d

[PATCH v3 1/2] xen: add asm-generic dir to include path

asm-generic dir will contain empty/stubs generic for all architectures. Signed-off-by: Oleksii Kurochko --- Changes in V3: - Rename stubs dir to asm-generic --- Changes in V2: - Nothing changed. --- xen/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/Makefile b/xen/Makefile in

[PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

asm/vm_event.h is common for ARM and RISC-V so it will be moved to asm-generic dir. Original asm/vm_event.h from ARM was updated: * use SPDX-License-Identifier. * update comment messages of stubs. * update #ifdef. * change public/domctl.h to public/vm_event.h. Signed-off-by: Oleksii Kurochko

QEMU features useful for Xen development?

Dear Xen community, Linaro is significantly invested in QEMU development, with a special focus on Arm-related aspects. We recognize the value of QEMU as a readily available software reference platform for projects that need to test their software well before the availability of real hardware. T

[xen-unstable test] 182563: tolerable FAIL

flight 182563 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182563/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182557 test-armhf-armhf-libvirt 16 save

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30.08.2023 17:28, Andrew Cooper wrote: > On 30/08/2023 4:12 pm, Jan Beulich wrote: >> On 30.08.2023 16:35, Andrew Cooper wrote: >>> On 29/08/2023 3:08 pm, Jan Beulich wrote: On 29.08.2023 15:43, Andrew Cooper wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @

[PATCH v8 4/4] x86/microcode: Disable microcode update handler if DIS_MCU_UPDATE is set

If IA32_MSR_MCU_CONTROL exists then it's possible a CPU may be unable to perform microcode updates. This is controlled through the DIS_MCU_LOAD bit and is intended for baremetal clouds where the owner may not trust the tenant to choose the microcode version in use. If we notice that bit being set t

[PATCH v8 1/4] x86/microcode: WARN->INFO for the "no ucode loading" log message

Currently there's a printk statement triggered when no ucode loading facilities are discovered. This statement should have severity INFO rather than WARNING because it's not reporting anything wrong. Warnings ought to be reserved for recoverable system errors. Signed-off-by: Alejandro Vallejo --

[PATCH v8 3/4] x86: Read MSR_ARCH_CAPS immediately after early_microcode_init()

Move MSR_ARCH_CAPS read code from tsx_init() to early_cpu_init(). Because microcode updates might make them that MSR to appear/have different values we also must reload it after a microcode update in early_microcode_init(). Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v8: * No

[PATCH v8 0/4] Prevent attempting updates known to fail

Now that XENLOG_INFO is the default logging level... v8: * Fixed last bits mentioned by Jan in v7/patch1 (v8/patch2) * Rolled back to having new printk as INFO * Added v8/patch1 to ensure the existing early exit from early_cpu_init() has INFO severity as well. Original cover letter: Un

[PATCH v8 2/4] x86/microcode: Ignore microcode loading interface for revision = -1

Some hypervisors report ~0 as the microcode revision to mean "don't issue microcode updates". Ignore the microcode loading interface in that case. Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v8: * Added missing newline in printk statement * Reduced indentation of second lin

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

Jan! On Wed, Aug 30 2023 at 09:20, Jan Beulich wrote: > On 30.08.2023 00:54, Thomas Gleixner wrote: >> On Tue, Aug 29 2023 at 16:25, Roger Pau Monné wrote: >> >> Correct. These IDs are invalid independent of any flag value. > > What we apparently agree on is these special UID values to be invali

[ovmf test] 182568: all pass - PUSHED

flight 182568 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182568/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0c4d0b6c8a05a6a62c0dca042f8e15e579e6f4af baseline version: ovmf a481c1114474160f53b16

RE: [EXT] Re: xen arm64 low power sleep support

-Original Message- From: Stefano Stabellini Sent: Tuesday, August 29, 2023 4:13 PM To: Anthony Chan Cc: xen-devel@lists.xenproject.org; bertrand.marq...@arm.com; jul...@xen.org; volodymyr_babc...@epam.com; michal.or...@amd.com; Dan Waqar ; sstabell...@kernel.org Subject: [EXT] Re: xe

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30/08/2023 4:12 pm, Jan Beulich wrote: > On 30.08.2023 16:35, Andrew Cooper wrote: >> On 29/08/2023 3:08 pm, Jan Beulich wrote: >>> On 29.08.2023 15:43, Andrew Cooper wrote: --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -1074,8 +1074,27 @@ int arch_set_info_guest( >>>

Re: [XEN PATCH 07/13] x86/asm: address violations of MISRA C:2012 Directive 4.10

On 29/08/23 00:30, Stefano Stabellini wrote: On Mon, 28 Aug 2023, Simone Ballarin wrote: Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusion gu

Re: [PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

On 30.08.2023 16:20, Andrew Cooper wrote: > On 30/08/2023 2:39 pm, Jan Beulich wrote: >> On 24.08.2023 17:26, Jinoh Kang wrote: >>> --- a/xen/arch/x86/x86_emulate/x86_emulate.h >>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h >>> @@ -78,7 +78,10 @@ struct x86_event { >>> uint8_t type;

Re: [XEN PATCH 06/13] x86/EFI: address violations of MISRA C:2012 Directive 4.10

On 29/08/23 15:27, Jan Beulich wrote: On 28.08.2023 15:20, Simone Ballarin wrote: Add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Mechanical change. Signed-

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30.08.2023 16:35, Andrew Cooper wrote: > On 29/08/2023 3:08 pm, Jan Beulich wrote: >> On 29.08.2023 15:43, Andrew Cooper wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -1074,8 +1074,27 @@ int arch_set_info_guest( >>> #endif >>> flags = c(flags); >>> >>> +

RE: [EXT] Re: xen arm64 low power sleep support

On Tue, 29 Aug 2023, Stefano Stabellini wrote: > On Tue, 29 Aug 2023, Anthony Chan wrote: > > Hi all, > > > > My name is Tony and I've been researching/developing using Xen for > potential upcoming uses in our embedded systems. I started with Xen > using Xilinx tools about a year ago and still hav

Re: [PATCH v7 9/9] swiotlb: search the software IO TLB only if the device makes use of it

So it seems this code got merged without this question ever being answered. Sorry if it's a dumb one, but I don't think this functionality works as advertised... Thanks, jon Jonathan Corbet writes: > Petr Tesarik writes: > >> From: Petr Tesarik >> >> Skip searching the software IO TLB if a

Re: [XEN PATCH 11/13] xen/sched: address violations of MISRA C:2012 Directive 4.10

On Mon, Aug 28, 2023 at 2:20 PM Simone Ballarin wrote: > > Add inclusion guards to address violations of > MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order > to prevent the contents of a header file being included more than > once"). > > Mechanical change. > > Signed-off-by: Simon

Re: [PATCH v2 2/8] x86/hvm: Only populate info->cr2 for #PF in hvm_get_pending_event()

On 8/30/23 22:41, Jan Beulich wrote: > On 24.08.2023 17:25, Jinoh Kang wrote: >> Prepare for an upcoming patch that overloads the 'cr2' field for #DB. > > Seeing the subsequent change and the fact that earlier on Andrew didn't > need such an adjustment, I'm afraid I can't see the need for this cha

Re: [XEN PATCH 05/13] automation/eclair: add deviation for usercopy.c

On 29/08/23 00:27, Stefano Stabellini wrote: +Nicola, Luca On Mon, 28 Aug 2023, Simone Ballarin wrote: xen/arch/x86/usercopy.c includes itself, so it is not supposed to comply with Directive 4.10: "Precautions shall be taken in order to prevent the contents of a header file being included more

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 30/08/2023 7:46 am, Jan Beulich wrote: > On 29.08.2023 15:43, Andrew Cooper wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -1074,8 +1074,27 @@ int arch_set_info_guest( >> #endif >> flags = c(flags); >> >> +if ( !compat ) >> +{ >> +if ( c(debugr

Re: [PATCH 1/3] x86: Reject bad %dr6/%dr7 values when loading guest state

On 29/08/2023 3:08 pm, Jan Beulich wrote: > On 29.08.2023 15:43, Andrew Cooper wrote: >> --- a/xen/arch/x86/domain.c >> +++ b/xen/arch/x86/domain.c >> @@ -1074,8 +1074,27 @@ int arch_set_info_guest( >> #endif >> flags = c(flags); >> >> +if ( !compat ) >> +{ >> +if ( c(debugr

Re: [PATCH v2 1/2] xen: add stubs dir to include path

On Wed, 2023-08-30 at 09:30 +0200, Jan Beulich wrote: > On 29.08.2023 16:34, Oleksii Kurochko wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -438,6 +438,7 @@ ifdef building_out_of_srctree > >  endif > >  CFLAGS += -I$(srctree)/include > >  CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

On Wed, Sep 12, 2018 at 03:09:35AM -0600, Jan Beulich wrote: > The function does two translations in one go for a single guest access. > Any failure of the first translation step (guest linear -> guest > physical), resulting in #PF, ought to take precedence over any failure > of the second step (gu

Re: [PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

On 30/08/2023 2:39 pm, Jan Beulich wrote: > On 24.08.2023 17:26, Jinoh Kang wrote: >> @@ -62,9 +63,16 @@ void pv_inject_event(const struct x86_event *event) >> error_code |= PFEC_user_mode; >> >> trace_pv_page_fault(event->cr2, error_code); >> -} >> -else >> +

Re: [PATCH v4 4/6] xen/vpci: header: status register handler

On 28.08.2023 19:56, Stewart Hildebrand wrote: > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -413,6 +413,18 @@ static void cf_check cmd_write( > pci_conf_write16(pdev->sbdf, reg, cmd); > } > > +static uint32_t cf_check status_read(const struct pci_dev *pdev, >

Re: [PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

On 30/08/2023 2:30 pm, Jan Beulich wrote: > On 24.08.2023 17:26, Jinoh Kang wrote: >> From: Andrew Cooper >> >> All #DB exceptions result in an update of %dr6, but this isn't captured in >> Xen's handling. >> >> PV guests generally work by modifying %dr6 before raising #DB, whereas HVM >> guests d

Re: [PATCH v4 3/6] x86/msi: rearrange read_pci_mem_bar slightly

On 28.08.2023 19:56, Stewart Hildebrand wrote: > Use pdev->sbdf instead of the PCI_SBDF macro in calls to pci_* functions > where appropriate. Move NULL check earlier. > > Suggested-by: Jan Beulich > Signed-off-by: Stewart Hildebrand Reviewed-by: Jan Beulich

Re: [PATCH v2 2/8] x86/hvm: Only populate info->cr2 for #PF in hvm_get_pending_event()

On 30/08/2023 2:41 pm, Jan Beulich wrote: > On 24.08.2023 17:25, Jinoh Kang wrote: >> Prepare for an upcoming patch that overloads the 'cr2' field for #DB. > Seeing the subsequent change and the fact that earlier on Andrew didn't > need such an adjustment, I'm afraid I can't see the need for this c

Re: [PATCH v4 2/6] xen/pci: convert pci_find_*cap* to pci_sbdf_t

On 28.08.2023 19:56, Stewart Hildebrand wrote: > Convert pci_find_*cap* functions and call sites to pci_sbdf_t, and remove some > now unused local variables. Also change to more appropriate types on lines > that > are already being modified as a result of the pci_sbdf_t conversion. > > Signed-off

Re: [PATCH v2 2/8] x86/hvm: Only populate info->cr2 for #PF in hvm_get_pending_event()

On 24.08.2023 17:25, Jinoh Kang wrote: > Prepare for an upcoming patch that overloads the 'cr2' field for #DB. Seeing the subsequent change and the fact that earlier on Andrew didn't need such an adjustment, I'm afraid I can't see the need for this change, and the one sentence above also doesn't a

Re: [PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

On 24.08.2023 17:26, Jinoh Kang wrote: > @@ -62,9 +63,16 @@ void pv_inject_event(const struct x86_event *event) > error_code |= PFEC_user_mode; > > trace_pv_page_fault(event->cr2, error_code); > -} > -else > +break; > + > +case X86_EXC_DB: > +curr

Re: [PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

On 24.08.2023 17:26, Jinoh Kang wrote: > From: Andrew Cooper > > All #DB exceptions result in an update of %dr6, but this isn't captured in > Xen's handling. > > PV guests generally work by modifying %dr6 before raising #DB, whereas HVM > guests do nothing and have a single-step special case in

Re: [PATCH v2 7/8] xen/ppc: Add stub function and symbol definitions

On 23.08.2023 22:07, Shawn Anastasio wrote: > +/* irq.c */ > + > +struct pirq *alloc_pirq_struct(struct domain *d) > +{ > +BUG_ON("unimplemented"); > +} > + > +int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share) > +{ > +BUG_ON("unimplemented"); > +} > + > +void pirq_guest

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

On 30/08/23 15:01, Jan Beulich wrote: On 30.08.2023 14:53, Simone Ballarin wrote: On 29/08/23 00:10, Julien Grall wrote: On Mon, 28 Aug 2023 at 09:20, Simone Ballarin wrote: --- a/xen/arch/arm/include/asm/hypercall.h +++ b/xen/arch/arm/include/asm/hypercall.h @@ -1,10 +1,10 @@ +#ifndef __ASM_

Re: [PATCH v2 6/8] xen/ppc: Define bug frames table in linker script

On 23.08.2023 22:07, Shawn Anastasio wrote: > Define the bug frames table in ppc's linker script as is done by other > architectures. > > Signed-off-by: Shawn Anastasio > Acked-by: Jan Beulich If I'm not mistaken this change is independent of the earlier patches, and hence could go in right awa

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

On 30.08.2023 14:53, Simone Ballarin wrote: > On 29/08/23 00:10, Julien Grall wrote: >> On Mon, 28 Aug 2023 at 09:20, Simone Ballarin >> wrote: >>> --- a/xen/arch/arm/include/asm/hypercall.h >>> +++ b/xen/arch/arm/include/asm/hypercall.h >>> @@ -1,10 +1,10 @@ >>> +#ifndef __ASM_ARM_HYPERCALL_H__ >

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Directive 4.10

On 29/08/23 00:10, Julien Grall wrote: Hi, On Mon, 28 Aug 2023 at 09:20, Simone Ballarin wrote: Add or move inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). In

[libvirt test] 182562: tolerable all pass - PUSHED

flight 182562 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182562/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182550 test-armhf-armhf-libvirt-qcow2 15 saveres

[ovmf test] 182567: all pass - PUSHED

flight 182567 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182567/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a481c1114474160f53b1662fd3726b48c88ae82e baseline version: ovmf 5f46eb2307dd6d4ea163b

[xen-unstable-smoke test] 182565: tolerable all pass - PUSHED

flight 182565 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182565/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH 02/13] automation/eclair: add text-based deviation for empty headers

On 29/08/23 08:35, Jan Beulich wrote: On 28.08.2023 15:19, Simone Ballarin wrote: --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -80,6 +80,7 @@ inline functions." -doc_begin="This header file is autogenerated or empty, theref

Re: [PATCH v2 5/8] xen/ppc: Define minimal stub headers required for full build

On 23.08.2023 22:07, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/arch/ppc/include/asm/altp2m.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_PPC_ALTP2M_H__ > +#define __ASM_PPC_ALTP2M_H__ > + > +#include > + > +struct domain; > +struct vcpu; > + > +/* Al

Re: [XEN PATCH 02/13] automation/eclair: add text-based deviation for empty headers

On 29/08/23 00:00, Stefano Stabellini wrote: On Mon, 28 Aug 2023, Simone Ballarin wrote: This patch adds a text-based deviation for Directive 4.10: "Precautions shall be taken in order to prevent the contents of a header file being included more than once" Headers starting with the following co

[ovmf test] 182564: all pass - PUSHED

flight 182564 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182564/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5f46eb2307dd6d4ea163b6899ded81e795780059 baseline version: ovmf 9896a9c61836a5afba72c

[linux-linus test] 182559: regressions - FAIL

flight 182559 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182559/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

Re: [XEN][PATCH v10 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

On 30/08/2023 00:45, Stefano Stabellini wrote: > > > On Tue, 29 Aug 2023, Michal Orzel wrote: >> On 25/08/2023 10:02, Vikram Garhwal wrote: >>> Add remove_device callback for removing the device entry from smmu-master >>> using >>> following steps: >>> 1. Find if SMMU master exists for the de

Re: 4.17 backports

On 22.08.2023 21:25, Andrew Cooper wrote: > Looking at the patchqueue, the following should be considered for backport: > > 19c6cbd90965 xen/vcpu: ignore VCPU_SSHOTTMR_future I will admit I'm a little hesitant here, for being an ABI change (even if to the better), but I guess I'll still include i

Re: [XEN PATCH 01/13] misra: add deviation for headers that explicitly avoid guards

On 29/08/23 00:32, Stefano Stabellini wrote: On Mon, 28 Aug 2023, Stefano Stabellini wrote: On Mon, 28 Aug 2023, Simone Ballarin wrote: Some headers, under specific circumstances (documented in a comment at the beginning of the file), explicitly avoid inclusion guards: the caller is responsible

Re: [XEN PATCH 01/13] misra: add deviation for headers that explicitly avoid guards

On 29/08/23 08:33, Jan Beulich wrote: On 28.08.2023 15:19, Simone Ballarin wrote: --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -60,7 +60,8 @@ maintainers if you want to suggest a change. - Precautions shall be taken in order to prevent the contents of a header file be

[PATCH] MAINTAINERS: consolidate vm-event/monitor entry

If the F: description is to be trusted, the two xen/arch/x86/hvm/ lines were fully redundant with the earlier wildcard ones. Arch header files, otoh, were no longer covered by anything as of the move from include/asm-*/ to arch/*/include/asm/. Finally also generalize (by folding) the x86- and Arm-s

Re: [PATCH] docs/misra: add 14.3 and 14.4

On 30.08.2023 10:00, Bertrand Marquis wrote: > Hi, > >> On 30 Aug 2023, at 09:58, Jan Beulich wrote: >> >> On 30.08.2023 09:54, Bertrand Marquis wrote: On 30 Aug 2023, at 02:59, Stefano Stabellini wrote: + * - `Rule 14.4

Re: [PATCH] docs/misra: add 14.3 and 14.4

Hi, > On 30 Aug 2023, at 09:58, Jan Beulich wrote: > > On 30.08.2023 09:54, Bertrand Marquis wrote: >>> On 30 Aug 2023, at 02:59, Stefano Stabellini wrote: >>> + * - `Rule 14.4 >>> `_ >>> + - Required >>

Re: [PATCH] docs/misra: add 14.3 and 14.4

On 30.08.2023 09:54, Bertrand Marquis wrote: >> On 30 Aug 2023, at 02:59, Stefano Stabellini wrote: >> + * - `Rule 14.4 >> `_ >> + - Required >> + - The controlling expression of an if statement and the

Re: [PATCH v2 1/2] xen: add stubs dir to include path

Hi Jan, > On 30 Aug 2023, at 09:30, Jan Beulich wrote: > > On 29.08.2023 16:34, Oleksii Kurochko wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -438,6 +438,7 @@ ifdef building_out_of_srctree >> endif >> CFLAGS += -I$(srctree)/include >> CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include >>

Re: [PATCH] docs/misra: add 14.3 and 14.4

Hi Stefano, > On 30 Aug 2023, at 02:59, Stefano Stabellini wrote: > > From: Stefano Stabellini > > Add 14.3, with a project-wide deviations on if statements. > Add 14.4, clarifying that implicit conversions of integers, chars and > pointers to bool are allowed. > > Also take the opportunity t

Re: [PATCH v2] docs/misra: add rules 10.1 10.2 10.3 10.4

Hi Stefano, > On 25 Aug 2023, at 23:48, Stefano Stabellini wrote: > > From: Stefano Stabellini > > 10.1 with several caveats, described in the notes. > 10.3 and 10.4 as "aspirational" guidelines, as clarified in the notes. > > Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis

Re: [PATCH] docs/misra: add 14.3 and 14.4

On 30.08.2023 02:59, Stefano Stabellini wrote: > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -234,7 +234,7 @@ maintainers if you want to suggest a change. > * - `Rule 8.2 > `_ > - Requir

Re: [PATCH v9 12/16] vpci: add initial support for virtual PCI bus topology

On 30.08.2023 01:19, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > Assign SBDF to the PCI devices being passed through with bus 0. > The resulting topology is where PCIe devices reside on the bus 0 of the > root complex itself (embedded endpoints). > This implementation is limited

Re: [PATCH v2 1/2] xen: add stubs dir to include path

On 29.08.2023 16:34, Oleksii Kurochko wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -438,6 +438,7 @@ ifdef building_out_of_srctree > endif > CFLAGS += -I$(srctree)/include > CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include > +CFLAGS += -I$(srctree)/include/stubs > > # Note that link ord

Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT

On 30.08.2023 00:54, Thomas Gleixner wrote: > On Tue, Aug 29 2023 at 16:25, Roger Pau Monné wrote: >> On Sun, Aug 27, 2023 at 05:44:15PM +0200, Thomas Gleixner wrote: >>> The APIC/X2APIC description of MADT specifies flags: >>> >>> Enabled If this bit is set the processor is ready for u