[xen-unstable-smoke test] 182392: tolerable all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182392 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182392/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 182393: all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182393 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182393/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 00b51e0d78a547dd78119ec44fcc74a01b6f79c8 baseline version: ovmf 48089f3a7cdf308651234

[xen-unstable test] 182387: tolerable FAIL - PUSHED

2023-08-18 Thread osstest service owner
flight 182387 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182387/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182377 test-amd64-i386-xl-qemuu-win7-amd64

[linux-linus test] 182378: regressions - FAIL

2023-08-18 Thread osstest service owner
flight 182378 linux-linus real [real] flight 182390 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182378/ http://logs.test-lab.xenproject.org/osstest/logs/182390/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[PATCH] docs/misra: add exceptions to rules

2023-08-18 Thread Stefano Stabellini
From: Stefano Stabellini During the discussions that led to the acceptable of the Rules, we decided on a few exceptions that were not properly recorded in rules.rst. Other times, the exceptions were decided later when it came to enabling a rule in ECLAIR. Either way, update rules.rst with approp

[XEN][PATCH v9 15/19] xen/arm: Implement device tree node removal functionalities

2023-08-18 Thread Vikram Garhwal
Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node en

[XEN][PATCH v9 18/19] tools/libs/light: Implement new libxl functions for device tree overlay ops

2023-08-18 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/include/libxl.h | 11 + tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 + 3 files changed, 85 insertions(+) create mode 100644 tools/libs/ligh

[PATCH] docs/misra: document gcc-specific behavior with shifting signed integers

2023-08-18 Thread Stefano Stabellini
From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- Changes in v2: - use "shift" instead of << or >> - use All Architectures (I haven't changed all the other instances of x86/arm in the file yet) --- docs/misra/C-language-toolchain.rst | 6 ++ 1 file changed, 6 insertions(+) dif

[XEN][PATCH v9 19/19] tools/xl: Add new xl command overlay for device tree overlay support

2023-08-18 Thread Vikram Garhwal
Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 + 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81

[XEN][PATCH v9 16/19] xen/arm: Implement device tree node addition functionalities

2023-08-18 Thread Vikram Garhwal
Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is

[XEN][PATCH v9 17/19] tools/libs/ctrl: Implement new xc interfaces for dt overlay

2023-08-18 Thread Vikram Garhwal
xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal --- tools/include/xenctrl.h | 5 tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overlay.c | 51

[XEN][PATCH v9 13/19] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h

2023-08-18 Thread Vikram Garhwal
Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, we will need to add a rwlock to protect access to the dt_host. However, adding rwlock in device_tree.h causes following circular dependenc

[XEN][PATCH v9 11/19] xen/iommu: Introduce iommu_remove_dt_device()

2023-08-18 Thread Vikram Garhwal
Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Acked-by: Jan Beulich --- Changes from v7: Add check if IOMMU is enabled. Fix indentation of fail. --- --- xen/drivers/pass

[XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

2023-08-18 Thread Vikram Garhwal
Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition of dynamic programming feature(follow-up patches in this series), this function can be concurrently access by pci device assign/deassign and also by dynamic node add/remove using

[XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host

2023-08-18 Thread Vikram Garhwal
Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. dt_host writer will be added in the follow-up patch titled "xen/arm: Implement

[XEN][PATCH v9 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-08-18 Thread Vikram Garhwal
Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Remove static type so this can also be used by SMMU drivers to check if the device is being used before removing. Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while

[XEN][PATCH v9 07/19] libfdt: overlay: change overlay_get_target()

2023-08-18 Thread Vikram Garhwal
Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the ov

[XEN][PATCH v9 12/19] xen/smmu: Add remove_device callback for smmu_iommu ops

2023-08-18 Thread Vikram Garhwal
Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Check if device is currently in use. 3. Remove the SMMU master. Signed-off-by: Vikram Garhwal Reviewed-by: Luca Fancellu Reviewed-by: Michal Orze

[XEN][PATCH v9 06/19] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.

2023-08-18 Thread Vikram Garhwal
This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Mak

[XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree()

2023-08-18 Thread Vikram Garhwal
Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. The changes are done to make this function useable for dynamic node programming where new device tree overlay nodes are ad

[XEN][PATCH v9 02/19] common/device_tree.c: unflatten_device_tree() propagate errors

2023-08-18 Thread Vikram Garhwal
This will be useful in dynamic node programming when new dt nodes are unflattend during runtime. Invalid device tree node related errors should be propagated back to the caller. Signed-off-by: Vikram Garhwal --- Changes from v7: Free allocated memory in case of errors when calling unflatten_

[XEN][PATCH v9 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

2023-08-18 Thread Vikram Garhwal
Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unfl

[XEN][PATCH v9 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

2023-08-18 Thread Vikram Garhwal
Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for Arm. Signed-off-by: Vikram Garhwal Acked-by: Henry Wang Reviewed-by: Michal Orze

[XEN][PATCH v9 01/19] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

2023-08-18 Thread Vikram Garhwal
Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Fixes: fb97eb614acf ("xen/arm: Create a hierarchical device tree") Signed-off-by: Vikram Garhwal Reviewe

[XEN][PATCH v9 03/19] xen/arm/device: Remove __init from function type

2023-08-18 Thread Vikram Garhwal
Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupts() 3. map_range_to_domain() 4. unflatten_dt_node() Move map_irq_to_domain() prototype from domain_build.h to setup.h. To avoid breaking the build, following changes ar

[XEN][PATCH v9 00/19] dynamic node programming using overlay dtbo

2023-08-18 Thread Vikram Garhwal
Hi, This patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl dt_overlay" a device can be added/removed with dtbo. For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt wi

Re: Community Manager update - August 2023

2023-08-18 Thread Chuck Zmudzinski
On 8/18/2023 6:55 AM, Kelly Choi wrote: > Hi everyone! :)  > > I hope you're all well.  > > If we haven't met before, I'd like to introduce myself. I'm Kelly, the > Community Manager for The Xen Project. My role is to support everyone and > make sure the project is healthy and thriving.  > > *

[xen-unstable-smoke test] 182388: tolerable all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182388 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182388/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xtf test] 182389: all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182389 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182389/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf cec23a34c03ffcf12d68d35f0e1d7f9ae85ab49c baseline version: xtf bf1c4eb6cb52785cf539eb

Re: [XEN][PATCH v8 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-08-18 Thread Julien Grall
Hi Vikram, On 18/08/2023 20:52, Vikram Garhwal wrote: Hi Jan On Thu, Aug 17, 2023 at 09:05:44AM +0200, Jan Beulich wrote: On 17.08.2023 02:39, Vikram Garhwal wrote: --- /dev/null +++ b/xen/include/xen/iommu-private.h I don't think private headers should live in include/xen/. Judging from onl

Re: [PATCH 0/6] x86/debug: fix guest dr6 value for single stepping and HW breakpoints

2023-08-18 Thread Andrew Cooper
On 18/08/2023 4:44 pm, Jinoh Kang wrote: > Xen has a bug where hardware breakpoint exceptions (DR_TRAP) are > erroneously recognized as single-stepping exceptions (DR_STEP). I expected this to come back and bite. https://lore.kernel.org/xen-devel/1528120755-17455-1-git-send-email-andrew.coop...@c

Re: Community Manager update - August 2023

2023-08-18 Thread Stefano Stabellini
On Fri, 18 Aug 2023, Bertrand Marquis wrote: > Hi Kelly, > > > On 18 Aug 2023, at 12:55, Kelly Choi wrote: > > > > Hi everyone! :) > > > > I hope you're all well. > > > > If we haven't met before, I'd like to introduce myself. I'm Kelly, the > > Community Manager for The Xen Project. My role is

Re: [PATCH 3/6] x86: don't assume #DB is always caused by singlestep if EFLAGS.TF is set

2023-08-18 Thread Jinoh Kang
On 8/19/23 00:47, Jinoh Kang wrote: > Today, when a HVM (or PVH) guest triggers a hardware breakpoint while > EFLAGS.TF is set, Xen incorrectly assumes that this is a single stepping > exception and sets DR_STEP in dr6 in addition to DR_TRAP. > > This causes problems with Linux HW breakpoint handl

Re: [XEN][PATCH v8 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-08-18 Thread Vikram Garhwal
Hi Jan On Thu, Aug 17, 2023 at 09:05:44AM +0200, Jan Beulich wrote: > On 17.08.2023 02:39, Vikram Garhwal wrote: > > --- /dev/null > > +++ b/xen/include/xen/iommu-private.h > > I don't think private headers should live in include/xen/. Judging from only > the patches I was Cc-ed on, ... Thank you

Re: [XTF PATCH] xtf-runner: python3 fix

2023-08-18 Thread Andrew Cooper
On 17/08/2023 11:51 am, Anthony PERARD wrote: > issue: > File "/home/xtf/xtf-runner", line 410, in interpret_selection > if not line.startswith("xen_caps"): >^^^ > TypeError: startswith first arg must be bytes or a tuple of bytes, not str > > Adding `univer

Re: [PATCH] x86/svm: invert valid condition in svm_get_pending_event()

2023-08-18 Thread Andrew Cooper
On 18/08/2023 5:03 pm, Jinoh Kang wrote: > Fixes: 9864841914c2 ("x86/vm_event: add support for > VM_EVENT_REASON_INTERRUPT") > Signed-off-by: Jinoh Kang Yeah, that's just straight up broken.  I'm not aware of anyone having used this in anger on AMD systems yet. Reviewed-by: Andrew Cooper I've

[xen-unstable-smoke test] 182386: tolerable all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182386 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182386/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable test] 182377: tolerable FAIL

2023-08-18 Thread osstest service owner
flight 182377 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182377/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 182372 test-armhf-armhf-libvirt 16 s

Re: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove()

2023-08-18 Thread Anthony PERARD
On Wed, Aug 09, 2023 at 11:33:04AM +0100, Julien Grall wrote: > From: Julien Grall > > The function do_pci_remove() has two local variables 'domid' and > 'domainid' containing the same value. > > Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use > libxl__ao_device with pci_remove") the

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-18 Thread Anthony PERARD
On Wed, Aug 09, 2023 at 11:33:05AM +0100, Julien Grall wrote: > From: Julien Grall > > Currently, libxl will grant IOMEM, I/O port and IRQ permissions when > a PCI is attached (see pci_add_dm_done()) for all domain types. However, > the permissions are only revoked for non-HVM domain (see do_pci_

[PATCH] x86/svm: invert valid condition in svm_get_pending_event()

2023-08-18 Thread Jinoh Kang
Fixes: 9864841914c2 ("x86/vm_event: add support for VM_EVENT_REASON_INTERRUPT") Signed-off-by: Jinoh Kang --- xen/arch/x86/hvm/svm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 01dd592d9b83..beb076ea8d62 100

[libvirt test] 182376: tolerable FAIL - PUSHED

2023-08-18 Thread osstest service owner
flight 182376 libvirt real [real] flight 182382 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182376/ http://logs.test-lab.xenproject.org/osstest/logs/182382/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-li

[xen-unstable-smoke test] 182385: tolerable all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182385 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182385/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH 6/6] x86/debug: actually plumb pending_dbg through the monitor and devicemodel interfaces

2023-08-18 Thread Jinoh Kang
Commit 21867648033d ("x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces") introduced pending_dbg, but did not actually populate or use the field. Signed-off-by: Jinoh Kang --- xen/arch/x86/hvm/svm/svm.c | 34 +++--- xen/arch/x86/hvm/vmx/vmx.c

[PATCH 5/6] x86/pv: factor out single-step debug trap injection

2023-08-18 Thread Jinoh Kang
Add pv_inject_debug_exception() helper and use it wherever applicable. This helper corresponds to hvm_inject_debug_exception() in HVM. Signed-off-by: Jinoh Kang --- xen/arch/x86/include/asm/domain.h | 12 xen/arch/x86/pv/emulate.c | 5 + xen/arch/x86/pv/ro-page-fault.c

[PATCH 3/6] x86: don't assume #DB is always caused by singlestep if EFLAGS.TF is set

2023-08-18 Thread Jinoh Kang
Today, when a HVM (or PVH) guest triggers a hardware breakpoint while EFLAGS.TF is set, Xen incorrectly assumes that this is a single stepping exception and sets DR_STEP in dr6 in addition to DR_TRAP. This causes problems with Linux HW breakpoint handler, which ignores DR_TRAP bits when DR_STEP is

[PATCH 4/6] x86/pv: set DR_STEP if single-stepping after ro page fault emulation

2023-08-18 Thread Jinoh Kang
Signed-off-by: Jinoh Kang --- xen/arch/x86/pv/ro-page-fault.c | 4 1 file changed, 4 insertions(+) diff --git a/xen/arch/x86/pv/ro-page-fault.c b/xen/arch/x86/pv/ro-page-fault.c index cad28ef928ad..238bfbeb4ac4 100644 --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault

[PATCH 2/6] x86emul: rename field 'cr2' of struct x86_event to 'extra'

2023-08-18 Thread Jinoh Kang
XEN_DMOP_inject_event() copies the 'cr2' argument to struct x86_event. 'cr2' is overladed to mean pending_dbg for a debug trap, but consumers of struct x86_event always interpret it as CR2. Clarify the role of the 'cr2' field by renaming it to 'extra', in preparation for an upcoming patch that use

[PATCH 1/6] x86/hvm: only populate info->cr2 for #PF in hvm_get_pending_event()

2023-08-18 Thread Jinoh Kang
Prepare for an upcoming patch that overloads the 'cr2' field for #DB. Signed-off-by: Jinoh Kang --- xen/arch/x86/hvm/hvm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 3a99c0ff20be..48a77524f198 100644 --- a/xe

[PATCH 0/6] x86/debug: fix guest dr6 value for single stepping and HW breakpoints

2023-08-18 Thread Jinoh Kang
Xen has a bug where hardware breakpoint exceptions (DR_TRAP) are erroneously recognized as single-stepping exceptions (DR_STEP). This interferes with userland debugging and allows (otherwise restricted) usermode programs to detect Xen HVM (or PVH). This patch series aim to fix this. The last pat

Re: [PATCH v2 4/4] virtio-blk: remove batch notification BH

2023-08-18 Thread Eric Blake
On Thu, Aug 17, 2023 at 11:58:47AM -0400, Stefan Hajnoczi wrote: > There is a batching mechanism for virtio-blk Used Buffer Notifications > that is no longer needed because the previous commit added batching to > virtio_notify_irqfd(). > > Note that this mechanism was rarely used in practice becau

Re: [PATCH v2 3/4] virtio: use defer_call() in virtio_irqfd_notify()

2023-08-18 Thread Eric Blake
On Thu, Aug 17, 2023 at 11:58:46AM -0400, Stefan Hajnoczi wrote: > virtio-blk and virtio-scsi invoke virtio_irqfd_notify() to send Used > Buffer Notifications from an IOThread. This involves an eventfd > write(2) syscall. Calling this repeatedly when completing multiple I/O > requests in a row is w

[ovmf test] 182383: all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182383 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182383/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 48089f3a7cdf308651234f5bf8d8a301f4b8acf9 baseline version: ovmf eaffa1d7ff915d5af484e

Re: [PATCH] Drop remains of prior SCMs

2023-08-18 Thread Julien Grall
Hi Andrew, On 18/08/2023 15:45, Andrew Cooper wrote: None of the mercurial metadata has been updated since around Xen 4.2, making them more than a decade stale. Signed-off-by: Andrew Cooper Acked-by: Julien Grall Cheers, --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC:

[PATCH] Drop remains of prior SCMs

2023-08-18 Thread Andrew Cooper
None of the mercurial metadata has been updated since around Xen 4.2, making them more than a decade stale. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall --- .hgignore | 329

Re: [PATCH v5] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Andrew Cooper
On 18/08/2023 3:08 pm, Juergen Gross wrote: > diff --git a/.gitignore b/.gitignore > index c1b73b0968..c6489c4e70 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -237,22 +237,22 @@ tools/xenmon/xentrace_setmask > tools/xenmon/xenbaked > tools/xenpaging/xenpaging > tools/xenpmd/xenpmd > -tools/

[PATCH v5] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Juergen Gross
In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names. Move the xenstored sources into a new directory tools/xenstored while dropping the "xenstored_" prefix from their names. This will make it clearer that x

[PATCH 0/2] xen/x86: Optimize timer_irq_works()

2023-08-18 Thread Julien Grall
From: Julien Grall Hi all, At the moment timer_irq_works() will always wait 100ms even with enough ticks elapsed. This is a bit wasteful when most of the HW should not be buggy. The admin may also know that their HW is not buggy so they could decide to skip the full 100ms. Also, looking at Linu

[PATCH 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2023-08-18 Thread Julien Grall
From: Julien Grall Currently, Xen will spend ~100ms to check if the timer works. If the Admin knows their platform have a working timer, then it would be handy to be able to bypass the check. Introduce a command line option 'no_timer_check' (the name is matching the Linux parameter) for this pur

[PATCH 2/2] xen/x86: ioapic: Bail out from timer_irq_works() as soon as possible

2023-08-18 Thread Julien Grall
From: Julien Grall Currently timer_irq_works() will wait the full 100ms before checking that pit0_ticks has been incremented at least 4 times. However, the bulk of the BIOS/platform should not have a buggy timer. So waiting for the full 100ms is a bit harsh. Rework the logic to only wait until

Re: [PATCH 0/2] Rombios build fixes

2023-08-18 Thread Andrew Cooper
On 18/08/2023 2:13 pm, Jan Beulich wrote: > On 18.08.2023 15:05, Andrew Cooper wrote: >> On 18/08/2023 1:57 pm, Andrew Cooper wrote: >>> Andrew Cooper (2): >>> rombios: Avoid using K&R function syntax >>> rombiosn: Remove the use of egrep >>> >>> tools/firmware/rombios/32bit/Makefile

Re: [PATCH 0/2] Rombios build fixes

2023-08-18 Thread Jan Beulich
On 18.08.2023 15:05, Andrew Cooper wrote: > On 18/08/2023 1:57 pm, Andrew Cooper wrote: >> Andrew Cooper (2): >> rombios: Avoid using K&R function syntax >> rombiosn: Remove the use of egrep >> >> tools/firmware/rombios/32bit/Makefile | 2 +- >> tools/firmware/rombios/32bit/tcgbios/t

Re: [PATCH 2/2] rombiosn: Remove the use of egrep

2023-08-18 Thread Jan Beulich
On 18.08.2023 14:57, Andrew Cooper wrote: > As Alpine 3.18 container notes: > > egrep: warning: egrep is obsolescent; using grep -E > > Adjust it. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH 1/2] rombios: Avoid using K&R function syntax

2023-08-18 Thread Jan Beulich
On 18.08.2023 14:57, Andrew Cooper wrote: > The declarations for these functions in 32bitprotos.h are already Ansi > compatible. Update the definitions to match. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich

Re: [PATCH 0/2] Rombios build fixes

2023-08-18 Thread Andrew Cooper
On 18/08/2023 1:57 pm, Andrew Cooper wrote: > Andrew Cooper (2): > rombios: Avoid using K&R function syntax > rombiosn: Remove the use of egrep > > tools/firmware/rombios/32bit/Makefile | 2 +- > tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +- > 2 files changed, 6 ins

[PATCH 1/2] rombios: Avoid using K&R function syntax

2023-08-18 Thread Andrew Cooper
The declarations for these functions in 32bitprotos.h are already Ansi compatible. Update the definitions to match. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +- 1 file changed, 5 insertion

[PATCH 2/2] rombiosn: Remove the use of egrep

2023-08-18 Thread Andrew Cooper
As Alpine 3.18 container notes: egrep: warning: egrep is obsolescent; using grep -E Adjust it. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- tools/firmware/rombios/32bit/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/too

[PATCH 0/2] Rombios build fixes

2023-08-18 Thread Andrew Cooper
Andrew Cooper (2): rombios: Avoid using K&R function syntax rombiosn: Remove the use of egrep tools/firmware/rombios/32bit/Makefile | 2 +- tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) base-commit: e6cb27f2f20d09d

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

2023-08-18 Thread Nicola Vetrini
Jan has a point: I think we should record all our deviations and unique ways to interpret the rules under docs/misra. And the Eclair configuration should reflect that. It is not a good idea to only keep the information in the Eclair config because, even if it is now upstream in xen.git, it is

Re: [PATCH v4 00/19] tools/xenstore: drop TDB

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:46, Juergen Gross wrote: Juergen Gross (19): tools/xenstore: make hashtable key parameter const tools/xenstore: let hashtable_add() fail in case of existing entry tools/xenstore: add hashtable_replace() function tools/xenstore: drop use of tdb tools/xe

Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Juergen Gross
On 18.08.23 14:42, Julien Grall wrote: Hi Juergen, On 18/08/2023 13:14, Juergen Gross wrote: On 18.08.23 13:22, Julien Grall wrote: Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apa

Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Julien Grall
Hi Juergen, On 18/08/2023 13:14, Juergen Gross wrote: On 18.08.23 13:22, Julien Grall wrote: Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names.

[xen-unstable-smoke test] 182379: tolerable all pass - PUSHED

2023-08-18 Thread osstest service owner
flight 182379 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182379/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: Community Manager update - August 2023

2023-08-18 Thread Bertrand Marquis
Hi Kelly, > On 18 Aug 2023, at 12:55, Kelly Choi wrote: > > Hi everyone! :) > > I hope you're all well. > > If we haven't met before, I'd like to introduce myself. I'm Kelly, the > Community Manager for The Xen Project. My role is to support everyone and > make sure the project is healthy and t

Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Juergen Gross
On 18.08.23 13:22, Julien Grall wrote: Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names. Move the xenstored sources into a new directory tools/xe

Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names. Move the xenstored sources into a new directory tools/xenstored while dropping the "xenstored_"

Re: [PATCH v4 17/19] tools/xenstore: introduce get_node_const()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: Add a variant of get_node() returning a const struct node pointer. Note that all callers of this new variant don't supply a pointer where to store the canonical node name, while all callers needing a non-const node do supply this pointer. Th

Re: [PATCH v4 16/19] tools/xenstore: rework get_node()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: Today get_node_canonicalized() is the only caller of get_node(). In order to prepare introducing a get_node() variant returning a pointer to const struct node, do the following restructuring: - move the call of read_node() from get_node() i

Re: [PATCH v4 15/19] tools/xenstore: merge is_valid_nodename() into canonicalize()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: Today is_valid_nodename() is always called directly after calling canonicalize(), with the exception of do_unwatch(), where the call is missing (which is not correct, but results just in a wrong error reason being returned). Merge is_valid_n

Re: [PATCH v7 0/2] xen/riscv: introduce identity mapping

2023-08-18 Thread Oleksii
Hello Alistair and Bobby, Could you please review this patch series when you have a moment? Your insights would be greatly appreciated. Thanks in advance. ~ Oleksii On Tue, 2023-08-08 at 18:14 +0300, Oleksii Kurochko wrote: > The patch series introduces things necessary to implement identity >

Re: [PATCH v4 14/19] tools/xenstore: merge get_spec_node() into get_node_canonicalized()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: Add a "allow_special" parameter to get_node_canonicalized() allowing to merge get_spec_node() into get_node_canonicalized(). Add the same parameter to is_valid_nodename(), as this will simplify check_watch_path(). This is done in preparatio

Re: [PATCH v2 1/4] block: rename blk_io_plug_call() API to defer_call()

2023-08-18 Thread Paul Durrant
On 17/08/2023 16:58, Stefan Hajnoczi wrote: Prepare to move the blk_io_plug_call() API out of the block layer so that other subsystems call use this deferred call mechanism. Rename it to defer_call() but leave the code in block/plug.c. The next commit will move the code out of the block layer.

Re: [PATCH v4 13/19] tools/xenstore: introduce read_node_const()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: Introduce a read_node() variant returning a pointer to const struct node, which doesn't do a copy of the node data after retrieval from the data base. Call this variant where appropriate. Signed-off-by: Juergen Gross Reviewed-by: Julien

Re: [PATCH v4 12/19]tools/xenstore: alloc new memory in domain_adjust_node_perms()

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:47, Juergen Gross wrote: In order to avoid modifying the node data in the data base in case a domain is gone, let domain_adjust_node_perms() allocate new memory for the permissions in case they need to be modified. As this should happen only in very rare cases, it is

Re: [PATCH v4 11/19] tools/xenstore: use struct node_hdr in struct node

2023-08-18 Thread Julien Grall
Hi Juergen, On 14/08/2023 08:46, Juergen Gross wrote: Replace some individual fields in struct node with struct node_hdr. This allows to add a helper for calculating the accounted memory size of a node. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall Cheers, -- Julien Grall

Community Manager update - August 2023

2023-08-18 Thread Kelly Choi
Hi everyone! :) I hope you're all well. If we haven't met before, I'd like to introduce myself. I'm Kelly, the Community Manager for The Xen Project. My role is to support everyone and make sure the project is healthy and thriving. *The latest update below requires your attention:* - *We wi

Re: [PATCH 1/2] code-of-conduct.rst: Remove Ian Jackson as a team member

2023-08-18 Thread George Dunlap
On Fri, Aug 18, 2023 at 11:45 AM Andrew Cooper wrote: > On 18/08/2023 11:33 am, George Dunlap wrote: > > > On Fri, Aug 18, 2023 at 11:32 AM George Dunlap > wrote: > >> Ian Jackson is no longer involved with the Xen Project. >> >> Signed-off-by: George Dunlap >> > > NB that I don't consider thes

Re: [PATCH 1/2] code-of-conduct.rst: Remove Ian Jackson as a team member

2023-08-18 Thread Andrew Cooper
On 18/08/2023 11:33 am, George Dunlap wrote: > > On Fri, Aug 18, 2023 at 11:32 AM George Dunlap > wrote: > > Ian Jackson is no longer involved with the Xen Project. > > Signed-off-by: George Dunlap > > > NB that I don't consider these changes as needing a full vote; I'll > check them in o

Re: [PATCH 1/2] code-of-conduct.rst: Remove Ian Jackson as a team member

2023-08-18 Thread George Dunlap
On Fri, Aug 18, 2023 at 11:32 AM George Dunlap wrote: > Ian Jackson is no longer involved with the Xen Project. > > Signed-off-by: George Dunlap > NB that I don't consider these changes as needing a full vote; I'll check them in on Monday unless someone wants to argue otherwise. Thanks, -Geor

[PATCH 1/2] code-of-conduct.rst: Remove Ian Jackson as a team member

2023-08-18 Thread George Dunlap
Ian Jackson is no longer involved with the Xen Project. Signed-off-by: George Dunlap --- source/code-of-conduct.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/source/code-of-conduct.rst b/source/code-of-conduct.rst index 963d605..c6003bb 100644 --- a/source/code-of-conduct.rst +++ b/sour

[PATCH 2/2] code-of-conduct.rst: Update George Dunlap's email address

2023-08-18 Thread George Dunlap
Signed-off-by: George Dunlap --- source/code-of-conduct.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/code-of-conduct.rst b/source/code-of-conduct.rst index c6003bb..6ef11c8 100644 --- a/source/code-of-conduct.rst +++ b/source/code-of-conduct.rst @@ -79,7 +79,7 @@

Re: [PATCH] rombios: Work around GCC issue 99578

2023-08-18 Thread Andrew Cooper
On 18/08/2023 11:09 am, Jan Beulich wrote: > On 18.08.2023 11:44, Andrew Cooper wrote: >> On 18/08/2023 7:50 am, Jan Beulich wrote: >>> On 17.08.2023 22:45, Andrew Cooper wrote: GCC 12 objects to pointers derived from a constant: util.c: In function 'find_rsdp': util.c:429:1

Re: [PATCH] rombios: Work around GCC issue 99578

2023-08-18 Thread Jan Beulich
On 18.08.2023 11:44, Andrew Cooper wrote: > On 18/08/2023 7:50 am, Jan Beulich wrote: >> On 17.08.2023 22:45, Andrew Cooper wrote: >>> GCC 12 objects to pointers derived from a constant: >>> >>> util.c: In function 'find_rsdp': >>> util.c:429:16: error: array subscript 0 is outside array bounds

Re: [PATCH] rombios: Work around GCC issue 99578

2023-08-18 Thread Andrew Cooper
On 18/08/2023 7:50 am, Jan Beulich wrote: > On 17.08.2023 22:45, Andrew Cooper wrote: >> GCC 12 objects to pointers derived from a constant: >> >> util.c: In function 'find_rsdp': >> util.c:429:16: error: array subscript 0 is outside array bounds of >> 'uint16_t[0]' {aka 'short unsigned int[]'

Re: [PATCH v1 02/57] xen/riscv: add public arch-riscv.h

2023-08-18 Thread Oleksii
On Thu, 2023-08-17 at 17:00 +0200, Jan Beulich wrote: > On 16.08.2023 12:19, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/include/public/arch-riscv.h > > @@ -0,0 +1,90 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* > > + * Guest OS interface to RISC-V Xen. > > + * Initia

Re: [PATCH 3/3] xen/public: arch-arm: All PSR_* defines should be unsigned

2023-08-18 Thread Julien Grall
Hi Jan, On 18/08/2023 09:14, Jan Beulich wrote: On 18.08.2023 09:39, Julien Grall wrote: On 18/08/2023 07:33, Jan Beulich wrote: As an aside I wonder why they're here: They look like definitions of processor registers, which aren't under our (Xen's) control. I agree they are not under Xen's

Re: [PATCH 3/3] xen/public: arch-arm: All PSR_* defines should be unsigned

2023-08-18 Thread Julien Grall
Hi Juergen, On 18/08/2023 09:25, Juergen Gross wrote: On 18.08.23 10:05, Julien Grall wrote: Hi, On 18/08/2023 09:00, Juergen Gross wrote: On 18.08.23 09:39, Julien Grall wrote: Hi Jan, On 18/08/2023 07:33, Jan Beulich wrote: On 17.08.2023 23:43, Julien Grall wrote: --- a/xen/include/publ

[linux-linus test] 182374: regressions - FAIL

2023-08-18 Thread osstest service owner
flight 182374 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182374/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 182357

Re: [PATCH v2 1/4] block: rename blk_io_plug_call() API to defer_call()

2023-08-18 Thread Philippe Mathieu-Daudé
On 17/8/23 17:58, Stefan Hajnoczi wrote: Prepare to move the blk_io_plug_call() API out of the block layer so that other subsystems call use this deferred call mechanism. Rename it to defer_call() but leave the code in block/plug.c. The next commit will move the code out of the block layer. Sug

Re: [XEN PATCH v11 00/14] Xen FF-A mediator

2023-08-18 Thread Julien Grall
Hi Jens, On 31/07/2023 13:15, Jens Wiklander wrote: Jens Wiklander (14): xen/arm: ffa: add direct request support xen/arm: ffa: map SPMC rx/tx buffers xen/arm: ffa: send guest events to Secure Partitions xen/arm: ffa: support mapping guest RX/TX buffers xen/arm: ffa: support guest

  1   2   >