On 18.08.23 13:22, Julien Grall wrote:
Hi Juergen,On 14/08/2023 08:47, Juergen Gross wrote:In tools/xenstore there are living xenstored and xenstore clients. They are no longer sharing anything apart from the "xenstore" in their names. Move the xenstored sources into a new directory tools/xenstored while dropping the "xenstored_" prefix from their names. This will make it clearer that xenstore clients and xenstored are independent from each other.In term of naming, I would prefer if we follow what was done for the console. I.e: xenstore/client: All the clients xenstore/daemon: C Xenstored This would avoid the one character difference between the two directories.
Yes, that would be the alternative (apart from renaming the xenstore directory to something different, e.g. xs-clients). The reason I was leaning towards my solution was that the clients are meant to be used with any xenstored implementation. This wouldn't be reflected by using a common tools/xenstore parent directory for the clients and C xenstored. In the end I could live with your proposal, too.
What do the other thinks?Signed-off-by: Juergen Gross <jgr...@suse.com> --- After the large overhaul of xenstored I think such a reorg would make sense to go into the same Xen version. Delaying it until the next version would make potential backports for 4.18 harder.+1.
Thanks, Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
