On 09/08/2023 21:51, Stefano Stabellini wrote:
>
>
> Adding hyperlaunch and x86 maintainers.
>
>
> Hi Luca,
>
> This patch series is very timely. You might not have realized but we
> were just discussing with the hyperlaunch guys to move dom0less code to
> common.
>
> Your series is a grea
flight 182239 linux-5.4 real [real]
flight 182256 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182239/
http://logs.test-lab.xenproject.org/osstest/logs/182256/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
t
Hi Julien,
> On Aug 9, 2023, at 20:04, Julien Grall wrote:
>
> Hi Henry,
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> There are two types of memory system architectures available for
>> Arm-based systems, namely the Virtual Memory System Architecture (VMSA)
>> and the Protected Memory System A
Hi Julien,
> On Aug 9, 2023, at 19:59, Julien Grall wrote:
>
> Hi Henry,
>
> Title: NIT: Add () after _mm to stay consistent with the rest.
Yes sure, I will add “()” in v5.
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> From: Wei Chen
>>
>> +enable_secondary_cpu_mm:
>> +mov x5, lr
flight 182255 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182255/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
From: Stefano Stabellini
Signed-off-by: Stefano Stabellini
---
automation/gitlab-ci/build.yaml | 64 -
automation/gitlab-ci/test.yaml | 56 ++---
2 files changed, 60 insertions(+), 60 deletions(-)
diff --git a/automation/gitlab-ci/build.
From: Stefano Stabellini
Alpine 3.12 is EOL. Also update the containerize script.
Signed-off-by: Stefano Stabellini
---
.../{3.12-arm64v8.dockerfile => 3.18-arm64v8.dockerfile} | 2 +-
automation/build/alpine/{3.12.dockerfile => 3.18.dockerfile} | 2 +-
automation/scripts/containerize
Hi all,
This short series introduces a painless upgrade to Alpine 3.18, given
that 3.12 is EOL.
Proof that it works:
https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/961413389
Cheers,
Stefano
flight 182235 xen-4.15-testing real [real]
flight 182254 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182235/
http://logs.test-lab.xenproject.org/osstest/logs/182254/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
flight 182236 xen-4.16-testing real [real]
flight 182253 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182236/
http://logs.test-lab.xenproject.org/osstest/logs/182253/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
flight 182234 xen-4.14-testing real [real]
flight 182251 xen-4.14-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182234/
http://logs.test-lab.xenproject.org/osstest/logs/182251/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
flight 182237 xen-4.17-testing real [real]
flight 182252 xen-4.17-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182237/
http://logs.test-lab.xenproject.org/osstest/logs/182252/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
On Wed, 9 Aug 2023, Julien Grall wrote:
> On 09/08/2023 23:06, Stefano Stabellini wrote:
> > On Wed, 9 Aug 2023, Julien Grall wrote:
> > > Hi,
> > >
> > > On 09/08/2023 21:35, Stefano Stabellini wrote:
> > > > P.S.
> > > > Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today
>
On Wed, 9 Aug 2023, Andrew Cooper wrote:
> On 09/08/2023 11:34 pm, Stefano Stabellini wrote:
> > On Wed, 9 Aug 2023, Andrew Cooper wrote:
> >> On 09/08/2023 10:43 pm, Stefano Stabellini wrote:
> >>> On Wed, 9 Aug 2023, Andrew Cooper wrote:
> On 07/08/2023 2:24 am, Henry Wang wrote:
> > Hi
Hi,
On 09/08/2023 23:06, Stefano Stabellini wrote:
On Wed, 9 Aug 2023, Julien Grall wrote:
Hi,
On 09/08/2023 21:35, Stefano Stabellini wrote:
P.S.
Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today
it is not clarified) 32-bit guests on a 64-bit ARM hypervisor?
I read y
Add code to construct early identity-mapped page tables as well as the
required process and partition tables to enable the MMU.
Signed-off-by: Shawn Anastasio
---
v3:
- Add XEN_PT_SIZE_LVL() macro for calculating the size in bytes
of a page directory/page table structure.
- Add alignment
(v3: Apologies for the noise, but v2 was submitted in error and was
missing a few changes to patch 3 that were discussed)
Hello all,
This series adds support for bringing up the Radix MMU with basic
identity-mapped page tables.
In order to simplify the memory layout, the series changes XEN_VIRT
In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B
from the supported ISA list to avoid having a non-working
configuration in tree. It can be re-added at a later point when Hash
MMU support is added.
Signed-off-by: Shawn Anastasio
---
v3: no changes.
v2: no changes.
xen/arc
Introduce a small assembly loop in `start` to copy the kernel to
physical address 0 before continuing. This ensures that the physical
address lines up with XEN_VIRT_START (0xc000) and allows us
to identity map the kernel when the MMU is set up in the next patch.
We are also able to sta
On 09/08/2023 11:34 pm, Stefano Stabellini wrote:
> On Wed, 9 Aug 2023, Andrew Cooper wrote:
>> On 09/08/2023 10:43 pm, Stefano Stabellini wrote:
>>> On Wed, 9 Aug 2023, Andrew Cooper wrote:
On 07/08/2023 2:24 am, Henry Wang wrote:
> Hi everyone,
>
> Following the release schedule
On Wed, 9 Aug 2023, Andrew Cooper wrote:
> On 09/08/2023 10:43 pm, Stefano Stabellini wrote:
> > On Wed, 9 Aug 2023, Andrew Cooper wrote:
> >> On 07/08/2023 2:24 am, Henry Wang wrote:
> >>> Hi everyone,
> >>>
> >>> Following the release schedule discussion in in April, I am sending this
> >>> emai
Introduce a small assembly loop in `start` to copy the kernel to
physical address 0 before continuing. This ensures that the physical
address lines up with XEN_VIRT_START (0xc000) and allows us
to identity map the kernel when the MMU is set up in the next patch.
We are also able to sta
Add code to construct early identity-mapped page tables as well as the
required process and partition tables to enable the MMU.
Signed-off-by: Shawn Anastasio
---
v2:
- Add missing ')' to mm.h/maddr_to_virt definition
- Add missing parens around `va` argument in XEN_PT_INDEX_LVL
- Drop '&'
Hello all,
This series adds support for bringing up the Radix MMU with basic
identity-mapped page tables.
In order to simplify the memory layout, the series changes XEN_VIRT
_START to 0xC000___, which has a couple of convenient
properties. When the MMU is off, the top 4 address bits a
In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B
from the supported ISA list to avoid having a non-working
configuration in tree. It can be re-added at a later point when Hash
MMU support is added.
Signed-off-by: Shawn Anastasio
---
v2: no changes.
xen/arch/ppc/Kconfig |
On Wed, 9 Aug 2023, Julien Grall wrote:
> Hi,
>
> On 09/08/2023 21:35, Stefano Stabellini wrote:
> > P.S.
> > Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today
> > it is not clarified) 32-bit guests on a 64-bit ARM hypervisor?
>
> I read your explanation above and I don't r
On 09/08/2023 10:43 pm, Stefano Stabellini wrote:
> On Wed, 9 Aug 2023, Andrew Cooper wrote:
>> On 07/08/2023 2:24 am, Henry Wang wrote:
>>> Hi everyone,
>>>
>>> Following the release schedule discussion in in April, I am sending this
>>> email
>>> to remind that according to the release schedule
Hi,
On 09/08/2023 21:35, Stefano Stabellini wrote:
P.S.
Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today
it is not clarified) 32-bit guests on a 64-bit ARM hypervisor?
I read your explanation above and I don't really understand why you
would want to de-support it. This
On Wed, 9 Aug 2023, Andrew Cooper wrote:
> On 07/08/2023 2:24 am, Henry Wang wrote:
> > Hi everyone,
> >
> > Following the release schedule discussion in in April, I am sending this
> > email
> > to remind that according to the release schedule [1], August 11 (this
> > Friday)
> > will be the las
Petr Tesarik writes:
> From: Petr Tesarik
>
> Skip searching the software IO TLB if a device has never used it, making
> sure these devices are not affected by the introduction of multiple IO TLB
> memory pools.
>
> Additional memory barrier is required to ensure that the new value of the
> flag
On 07/08/2023 2:24 am, Henry Wang wrote:
> Hi everyone,
>
> Following the release schedule discussion in in April, I am sending this email
> to remind that according to the release schedule [1], August 11 (this Friday)
> will be the last posting date, when patches adding new features are expected
>
On 8/1/23 8:18 AM, Jan Beulich wrote:
> On 29.07.2023 00:21, Shawn Anastasio wrote:
>> --- /dev/null
>> +++ b/xen/arch/ppc/include/asm/bitops.h
>> @@ -0,0 +1,11 @@
>> +#ifndef _ASM_PPC_BITOPS_H
>> +#define _ASM_PPC_BITOPS_H
>> +
>> +#include
>
> Not a big deal, but ...
>
>> +/* PPC bit number co
On Wed, 9 Aug 2023, Simone Ballarin wrote:
> This patch adds some deviations for the following guidelines:
> Rule 2.1, Rule 5.3 and Rule 8.2.
>
> Signed-off-by: Simone Ballarin
Acked-by: Stefano Stabellini
Looking at the below, is there anything we should add to
docs/misra/rules.rst to specify
On Wed, 9 Aug 2023, Simone Ballarin wrote:
> This patch splits the former list in two separate selectors
> clean_guidelines_common and additional_clean_guidelines.
>
> clean_guidelines_common contains the guidelines that are clean
> in both the analyzed builds, instead additional_clean_guidelines
On Wed, 9 Aug 2023, Simone Ballarin wrote:
> The xen build for ARM64 now has new configuration options which
> require to be defined: this patch defines them.
>
> In both configuration files some no longer true comments have been removed.
>
> Signed-off-by: Simone Ballarin
Acked-by: Stefano Sta
On Wed, 9 Aug 2023, Jan Beulich wrote:
> On 09.08.2023 01:22, Stefano Stabellini wrote:
> > On Tue, 8 Aug 2023, Jan Beulich wrote:
> >> On 08.08.2023 10:47, Federico Serafini wrote:
> >>> Hello everyone.
> >>>
> >>> I would like to to ask your opinion about the auto-generated file
> >>> xen/include
This popped up with insufficient time to organise a response before the
pile of fixes yesterday.
https://www.amd.com/en/resources/product-security/bulletin/amd-sb-7007.html
Per my current understanding:
* There is a single integer divider in a Zen1 pipeline. When SMT is
active, it services uops
On Wed, 9 Aug 2023, Jan Beulich wrote:
> On 09.08.2023 16:17, Nicola Vetrini wrote:
> > On 09/08/2023 14:52, Jan Beulich wrote:
> >> On 09.08.2023 13:02, Nicola Vetrini wrote:
> >>> The additional header file makes the declaration for the function
> >>> 'init_IRQ', defined in this file visible, the
On Wed, 9 Aug 2023, Luca Fancellu wrote:
> > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
> >
> > Add a declaration for the variable 'init_ttbr' to resolve
> > the violation of Rule 8.4 present in the associated source file 'mm.c'.
> >
> > No functional changes.
> >
> > Signed-off-by: Nicola
On Wed, 9 Aug 2023, Jan Beulich wrote:
> On 09.08.2023 13:02, Nicola Vetrini wrote:
> > 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
> > the declaration of 'arch_get_xen_caps' to be visible when
> > defining the function.
> >
> > The header 'xen/delay.h' is included in 'xen/arc
On Wed, 9 Aug 2023, Luca Fancellu wrote:
> > On 9 Aug 2023, at 15:06, Jan Beulich wrote:
> >
> > On 09.08.2023 15:50, Luca Fancellu wrote:
> >>> On 9 Aug 2023, at 12:02, Nicola Vetrini
> >>> wrote:
> >>>
> >>> The variable 'saved_cmdline' can be defined static,
> >>> as its only uses are withi
On Wed, 9 Aug 2023, Luca Fancellu wrote:
> > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
> >
> > The function 'ioreq_server_max_frames' can be defined static,
> > as its only uses are within the same file. This in turn avoids
> > violating Rule 8.4 because no declaration is present.
> >
> > N
On Wed, 9 Aug 2023, Luca Fancellu wrote:
> > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
> >
> > the function 'fdt_add_uefi_nodes' can be defined static, as its
> > only callers are within the same file. This in turn avoids
> > violating Rule 8.4 because no declaration is present.
> >
> > No
Adding hyperlaunch and x86 maintainers.
Hi Luca,
This patch series is very timely. You might not have realized but we
were just discussing with the hyperlaunch guys to move dom0less code to
common.
Your series is a great step in the right direction. However, we don't
want to move the dom0less c
On 8/8/23 4:12 AM, Jan Beulich wrote:
> On 03.08.2023 01:03, Shawn Anastasio wrote:
>> --- /dev/null
>> +++ b/xen/arch/ppc/include/asm/altp2m.h
>> @@ -0,0 +1,39 @@
>> +/*
>> + * Alternate p2m
>> + *
>> + * Copyright (c) 2014, Intel Corporation.
>> + *
>> + * This program is free software; you can r
flight 182250 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182250/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 02/08/2023 04:59, Henry Wang wrote:
Hi Julien,
Hi Henry,
-Original Message-
From: Julien Grall
Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of
MPU work
Hi,
On 01/08/2023 04:44, Henry Wang wrote:
Based on the discussion in the Xen Summit [1], sending t
flight 182249 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182249/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 991515a0583f65a64b3a6fa354409c64e670a762
baseline version:
ovmf 136931c4dbf532ec913b6
> On 9 Aug 2023, at 16:48, Jan Beulich wrote:
>
> On 28.07.2023 10:11, Luca Fancellu wrote:
>> --- /dev/null
>> +++ b/xen/.clang-format
>> @@ -0,0 +1,693 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +#
>> +# clang-format configuration file. Intended for clang-format >= 15.
>> +#
>> +# For
> On 9 Aug 2023, at 16:41, Jan Beulich wrote:
>
> On 28.07.2023 10:11, Luca Fancellu wrote:
>> This script finds every .c and .h file in the xen hypervisor
>> codebase, takes the exclusion list from docs/misra, removes the
>> file excluded from the list and for the remaining files is
>> callin
On 28.07.2023 10:11, Luca Fancellu wrote:
> --- /dev/null
> +++ b/xen/.clang-format
> @@ -0,0 +1,693 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# clang-format configuration file. Intended for clang-format >= 15.
> +#
> +# For more information, see:
> +#
> +# Documentation/process/clang
On 28.07.2023 10:11, Luca Fancellu wrote:
> This script finds every .c and .h file in the xen hypervisor
> codebase, takes the exclusion list from docs/misra, removes the
> file excluded from the list and for the remaining files is
> calling clang-format on them.
I was going to ask what the intend
On 01.08.2023 22:20, Daniel P. Smith wrote:
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void)
> {
> struct vcpu *v = current;
> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb;
> -bool debug_s
flight 182248 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182248/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 09.08.2023 17:08, Andrew Cooper wrote:
> ... now that it exists in public.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Jan Beulich
... now that it exists in public.
Signed-off-by: Andrew Cooper
---
CC: Jan Beulich
CC: Roger Pau Monné
CC: Wei Liu
I did try to get this URL ahead of finalising the XSA-434 patches, but alas...
---
xen/arch/x86/spec_ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/x86/s
flight 182245 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182245/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 136931c4dbf532ec913b68673c91b4285e63464b
baseline version:
ovmf 3c274c0d83d5464b336e4
On 09/08/2023 1:29 pm, Jan Beulich wrote:
> Since as a bug workaround (likely inapplicable to any 64-bit CPUs, but
> it probably doesn't hurt to keep this) we clear %ecx on input anyway,
> we can as well fall back to cpuid_count(). This allows getting rid of
> four risky casts and makes things type
On 09.08.2023 16:17, Nicola Vetrini wrote:
> On 09/08/2023 14:52, Jan Beulich wrote:
>> On 09.08.2023 13:02, Nicola Vetrini wrote:
>>> The additional header file makes the declaration for the function
>>> 'init_IRQ', defined in this file visible, thereby resolving the
>>> violation of Rule 8.4.
>>>
On 09/08/2023 14:52, Jan Beulich wrote:
On 09.08.2023 13:02, Nicola Vetrini wrote:
The additional header file makes the declaration for the function
'init_IRQ', defined in this file visible, thereby resolving the
violation of Rule 8.4.
No functional change.
Signed-off-by: Nicola Vetrini
---
> On 9 Aug 2023, at 15:06, Jan Beulich wrote:
>
> On 09.08.2023 15:50, Luca Fancellu wrote:
>>> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>>>
>>> The variable 'saved_cmdline' can be defined static,
>>> as its only uses are within the same file. This in turn avoids
>>> violating Rule 8.4
On 09/08/2023 15:50, Luca Fancellu wrote:
On 9 Aug 2023, at 12:02, Nicola Vetrini
wrote:
The variable 'saved_cmdline' can be defined static,
as its only uses are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
Signed-off-by: Nicola Vetrini
---
On 09/08/2023 15:56, Luca Fancellu wrote:
On 9 Aug 2023, at 08:55, Nicola Vetrini
wrote:
The variable 'msec' declared in the macro shadows the local
variable in 'ehci_dbgp_bios_handoff', but to prevent any
future clashes with other functions the macro is converted to
a static inline function.
On 09.08.2023 15:50, Luca Fancellu wrote:
>> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>>
>> The variable 'saved_cmdline' can be defined static,
>> as its only uses are within the same file. This in turn avoids
>> violating Rule 8.4 because no declaration is present.
>>
>> Signed-off-by: Nico
> On 9 Aug 2023, at 08:55, Nicola Vetrini wrote:
>
> The variable 'msec' declared in the macro shadows the local
> variable in 'ehci_dbgp_bios_handoff', but to prevent any
> future clashes with other functions the macro is converted to
> a static inline function.
>
> No functional change.
>
> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>
> The variable 'saved_cmdline' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
>
> Signed-off-by: Nicola Vetrini
> ---
> xen/common/kernel.c | 2
On 09.08.2023 13:02, Nicola Vetrini wrote:
> The functions and variables touched by this commit can be static,
> as they are only used within the same unit. This in turn addresses
> the absence of declarations that violates Rule 8.4.
>
> Signed-off-by: Nicola Vetrini
I'm happy with the code chan
> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>
> the function 'fdt_add_uefi_nodes' can be defined static, as its
> only callers are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>
> Add a declaration for the variable 'init_ttbr' to resolve
> the violation of Rule 8.4 present in the associated source file 'mm.c'.
>
> No functional changes.
>
> Signed-off-by: Nicola Vetrini
> ---
Reviewed-by: Luca Fancellu
With:
Fi
On 09.08.2023 15:34, Luca Fancellu wrote:
>> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>>
>> The function 'ioreq_server_max_frames' can be defined static,
>> as its only uses are within the same file. This in turn avoids
>> violating Rule 8.4 because no declaration is present.
>>
>> No functi
> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote:
>
> The function 'ioreq_server_max_frames' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.
>
> No functional change.
>
> Signed-off-by: Nicola Vetri
To prevent back and forth I would suggest also to have a look in
sending-patches.pandoc,
### Fixes section, on the expected syntax for the tag
Thanks
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
On 09/08/2023 14:42, Jan Beulich wrote:
On 09.08.2023 13:02, Nicola Vetrini wrote:
'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
the declaration of 'arch_get_xen_caps' to be visible when
defining the function.
The header 'xen/delay.h' is included in 'xen/arch/arm/time.c'
to a
On 09.08.2023 13:02, Nicola Vetrini wrote:
> Include an additional header to make the declarations for
> functions 'watchdog_*' visible prior to their definition in
> the file, thereby resolving the violations of Rule 8.4.
>
> No functional change.
Fixes: c8177e691f0f ("watchdog: Move watchdog fr
> On 9 Aug 2023, at 13:42, Jan Beulich wrote:
>
> On 09.08.2023 13:02, Nicola Vetrini wrote:
>> 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
>> the declaration of 'arch_get_xen_caps' to be visible when
>> defining the function.
>>
>> The header 'xen/delay.h' is included in
On 09.08.2023 13:02, Nicola Vetrini wrote:
> The additional header file makes the declaration for the function
> 'init_IRQ', defined in this file visible, thereby resolving the
> violation of Rule 8.4.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini
> ---
> xen/arch/x86/i8259.c | 1
On 09.08.2023 09:55, Nicola Vetrini wrote:
> The local variables 'irq_desc' shadow the homonymous global variable,
> declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed
> 'irqd' for consistency.
Perhaps with "for consistency" dropped (or else clarified what this
is to be consi
On 09.08.2023 13:02, Nicola Vetrini wrote:
> 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
> the declaration of 'arch_get_xen_caps' to be visible when
> defining the function.
>
> The header 'xen/delay.h' is included in 'xen/arch/arm/time.c'
> to allow the declaration of 'udelay
Since as a bug workaround (likely inapplicable to any 64-bit CPUs, but
it probably doesn't hurt to keep this) we clear %ecx on input anyway,
we can as well fall back to cpuid_count(). This allows getting rid of
four risky casts and makes things type-safe. The latter aspect requires
two type adjustm
Hi Henry,
Title: NIT: It is more a fold rather than move.
On 01/08/2023 04:44, Henry Wang wrote:
For the
future MPU support work, the early UART mapping could then be moved
in prepare_early_mappings().
I would drop this sentence as this is more related to the future
implementation of MPU ra
Hi Henry,
On 01/08/2023 04:44, Henry Wang wrote:
From: Wei Chen
Xen defines some global configuration macros for Arm in config.h.
However there are some address layout related definitions that are
defined for MMU systems only, and these definitions could not be
used by MPU systems. Adding ifde
Hi Henry,
On 01/08/2023 04:44, Henry Wang wrote:
From: Wei Chen
We want to reuse head.S for MPU systems, but there are some
code are implemented for MMU systems only. We will move such
code to another MMU specific file. But before that we will
do some indentations fix in this patch to make the
Hi Henry,
On 01/08/2023 04:44, Henry Wang wrote:
There are two types of memory system architectures available for
Arm-based systems, namely the Virtual Memory System Architecture (VMSA)
and the Protected Memory System Architecture (PMSA). According to
ARM DDI 0487G.a, A VMSA provides a Memory Ma
Hi Henry,
Title: NIT: Add () after _mm to stay consistent with the rest.
On 01/08/2023 04:44, Henry Wang wrote:
From: Wei Chen
At the moment, on MMU system, enable_mmu() will return to an
address in the 1:1 mapping, then each path is responsible to
switch to virtual runtime mapping. Then remo
flight 182246 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182246/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
Hi Jan,
On 08/08/2023 10:42, Jan Beulich wrote:
From briefly going over 9062553a0dc1 it looks like the #include in what
was ac_timer.c was added there for no reason. It's unneeded now in any
event, and it is the sole reason for Arm to have that dummy header.
Purge that, thus avoiding PPC to als
Hi Jan,
On 08/08/2023 11:47, Jan Beulich wrote:
Common code references both, so the variables shouldn't need declaring
and defining by every arch. While moving the definitions, add
__read_mostly (__ro_after_init would only be appropriate when
!mem_hotplug).
Signed-off-by: Jan Beulich
Acked-b
Hi Nicola,
On 09/08/2023 08:55, Nicola Vetrini wrote:
The variable 'msec' declared in the macro shadows the local
variable in 'ehci_dbgp_bios_handoff', but to prevent any
future clashes with other functions the macro is converted to
a static inline function.
No functional change.
Signed-off-by
the function 'fdt_add_uefi_nodes' can be defined static, as its
only callers are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
No functional change.
Signed-off-by: Nicola Vetrini
---
xen/arch/arm/efi/efi-boot.h | 2 +-
1 file changed, 1 insertio
The additional header file makes the declaration for the function
'init_IRQ', defined in this file visible, thereby resolving the
violation of Rule 8.4.
No functional change.
Signed-off-by: Nicola Vetrini
---
xen/arch/x86/i8259.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/
Include an additional header to make the declarations for
functions 'watchdog_*' visible prior to their definition in
the file, thereby resolving the violations of Rule 8.4.
No functional change.
Signed-off-by: Nicola Vetrini
---
xen/arch/x86/nmi.c | 1 +
1 file changed, 1 insertion(+)
diff --
The functions and variables touched by this commit can be static,
as they are only used within the same unit. This in turn addresses
the absence of declarations that violates Rule 8.4.
Signed-off-by: Nicola Vetrini
---
xen/arch/x86/cpu/mcheck/mce.c | 2 +-
xen/arch/x86/cpu/mcheck/mce_amd.c |
Add a declaration for the variable 'init_ttbr' to resolve
the violation of Rule 8.4 present in the associated source file 'mm.c'.
No functional changes.
Signed-off-by: Nicola Vetrini
---
xen/arch/arm/include/asm/mm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/arm/include/as
Rule states the following:
"A compatible declaration shall be visible when an object or function with
external linkage is defined".
This series deals with violations concerning functions and variables used by C
code (thus not used only within asm). The resolution strategies are as follows:
1. mak
'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow
the declaration of 'arch_get_xen_caps' to be visible when
defining the function.
The header 'xen/delay.h' is included in 'xen/arch/arm/time.c'
to allow the declaration of 'udelay' to be visible.
At the same time, a declaration for '
The function 'ioreq_server_max_frames' can be defined static,
as its only uses are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
No functional change.
Signed-off-by: Nicola Vetrini
---
xen/common/memory.c | 2 +-
1 file changed, 1 insertion(+),
The variable 'saved_cmdline' can be defined static,
as its only uses are within the same file. This in turn avoids
violating Rule 8.4 because no declaration is present.
Signed-off-by: Nicola Vetrini
---
xen/common/kernel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/c
On 09/08/2023 12:00, Julien Grall wrote:
Hi Michal,
On 08/08/2023 12:07, Michal Orzel wrote:
Instead of repeating the same sequence of instructions to flush the TLBs
in various places, introduce a macro flush_xen_tlb_local and make use of
it. This is similar to what was done for arm32 by the
Hi Michal,
On 08/08/2023 12:07, Michal Orzel wrote:
Instead of repeating the same sequence of instructions to flush the TLBs
in various places, introduce a macro flush_xen_tlb_local and make use of
it. This is similar to what was done for arm32 by the commit:
dea9dddeceec8a1d68da24b14d5b2396effe
On 09/08/2023 11:58, Jan Beulich wrote:
On 09.08.2023 12:49, Julien Grall wrote:
On 04/08/2023 07:08, Jan Beulich wrote:
Have these in one place, for all architectures to use. Also use the C99
types as the "original" ones, and derive the Linux compatible ones
(which we're trying to phase out
1 - 100 of 123 matches
Mail list logo
