Re: [PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 03/08/2023 16:40, Luca Fancellu wrote: > > > Introduce Kconfig GICV2 to be able to compile the GICv2 driver only > when needed, the option is active by default. > > Introduce Kconfig VGICV2 that compiles the Generic Interrupt > Controller v2 emulation for domains, it is required only when

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

On 04.08.2023 01:50, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> Rule 2.1 states: "A project shall not contain unreachable code". >>> >>> The functions >>> - machine_halt >>> - maybe_reboot >>> - machine_restart >>> are not su

[ovmf test] 182176: all pass - PUSHED

flight 182176 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182176/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 01ad4134c3e6339ac53c85fccf62ed10d5b6d662 baseline version: ovmf ef051451367fa5455d75b

Re: [PATCH v4 0/8] annotate entry points with type and size

On 04.08.2023 08:24, Jan Beulich wrote: > The model introduced in patch 1 is now arch-agnostic, and all arch-es > are being switched at least partly (to at least give examples of how > things will look like); PPC and RISC-V are still small enough to switch > completely in one go. > > 1: common: as

[PATCH v4 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions

Leverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked. Signed-off-by: Jan Beulich --- TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not rea

[PATCH v4 6/8] tools/binfile: switch to common annotations model

Use DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/tools/binfile +++ b/xen/tools/binfile @@ -29,15 +29,10 @@ cat <$target .section $section.

[PATCH v4 5/8] PPC: switch entry point annotations to common model

Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbol changes to be a hidden one. Signed-off-by: Jan Beulich --- v4: Also drop #undef-s from linker script. Re-base. v3: New. --- a/xen/arch/ppc/include/asm/asm-defns.h +++ b/xen/arch/ppc/incl

[PATCH v4 5/8] RISC-V: annotate entry points with type and size

Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size. Signed-off-by: Jan Beulich --- Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any

[PATCH v4 4/8] Arm: annotate entry points with type and size

Use the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the

[PATCH v4 3/8] x86: also mark assembler globals hidden

Let's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau

[PATCH v4 2/8] x86: annotate entry points with type and size

Use the generic framework in xen/linkage.h. For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints

[PATCH v4 1/8] common: assembly entry point type/size annotations

Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all arc

[PATCH v4 0/8] annotate entry points with type and size

The model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go. 1: common: assembly entry point type/size annotations 2: x86: ann

[PATCH v2 2/2] common: __u8 is history

With the last uses gone, move the type to linux-compat.h. No functional change intended. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- The primary use of __u{16,32,64} is in the byte-order headers. Iirc there is a series re-working part of that, so I guess before touching the logic the

[PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header

Have these in one place, for all architectures to use. Also use the C99 types as the "original" ones, and derive the Linux compatible ones (which we're trying to phase out). For __s, seeing that no uses exist anymore, move them to a new Linux compatibility header (as an act of precaution - as said,

[PATCH v2 0/2] fixed width type adjustments

Patch 1 significantly reduced from Andrew's introduction of xen/stdint.h. 1: move Linux-inherited fixed width type decls to common header 2: __u8 is history Jan

[PATCH 2/2] tools: add configure option for libfsimage

The only in-tree user of libfsimage is pygrub. Now that it is possible to disable the build of pygrub, the same should be possible for libfsimage. Add an option for controlling the build of libfsimage. The default is on if pygrub is being built, and off if it isn't. Without pygrub the build of lib

[PATCH 1/2] tools: add configure option for disabling pygrub

Add a "--disable-pygrub" option for being able to disable the build and installation of pygrub. There are two main reasons to do so: - A main reason to use pygrub is to allow a PV guest to choose its bitness (32- or 64-bit). Pygrub allows that by looking into the boot image and to start the g

[PATCH 0/2] tools: add some more configure options

Add two additional configure options for controlling the build of pygrub and libfsimage. Juergen Gross (2): tools: add configure option for disabling pygrub tools: add configure option for libfsimage config/Tools.mk.in | 2 ++ tools/Makefile | 4 ++-- tools/configure| 54 ++

[PATCH v3] x86emul: further correct 64-bit mode zero count repeated string insn handling

In an entirely different context I came across Linux commit 428e3d08574b ("KVM: x86: Fix zero iterations REP-string"), which points out that we're still doing things wrong: For one, there's no zero-extension at all on AMD. And then while RCX is zero-extended from 32 bits uniformly for all string in

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

On 03.08.2023 18:13, Elliott Mitchell wrote: > On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: >> >> Some of the patches looks to have been posted previously as a 7-patch >> series. It would have been nice if therefore this one was marked as >> v2, indicating in a revision log what the

[xen-unstable-smoke test] 182177: tolerable all pass - PUSHED

flight 182177 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182177/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

Hi Daniel, > -Original Message- > Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability o

[xen-4.16-testing test] 182166: tolerable trouble: fail/pass/starved - PUSHED

flight 182166 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182166/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182107 test-amd64-amd64-xl-qemut-win7-a

[PATCH] docs/misra: add always_inline to C-language-toolchain

From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- docs/misra/C-language-toolchain.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/misra/C-language-toolchain.rst b/docs/misra/C-language-toolchain.rst index 785aed1eaf..21b292898c 100644 --- a/docs/misra/C-language-too

[libvirt test] 182131: tolerable all pass - PUSHED

flight 182131 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182131/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182099 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On Thu, 3 Aug 2023, Stefano Stabellini wrote: > > Actually, they can be deviated because they don't result in wrong code being > > generated. > > This, modulo the review comments received, is what most of the code would > > look > > like if > > they weren't, with the biggest pain point being that

[xen-unstable test] 182128: tolerable FAIL - PUSHED

flight 182128 xen-unstable real [real] flight 182173 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182128/ http://logs.test-lab.xenproject.org/osstest/logs/182173/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[PATCH] automation: add missing "needs"

From: Stefano Stabellini The test artifacts export jobs don't need prerequisites, so we should specify "needs" with an empty array for them. That way, they are not going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete before continuing. Signed-off-by: Stefano Stabellini --- aut

Re: [XEN PATCH 13/13] xen: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 12/13] xen/common: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 09/13] x86/mm: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 07/13] xen/vpci: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 05/13] xen/ioreq: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 04/13] x86/IOMMU: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: [XEN PATCH 01/13] AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3

On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potentia

Re: Address MISRA C:2012 Rule 8.4

I think that's OK for me. My only concern is that we should track the project-wide deviations properly somewhere besides the ECLAIR configuration under xen.git which is ECLAIR specific. So far we used the notes in docs/misra/rules.rst. I don't know if that sufficient, but we could add a note for 8.

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

On Thu, 3 Aug 2023, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > > Also, what is the plan for the existing dom0less dt properties? > > > Will they need to be moved to new /hypervisor node or we will have to > > > parse > > > both /chosen and /hypervisor nodes? > > >

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

On Thu, 3 Aug 2023, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: > > Rule 2.1 states: "A project shall not contain unreachable code". > > > > The functions > > - machine_halt > > - maybe_reboot > > - machine_restart > > are not supposed to return, hence the following break state

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > Also, what is the plan for the existing dom0less dt properties? > > Will they need to be moved to new /hypervisor node or we will have to parse > > both /chosen and /hypervisor nodes? > > In the proposal I sent to xen-devel in response to Luca's RFC f

[xen-unstable-smoke test] 182172: tolerable all pass - PUSHED

flight 182172 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182172/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize()

Hi, On 24/07/2023 12:02, Juergen Gross wrote: Today is_valid_nodename() is always called directly after calling canonicalize(), with the exception of do_unwatch(), where the call is missing (which is not correct, but results just in a wrong error reason being returned). While this change makes

Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized()

Hi, On 24/07/2023 12:02, Juergen Gross wrote: diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c index 86cf8322b4..2662a3fa49 100644 --- a/tools/xenstore/xenstored_watch.c +++ b/tools/xenstore/xenstored_watch.c @@ -166,19 +166,12 @@ static int destroy_watch(void *_w

[ovmf test] 182168: all pass - PUSHED

flight 182168 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182168/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef051451367fa5455d75b38c407ca352a43b4849 baseline version: ovmf 7672d1cca58228b0cb7f0

Re: [RFC 4/6] capabilities: introduce console io as a domain capability

Hi Daniel, On 03/08/2023 16:41, Daniel P. Smith wrote: On 8/1/23 21:01, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: patch the field is renamed to capabilities to encapsulate the capabilities a domain has been granted. The first capability being the ability to read/wri

Re: [RFC 4/6] capabilities: introduce console io as a domain capability

Hi, On 01/08/2023 21:20, Daniel P. Smith wrote: The field `is_console` suggests that the field represents a state of being or posession, not that it reflects the privilege to access the console. In this patch the field is renamed to capabilities to encapsulate the capabilities a domain has been

Re: [PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi, On 03/08/2023 15:40, Luca Fancellu wrote: Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that compiles the Generic Interrupt Controller v2 emulation for domains, it is required only when using GICv2

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

> >> Regarding the coding style, I think it’s better to keep the style you’ve >> found in the original file, >> and change only some bits when the code is not following it. >> I know there is nothing enforcing parameters on the same line of the >> function definition at the >> moment, but it is

[PATCH] subdom: Fix -Werror=address failure in tmp_emulator

The opensuse-tumbleweed build jobs currently fail with: /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

On Thu, 3 Aug 2023, Daniel P. Smith wrote: > On 8/1/23 20:54, Stefano Stabellini wrote: > > On Tue, 1 Aug 2023, Daniel P. Smith wrote: > > > The existing concepts such as unbounded domain, ie. all powerful, control > > > domain and hardware domain are, effectively, roles the domains provide for > >

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

On 8/3/23 14:05, Luca Fancellu wrote: Hi Daniel, [...] diff --git a/xen/common/fdt.c b/xen/common/fdt.c new file mode 100644 index 00..8d7acaaa43 --- /dev/null +++ b/xen/common/fdt.c @@ -0,0 +1,153 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012-2014 Citrix Systems, Inc. + *

Re: [PATCH] console: generalize the ability for domU access

On 8/3/23 15:30, Stefano Stabellini wrote: On Thu, 3 Aug 2023, Daniel P. Smith wrote: On 8/2/23 19:58, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Jan Beulich wrote: -for ( ; ; ) +if ( d == NULL ) This covers both Xen receiving input and the domain receiving input having gone aw

Re: [PATCH] console: generalize the ability for domU access

On Thu, 3 Aug 2023, Daniel P. Smith wrote: > On 8/2/23 19:58, Stefano Stabellini wrote: > > On Wed, 2 Aug 2023, Jan Beulich wrote: > > > > -for ( ; ; ) > > > > +if ( d == NULL ) > > > > > > This covers both Xen receiving input and the domain receiving input having > > > gone away. Original

Re: [XEN PATCH v2] xen/string: add missing parameter names

On Thu, 3 Aug 2023, Julien Grall wrote: > On 03/08/2023 12:52, Luca Fancellu wrote: > > > On 3 Aug 2023, at 12:46, Julien Grall wrote: > > > > > > Hi Luca, > > > > > > On 03/08/2023 11:28, Luca Fancellu wrote: > > > > > On 3 Aug 2023, at 09:26, Federico Serafini > > > > > wrote: > > > > > > >

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On Thu, 3 Aug 2023, Nicola Vetrini wrote: > On 03/08/2023 11:01, Jan Beulich wrote: > > On 03.08.2023 04:13, Stefano Stabellini wrote: > > > On Wed, 2 Aug 2023, Nicola Vetrini wrote: > > > > @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void > > > > *data) > > > > > > > >

Re: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3

On Thu, 3 Aug 2023, Jan Beulich wrote: > On 03.08.2023 04:00, Stefano Stabellini wrote: > > On Wed, 2 Aug 2023, Nicola Vetrini wrote: > >> The extern variable 'irq_desc' defined in 'irq.h' is shadowed by > >> local variables in the changed file. To avoid this, the variable is > >> renamed to 'irq_d

[xen-unstable-smoke test] 182170: tolerable all pass - PUSHED

flight 182170 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182170/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

Hi Daniel, [...] > diff --git a/xen/common/fdt.c b/xen/common/fdt.c > new file mode 100644 > index 00..8d7acaaa43 > --- /dev/null > +++ b/xen/common/fdt.c > @@ -0,0 +1,153 @@ > +/* > + * Flattened Device Tree > + * > + * Copyright (C) 2012-2014 Citrix Systems, Inc. > + * > + * This program

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

Hi, On 03/08/2023 18:45, Elliott Mitchell wrote: On Thu, Aug 03, 2023 at 05:34:31PM +0100, Julien Grall wrote: On 03/08/2023 17:13, Elliott Mitchell wrote: I didn't know which way to go, so with no idea which option to choose the last one ended up winning out. Perhaps that was wrong yet I'v

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

On Thu, Aug 03, 2023 at 05:34:31PM +0100, Julien Grall wrote: > > On 03/08/2023 17:13, Elliott Mitchell wrote: > > > > I didn't know which way to go, so with no idea which option to choose the > > last one ended up winning out. Perhaps that was wrong yet I've still no > > feedback on the actual

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

On 8/3/23 08:48, Michal Orzel wrote: Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is IIUC, you just try to untangle the code for fdt from d

[qemu-mainline test] 182114: tolerable FAIL - PUSHED

flight 182114 qemu-mainline real [real] flight 182169 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182114/ http://logs.test-lab.xenproject.org/osstest/logs/182169/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

On 8/3/23 08:19, Jan Beulich wrote: On 03.08.2023 12:44, Daniel P. Smith wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -332,6 +332,15 @@ M: Nick Rosbrook S:Maintained F:tools/golang +HYPERLAUNCH +M: Daniel P. Smith +M: Christopher Clark +W: https://wiki.xenproject.

Re: [PATCH 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

On 8/1/23 1:08 AM, Jan Beulich wrote: > On 01.08.2023 01:37, Shawn Anastasio wrote: >> On 7/31/23 10:46 AM, Jan Beulich wrote: >>> On 29.07.2023 00:21, Shawn Anastasio wrote: +/* If we're at the correct address, skip copy */ +cmpld %r1, %r12 +beq .L_correct_address

RE: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling

> > Jumping way back to providing a wrapper for FRED, if we do that, then > > there's no need to include calling.h, and the weird wrinkle about the > > ERET target kinda goes away too. E.g. provide this in > > arch/x86/entry/entry_64_fred.S > > > > .section .text, "ax" > > > > /* Note, this is

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

On 8/3/23 07:45, Michal Orzel wrote: Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be mad

Re: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states()

Hi Jan, On 03/08/2023 09:53, Jan Beulich wrote: On 02.08.2023 17:47, Julien Grall wrote: From: Julien Grall expand_xsave_states() is not meant to modify the vCPU. So the parameter can be const. Signed-off-by: Julien Grall Acked-by: Jan Beulich Thanks. I have committed the patch. Cheer

Re: Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()

On 03/08/2023 12:46, Jan Beulich wrote: On 27.07.2023 20:41, Stefano Stabellini wrote: On Thu, 27 Jul 2023, Jan Beulich wrote: In the latter case the variable altogether is then unused and hence gets dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly introduced both assign

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

Hi Elliott, On 03/08/2023 17:13, Elliott Mitchell wrote: On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: Some of the patches looks to have been posted previously as a 7-patch series. It would have been nice if therefore this one was marked as v2, indicating in a revision log what

Re: [PATCH] console: generalize the ability for domU access

On 8/3/23 11:56, Jan Beulich wrote: On 03.08.2023 14:56, Daniel P. Smith wrote: On 8/2/23 07:01, Jan Beulich wrote: On 01.08.2023 18:06, Daniel P. Smith wrote: +if ( hardware_domain ) +{ +console_rx = hardware_domain->domain_id + 1; +printk("*** Serial i

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: > > Some of the patches looks to have been posted previously as a 7-patch > series. It would have been nice if therefore this one was marked as > v2, indicating in a revision log what the differences are. It appears > as if at least one

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 8/3/23 11:59, Jan Beulich wrote: On 03.08.2023 17:52, Daniel P. Smith wrote: On 8/1/23 21:06, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -474,9 +474,8 @@ struct domain uint8_t role; #

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 03.08.2023 17:52, Daniel P. Smith wrote: > On 8/1/23 21:06, Stefano Stabellini wrote: >> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -474,9 +474,8 @@ struct domain >>> uint8_t role; >>> #define CAP_CONSOLE

Re: [RFC 1/6] dom0: replace explict zero checks

On 8/3/23 09:36, Julien Grall wrote: Hi Daniel, Hey Julien, On 03/08/2023 14:33, Daniel P. Smith wrote: On 8/2/23 03:46, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: A legacy concept is that the initial domain will have a domain id of zero. As a result there are places wh

Re: [PATCH] console: generalize the ability for domU access

On 03.08.2023 14:56, Daniel P. Smith wrote: > On 8/2/23 07:01, Jan Beulich wrote: >> On 01.08.2023 18:06, Daniel P. Smith wrote: >>> +if ( hardware_domain ) >>> +{ >>> +console_rx = hardware_domain->domain_id + 1; >>> +printk("*** Serial input to DOM%d", CON_

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 8/1/23 21:06, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: Expresses the ability to attach a debugger as a capability that a domain can be provisioned. Signed-off-by: Daniel P. Smith --- xen/arch/x86/hvm/svm/svm.c | 8 xen/arch/x86/hvm/vmx/realmode.

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

On 03.08.2023 11:30, Nicola Vetrini wrote: > On 03/08/2023 11:20, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> --- a/xen/arch/x86/mm/p2m-pod.c >>> +++ b/xen/arch/x86/mm/p2m-pod.c >>> @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const >>> gfn_t *gfns, uns

Re: [RFC 4/6] capabilities: introduce console io as a domain capability

On 8/1/23 21:01, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: The field `is_console` suggests that the field represents a state of being or posession, not that it reflects the privilege to access the console. In this ^ possession Thank you for the catch. patch the

Re: [PATCH 0/2] libxl: build fixes for recent CPUID work

On 03/08/2023 3:32 pm, Juergen Gross wrote: > On 03.08.23 16:13, Jan Beulich wrote: >> 1: avoid shadowing of index() >> 2: allow building with old gcc again >> >> Jan > > For the series: > > Reviewed-by: Juergen Gross Acked-by: Andrew Cooper

Re: Call for agenda items for 03/08/23 Community Call @ 1500 UTC

On 03.08.2023 16:48, Kelly Choi wrote: > The proposed agenda is in this link > and you can > edit to add items. Alternatively, you can reply to this mail directly. Just to mention it: George has previously pointed at https://cryptpa

Call for agenda items for 03/08/23 Community Call @ 1500 UTC

Hi all, The proposed agenda is in this link and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the d

[ovmf test] 182163: all pass - PUSHED

flight 182163 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182163/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7672d1cca58228b0cb7f099e8863aa3a44ae45db baseline version: ovmf fa789cc68a85a5781c18c

[PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that compiles the Generic Interrupt Controller v2 emulation for domains, it is required only when using GICv2 driver, otherwise using the GICv3 driver it is op

Re: [PATCH 0/2] libxl: build fixes for recent CPUID work

On 03.08.23 16:13, Jan Beulich wrote: 1: avoid shadowing of index() 2: allow building with old gcc again Jan For the series: Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On 03/08/2023 11:01, Jan Beulich wrote: On 03.08.2023 04:13, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Nicola Vetrini wrote: @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) switch ( action->ack_type ) { -cpumask_t *cpu_eoi_map; It is only

Re: [PATCH] libxenstat/Linux: pass nul-terminated string to strpbrk()

On 26.07.23 12:42, Jan Beulich wrote: While what "tmp" points to has been cleared at the end of the first iteration of parseNetDevLine()'s main loop, this is too late for the first iteration's invocation of strpbrk() (copying the interface name). Properly nul-terminate the string at population ti

[PATCH 2/2] libxl: allow building with old gcc again

We can't use initializers of unnamed struct/union members just yet. Fixes: d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -316,12 +316,16 @@ int libxl_cpuid_parse_con

[PATCH 1/2] libxl: avoid shadowing of index()

Because of -Wshadow the build otherwise fails with old enough glibc. While there also obey line length limits for msr_add(). Fixes: 6d21cedbaa34 ("libxl: add support for parsing MSR features") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @

[PATCH 0/2] libxl: build fixes for recent CPUID work

1: avoid shadowing of index() 2: allow building with old gcc again Jan

Re: [RFC 3/6] roles: add a role for xenstore domain

On 8/1/23 20:57, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: Expand the possible roles for a domain to include a role for the Xenstore domain. Signed-off-by: Daniel P. Smith Reviewed-by: Stefano Stabellini Thank you! --- xen/common/domain.c | 3 +++ xen/i

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

On 8/2/23 03:51, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) setup_io_bitmap(dom0); #endif +/* + * "dom0" may have been created under the u

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

On 8/1/23 20:54, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: The existing concepts such as unbounded domain, ie. all powerful, control domain and hardware domain are, effectively, roles the domains provide for the system. Currently, these are represented with booleans wi

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 03/08/2023 14:03, Luca Fancellu wrote: Hi Julien, Hi, + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC @@ -92,6 +100,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +conf

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3

> On 3 Aug 2023, at 11:22, Simone Ballarin wrote: > > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to

  1   2   >