Re: [PATCH v3 10/52] xen/arm: Move MMU related definitions from config.h to mmu/layout.h

Hi Julien On 2023/7/5 05:54, Julien Grall wrote: Hi Penny, On 26/06/2023 04:34, Penny Zheng wrote: From: Wei Chen Xen defines some global configuration macros for Arm in config.h. We still want to use it for MMU systems, but there are some address Did you mean MPU? yes, typo layout re

Re: [PATCH v3 2/4] xen: Add files needed for minimal ppc64le build

On 14.06.2023 18:36, Shawn Anastasio wrote: > On Wed Jun 14, 2023 at 10:51 AM CDT, Jan Beulich wrote: >> On 13.06.2023 16:50, Shawn Anastasio wrote: >>> --- /dev/null >>> +++ b/xen/arch/ppc/arch.mk >>> @@ -0,0 +1,11 @@ >>> + >>> +# Power-specific definitions

Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm

> On 4 Jul 2023, at 20:11, Julien Grall wrote: > > Hi, > > Replying here because there is no cover letter (in the future please add one > if you have more than two patches bundled together). Sure I will > > On 04/07/2023 10:42, Anthony PERARD wrote: >> On Thu, Jun 08, 2023 at 02:59:12PM +

Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op

On 04.07.2023 19:04, Andrew Cooper wrote: > On 04/07/2023 3:29 pm, Jan Beulich wrote: >> On 30.06.2023 17:20, Andrew Cooper wrote: >>> It was previously noted that CALL/BUG is a weird combination, but there is >>> good reason to use this pattern. >>> >>> Introduce an explicit tailcall macro make it

Re: [PATCH v3 08/52] xen/arm64: move MMU related code from head.S to mmu/head.S

Hi Julien On 2023/7/5 05:46, Julien Grall wrote: Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen There are lots of MMU specific code in head.S. This code will not be used in MPU systems. If we use #ifdef to gate them, the code will become messy and hard to maintain. So we mo

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

On 04.07.23 19:14, Oleksandr Tyshchenko wrote: On Tue, Jul 4, 2023 at 5:49 PM Roger Pau Monné > wrote: Hello all. [sorry for the possible format issues] On Tue, Jul 04, 2023 at 01:43:46PM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > FWI

Re: [PATCH v3 07/52] xen/arm64: prepare for moving MMU related code from head.S

Hi Julien On 2023/7/5 05:35, Julien Grall wrote: Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen We want to reuse head.S for MPU systems, but there are some code are implemented for MMU systems only. We will move such code to another MMU specific file. But before that we wil

Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU

Hi Julien and Ayan On 2023/7/4 20:04, Ayan Kumar Halder wrote: On 04/07/2023 12:44, Julien Grall wrote: Hi, On 04/07/2023 12:14, Ayan Kumar Halder wrote: On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caut

Re: [PATCH v3 05/52] xen/arm64: head: Introduce enable_boot_mmu and enable_runtime_mmu

Hi Julien On 2023/7/5 05:24, Julien Grall wrote: Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen At the moment, on MMU system, enable_mmu() will return to an address in the 1:1 mapping, then each path is responsible to switch to virtual runtime mapping. Then remove_identity_

[linux-linus test] 181696: regressions - trouble: broken/fail/pass

flight 181696 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181696/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 broken test-amd64-amd64-freebsd12-amd64 5 ho

[xen-unstable-smoke test] 181698: tolerable all pass - PUSHED

flight 181698 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181698/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable test] 181695: tolerable FAIL - PUSHED

flight 181695 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181695/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 181689 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v3 12/52] xen/mmu: extract early uart mapping from setup_fixmap

Hi Penny, Title: You want to clarify that this change is arm64 only. So: xen/arm64: mmu: ... On 26/06/2023 04:34, Penny Zheng wrote: Original setup_fixmap is actually doing two seperate tasks, one is enabling the early UART when earlyprintk on, and the other is to set up the fixmap even when e

Re: [PATCH v3 11/52] xen/arm: mmu: fold FIXMAP into MMU system

Hi, On 26/06/2023 04:34, Penny Zheng wrote: FIXMAP in MMU system is used to do special-purpose 4K mapping, like mapping early UART, temporarily mapping source codes for copy and paste (copy_from_paddr), etc. As FIXMAP feature is highly dependent on virtual address translation, we introduce a ne

Re: [PATCH v3 10/52] xen/arm: Move MMU related definitions from config.h to mmu/layout.h

Hi Penny, On 26/06/2023 04:34, Penny Zheng wrote: From: Wei Chen Xen defines some global configuration macros for Arm in config.h. We still want to use it for MMU systems, but there are some address Did you mean MPU? layout related definitions that are defined for MMU systems only. These d

Re: [PATCH v3 08/52] xen/arm64: move MMU related code from head.S to mmu/head.S

Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen There are lots of MMU specific code in head.S. This code will not be used in MPU systems. If we use #ifdef to gate them, the code will become messy and hard to maintain. So we move MMU related code to mmu/head.S, and keep common

[xen-unstable-smoke test] 181697: tolerable all pass - PUSHED

flight 181697 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181697/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [PATCH v3 07/52] xen/arm64: prepare for moving MMU related code from head.S

Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen We want to reuse head.S for MPU systems, but there are some code are implemented for MMU systems only. We will move such code to another MMU specific file. But before that we will do some indentations fix in this patch to make th

Re: [PATCH v3 05/52] xen/arm64: head: Introduce enable_boot_mmu and enable_runtime_mmu

Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen At the moment, on MMU system, enable_mmu() will return to an address in the 1:1 mapping, then each path is responsible to switch to virtual runtime mapping. Then remove_identity_mapping() is called to remove all 1:1 mapping. Th

Re: [PATCH v7 01/12] vpci: introduce per-domain lock to protect vpci structure

Hi Roger, Roger Pau Monné writes: > On Thu, Jun 22, 2023 at 09:17:36PM +, Volodymyr Babchuk wrote: >> >> Hi Roger, >> >> Roger Pau Monné writes: >> >> > On Wed, Jun 21, 2023 at 10:07:20PM +, Volodymyr Babchuk wrote: >> >> >> >> Hi Roger, >> >> >> >> Roger Pau Monné writes: >> >>

[PATCH] iommu/ipmmu-vmsa: Add missing 'U' in IMTTLBR0_TTBR_MASK for shifted constant

From: Oleksandr Tyshchenko With enabling both CONFIG_UBSAN and CONFIG_IPMMU_VMSA I have got the following splat when an IOMMU driver tried to setup page tables: (XEN) ipmmu: /soc/iommu@e67b: d1: Set IPMMU context 1 (pgd 0x77fe9) (XEN)

Re: [PATCH v3 09/52] xen/arm: use PA == VA for EARLY_UART_VIRTUAL_ADDRESS on MPU systems

Hi Penny, On 26/06/2023 04:34, Penny Zheng wrote: From: Wei Chen There is no VMSA support on MPU systems, so we can not map early UART to FIXMAP_CONSOLE. In stead, we can use PA == VA for early UART on MPU systems. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng Is this change necessar

Re: [PATCH v3 04/52] xen/arm: add .text.idmap in ld script for Xen identity map sections

Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen Only the first 4KB of Xen image will be mapped as identity (PA == VA). At the moment, Xen guarantees this by having everything that needs to be used in the identity mapping in .text.header section of head.S, and the size will be

Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R

Hi, On 26/06/2023 04:33, Penny Zheng wrote: From: Wei Chen On Armv8-A, Xen has a fixed virtual start address (link address too) for all Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. So, on Armv8-A platforms, the Xen start address does

Re: [PATCH v3 00/52] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1

Hi Penny, On 26/06/2023 04:33, Penny Zheng wrote: Wei Chen (11): xen/arm: remove xen_phys_start and xenheap_phys_end from config.h xen/arm: make ARM_EFI selectable for Arm64 I have committed these two patches. Cheers, -- Julien Grall

Re: [PATCH] xen/arm: vgic: Add missing 'U' in VGIC_ICFG_MASK for shifted constant

Hi, On 30/06/2023 00:03, Stefano Stabellini wrote: On Fri, 30 Jun 2023, Henry Wang wrote: With UBSAN on some arm64 platforms, e.g. FVP_Base_RevC-2xAEMvA, the following splat will be printed while Dom0 is booting: ``` (XEN) == (XEN)

Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm

Hi, Replying here because there is no cover letter (in the future please add one if you have more than two patches bundled together). On 04/07/2023 10:42, Anthony PERARD wrote: On Thu, Jun 08, 2023 at 02:59:12PM +0100, Luca Fancellu wrote: Commit 56a7aaa16bfe introduced some SVE related code

Re: [PATCH 0/7] xen/arm: Add some missing ISBs after updating the PTEs

Hi, On 19/06/2023 18:01, Julien Grall wrote: From: Julien Grall Hi all, The main goal of this series is to add some missing ISBs after update the PTEs. The last patch is re-ingesting a patch that was reverted due to a boot failure on the Arndale. This has now been fixed by patch #2. Cheers,

Re: [PATCH 4/7] xen/arm: page: Consolidate write_pte() and clarify the documentation

Hi Bertrand, On 04/07/2023 16:06, Bertrand Marquis wrote: On 19 Jun 2023, at 19:01, Julien Grall wrote: From: Julien Grall The implementation of write_pte() is pretty much the same on arm32 and arm64. So it would be good to consolidate it as this would help to clarify the requirements when u

Re: xen | Failed pipeline for staging | 9dd3caf1

Hi, On 04/07/2023 16:50, Andrew Cooper wrote: On 04/07/2023 4:39 pm, Jan Beulich wrote: On 30.06.2023 16:50, GitLab wrote: Pipeline #917215286 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 9dd

Re: [v2 0/4] xen/arm: Enable USBAN support

Hi all, On 29/06/2023 21:11, Julien Grall wrote: From: Julien Grall Hi all, At the moment, we are not able to enable UBSAN on Arm because the final binary will be over the maximum size of Xen we currently support (i.e. 2MB). This patch series aim to lift the restrictions and also enable UBSA

Re: [v2 4/4] xen/arm: Allow the user to build Xen with UBSAN

Hi Michal, On 30/06/2023 07:58, Michal Orzel wrote: On 29/06/2023 22:11, Julien Grall wrote: From: Julien Grall UBSAN has been enabled a few years ago on x86 but was never enabled on Arm because the final binary is bigger than 2MB ( the maximum we can currently handled). With the recent

Re: [v2 3/4] xen/arm: Rework the code mapping Xen to avoid relying on the size of Xen

Hi, On 30/06/2023 07:56, Michal Orzel wrote: On 29/06/2023 22:11, Julien Grall wrote: From: Julien Grall At the moment, the maximum size of Xen binary we can support is 2MB. This is what we reserved in the virtual address but also what all the code in Xen relies on as we only allocate one

Re: [v2 2/4] xen/arm32: head: Don't map too much in boot_third

Hi Bertrand, On 04/07/2023 15:12, Bertrand Marquis wrote: On 29 Jun 2023, at 22:11, Julien Grall wrote: From: Julien Grall At the moment, we are mapping the size of the reserved area for Xen (i.e. 2MB) even if the binary is smaller. We don't exactly know what's after Xen, so it is not a good

Re: [v2 1/4] xen/arm64: head: Don't map too much in boot_third

Hi Michal, On 30/06/2023 07:50, Michal Orzel wrote: On 29/06/2023 22:11, Julien Grall wrote: From: Julien Grall At the moment, we are mapping the size of the reserved area for Xen (i.e. 2MB) even if the binary is smaller. We don't exactly know what's after Xen, so it is not a good idea to

Re: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers

Hi Bertrand, On 04/07/2023 15:35, Bertrand Marquis wrote: On 29 Jun 2023, at 23:01, Julien Grall wrote: From: Julien Grall Both the stub and the x86 prototypes for replace_grant_host_mapping() and create_grant_host_mapping() will define the first parameter (and third for the former) as uint6

Re: [PATCH] xen-block: Avoid leaks on new error path

On Tue, 4 Jul 2023 at 18:19, Anthony PERARD wrote: > > From: Anthony PERARD > > Commit 189829399070 ("xen-block: Use specific blockdev driver") > introduced a new error path, without taking care of allocated > resources. > > So only allocate the qdicts after the error check, and free both > `file

Re: [PATCH v3 42/52] xen/mpu: implement setup_virt_paging for MPU system

Hi Penny, Most of these are specific to ARM_64, thus we can add "#ifdef CONFIG_ARM_64" as follows :- On 26/06/2023 04:34, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or respo

Re: [PATCH 1/2] credit: Limit load balancing to once per millisecond

On 30/06/2023 12:37 pm, George Dunlap wrote: > The credit scheduler tries as hard as it can to ensure that it always > runs scheduling units with positive credit (PRI_TS_UNDER) before > running those with negative credit (PRI_TS_OVER). If the next > runnable scheduling unit is of priority OVER, it

[PATCH] xen-block: Avoid leaks on new error path

From: Anthony PERARD Commit 189829399070 ("xen-block: Use specific blockdev driver") introduced a new error path, without taking care of allocated resources. So only allocate the qdicts after the error check, and free both `filename` and `driver` when we are about to return and thus taking care

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

On Tue, Jul 4, 2023 at 5:49 PM Roger Pau Monné wrote: Hello all. [sorry for the possible format issues] On Tue, Jul 04, 2023 at 01:43:46PM +0200, Marek Marczykowski-Górecki wrote: > > Hi, > > > > FWIW, I have ran into this issue some time ago too. I run Xen on top of > > KVM and then passthrou

Re: [PATCH v2.5 3/3] xen/types: Rework stdint vs __{u,s}$N types

On 04/07/2023 3:38 pm, Jan Beulich wrote: > On 28.06.2023 16:54, Andrew Cooper wrote: >> Xen uses the stdint types. Rearrange the types headers to define the >> compatibility __{u,s}$N types in terms of the stdint types, not the other way >> around. >> >> All supported compilers on architectures o

Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op

On 04/07/2023 3:29 pm, Jan Beulich wrote: > On 30.06.2023 17:20, Andrew Cooper wrote: >> It was previously noted that CALL/BUG is a weird combination, but there is >> good reason to use this pattern. >> >> Introduce an explicit tailcall macro make it clearer in context. >> >> No functional change.

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > + void *holder, const struct blk_holder_ops *hops) > +{ > + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), > +

Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)

On 04.07.2023 18:10, Roger Pau Monné wrote: > On Tue, Jul 04, 2023 at 06:04:36PM +0200, Jan Beulich wrote: >> On 04.07.2023 17:55, Roger Pau Monné wrote: >>> On Tue, Jul 04, 2023 at 05:42:33PM +0200, Jan Beulich wrote: Plus is the mentioned "potential ABI change" safe to take on a stable

Re: [PATCH v3] xen: speed up grant-table reclaim

On Tue, Jul 04, 2023 at 02:07:47PM +0200, Jan Beulich wrote: > On 27.06.2023 19:22, Demi Marie Obenour wrote: > > When a grant entry is still in use by the remote domain, Linux must put > > it on a deferred list. Normally, this list is very short, because > > the PV network and block protocols exp

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Tue, Jul 04, 2023 at 07:06:26AM -0700, Bart Van Assche wrote: > On 7/4/23 05:21, Jan Kara wrote: > > +struct bdev_handle { > > + struct block_device *bdev; > > + void *holder; > > +}; > > Please explain in the patch description why a holder pointer is introduced > in struct bdev_handle and

Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)

On Tue, Jul 04, 2023 at 06:04:36PM +0200, Jan Beulich wrote: > On 04.07.2023 17:55, Roger Pau Monné wrote: > > On Tue, Jul 04, 2023 at 05:42:33PM +0200, Jan Beulich wrote: > >> On 28.06.2023 11:46, Roger Pau Monné wrote: > >>> On Mon, May 08, 2023 at 04:46:18PM +, Olaf Hering wrote: > clan

Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)

On 04.07.2023 17:55, Roger Pau Monné wrote: > On Tue, Jul 04, 2023 at 05:42:33PM +0200, Jan Beulich wrote: >> On 28.06.2023 11:46, Roger Pau Monné wrote: >>> On Mon, May 08, 2023 at 04:46:18PM +, Olaf Hering wrote: clang complains about the signed type: implicit truncation from '

Re: [XEN PATCH v3 3/3] xen: fix violations of MISRA C:2012 Rule 3.1

On 29.06.2023 21:20, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Luca Fancellu wrote: >>> On 29 Jun 2023, at 11:06, Nicola Vetrini wrote: >>> --- a/xen/common/xmalloc_tlsf.c >>> +++ b/xen/common/xmalloc_tlsf.c >>> @@ -140,9 +140,7 @@ static inline void MAPPING_SEARCH(unsigned long *r, int >>

Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)

On Tue, Jul 04, 2023 at 05:42:33PM +0200, Jan Beulich wrote: > On 28.06.2023 11:46, Roger Pau Monné wrote: > > On Mon, May 08, 2023 at 04:46:18PM +, Olaf Hering wrote: > >> clang complains about the signed type: > >> > >> implicit truncation from 'int' to a one-bit wide bit-field changes value

Re: [XEN PATCH v3 2/3] xen/drivers/passthrough/arm/smmu-v3.c: fix violations of MISRA C:2012 Rule 3.1

On 29.06.2023 16:52, Luca Fancellu wrote: > > >> On 29 Jun 2023, at 11:06, Nicola Vetrini wrote: >> >> In the file `xen/drivers/passthrough/arm/smmu-v3.c' there are a few >> occurrences > > here you use a different character to enclose the file path (` vs ‘) may I > suggest to > use only (‘)?

Re: xen | Failed pipeline for staging | 9dd3caf1

On 04/07/2023 4:39 pm, Jan Beulich wrote: > On 30.06.2023 16:50, GitLab wrote: >> >> Pipeline #917215286 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) >> >> Commit: 9dd3caf1 ( >> https://gitlab.com/

Re: Backport request (was: [PATCH v2] tools: convert bitfields to unsigned type)

On 28.06.2023 11:46, Roger Pau Monné wrote: > On Mon, May 08, 2023 at 04:46:18PM +, Olaf Hering wrote: >> clang complains about the signed type: >> >> implicit truncation from 'int' to a one-bit wide bit-field changes value >> from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] >> >> The

Re: xen | Failed pipeline for staging | 9dd3caf1

On 30.06.2023 16:50, GitLab wrote: > > > Pipeline #917215286 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: 9dd3caf1 ( > https://gitlab.com/xen-project/xen/-/commit/9dd3caf12f52b859947c2

[libvirt test] 181691: tolerable all pass - PUSHED

flight 181691 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/181691/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 181667 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v3 35/52] xen/arm: map static memory on demand

Hi Penny, On 26/06/2023 04:34, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. In function init_staticmem_pages, we need the access to static memory

Re: [PATCH 7/7] xen/arm32: head: Widen the use of the temporary mapping

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. > > In follow-up patches, we will rework how secondary CPU bring-up works > an

Re: [PATCH 4/7] xen/arm: page: Consolidate write_pte() and clarify the documentation

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > The implementation of write_pte() is pretty much the same on arm32 > and arm64. So it would be good to consolidate it as this would help > to clarify the requirements when using the helper. > > Take the oppo

Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO

On 04.07.2023 16:53, Nicola Vetrini wrote: > > > On 04/07/23 16:24, Jan Beulich wrote: >> On 26.06.2023 17:37, Nicola Vetrini wrote: >>> Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension >>> that gives an acceptable semantics to C99 undefined behavior 58 >>> ("A structure or union is

Re: [PATCH 5/7] xen/arm: pmap: Add missing ISB in arch_pmap_map()

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > Per the Arm Arm, (Armv7 DDI406C.d A3.8.3 and Armv8 DDI 0487J.a B2.3.12): > > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or u

Re: [PATCH 6/7] xen/arm: mm: Add missing ISB in xen_pt_update()

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > Per the Arm Arm, (Armv7 DDI406C.d A3.8.3 and Armv8 DDI 0487J.a B2.3.12): > > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or u

Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO

On 04/07/23 16:24, Jan Beulich wrote: On 26.06.2023 17:37, Nicola Vetrini wrote: Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension that gives an acceptable semantics to C99 undefined behavior 58 ("A structure or union is defined as containing no named members (6.7.2.1)"). The fi

Re: [PATCH 1/7] xen/arm32: head: Add missing isb in setup_fixmap()

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > Per the Arm Arm (ARM DDI 0406C.d A3.8.3): > > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance oper

Re: [PATCH 2/7] xen/arm32: head: Add mising isb in switch_to_runtime_mapping()

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > Per the Arm Arm (ARM DDI 0406C.d A3.8.3): > > "The DMB and DSB memory barriers affect reads and writes to the memory > system generated by load/store instructions and data or unified cache > maintenance oper

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

On 04.07.2023 12:23, Federico Serafini wrote: > Change mechanically the parameter names and types of function > declarations to be consistent with the ones used in the corresponding > definitions so as to fix violations of MISRA C:2012 Rule 8.3 ("All > declarations of an object or function shall us

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

On Tue, Jul 04, 2023 at 01:43:46PM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > FWIW, I have ran into this issue some time ago too. I run Xen on top of > KVM and then passthrough some of the virtio devices (network one > specifically) into a (PV) guest. So, I hit both cases, the dom0 one and

Re: [PATCH 3/7] xen/arm64: head: Add missing isb in setup_fixmap()

Hi Julien, > On 19 Jun 2023, at 19:01, Julien Grall wrote: > > From: Julien Grall > > On older version of the Arm Arm (ARM DDI 0487E.a, B2-125) there were > the following paragraph: > > "DMB and DSB instructions affect reads and writes to the memory system > generated by Load/Store instructio

[linux-linus test] 181690: regressions - trouble: broken/fail/pass

flight 181690 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd broken test-amd64-amd64-xl-vhd 5 host-insta

Re: [PATCH v2.5 3/3] xen/types: Rework stdint vs __{u,s}$N types

On 28.06.2023 16:54, Andrew Cooper wrote: > Xen uses the stdint types. Rearrange the types headers to define the > compatibility __{u,s}$N types in terms of the stdint types, not the other way > around. > > All supported compilers on architectures other than x86 support the stdint > __*_TYPE__ ma

Re: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers

Hi Julien, > On 29 Jun 2023, at 23:01, Julien Grall wrote: > > From: Julien Grall > > Both the stub and the x86 prototypes for replace_grant_host_mapping() > and create_grant_host_mapping() will define the first parameter (and > third for the former) as uint64_t. Yet Arm will define it as > 'u

Re: [PATCH v2 2/3] treewide: Avoid including asm/types.h

On 27.06.2023 09:56, Andrew Cooper wrote: > We're about to rearrange the common and arch types.h split. While most > users already include , a few do not and some files fail to > compile as a result. > > Almost all logic is going to have types very early in the include chain. Drop > the include

Re: [PATCH] x86/asm: Introduce a tailcall pseduo-op

On 30.06.2023 17:20, Andrew Cooper wrote: > It was previously noted that CALL/BUG is a weird combination, but there is > good reason to use this pattern. > > Introduce an explicit tailcall macro make it clearer in context. > > No functional change. > > Reported-by: Jan Beulich Did I? Must have

Re: [XEN PATCH v6] xen/include: avoid using a compiler extension for BUILD_BUG_ON_ZERO

On 26.06.2023 17:37, Nicola Vetrini wrote: > Redefine BUILD_BUG_ON_ZERO to avoid using a compiler extension > that gives an acceptable semantics to C99 undefined behavior 58 > ("A structure or union is defined as containing no named members > (6.7.2.1)"). > > The first definition includes an addit

Re: [v2 3/4] xen/arm: Rework the code mapping Xen to avoid relying on the size of Xen

> On 29 Jun 2023, at 22:11, Julien Grall wrote: > > From: Julien Grall > > At the moment, the maximum size of Xen binary we can support is 2MB. > This is what we reserved in the virtual address but also what all > the code in Xen relies on as we only allocate one L3 page-table. > > When fea

Re: [PATCH v3 00/52] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1

On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. So sorry for the long long wait before v3 serie, since I got sidetracked to a n

Re: [v2 4/4] xen/arm: Allow the user to build Xen with UBSAN

Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: > > From: Julien Grall > > UBSAN has been enabled a few years ago on x86 but was never > enabled on Arm because the final binary is bigger than 2MB ( > the maximum we can currently handled). > > With the recent rework, it is now possi

Re: [v2 2/4] xen/arm32: head: Don't map too much in boot_third

Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: > > From: Julien Grall > > At the moment, we are mapping the size of the reserved area for Xen > (i.e. 2MB) even if the binary is smaller. We don't exactly know what's > after Xen, so it is not a good idea to map more than necessary fo

Re: [v2 1/4] xen/arm64: head: Don't map too much in boot_third

Hi Julien, > On 29 Jun 2023, at 22:11, Julien Grall wrote: > > From: Julien Grall > > At the moment, we are mapping the size of the reserved area for Xen > (i.e. 2MB) even if the binary is smaller. We don't exactly know what's > after Xen, so it is not a good idea to map more than necessary fo

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On 7/4/23 05:21, Jan Kara wrote: +struct bdev_handle { + struct block_device *bdev; + void *holder; +}; Please explain in the patch description why a holder pointer is introduced in struct bdev_handle and how it relates to the bd_holder pointer in struct block_device. Is one of th

Re: [XEN PATCH 5/5] x86: make parameter names of function declarations consistent

On 29.06.2023 17:55, Federico Serafini wrote: > --- a/xen/arch/x86/cpu/mcheck/mce.h > +++ b/xen/arch/x86/cpu/mcheck/mce.h > @@ -44,7 +44,7 @@ extern uint8_t cmci_apic_vector; > extern bool lmce_support; > > /* Init functions */ > -enum mcheck_type amd_mcheck_init(struct cpuinfo_x86 *c); > +enum

Re: [XEN PATCH 4/5] x86/x86_emulate: change parameter name from 's' to 'state'

On 29.06.2023 21:31, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Federico Serafini wrote: >> Change parameter name from 's' to 'state' in function definitions in >> order to: >> 1) keep consistency with the parameter names used in the corresponding >>declarations; >> 2) keep consistency wi

Re: [XEN PATCH 2/5] x86: change parameter names of nestedhvm_vcpu_iomap_get() definition

On 29.06.2023 21:25, Stefano Stabellini wrote: > On Thu, 29 Jun 2023, Federico Serafini wrote: >> Change parameter names of nestedhvm_vcpu_iomap_get() definition to >> those used in the function declaration in order to: >> 1) improve readability; I see this was committed already, so ftaod no reque

Re: XenSummit: Empty per-arch files

On 28.06.2023 13:32, Andrew Cooper wrote: > Hello, > > This wasn't a formal discussion point at XenSummit, but Oleksii pointed > out that it was still a problem, hence this thread. > > As we take on more architectures, it becomes more and more important for > things to be handled in a mostly-comm

Re: [PATCH v3 3/3] cmdline: parse multiple instances of the vga option

On Wed, Jun 07, 2023 at 12:07:54PM +0200, Jan Beulich wrote: > On 01.06.2023 15:05, Roger Pau Monne wrote: > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -2628,6 +2628,9 @@ with the specified width, height and depth. > > `ask` option. (N.B menu mode

[xen-unstable-smoke test] 181694: tolerable all pass - PUSHED

flight 181694 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181694/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Tue 04-07-23 13:43:51, Matthew Wilcox wrote: > On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > > + void *holder, const struct blk_holder_ops *hops) > > +{ > > + struct bdev_handle *handle = kmal

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

On Tue, Jul 04, 2023 at 02:21:28PM +0200, Jan Kara wrote: > +struct bdev_handle *blkdev_get_handle_by_dev(dev_t dev, blk_mode_t mode, > + void *holder, const struct blk_holder_ops *hops) > +{ > + struct bdev_handle *handle = kmalloc(sizeof(struct bdev_handle), > +

[PATCH 32/32] block: Rename blkdev_get_handle_by_*() and blkdev_handle_put()

Now that everybody is converted, we can rename blkdev_get_handle_by_*() and blkdev_handle_put() back to their original names. No functional change. Done by Coccinelle patch: @@ expression dev, mode, holder, hops; @@ - blkdev_get_handle_by_dev(dev, mode, holder, hops) + blkdev_get_by_d

[PATCH 01/32] block: Provide blkdev_get_handle_* functions

Create struct bdev_handle that contains all parameters that need to be passed to blkdev_put() and provide blkdev_get_handle_* functions that return this structure instead of plain bdev pointer. This will eventually allow us to pass one more argument to blkdev_put() without too much hassle. CC: Ala

[PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle

Hello, this patch series implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to modify all the users (agai

[PATCH 08/32] xen/blkback: Convert to blkdev_get_handle_by_dev()

Convert xen/blkback to use blkdev_get_handle_by_dev() and pass the handle around. CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- drivers/block/xen-blkback/blkback.c | 4 +-- drivers/block/xen-blkback/common.h | 4 +-- drivers/block/xen-blkback/xenbus.c | 40 +++---

Re: [PATCH v3 15/52] xen: make VMAP only support in MMU system

On 28.06.2023 07:38, Penny Zheng wrote: > On 2023/6/26 14:00, Jan Beulich wrote: >> On 26.06.2023 05:34, Penny Zheng wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -27,6 +27,7 @@ config X86 >>> select HAS_PDX >>> select HAS_SCHED_GRANULARITY >>> select HAS_U

Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R

On 04/07/2023 13:02, Ayan Kumar Halder wrote: On 04/07/2023 12:47, Julien Grall wrote: On 04/07/2023 11:36, Ayan Kumar Halder wrote: Hi Penny, Hi Ayan, Hi Julien, On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper

Re: [PATCH v3] xen: speed up grant-table reclaim

On 27.06.2023 19:22, Demi Marie Obenour wrote: > When a grant entry is still in use by the remote domain, Linux must put > it on a deferred list. Normally, this list is very short, because > the PV network and block protocols expect the backend to unmap the grant > first. However, Qubes OS's GUI

Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU

On 04/07/2023 12:44, Julien Grall wrote: Hi, On 04/07/2023 12:14, Ayan Kumar Halder wrote: On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to

Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R

On 04/07/2023 12:47, Julien Grall wrote: On 04/07/2023 11:36, Ayan Kumar Halder wrote: Hi Penny, Hi Ayan, Hi Julien, On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, c

Re: [PATCH v3 08/52] xen/arm64: move MMU related code from head.S to mmu/head.S

On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Wei Chen There are lots of MMU specific code in head.S. This code will

Re: [PATCH v3 03/52] xen/arm: add an option to define Xen start address for Armv8-R

On 04/07/2023 11:36, Ayan Kumar Halder wrote: Hi Penny, Hi Ayan, On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: We

Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU

Hi, On 04/07/2023 12:14, Ayan Kumar Halder wrote: On 26/06/2023 04:33, Penny Zheng wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. This commit wants to introduc

  1   2   >