[GIT PULL] xen: branch for v6.3-rc3

2023-03-16 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.3-rc3-tag xen: branch for v6.3-rc3 It contains: - a small cleanup series for xen time handling - a patch for enabling the VGA console in a Xen PVH dom0 - a small cleanup patch for t

[ovmf test] 179705: all pass - PUSHED

2023-03-16 Thread osstest service owner
flight 179705 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179705/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0e5717009779ec6c1e35f979426a2cd407b3e73a baseline version: ovmf 16e0969ef775b898ac700

[qemu-mainline test] 179682: regressions - trouble: fail/pass/starved

2023-03-16 Thread osstest service owner
flight 179682 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179682/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518 test-amd64-i386-l

[PATCH 0/2] automation: add another Gitlab-CI test, x86-64 S3 this time

2023-03-16 Thread Marek Marczykowski-Górecki
This series adds another Gitlab-CI test running on a real hardware. The gitlab-runner I have currently connected to https://gitlab.com/marmarek/xen. I'll need a registration token to connect it to the official repo. Example test run: https://gitlab.com/marmarek/xen/-/jobs/3952014197 Details about

[PATCH 2/2] automation: add a suspend test on an Alder Lake system

2023-03-16 Thread Marek Marczykowski-Górecki
This is a first test using Qubes OS CI infra. The gitlab-runner has access to ssh-based control interface (control@thor.testnet, ssh key exposed to the test via ssh-agent) and pre-configured HTTP dir for boot files (mapped under /scratch/gitlab-runner/tftp inside the container). Details about the s

[PATCH 1/2] automation: build 6.1.19 kernel for x86-64 dom0

2023-03-16 Thread Marek Marczykowski-Górecki
It will be used in tests added in subsequent patches. Enable config options needed for those tests. Signed-off-by: Marek Marczykowski-Górecki --- automation/gitlab-ci/build.yaml | 11 - automation/tests-artifacts/kernel/6.1.19.dockerfile | 40 ++- 2 files chan

RE: [PATCH v2 0/4] P2M improvements for Arm

2023-03-16 Thread Henry Wang
Hi everyone, > -Original Message- > Subject: [PATCH v2 0/4] P2M improvements for Arm > > There are some clean-up/improvement work that can be done in the > Arm P2M code triggered by [1] and [2]. These were found at the 4.17 > code freeze period so the issues were not fixed at that time. >

Re: [PATCH v2 2/2] automation: arm64: Create test jobs for testing static shared memory on qemu

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, jiamei.xie wrote: > Create 2 new test jobs, called qemu-smoke-dom0less-arm64-gcc-static-shared-mem > and qemu-smoke-dom0less-arm64-gcc-debug-static-shared-mem. > > Adjust qemu-smoke-dom0less-arm64.sh script to accomodate the static > shared memory test as a new test variant. T

[ovmf test] 179698: all pass - PUSHED

2023-03-16 Thread osstest service owner
flight 179698 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179698/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 16e0969ef775b898ac700f3261d76030b8ab9ef0 baseline version: ovmf 997c6967b00cdd797fe78

[linux-linus test] 179675: regressions - trouble: fail/pass/starved

2023-03-16 Thread osstest service owner
flight 179675 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179675/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail REGR. vs. 178042 test-amd64-amd64-xl

Re: [PATCH v2 1/2] automation: arm64: Create test jobs for testing static heap on qemu

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, jiamei.xie wrote: > From: Jiamei Xie > > Create 2 new test jobs, called qemu-smoke-dom0less-arm64-gcc-staticheap > and qemu-smoke-dom0less-arm64-gcc-debug-staticheap. > > Add property "xen,static-heap" under /chosen node to enable static-heap. > If the domU can start success

Re: [ImageBuilder][PATCH v2 2/2] uboot-script-gen: add support for static shared memory

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, jiamei.xie wrote: > Introduce support for creating shared-mem node for dom0less domUs in > the device tree. Add the following option: > - DOMU_SHARED_MEM[number]="SHM-ID HPA GPA size" > if specified, indicate the unique identifier of the shared memory > region is SHM-ID, th

Re: [ImageBuilder][PATCH v2 1/2] uboot-script-gen: Add XEN_STATIC_HEAP

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, Michal Orzel wrote: > On 16/03/2023 10:09, jiamei.xie wrote: > > From: jiamei Xie > > > > Add a new config parameter to configure Xen static heap. > > XEN_STATIC_HEAP="baseaddr1 size1 ... baseaddrN sizeN" > > if specified, indicates the host physical address regions > > [base

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, Jan Beulich wrote: > On 16.03.2023 10:27, Roger Pau Monné wrote: > > On Thu, Mar 16, 2023 at 09:55:03AM +0100, Jan Beulich wrote: > >> On 16.03.2023 01:44, Stefano Stabellini wrote: > >>> On Wed, 15 Mar 2023, Roger Pau Monné wrote: > On Sun, Mar 12, 2023 at 03:54:55PM +080

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, Juergen Gross wrote: > On 16.03.23 14:53, Alex Deucher wrote: > > On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > > > > > On 16.03.23 14:45, Alex Deucher wrote: > > > > On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: > > > > > > > > > > On 16.03.2023 00:25, Stef

Re: [PATCH v2] xen/console: Skip switching serial input to non existing domains

2023-03-16 Thread Stefano Stabellini
On Thu, 16 Mar 2023, Jan Beulich wrote: > On 16.03.2023 11:26, Michal Orzel wrote: > > --- a/xen/drivers/char/console.c > > +++ b/xen/drivers/char/console.c > > @@ -490,7 +490,24 @@ static void switch_serial_input(void) > > } > > else > > { > > -console_rx++; > > +uns

Re: [BUG] x2apic broken with current AMD hardware

2023-03-16 Thread Elliott Mitchell
On Mon, Mar 13, 2023 at 08:01:02AM +0100, Jan Beulich wrote: > On 11.03.2023 01:09, Elliott Mitchell wrote: > > On Thu, Mar 09, 2023 at 10:03:23AM +0100, Jan Beulich wrote: > >> > >> In any event you will want to collect a serial log at maximum verbosity. > >> It would also be of interest to know w

[xen-unstable test] 179668: tolerable trouble: fail/pass/starved - PUSHED

2023-03-16 Thread osstest service owner
flight 179668 xen-unstable real [real] flight 179694 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/179668/ http://logs.test-lab.xenproject.org/osstest/logs/179694/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v2 5/7] tools: Use -s for python shebangs

2023-03-16 Thread Marek Marczykowski-Górecki
On Thu, Mar 16, 2023 at 07:37:44PM +, Andrew Cooper wrote: > This is mandated by the Fedora packaging guidelines because it is a security > vulnerability otherwise in suid scripts. While Xen doesn't have suid scripts, > it's a very good idea generally, because it prevents the users local pytho

[PATCH v2 5/7] tools: Use -s for python shebangs

2023-03-16 Thread Andrew Cooper
This is mandated by the Fedora packaging guidelines because it is a security vulnerability otherwise in suid scripts. While Xen doesn't have suid scripts, it's a very good idea generally, because it prevents the users local python environment interfering from system packaged scripts. pygrub is th

Re: [PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()

2023-03-16 Thread kernel test robot
Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus powerpc/next powerpc/fixes linus/master v6.3-rc2 next-20230316] [cannot apply to soc/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH 7/7] tools/python: Drop shebangs from library files

2023-03-16 Thread Marek Marczykowski-Górecki
On Tue, Mar 14, 2023 at 02:15:20PM +, Andrew Cooper wrote: > These aren't runable scripts, so shouldn't have shebangs. > > Signed-off-by: Andrew Cooper Acked-by: Marek Marczykowski-Górecki > --- > CC: Wei Liu > CC: Anthony PERARD > CC: Marek Marczykowski-Górecki > CC: Bernhard Kaindl >

Re: [PATCH 6/7] tools/python: Improve unit test handling

2023-03-16 Thread Marek Marczykowski-Górecki
On Tue, Mar 14, 2023 at 02:15:19PM +, Andrew Cooper wrote: > * Add X86_{CPUID,MSR}_POLICY_FORMAT checks which were missed previously. > * Drop test_suite(). It hasn't been necessary since the Py2.3 era. > * Drop the __main__ logic. This can't be used without manually adjusting the >inc

[ovmf test] 179690: all pass - PUSHED

2023-03-16 Thread osstest service owner
flight 179690 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179690/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 997c6967b00cdd797fe787567a28a7565aafd301 baseline version: ovmf 7cfe9048e3ecad7988d66

Re: [PATCH 3/7] tools: Delete trailing whitespace in python scripts

2023-03-16 Thread Marek Marczykowski-Górecki
On Tue, Mar 14, 2023 at 02:15:16PM +, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Acked-by: Marek Marczykowski-Górecki -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab signature.asc Description: PGP signature

Re: [PATCH 2/7] tools/misc: Drop xencons

2023-03-16 Thread Marek Marczykowski-Górecki
On Tue, Mar 14, 2023 at 02:15:15PM +, Andrew Cooper wrote: > This is a python script which has it's shebang modified by be python3, but > was never converted to be python3 compatible. > > The most recent reference I can find to this script (which isn't incidental > adjustments in the makefile)

Re: [PATCH 1/7] tools/python: Drop pylintrc

2023-03-16 Thread Marek Marczykowski-Górecki
On Tue, Mar 14, 2023 at 02:15:14PM +, Andrew Cooper wrote: > This was added in 2004 in c/s b7d4a69f0ccb5 and has never been referenced > since. Given the the commit message of simply "Added .", it was quite > possibly a mistake in the first place. > > Signed-off-by: Andrew Cooper Ideally, w

[PATCH 1/4] tools: convert setup.py to use setuptools

2023-03-16 Thread Marek Marczykowski-Górecki
Python distutils is deprecated and is going to be removed in Python 3.12. Migrate to setuptools. Setuptools in Python 3.11 complains: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools. Keep using setup.py anyway to build C extension. S

[PATCH 4/4] Update README to state Python3 requirement

2023-03-16 Thread Marek Marczykowski-Górecki
Python2 is not supported anymore. Signed-off-by: Marek Marczykowski-Górecki --- README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 755b3d8eaf8f..b2d9d79d891b 100644 --- a/README +++ b/README @@ -50,7 +50,7 @@ provided by your OS distributor:

[PATCH 2/4] tools: don't use distutils in configure nor Makefile

2023-03-16 Thread Marek Marczykowski-Górecki
Python distutils is deprecated and is going to be removed in Python 3.12. The distutils.sysconfig is available as sysconfig module in stdlib since Python 3.2, so use that directly. Signed-off-by: Marek Marczykowski-Górecki --- m4/python_devel.m4 | 28 ++-- tools/lib

[xen-unstable-smoke test] 179687: tolerable trouble: pass/starved - PUSHED

2023-03-16 Thread osstest service owner
flight 179687 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179687/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Jan Beulich
On 14.03.2023 21:56, Volodymyr Babchuk wrote: > +static inline void refcnt_put(refcnt_t *refcnt, void (*destructor)(refcnt_t > *refcnt)) Hmm, this means all callers need to pass (and agree on) the supposedly single destructor function that needs calling. Wouldn't the destructor function better be

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Jan Beulich
On 16.03.2023 17:48, Roger Pau Monné wrote: > On Thu, Mar 16, 2023 at 05:43:18PM +0100, Jan Beulich wrote: >> On 16.03.2023 17:39, Roger Pau Monné wrote: >>> On Thu, Mar 16, 2023 at 05:32:38PM +0100, Jan Beulich wrote: On 16.03.2023 17:19, Roger Pau Monné wrote: > On Tue, Mar 14, 2023 at 0

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Roger Pau Monné
On Thu, Mar 16, 2023 at 05:43:18PM +0100, Jan Beulich wrote: > On 16.03.2023 17:39, Roger Pau Monné wrote: > > On Thu, Mar 16, 2023 at 05:32:38PM +0100, Jan Beulich wrote: > >> On 16.03.2023 17:19, Roger Pau Monné wrote: > >>> On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > >>>

[PATCH v2 2/3] xen/riscv: setup initial pagetables

2023-03-16 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V2: * Update the commit message --- xen/arch/riscv/setup.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index b56c69a3dc..a3481973ff 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv

[PATCH v2 3/3] xen/riscv: remove dummy_bss variable

2023-03-16 Thread Oleksii Kurochko
After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V2: * patch was introduced in the current one patch series (v2). --- xen/arch/riscv/setup.c | 8 1 file changed,

[PATCH v2 1/3] xen/riscv: introduce setup_initial_pages

2023-03-16 Thread Oleksii Kurochko
Mostly the code for setup_initial_pages was taken from Bobby's repo except for the following changes: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags.

[PATCH v2 0/3] enable MMU for RISC-V

2023-03-16 Thread Oleksii Kurochko
The patch series is based on top of 'RISCV basic exception handling implementation' patch series. [1] The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. C

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Jan Beulich
On 16.03.2023 17:39, Roger Pau Monné wrote: > On Thu, Mar 16, 2023 at 05:32:38PM +0100, Jan Beulich wrote: >> On 16.03.2023 17:19, Roger Pau Monné wrote: >>> On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: +static inline void refcnt_get(refcnt_t *refcnt) +{ +in

[PATCH v4] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2023-03-16 Thread Roger Pau Monne
In ACPI systems, the OS can direct power management, as opposed to the firmware. This OS-directed Power Management is called OSPM. Part of telling the firmware that the OS going to direct power management is making ACPI "_PDC" (Processor Driver Capabilities) calls. These _PDC methods must be eva

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Roger Pau Monné
On Thu, Mar 16, 2023 at 05:32:38PM +0100, Jan Beulich wrote: > On 16.03.2023 17:19, Roger Pau Monné wrote: > > On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > >> +static inline void refcnt_get(refcnt_t *refcnt) > >> +{ > >> +int old = atomic_add_unless(&refcnt->refcnt, 1, 0

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Jan Beulich
On 16.03.2023 17:19, Roger Pau Monné wrote: > On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: >> +static inline void refcnt_get(refcnt_t *refcnt) >> +{ >> +int old = atomic_add_unless(&refcnt->refcnt, 1, 0); > > Occurred to me while looking at the next patch: > > Don't you

Re: [PATCH v3 3/6] vpci: crash domain if we wasn't able to (un) map vPCI regions

2023-03-16 Thread Roger Pau Monné
On Tue, Mar 14, 2023 at 08:56:30PM +, Volodymyr Babchuk wrote: > In that unlikely case, when map_range() fails to do it's job, > domain memory mapping will be left in inconsistent state. As there is > no easy way to remove stale p2m mapping we need to crash domain, as > FIXME suggests. > > Sig

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Roger Pau Monné
On Sun, Mar 12, 2023 at 08:01:53PM +0800, Huang Rui wrote: > Xen PVH is the paravirtualized mode and takes advantage of hardware > virtualization support when possible. It will using the hardware IOMMU > support instead of xen-swiotlb, so disable swiotlb if current domain is > Xen PVH. > > Signed-

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Roger Pau Monné
On Thu, Mar 16, 2023 at 03:03:42PM +0100, Jan Beulich wrote: > On 16.03.2023 14:54, Roger Pau Monné wrote: > > On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > >> +{ > >> +return atomic_read(&refcnt->refcnt); > >> +} > >> + > >> +static inline void refcnt_get(refcnt_t *refcn

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Roger Pau Monné
On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > We can use reference counter to ease up object lifetime management. > This patch adds very basic support for reference counters. refcnt > should be used in the following way: > > 1. Protected structure should have refcnt_t field

Re: [PATCH v3 2/6] xen: pci: introduce reference counting for pdev

2023-03-16 Thread Roger Pau Monné
On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > Prior to this change, lifetime of pci_dev objects was protected by global > pcidevs_lock(). Long-term plan is to remove this log, so we need some ^ lock I wouldn't say remove, as

Re: [PATCH v2] xen/console: Skip switching serial input to non existing domains

2023-03-16 Thread Jan Beulich
On 16.03.2023 15:15, Michal Orzel wrote: > > > On 16/03/2023 12:11, Jan Beulich wrote: >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> On 16.03.2023 11:26, Michal Orzel wrote: >>> --- a/xen/drive

Re: [PATCH v3 3/3] xen/riscv: initialize .bss section

2023-03-16 Thread Bobby Eshleman
On Fri, Mar 03, 2023 at 12:24:24PM +0200, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/riscv64/head.S | 9 + > xen/arch/riscv/setup.c| 8 > 2 files changed, 17 insertions(+) > > diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/ris

Re: Aw: Re: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-16 Thread Jan Beulich
On 14.03.2023 16:11, Andrew Cooper wrote: > On 14/03/2023 2:53 pm, Denis wrote: >> On 14.03.2023 07:37; Jan Beulich wrote: >>> On 14.03.2023 02:15, Denis wrote: On 13.03.2023 10:36, Jan wrote > On 10.03.2023 21:50, Denis wrote: >> Should I test something else? > ... there was no re

Re: [PATCH v3 2/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader

2023-03-16 Thread Bobby Eshleman
On Fri, Mar 03, 2023 at 12:24:23PM +0200, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes since v2: > * Add the comment for start() function with the explanation what and >how OpenSBI pass to start() function. > * Clean up start() code related to read&save hart_id &

Re: [PATCH v3 1/3] xen/riscv: disable fpu

2023-03-16 Thread Bobby Eshleman
On Fri, Mar 03, 2023 at 12:24:22PM +0200, Oleksii Kurochko wrote: > Disable FPU to detect illegal usage of floating point in kernel > space. > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/riscv64/head.S | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/xen/arch/riscv/r

Re: [PATCH v3 1/3] xen/riscv: disable fpu

2023-03-16 Thread Bobby Eshleman
On Fri, Mar 03, 2023 at 12:24:22PM +0200, Oleksii Kurochko wrote: > Disable FPU to detect illegal usage of floating point in kernel > space. > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/riscv64/head.S | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/xen/arch/riscv/r

[ovmf test] 179677: all pass - PUSHED

2023-03-16 Thread osstest service owner
flight 179677 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179677/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7cfe9048e3ecad7988d66ce1f0ec20d9aef509ee baseline version: ovmf 961792c9d61f7e03e0c1b

[xen-unstable-smoke test] 179681: tolerable trouble: pass/starved - PUSHED

2023-03-16 Thread osstest service owner
flight 179681 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179681/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v5 7/7] xen/riscv: test basic handling stuff

2023-03-16 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V5: - Nothing changed --- Changes in V4: - Add Acked-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes in V2: - Nothing changed --- xen/arch/riscv/setup.c | 17 + 1 file changed

[PATCH v5 6/7] xen/riscv: introduce an implementation of macros from

2023-03-16 Thread Oleksii Kurochko
The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. To be precise, the macros from generic bug implementation () will be used. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. S

[PATCH v5 0/7] RISCV basic exception handling implementation

2023-03-16 Thread Oleksii Kurochko
The patch series is based on: * [introduce generic implementation of macros from bug.h][1] * [Do basic initialization things][2] * [Deal with GOT stuff for RISC-V][3] which haven't been commited yet. The patch series provides a basic implementation of exception handling. It can do only basic thing

[PATCH v5 5/7] xen/riscv: introduce trap_init()

2023-03-16 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed --- Changes in V2: - Rename setup_trap_handler() to trap_init(). - Add Reviewed-by to the commit message. --- xen

[PATCH v5 4/7] xen/riscv: introduce decode_cause() stuff

2023-03-16 Thread Oleksii Kurochko
The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko --- Changes in V5: - Remove from riscv/traps/c as nothing would require inclusion. - decode_reserved_interrupt_cause(), decode_interrupt_cause(), decode_cause, do_unexpected_trap()

[PATCH v5 3/7] xen/riscv: introduce dummy

2023-03-16 Thread Oleksii Kurochko
will be used in the patch "xen/riscv: introduce decode_cause() stuff" and requires Signed-off-by: Oleksii Kurochko --- Changes in V5: * the patch was introduced in the current patch series (V5) --- xen/arch/riscv/include/asm/bug.h | 10 ++ 1 file changed, 10 insertions(+) create mode

[PATCH v5 2/7] xen/riscv: initialize boot_info structure

2023-03-16 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V5: * the patch was introduced in the current patch series (V5) --- xen/arch/riscv/setup.c | 12 1 file changed, 12 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 0908bdb9f9..36556eb779 100644 --- a/xe

[PATCH v5 1/7] xen/riscv: introduce boot information structure

2023-03-16 Thread Oleksii Kurochko
The structure holds information about: 1. linker start/end address 2. load start/end address Also the patch introduces offsets for boot information structure members to access them in assembly code. Signed-off-by: Oleksii Kurochko --- Changes in V5: * the patch was introduced in the current pat

Re: [PATCH v2] xen/console: Skip switching serial input to non existing domains

2023-03-16 Thread George Dunlap
On Thu, Mar 16, 2023 at 2:15 PM Michal Orzel wrote: > > > On 16/03/2023 12:11, Jan Beulich wrote: > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > > > > On 16.03.2023 11:26, Michal Orzel wrote: > >> -

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Juergen Gross
On 16.03.23 14:53, Alex Deucher wrote: On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: On 16.03.23 14:45, Alex Deucher wrote: On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: On 16.03.2023 00:25, Stefano Stabellini wrote: On Wed, 15 Mar 2023, Jan Beulich wrote: On 15.03.2023 01:52

Re: [PATCH v2] xen/console: Skip switching serial input to non existing domains

2023-03-16 Thread Michal Orzel
On 16/03/2023 12:11, Jan Beulich wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 16.03.2023 11:26, Michal Orzel wrote: >> --- a/xen/drivers/char/console.c >> +++ b/xen/drivers/char/consol

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Jan Beulich
On 16.03.2023 14:54, Roger Pau Monné wrote: > On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: >> --- /dev/null >> +++ b/xen/include/xen/refcnt.h >> @@ -0,0 +1,59 @@ > > This seems to be missing some kind of license, can we have an SPDX tag > at least? Not "at least", but strict

Re: [PATCH v2 0/2] deal with GOT stuff for RISC-V

2023-03-16 Thread Andrew Cooper
On 16/03/2023 1:22 pm, Oleksii Kurochko wrote: > Oleksii Kurochko (2): > xen/riscv: add EMBEDDED_EXTRA_CFLAGS to CFLAGS > xen/riscv: add explicit check that .got{.plt} is empty Acked-by: Andrew Cooper

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Jan Beulich
On 16.03.2023 14:53, Alex Deucher wrote: > On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: >> >> On 16.03.23 14:45, Alex Deucher wrote: >>> On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: On 16.03.2023 00:25, Stefano Stabellini wrote: > On Wed, 15 Mar 2023, Jan Beulich wrote

Re: [PATCH v2 2/2] xen/riscv: add explicit check that .got{.plt} is empty

2023-03-16 Thread Jan Beulich
On 16.03.2023 14:22, Oleksii Kurochko wrote: > The GOT sections usage should be avoided in the hypervisor > so to catch such use cases earlier when GOT things are > produced the patch introduces .got and .got.plt sections > and adds asserts that they're empty. > > The sections won't be created unt

Re: [PATCH v3 1/6] xen: add reference counter support

2023-03-16 Thread Roger Pau Monné
On Tue, Mar 14, 2023 at 08:56:29PM +, Volodymyr Babchuk wrote: > We can use reference counter to ease up object lifetime management. > This patch adds very basic support for reference counters. refcnt > should be used in the following way: > > 1. Protected structure should have refcnt_t field

Re: [PATCH v2 1/2] xen/riscv: add EMBEDDED_EXTRA_CFLAGS to CFLAGS

2023-03-16 Thread Jan Beulich
On 16.03.2023 14:22, Oleksii Kurochko wrote: > The patch is needed to keep all address of cpu0_boot_stack > PC-relative. > > Pseudoinstruction 'la' can be transformed to 'auipc/addi' or > 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic > or compiler flags. > > Right now, 'la' t

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Alex Deucher
On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: > > On 16.03.23 14:45, Alex Deucher wrote: > > On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: > >> > >> On 16.03.2023 00:25, Stefano Stabellini wrote: > >>> On Wed, 15 Mar 2023, Jan Beulich wrote: > On 15.03.2023 01:52, Stefano Stabell

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Juergen Gross
On 16.03.23 14:45, Alex Deucher wrote: On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: On 16.03.2023 00:25, Stefano Stabellini wrote: On Wed, 15 Mar 2023, Jan Beulich wrote: On 15.03.2023 01:52, Stefano Stabellini wrote: On Mon, 13 Mar 2023, Jan Beulich wrote: On 12.03.2023 13:01, Huang

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-16 Thread Alex Deucher
On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote: > > On 16.03.2023 00:25, Stefano Stabellini wrote: > > On Wed, 15 Mar 2023, Jan Beulich wrote: > >> On 15.03.2023 01:52, Stefano Stabellini wrote: > >>> On Mon, 13 Mar 2023, Jan Beulich wrote: > On 12.03.2023 13:01, Huang Rui wrote: > > X

Re: [PATCH v2 1/5] x86/paging: fold most HAP and shadow final teardown

2023-03-16 Thread Jan Beulich
On 16.03.2023 14:28, Roger Pau Monné wrote: > On Thu, Mar 16, 2023 at 01:57:45PM +0100, Jan Beulich wrote: >> On 16.03.2023 13:24, Roger Pau Monné wrote: >>> Maybe we want to pull that hap_teardown() out of hap_final_teardown() >> >> That's what I'm doing here. > > Oh, sorry, I've missed that chun

Re: [PATCH] build: omit "source" symlink when building hypervisor in-tree

2023-03-16 Thread Jan Beulich
On 15.03.2023 16:20, Anthony PERARD wrote: > On Wed, Mar 15, 2023 at 03:56:21PM +0100, Jan Beulich wrote: >> This symlink is getting in the way of using e.g. "find" on the xen/ >> subtree, and it isn't really needed when not building out-of-tree: >> the one use that there was can easily be avoided.

Re: [PATCH v2 1/5] x86/paging: fold most HAP and shadow final teardown

2023-03-16 Thread Roger Pau Monné
On Thu, Mar 16, 2023 at 01:57:45PM +0100, Jan Beulich wrote: > On 16.03.2023 13:24, Roger Pau Monné wrote: > > On Mon, Jan 09, 2023 at 02:39:19PM +0100, Jan Beulich wrote: > >> HAP does a few things beyond what's common, which are left there at > >> least for now. Common operations, however, are mo

[PATCH v2 0/2] deal with GOT stuff for RISC-V

2023-03-16 Thread Oleksii Kurochko
The patch series introduces things to deal with GOT stuff whichwas faced during the work on [1]. Initially, the issue was with 'la' pseudo instruction, which transformed to 'aupic/l{w|d} GOT' instead of 'auipc/addi'. The transformation dependson .option {nopic, pic} directive or compiler flags. R

[PATCH v2 2/2] xen/riscv: add explicit check that .got{.plt} is empty

2023-03-16 Thread Oleksii Kurochko
The GOT sections usage should be avoided in the hypervisor so to catch such use cases earlier when GOT things are produced the patch introduces .got and .got.plt sections and adds asserts that they're empty. The sections won't be created until they remain empty otherwise the asserts would cause ea

[PATCH v2 1/2] xen/riscv: add EMBEDDED_EXTRA_CFLAGS to CFLAGS

2023-03-16 Thread Oleksii Kurochko
The patch is needed to keep all address of cpu0_boot_stack PC-relative. Pseudoinstruction 'la' can be transformed to 'auipc/addi' or 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic or compiler flags. Right now, 'la' transforms to 'auipc/l{w|d}', which in case of cpu0_boot_stack

[qemu-mainline test] 179657: regressions - trouble: fail/pass/starved

2023-03-16 Thread osstest service owner
flight 179657 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179657/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518 test-amd64-i386-l

seabios 1.16.2 release tagged (was: Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at). 0x1000 to detect Xen

2023-03-16 Thread Gerd Hoffmann
Hi, > Ok, we have as of today two changes: > > kraxel@sirius ~/projects/seabios (master)# git log --oneline rel-1.16.1.. > ea1b7a073390 xen: require Xen info structure at 0x1000 to detect Xen > 645a64b4911d usb: fix wrong init of keyboard/mouse's if first interface is > not boot protocol

RE: [PATCH] CHANGELOG: Mention xl/libxl SMBIOS support

2023-03-16 Thread Henry Wang
Hi Jason, > -Original Message- > From: Jason Andryuk > Subject: [PATCH] CHANGELOG: Mention xl/libxl SMBIOS support > > Add an entry for the new xl/libxl SMBIOS support. > > Signed-off-by: Jason Andryuk Acked-by: Henry Wang Kind regards, Henry

Re: [PATCH v2 1/5] x86/paging: fold most HAP and shadow final teardown

2023-03-16 Thread Jan Beulich
On 16.03.2023 13:24, Roger Pau Monné wrote: > On Mon, Jan 09, 2023 at 02:39:19PM +0100, Jan Beulich wrote: >> HAP does a few things beyond what's common, which are left there at >> least for now. Common operations, however, are moved to >> paging_final_teardown(), allowing shadow_final_teardown() t

Re: [PATCH v4 0/3] libxl smbios support

2023-03-16 Thread Andrew Cooper
On 16/03/2023 7:53 am, Jan Beulich wrote: > On 06.03.2023 21:40, Jason Andryuk wrote: >> hvm_xs_strings.h specifies xenstore entries which can be used to set or >> override smbios strings. hvmloader has support for reading them, but >> xl/libxl support is not wired up. This patches adds a new xl.

Re: [PATCH v2 3/5] x86/paging: move update_paging_modes() hook

2023-03-16 Thread Roger Pau Monné
On Mon, Jan 09, 2023 at 02:40:50PM +0100, Jan Beulich wrote: > The hook isn't mode dependent, hence it's misplaced in struct > paging_mode. (Or alternatively I see no reason why the alloc_page() and > free_page() hooks don't also live there.) Move it to struct > paging_domain. > > Signed-off-by: J

[PATCH] CHANGELOG: Mention xl/libxl SMBIOS support

2023-03-16 Thread Jason Andryuk
Add an entry for the new xl/libxl SMBIOS support. Signed-off-by: Jason Andryuk --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b116163b62..c978cfd9b6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ The format is based on [Keep

Re: [PATCH v2 2/5] x86/paging: drop set-allocation from final-teardown

2023-03-16 Thread Roger Pau Monné
On Mon, Jan 09, 2023 at 02:39:52PM +0100, Jan Beulich wrote: > The fixes for XSA-410 have arranged for P2M pages being freed by P2M > code to be properly freed directly, rather than being put back on the > paging pool list. Therefore whatever p2m_teardown() may return will no > longer need taking c

Re: [PATCH v4 0/3] libxl smbios support

2023-03-16 Thread Jason Andryuk
On Thu, Mar 16, 2023 at 3:53 AM Jan Beulich wrote: > Is this work something that's worth mentioning in CHANGELOG.md? Sure, I'll add an entry. Thanks, Jason

Re: [XEN PATCH v2] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-16 Thread Tamas K Lengyel
On Wed, Mar 15, 2023 at 2:55 PM Dmitry Isaykin wrote: > > Adds monitor support for I/O instructions. > > Signed-off-by: Dmitry Isaykin > Signed-off-by: Anton Belousov Acked-by: Tamas K Lengyel

Re: [PATCH v2 1/5] x86/paging: fold most HAP and shadow final teardown

2023-03-16 Thread Roger Pau Monné
On Mon, Jan 09, 2023 at 02:39:19PM +0100, Jan Beulich wrote: > HAP does a few things beyond what's common, which are left there at > least for now. Common operations, however, are moved to > paging_final_teardown(), allowing shadow_final_teardown() to go away. > > While moving (and hence generaliz

[libvirt test] 179665: regressions - trouble: blocked/fail/pass/starved

2023-03-16 Thread osstest service owner
flight 179665 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/179665/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 179640 build-arm64-pvops

Re: [PATCH 5/7] tools: Use -s for python shebangs

2023-03-16 Thread Anthony PERARD
On Tue, Mar 14, 2023 at 02:50:48PM +, Andrew Cooper wrote: > On 14/03/2023 2:15 pm, Andrew Cooper wrote: > > diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile > > index 29ad0513212f..04b3995cc0f6 100644 > > --- a/tools/pygrub/Makefile > > +++ b/tools/pygrub/Makefile > > @@ -7,7 +7,7 @@

[PATCH v2] vpci/msix: handle accesses adjacent to the MSI-X table

2023-03-16 Thread Roger Pau Monne
The handling of the MSI-X table accesses by Xen requires that any pages part of the MSI-X related tables are not mapped into the domain physmap. As a result, any device registers in the same pages as the start or the end of the MSIX or PBA tables is not currently accessible, as the accesses are ju

Re: [PATCH 2/7] tools/misc: Drop xencons

2023-03-16 Thread Andrew Cooper
On 16/03/2023 11:33 am, Anthony PERARD wrote: > On Tue, Mar 14, 2023 at 02:15:15PM +, Andrew Cooper wrote: >> This is a python script which has it's shebang modified by be python3, but >> was never converted to be python3 compatible. > Not quite, that's the original shebang ;-) What I meant wa

Re: [PATCH] move {,vcpu_}show_execution_state() declarations to common header

2023-03-16 Thread Andrew Cooper
On 16/03/2023 11:55 am, Jan Beulich wrote: > These are used from common code, so their signatures should be > consistent across architectures. This is achieved / guaranteed easiest > when their declarations are in a common header. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > --- > T

[PATCH] move {,vcpu_}show_execution_state() declarations to common header

2023-03-16 Thread Jan Beulich
These are used from common code, so their signatures should be consistent across architectures. This is achieved / guaranteed easiest when their declarations are in a common header. Signed-off-by: Jan Beulich --- There's no really good header to put the decls, imo; I wanted to avoid the already o

Re: [PATCH 4/7] tools/pygrub: Factor out common setup.py parts

2023-03-16 Thread Anthony PERARD
On Tue, Mar 14, 2023 at 02:15:17PM +, Andrew Cooper wrote: > ... to mirror the tools/python side in c/s 2b8314a3c354. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 3/7] tools: Delete trailing whitespace in python scripts

2023-03-16 Thread Anthony PERARD
On Tue, Mar 14, 2023 at 02:15:16PM +, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

  1   2   >