On 16/03/2023 11:55 am, Jan Beulich wrote: > These are used from common code, so their signatures should be > consistent across architectures. This is achieved / guaranteed easiest > when their declarations are in a common header. > > Signed-off-by: Jan Beulich <jbeul...@suse.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > There's no really good header to put the decls, imo; I wanted to avoid > the already overcrowded sched.h. Yeah - lets please not make sched any worse than it already is. I can't suggest a better location than kernel.h, but I certainly would like something else if one were to be found. > show_execution_state_nonconst(), being > there solely for dump_execution_state(), could of course live in the > upcoming xen/bug.h ... > > Is there a reason that Arm (still) expands dump_execution_state() to > WARN()? Without that moving x86's show_execution_state_nonconst() > definition to common code would also make sense (it could be done > anyway, but then at the expense of introducing dead code to Arm), > perhaps (see also above) into the upcoming common/bug.c. That sounds like something that should be fixed up...
