Re: [PATCH] flask: label-pci: Allow specifying optional irq label

2023-03-13 Thread Jan Beulich
On 13.03.2023 22:11, dpsmith.dev wrote: > On 3/13/23 15:14, Jason Andryuk wrote: >> On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith >> wrote: >>> On 3/13/23 13:50, Jason Andryuk wrote:    usage(argCnt, argv); + if (argCnt == 4) { + pirq_label = argv[3];

Re: Aw: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Jan Beulich
On 14.03.2023 02:15, Denis wrote: > On 13.03.2023 10:36, Jan wrote >> On 10.03.2023 21:50, Denis wrote: >>> Should I test something else? >> >> ... there was no request for any further testing here, for the moment. > > ah...sorry, going by "Would be nice to have this confirmed forthe system > in

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-13 Thread Michael S. Tsirkin
On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the > xenfv machine when the guest is configured for igd-passthru. > > A desired extension

Re: [PATCH] Drop ELF notes from non-EFI binary too

2023-03-13 Thread Jan Beulich
On 14.03.2023 02:46, Marek Marczykowski-Górecki wrote: > On Mon, Feb 27, 2023 at 11:28:28AM +0100, Jan Beulich wrote: >> On 26.02.2023 00:56, Marek Marczykowski-Górecki wrote: >>> The ELF is repacked from from 64bit to 32bit. With CET-related notes, >>> which use 64bit fields, this results in 32bit

[ovmf test] 179613: all pass - PUSHED

2023-03-13 Thread osstest service owner
flight 179613 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179613/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a1386bb252066262c0b6664af9a6143306d88512 baseline version: ovmf e4c1d8d2317984bd9cb44

[PATCH v2 0/2] pci: slot_reserved_mask improvements

2023-03-13 Thread Chuck Zmudzinski
This patch series consists of two patches. The first provides accessor functions in pci.h to avoid direct access of slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h. No functional change is intended with this patch. The second patch allows a pci bus to be configur

[PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-13 Thread Chuck Zmudzinski
Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the xenfv machine when the guest is configured for igd-passthru. A desired extension to that commit is to allow use of the reserved slot if the administrator ma

[PATCH v2 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-13 Thread Chuck Zmudzinski
This patch provides accessor functions as replacements for direct access to slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h which advises that data structures for PCIBus should not be directly accessed but instead be accessed using accessor functions in pci.h. Th

[linux-5.4 test] 179598: tolerable trouble: fail/pass/starved - PUSHED

2023-03-13 Thread osstest service owner
flight 179598 linux-5.4 real [real] flight 179612 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/179598/ http://logs.test-lab.xenproject.org/osstest/logs/179612/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386

[ovmf test] 179610: all pass - PUSHED

2023-03-13 Thread osstest service owner
flight 179610 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179610/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e4c1d8d2317984bd9cb447eba916956841063ec4 baseline version: ovmf d2bfe289668e32940cca5

RE: [PATCH] x86/altp2m: help gcc13 to avoid it emitting a warning

2023-03-13 Thread Tian, Kevin
> From: Jan Beulich > Sent: Friday, March 3, 2023 3:32 PM > > Switches of altp2m-s always expect a valid altp2m to be in place (and > indeed altp2m_vcpu_initialise() sets the active one to be at index 0). > The compiler, however, cannot know that, and hence it cannot eliminate > p2m_get_altp2m()'

RE: [PATCH v2] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device

2023-03-13 Thread Tian, Kevin
> From: Marek Marczykowski-Górecki > Sent: Tuesday, March 14, 2023 9:32 AM > > If the scope for IGD's IOMMU contains additional device that doesn't > actually exist, iommu=no-igfx would not disable that IOMMU. In this > particular case (Thinkpad x230) it included > 00:02.1, but there is no such d

RE: [PATCH] VT-d: constrain IGD check

2023-03-13 Thread Tian, Kevin
> From: Jan Beulich > Sent: Tuesday, February 28, 2023 5:52 PM > > Marking a DRHD as controlling an IGD isn't very sensible without > checking that at the very least it's a graphics device that lives at > :00:02.0. Re-use the reading of the class-code to control both the > clearing of "gfx_on

Re: [PATCH] Drop ELF notes from non-EFI binary too

2023-03-13 Thread Marek Marczykowski-Górecki
On Mon, Feb 27, 2023 at 11:28:28AM +0100, Jan Beulich wrote: > On 26.02.2023 00:56, Marek Marczykowski-Górecki wrote: > > The ELF is repacked from from 64bit to 32bit. With CET-related notes, > > which use 64bit fields, this results in 32bit binary with corrupted > > notes. Drop them all (except bu

[PATCH v2] IOMMU/VT-d: Fix iommu=no-igfx if the IOMMU scope contains phantom device

2023-03-13 Thread Marek Marczykowski-Górecki
If the scope for IGD's IOMMU contains additional device that doesn't actually exist, iommu=no-igfx would not disable that IOMMU. In this particular case (Thinkpad x230) it included 00:02.1, but there is no such device on this platform. Consider only existing devices for "gfx only" check. Fixes: 2d

Aw: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Denis
On 13.03.2023 12:54, Jan Beulich wrote: > On 13.03.2023 12:43, Andrew Cooper wrote: > > On 13/03/2023 9:36 am, Jan Beulich wrote: > >> On 10.03.2023 21:50, Denis wrote: > >>> On 10.03.2023 09:51, Jan Beulich wrote: > On 09.03.2023 21:37, Andrew Cooper wrote: > > On 09/03/2023 7:34 pm, tach

Aw: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Denis
On 13.03.2023 10:36, Jan wrote > On 10.03.2023 21:50, Denis wrote: > > On 10.03.2023 09:51, Jan Beulich wrote: > >> On 09.03.2023 21:37, Andrew Cooper wrote: > >>> On 09/03/2023 7:34 pm, tachyon_...@web.de wrote: > A short snippet of what I see when invoking "xl dmesg": >   > (XEN) N

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-13 Thread Jason Andryuk
Hi, David, On Mon, Mar 13, 2023 at 4:45 AM David Woodhouse wrote: > > On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote: > > > > This breaks dm_restrict=1 since the xs_open is not allowed by the > > time > > this is called. There are other evtchn errors before this as well: > > # cat /var/l

[qemu-mainline test] 179596: regressions - trouble: fail/pass/starved

2023-03-13 Thread osstest service owner
flight 179596 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179596/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518 test-amd64-i386-l

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

2023-03-13 Thread dpsmith.dev
On 3/13/23 15:14, Jason Andryuk wrote: On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith wrote: On 3/13/23 13:50, Jason Andryuk wrote: usage(argCnt, argv); + if (argCnt == 4) { + pirq_label = argv[3]; + } else { + pirq_label = argv[2]; + } + style ni

[PATCH] libxl: Fix libxl__device_pci_reset error messages

2023-03-13 Thread Jason Andryuk
Don't use the LOG*D macros. They expect a domid, but "domain" here is the PCI domain. Hence it is inappropriate for this use. Make the write error messages uniform with LOGE. errno has the interesting information while rc is just -1. Drop printing rc and use LOGE to print errno as text. The i

[linux-linus test] 179593: regressions - trouble: fail/pass/starved

2023-03-13 Thread osstest service owner
flight 179593 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179593/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

2023-03-13 Thread Jason Andryuk
On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith wrote: > On 3/13/23 13:50, Jason Andryuk wrote: > > usage(argCnt, argv); > > > > + if (argCnt == 4) { > > + pirq_label = argv[3]; > > + } else { > > + pirq_label = argv[2]; > > + } > > + > > style nit: space

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

2023-03-13 Thread Daniel P. Smith
On 3/13/23 13:50, Jason Andryuk wrote: IRQs can be shared between devices, so using the same label as the PCI device can create conflicts where the IRQ is labeled with one of the device labels preventing assignment of the second device to the second domain. Add the ability to specify an irq labe

[PATCH] xen/cpufreq: Remove

2023-03-13 Thread Jason Andryuk
The header is unneeded - there are no uses of BUG() or WARN() in these cpufreq files. Remove the include. It is still include transitively from xen/lib.h. Signed-off-by: Jason Andryuk --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 1 - xen/drivers/cpufreq/cpufreq.c | 1 - 2 files changed, 2 d

[PATCH] flask: label-pci: Allow specifying optional irq label

2023-03-13 Thread Jason Andryuk
IRQs can be shared between devices, so using the same label as the PCI device can create conflicts where the IRQ is labeled with one of the device labels preventing assignment of the second device to the second domain. Add the ability to specify an irq label distinct from the PCI device, so a shar

[xen-unstable-smoke test] 179601: tolerable trouble: pass/starved - PUSHED

2023-03-13 Thread osstest service owner
flight 179601 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179601/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] xen/grants: repurpose command line max options

2023-03-13 Thread Jan Beulich
On 13.03.2023 13:16, Roger Pau Monne wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1232,9 +1232,8 @@ The usage of gnttab v2 is not security supported on ARM > platforms. > > > Can be modified at runtime > > -Specify the maximum number of fram

Re: [PATCH v4 0/3] libxl smbios support

2023-03-13 Thread George Dunlap
On Mon, Mar 6, 2023 at 8:40 PM Jason Andryuk wrote: > hvm_xs_strings.h specifies xenstore entries which can be used to set or > override smbios strings. hvmloader has support for reading them, but > xl/libxl support is not wired up. This patches adds a new xl.cfg option > and libxl support to w

Re: [PATCH v2 3/3] tools/xen-ucode: print information about currently loaded ucode

2023-03-13 Thread Jan Beulich
On 01.03.2023 19:01, Sergey Dyasli wrote: > On Wed, Mar 1, 2023 at 11:31 AM Jan Beulich wrote: >> >> On 28.02.2023 18:39, Sergey Dyasli wrote: >>> Add an option to xen-ucode tool to print the currently loaded ucode >>> version and also print it during usage info. Print CPU signature and >>> proce

Re: [PATCH v7 1/5] xen: introduce CONFIG_GENERIC_BUG_FRAME

2023-03-13 Thread Jan Beulich
On 09.03.2023 14:33, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/common/bug.c > @@ -0,0 +1,107 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +/* > + * Returns a negative value in case of an error otherwise > + * BUGFRAME

Re: [XEN PATCH] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-13 Thread Jan Beulich
On 11.03.2023 15:50, Tamas K Lengyel wrote: > On Fri, Mar 10, 2023 at 10:57 PM Dmitry Isaykin >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -4579,6 +4579,8 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >> uint16_t port = (exit_qualification >>

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 10:22:24AM +0800, Dmitry Osipenko wrote: > On 3/12/23 20:51, Dmitry Osipenko wrote: > > On 3/12/23 12:22, Huang Rui wrote: > >> From: Antonio Caggiano > >> > >> Request Venus when initializing VirGL. > >> > >> Signed-off-by: Antonio Caggiano > >> --- > >> hw/display/virti

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote: > On 3/12/23 12:22, Huang Rui wrote: > > From: Antonio Caggiano > > > > Request Venus when initializing VirGL. > > > > Signed-off-by: Antonio Caggiano > > --- > > hw/display/virtio-gpu-virgl.c | 4 > > 1 file changed, 4 inse

Re: S0ix support in Xen

2023-03-13 Thread Simon Gaiser
Simon Gaiser: [...] > On my test system (NUC11TNHi5, Tiger Lake) I haven't seen it reaching > cstates lower PC7 with Xen (so it can of course not reach S0ix > residency). With plain Linux I got it working on that system although it > was rather fiddly and probably something is fishy on the firmware

Re: [PATCH] x86/PVH: obtain VGA console info in Dom0

2023-03-13 Thread Juergen Gross
On 13.03.23 15:45, Jan Beulich wrote: A new platform-op was added to Xen to allow obtaining the same VGA console information PV Dom0 is handed. Invoke the new function and have the output data processed by xen_init_vga(). Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen Ope

[PATCH] x86/PVH: obtain VGA console info in Dom0

2023-03-13 Thread Jan Beulich
A new platform-op was added to Xen to allow obtaining the same VGA console information PV Dom0 is handed. Invoke the new function and have the output data processed by xen_init_vga(). Signed-off-by: Jan Beulich --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -45,6 +45,6 @@ obj-$(CONFI

Ping: [PATCH] VT-d: constrain IGD check

2023-03-13 Thread Jan Beulich
On 28.02.2023 10:51, Jan Beulich wrote: > Marking a DRHD as controlling an IGD isn't very sensible without > checking that at the very least it's a graphics device that lives at > :00:02.0. Re-use the reading of the class-code to control both the > clearing of "gfx_only" and the setting of "igd

Re: [PATCH v2] bunzip: work around gcc13 warning

2023-03-13 Thread Andrew Cooper
On 13/03/2023 2:10 pm, Jan Beulich wrote: > While provable that length[0] is always initialized (because symCount > cannot be zero), upcoming gcc13 fails to recognize this and warns about > the unconditional use of the value immediately following the loop. > > See also https://gcc.gnu.org/bugzilla/

[PATCH v2] bunzip: work around gcc13 warning

2023-03-13 Thread Jan Beulich
While provable that length[0] is always initialized (because symCount cannot be zero), upcoming gcc13 fails to recognize this and warns about the unconditional use of the value immediately following the loop. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106511. Reported-by: Martin Liška

Re: [PATCH v3 2/2] arch/arm: time: Add support for parsing interrupts by names

2023-03-13 Thread Michal Orzel
On 13/03/2023 14:08, Andrei Cherechesu (OSS) wrote: > > > From: Andrei Cherechesu > > Added support for parsing the ARM generic timer interrupts DT > node by the "interrupt-names" property, if it is available. > > If not available, the usual parsing based on the expected > IRQ order is perfo

Re: [PATCH] x86/platform: make XENPF_get_dom0_console actually usable

2023-03-13 Thread Roger Pau Monné
On Mon, Feb 13, 2023 at 03:51:50PM +0100, Jan Beulich wrote: > struct dom0_vga_console_info has been extended in the past, and it may > be extended again. The use in PV Dom0's start info already covers for > that by supplying the size of the provided data. For the recently > introduced platform-op

[PATCH] xen/events: Add wakeup support to xen-pirq

2023-03-13 Thread Simon Gaiser
This allows entering and exiting s2idle. Actual S0ix residency is another topic [1]. Without this the ACPI code currently ignores the error enable_irq_wake() returns when being used on a xen-pirq and the system goes to idle for ever since the wakeup IRQ doesn't gets enabled. With [2] the error is

Re: [PATCH v3 2/2] arch/arm: time: Add support for parsing interrupts by names

2023-03-13 Thread Bertrand Marquis
HI Andrei, > On 13 Mar 2023, at 14:08, Andrei Cherechesu (OSS) > wrote: > > From: Andrei Cherechesu > > Added support for parsing the ARM generic timer interrupts DT > node by the "interrupt-names" property, if it is available. > > If not available, the usual parsing based on the expected >

Re: [XEN PATCH] x86/monitor: Add new monitor event to catch I/O instructions

2023-03-13 Thread Andrew Cooper
On 11/03/2023 3:57 am, Dmitry Isaykin wrote: > Adds monitor support for I/O instructions. > > Signed-off-by: Dmitry Isaykin > Signed-off-by: Anton Belousov Thankyou for the patch.  A couple of questions. Right now, you monitor all IO ports that end up in a vmexit.  But this is already subject t

Re: [PATCH v4] core-parking: fix build with gcc12 and NR_CPUS=1

2023-03-13 Thread Andrew Cooper
On 28/02/2023 12:34 pm, Jan Beulich wrote: > Gcc12 takes issue with core_parking_remove()'s > > for ( ; i < cur_idle_nums; ++i ) > core_parking_cpunum[i] = core_parking_cpunum[i + 1]; > > complaining that the right hand side array access is past the bounds of > 1. Clearly the compiler c

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Jan Beulich
On 13.03.2023 12:43, Andrew Cooper wrote: > On 13/03/2023 9:36 am, Jan Beulich wrote: >> On 10.03.2023 21:50, Denis wrote: >>> On 10.03.2023 09:51, Jan Beulich wrote: On 09.03.2023 21:37, Andrew Cooper wrote: > On 09/03/2023 7:34 pm, tachyon_...@web.de wrote: >> A short snippet of what

[PATCH] xen/grants: repurpose command line max options

2023-03-13 Thread Roger Pau Monne
Slightly change the meaning of the command line gnttab_max_{maptrack_,}frames: do not use them as upper bounds for the passed values at domain creation, instead just use them as defaults in the absence of any provided value. It's not very useful for the options to be used both as defaults and as c

Re: [PATCH] x86/altp2m: help gcc13 to avoid it emitting a warning

2023-03-13 Thread Andrew Cooper
On 03/03/2023 7:31 am, Jan Beulich wrote: > Switches of altp2m-s always expect a valid altp2m to be in place (and > indeed altp2m_vcpu_initialise() sets the active one to be at index 0). > The compiler, however, cannot know that, and hence it cannot eliminate > p2m_get_altp2m()'s case of returnin (

[xen-unstable test] 179591: tolerable trouble: fail/pass/starved

2023-03-13 Thread osstest service owner
flight 179591 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179591/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 179571 pass in 179591 test-amd64-i386-xl-qemuu-debianh

[PATCH v3 0/2] Fix ARM Generic Timer interrupt parsing

2023-03-13 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu This 2-patch series fixes the parsing of the ARM Generic Timer interrupts from the device tree. If the generic timer interrupts order in the DT was different than the expected order in Xen code, these interrupts would no longer be correctly parsed and registered by Xen, a

[PATCH v3 1/2] arch/arm: irq: Add platform_get_irq_byname() implementation

2023-03-13 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu Moved implementation for the function which parses the IRQs of a DT node by the "interrupt-names" property from the SMMU-v3 driver to the IRQ core code and made it non-static to be used as helper. Also changed it to receive a "struct dt_device_node*" as parameter, like it

[PATCH v3 2/2] arch/arm: time: Add support for parsing interrupts by names

2023-03-13 Thread Andrei Cherechesu (OSS)
From: Andrei Cherechesu Added support for parsing the ARM generic timer interrupts DT node by the "interrupt-names" property, if it is available. If not available, the usual parsing based on the expected IRQ order is performed. Also treated returning 0 as an error case for the platform_get_irq(

Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present

2023-03-13 Thread Andrew Cooper
On 13/03/2023 12:21 pm, Roger Pau Monné wrote: > On Mon, Mar 13, 2023 at 11:55:56AM +, Andrew Cooper wrote: >> On 12/03/2023 7:54 am, Huang Rui wrote: >>> From: Roger Pau Monne >>> >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing

Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present

2023-03-13 Thread Roger Pau Monné
On Mon, Mar 13, 2023 at 11:55:56AM +, Andrew Cooper wrote: > On 12/03/2023 7:54 am, Huang Rui wrote: > > From: Roger Pau Monne > > > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > > from the firmware instead of doing it on the PCI ROM on the physical > > device. > >

[PATCH v2] tests/vpci: install test

2023-03-13 Thread Roger Pau Monne
Introduce an install target, like it's used by other tests. This allows running the test on the installed systems, which is easier than running it during the build phase when dealing with automated testing. Strictly speaking the vpci test doesn't require to be run on a Xen host currently, but that

Re: [RFC XEN PATCH 1/6] x86/pvh: report ACPI VFCT table to dom0 if present

2023-03-13 Thread Andrew Cooper
On 12/03/2023 7:54 am, Huang Rui wrote: > From: Roger Pau Monne > > The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image > from the firmware instead of doing it on the PCI ROM on the physical > device. > > As such, this needs to be available for PVH dom0 to access, or else > the G

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Andrew Cooper
On 13/03/2023 9:36 am, Jan Beulich wrote: > On 10.03.2023 21:50, Denis wrote: >> On 10.03.2023 09:51, Jan Beulich wrote: >>> On 09.03.2023 21:37, Andrew Cooper wrote: On 09/03/2023 7:34 pm, tachyon_...@web.de wrote: > A short snippet of what I see when invoking "xl dmesg": >   > (X

Re: [PATCH] tests/vpci: install test

2023-03-13 Thread Jan Beulich
On 13.03.2023 12:15, Roger Pau Monné wrote: > On Mon, Mar 13, 2023 at 11:43:43AM +0100, Jan Beulich wrote: >> On 13.03.2023 11:31, Roger Pau Monné wrote: >>> On Fri, Mar 10, 2023 at 03:32:41PM +0100, Jan Beulich wrote: On 10.03.2023 14:38, Roger Pau Monné wrote: > On Fri, Mar 10, 2023 at 1

[PATCH v2 2/2] x86/spec-ctrl: Enumerations for DDP controls

2023-03-13 Thread Andrew Cooper
https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/technical-documentation/data-dependent-prefetcher.html We should offer DDP-CTRL to guests, but I'm not sure when it is appearing in hardware, and it's not massively urgent - the DDP behaviour is mostly

Re: [XEN PATCH v7 19/20] xen/arm: ffa: add support to reclaim shared memory

2023-03-13 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Adds support to reclaim memory previously shared with FFA_MEM_SHARE. > > Adds a check that the SP supports the needed FF-A feature > FFA_MEM_RECLAIM. > > Signed-off-by: Jens Wiklander Reviewed-by: Bertrand Marquis Just one thing

Re: [PATCH] tests/vpci: install test

2023-03-13 Thread Roger Pau Monné
On Mon, Mar 13, 2023 at 11:43:43AM +0100, Jan Beulich wrote: > On 13.03.2023 11:31, Roger Pau Monné wrote: > > On Fri, Mar 10, 2023 at 03:32:41PM +0100, Jan Beulich wrote: > >> On 10.03.2023 14:38, Roger Pau Monné wrote: > >>> On Fri, Mar 10, 2023 at 12:06:29PM +0100, Jan Beulich wrote: > On 0

Re: [PATCH 2/2] x86/spec-ctrl: Enumerations for DDP controls

2023-03-13 Thread Andrew Cooper
On 13/03/2023 9:24 am, Jan Beulich wrote: > On 13.03.2023 10:21, Jan Beulich wrote: >> On 10.03.2023 17:02, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/msr-index.h >>> +++ b/xen/arch/x86/include/asm/msr-index.h >>> @@ -41,6 +41,7 @@ >>> #define SPEC_CTRL_RRSBA_DIS_U (_AC(

Re: [PATCH] tests/vpci: install test

2023-03-13 Thread Jan Beulich
On 13.03.2023 11:31, Roger Pau Monné wrote: > On Fri, Mar 10, 2023 at 03:32:41PM +0100, Jan Beulich wrote: >> On 10.03.2023 14:38, Roger Pau Monné wrote: >>> On Fri, Mar 10, 2023 at 12:06:29PM +0100, Jan Beulich wrote: On 09.03.2023 17:58, Roger Pau Monne wrote: > Introduce an install targ

Re: [PATCH] tests/vpci: install test

2023-03-13 Thread Roger Pau Monné
On Fri, Mar 10, 2023 at 03:32:41PM +0100, Jan Beulich wrote: > On 10.03.2023 14:38, Roger Pau Monné wrote: > > On Fri, Mar 10, 2023 at 12:06:29PM +0100, Jan Beulich wrote: > >> On 09.03.2023 17:58, Roger Pau Monne wrote: > >>> Introduce an install target, like it's used by other tests. This > >>>

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

2023-03-13 Thread Jan Beulich
On 10.03.2023 21:50, Denis wrote: > On 10.03.2023 09:51, Jan Beulich wrote: >> On 09.03.2023 21:37, Andrew Cooper wrote: >>> On 09/03/2023 7:34 pm, tachyon_...@web.de wrote: A short snippet of what I see when invoking "xl dmesg":   (XEN) No southbridge IO-APIC found in IVRS table >>>

Re: [PATCH 2/2] x86/spec-ctrl: Enumerations for DDP controls

2023-03-13 Thread Jan Beulich
On 13.03.2023 10:21, Jan Beulich wrote: > On 10.03.2023 17:02, Andrew Cooper wrote: >> --- a/xen/arch/x86/include/asm/msr-index.h >> +++ b/xen/arch/x86/include/asm/msr-index.h >> @@ -41,6 +41,7 @@ >> #define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5) >> #define SPEC_CTRL_RRSBA_DIS_S

Re: [PATCH 2/2] x86/spec-ctrl: Enumerations for DDP controls

2023-03-13 Thread Jan Beulich
On 10.03.2023 17:02, Andrew Cooper wrote: > https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/technical-documentation/data-dependent-prefetcher.html > > Signed-off-by: Andrew Cooper In the cover letter you mention that we should enable use of this by

Re: [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature

2023-03-13 Thread Philippe Mathieu-Daudé
On 12/3/23 10:22, Huang Rui wrote: From: Antonio Caggiano Create virgl renderer context with flags using context_id when valid. The feature can be enabled via the context_init config option. A warning message will be emitted and the feature will not be used when linking with virglrenderer versi

Re: [PATCH 1/2] x86/spec-ctrl: Add BHI controls to userspace components

2023-03-13 Thread Jan Beulich
On 10.03.2023 17:02, Andrew Cooper wrote: > This was an oversight when adding the Xen parts. > > Fixes: cea9ae062295 ("x86/spec-ctrl: Enumeration for new Intel BHI controls") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [RFC QEMU PATCH 01/18] virtio: Add shared memory capability

2023-03-13 Thread Philippe Mathieu-Daudé
On 12/3/23 10:22, Huang Rui wrote: From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-speci

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-13 Thread Jan Beulich
On 12.03.2023 13:01, Huang Rui wrote: > Xen PVH is the paravirtualized mode and takes advantage of hardware > virtualization support when possible. It will using the hardware IOMMU > support instead of xen-swiotlb, so disable swiotlb if current domain is > Xen PVH. But the kernel has no way (yet)

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 03:26:09PM +0800, Koenig, Christian wrote: > Am 13.03.23 um 08:23 schrieb Christian König: > > > > > > Am 12.03.23 um 08:54 schrieb Huang Rui: > >> From: Chen Jiqian > >> > >> When dom0 is PVH and we want to passthrough gpu to guest, > >> we should allow BAR writes even thr

Re: [PATCH] xen: fix dm_restrict startup

2023-03-13 Thread David Woodhouse
On Sun, 2023-03-12 at 19:41 -0400, Jason Andryuk wrote: > QEMU is failing to signal it start when launched by libxl with > dm_restrict=1.  When xenstore_record_dm_state() is called, the > restrictions prevent xs_open() from succeeding.  QEMU can't write > running to the xenstore, and libxl fails th

Re: [PATCH 0/3] x86: Minor improvements to xen-cpuid

2023-03-13 Thread Jan Beulich
On 10.03.2023 21:37, Andrew Cooper wrote: > All to make it easier to do CPUID development work (which is fairness is > mostly me). > > Andrew Cooper (3): > tools/xen-cpuid: Support dash as a bitmap delimiter > tools/xen-cpuid: Rework the handling of dynamic featuresets > x86/sysctl: Retrofit

Re: [XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory

2023-03-13 Thread Bertrand Marquis
Hi Jens, > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > Adds support for a guest to share memory with an SP using FFA_MEM_SHARE > and FFA_MEM_RECLAIM. Only small memory regions can be shared using a > single call to FFA_MEM_SHARE are supported. This sentence needs a bit of rephrasing and

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Jan Beulich
On 13.03.2023 08:26, Christian König wrote: > Am 13.03.23 um 08:23 schrieb Christian König: >> Am 12.03.23 um 08:54 schrieb Huang Rui: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -392,7 +392,7 @@ static void cf_check bar_write( >>>    * Xen only cares whether

Re: [PATCH 3/3] x86/sysctl: Retrofit XEN_SYSCTL_cpu_featureset_{pv,hvm}_max

2023-03-13 Thread Christian Lindig
> On 10 Mar 2023, at 20:37, Andrew Cooper wrote: > > Featuresets are supposed to be disappearing when the CPU policy infrastructure > is complete, but that has taken longer than expected, and isn't going to be > complete imminently either. > > In the meantime, Xen does have proper default/max

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-13 Thread David Woodhouse
On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote: > > This breaks dm_restrict=1 since the xs_open is not allowed by the > time > this is called.  There are other evtchn errors before this as well: > # cat /var/log/xen/qemu-dm-debian.log > char device redirected to /dev/pts/8 (label serial0)

Re: [PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-off-by: Alexande

[PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Alexander Bulekov
This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-off-by: Alexander Bulekov --- hw/9pfs/xen-9p-backend.c

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Christian König
Am 13.03.23 um 08:23 schrieb Christian König: Am 12.03.23 um 08:54 schrieb Huang Rui: From: Chen Jiqian When dom0 is PVH and we want to passthrough gpu to guest, we should allow BAR writes even through BAR is mapped. If not, the value of BARs are not initialized when guest firstly start. Si

Re: [RFC XEN PATCH 0/6] Introduce VirtIO GPU and Passthrough GPU support on Xen PVH dom0

2023-03-13 Thread Christian König
Hi Ray, one nit comment on the style, apart from that looks technical correct. But I'm *really* not and expert on all that stuff. Regards, Christian. Am 12.03.23 um 08:54 schrieb Huang Rui: Hi all, In graphic world, the 3D applications/games are runing based on open graphic libraries such as

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

2023-03-13 Thread Christian König
Am 12.03.23 um 08:54 schrieb Huang Rui: From: Chen Jiqian When dom0 is PVH and we want to passthrough gpu to guest, we should allow BAR writes even through BAR is mapped. If not, the value of BARs are not initialized when guest firstly start. Signed-off-by: Chen Jiqian Signed-off-by: Huang

Re: [BUG] x2apic broken with current AMD hardware

2023-03-13 Thread Jan Beulich
On 11.03.2023 01:09, Elliott Mitchell wrote: > On Thu, Mar 09, 2023 at 10:03:23AM +0100, Jan Beulich wrote: >> >> In any event you will want to collect a serial log at maximum verbosity. >> It would also be of interest to know whether turning off the IOMMU avoids >> the issue as well (on the assump