On 13/03/2023 9:24 am, Jan Beulich wrote: > On 13.03.2023 10:21, Jan Beulich wrote: >> On 10.03.2023 17:02, Andrew Cooper wrote: >>> --- a/xen/arch/x86/include/asm/msr-index.h >>> +++ b/xen/arch/x86/include/asm/msr-index.h >>> @@ -41,6 +41,7 @@ >>> #define SPEC_CTRL_RRSBA_DIS_U (_AC(1, ULL) << 5) >>> #define SPEC_CTRL_RRSBA_DIS_S (_AC(1, ULL) << 6) >>> #define SPEC_CTRL_PSFD (_AC(1, ULL) << 7) >>> +#define SPEC_CTRL_DDPU_D (_AC(1, ULL) << 8) >> The doc calls this DDPD_U - typo, or do you happen to know that the doc has >> it the wrong way round (and is going to be fixed)? > Actually ... > >>> --- a/xen/include/public/arch-x86/cpufeatureset.h >>> +++ b/xen/include/public/arch-x86/cpufeatureset.h >>> @@ -295,6 +295,7 @@ XEN_CPUFEATURE(INTEL_PSFD, 13*32+ 0) /*A >>> MSR_SPEC_CTRL.PSFD */ >>> XEN_CPUFEATURE(IPRED_CTRL, 13*32+ 1) /* >>> MSR_SPEC_CTRL.IPRED_DIS_* */ >>> XEN_CPUFEATURE(RRSBA_CTRL, 13*32+ 2) /* >>> MSR_SPEC_CTRL.RRSBA_DIS_* */ >>> XEN_CPUFEATURE(BHI_CTRL, 13*32+ 4) /* MSR_SPEC_CTRL.BHI_DIS_S >>> */ >>> +XEN_CPUFEATURE(DDP_CTRL, 13*32+ 3) /* MSR_SPEC_CTRL.DDPU_U */ > ... here you have even two 'U' in the comment, when one of them wants to > be 'D'.
Yeah, I've messed this up. It's supposed to be consistent with the public document (which I ought to have checked was consistent with the non-public reference that I was using...) I'll fix up and repost. ~Andrew
