Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped

2022-11-07 Thread Juergen Gross
On 07.11.22 19:33, Julien Grall wrote: On 07/11/2022 07:54, Juergen Gross wrote: On 06.11.22 22:18, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: When a domain has been recognized to have stopped, remove all its registered watches. This avoids sending watch event

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-07 Thread Michal Orzel
Hi Julien, On 07/11/2022 19:06, Julien Grall wrote: > > > Hi Ayan, > > On 07/11/2022 12:49, Ayan Kumar Halder wrote: >> >> On 07/11/2022 10:44, Julien Grall wrote: >>> Hi Ayan, >> Hi Julien, >>> >>> On 07/11/2022 10:36, Ayan Kumar Halder wrote: On 06/11/2022 17:54, Julien Grall wrote:

[ovmf test] 174666: all pass - PUSHED

2022-11-07 Thread osstest service owner
flight 174666 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174666/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 50bee4cc121aacc67f40b6c5ee0c71d3879dcc41 baseline version: ovmf 239bcf78053f4581cc346

Re: [PATCH][4.17] kexec: restore hypercall 1st arg's type

2022-11-07 Thread Juergen Gross
On 07.11.22 16:09, Jan Beulich wrote: This reverts a small part of 7e21b25059ed ("xen: harmonize return types of hypercall handlers"). The change from "unsigned long" to "unsigned int" for the native handler function meant that previously invalid values became valid. While perhaps not a significa

[qemu-mainline test] 174662: tolerable FAIL - PUSHED

2022-11-07 Thread osstest service owner
flight 174662 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/174662/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 174651 test-armhf-armhf-libvirt 16 sav

[linux-5.4 test] 174660: regressions - FAIL

2022-11-07 Thread osstest service owner
flight 174660 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 broken in 174655 test-armhf-armhf-libvirt

RE: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU systems

2022-11-07 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年11月7日 3:12 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 03/11] xen/arm: disable EFI boot services for MPU > systems > >

RE: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable

2022-11-07 Thread Penny Zheng
> -Original Message- > From: Julien Grall > Sent: Monday, November 7, 2022 6:38 PM > To: Penny Zheng ; Wei Chen > ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 10/11] xen/arm64: introduce helpers for MP

[linux-linus test] 174659: regressions - FAIL

2022-11-07 Thread osstest service owner
flight 174659 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174659/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 8 xen-boot fail REGR. vs. 173462 test-arm64-arm64-xl

RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build

2022-11-07 Thread Wei Chen
> > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > > index 4fb5c20b13..bd30d3798c 100644 > > > --- a/xen/arch/arm/domain_build.c > > > +++ b/xen/arch/arm/domain_build.c > > > @@ -3418,6 +3418,8 @@ static void __init initrd_

RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build

2022-11-07 Thread Wei Chen
Hi Julien, > -Original Message- > From: Xen-devel On Behalf Of > Julien Grall > Sent: 2022年11月7日 2:55 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > ; Henry Wang > Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap

RE: [PATCH][4.17] kexec: restore hypercall 1st arg's type

2022-11-07 Thread Henry Wang
Hi Jan, Thanks for the patch. > -Original Message- > From: Jan Beulich > Subject: [PATCH][4.17] kexec: restore hypercall 1st arg's type > > This reverts a small part of 7e21b25059ed ("xen: harmonize return types > of hypercall handlers"). The change from "unsigned long" to "unsigned > i

[xen-unstable-smoke test] 174661: tolerable all pass - PUSHED

2022-11-07 Thread osstest service owner
flight 174661 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174661/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-07 Thread Julien Grall
On 07/11/2022 12:56, Jan Beulich wrote: On 07.11.2022 12:53, Luca Fancellu wrote: On 7 Nov 2022, at 11:49, Jan Beulich wrote: On 07.11.2022 11:47, Luca Fancellu wrote: --- a/xen/include/xen/kernel.h +++ b/xen/include/xen/kernel.h @@ -65,24 +65,28 @@ 1;

Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build

2022-11-07 Thread Julien Grall
On 06/11/2022 18:55, Julien Grall wrote: (+ Henry) Hi, On 04/11/2022 10:07, Wei Chen wrote: domain_build use ioremap_wc to map a new non-cacheable virtual s/use/uses/ address for initrd. After Xen copy initrd from this address to guest, this new allocated virtual address has not been un

Re: Xen vs Trenchboot: TXT AP bringup

2022-11-07 Thread Ross Philipson
On 11/3/22 05:29, 'Jan Beulich' via trenchboot-devel wrote: On 27.10.2022 21:37, Andrew Cooper wrote: However, we're also very close to supporting parallel boot.  The serialising point we currently have is __high_start loading %rsp from stack_start, because that's a single pointer adjusted by do

Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction

2022-11-07 Thread Julien Grall
On 07/11/2022 08:34, Juergen Gross wrote: On 06.11.22 23:00, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows to create arbitrary number of nodes. The

Re: [PATCH 06/20] tools/xenstore: remove all watches when a domain has stopped

2022-11-07 Thread Julien Grall
On 07/11/2022 07:54, Juergen Gross wrote: On 06.11.22 22:18, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: When a domain has been recognized to have stopped, remove all its registered watches. This avoids sending watch events to the dead domain when all the nodes

Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains

2022-11-07 Thread Julien Grall
On 07/11/2022 13:44, Carlo Nonato wrote: Hi Julien, Hi Carlo, On Tue, Oct 25, 2022 at 1:15 PM Julien Grall wrote: On 25/10/2022 11:53, Carlo Nonato wrote: Hi Julien, On Fri, Oct 21, 2022 at 8:02 PM Julien Grall wrote: Hi Carlo, On 26/08/2022 13:51, Carlo Nonato wrote: This commit

[ovmf test] 174658: all pass - PUSHED

2022-11-07 Thread osstest service owner
flight 174658 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174658/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 239bcf78053f4581cc3468ab961f9d37e859c7d9 baseline version: ovmf 82e70d9ac0aabf48a0cbd

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-07 Thread Julien Grall
Hi Ayan, On 07/11/2022 12:49, Ayan Kumar Halder wrote: On 07/11/2022 10:44, Julien Grall wrote: Hi Ayan, Hi Julien, On 07/11/2022 10:36, Ayan Kumar Halder wrote: On 06/11/2022 17:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need some clarification. To me the title and the explaina

Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-07 Thread Julien Grall
Hi Ayan, On 07/11/2022 14:00, Ayan Kumar Halder wrote: On 07/11/2022 11:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need one clarification. On 07/11/2022 11:33, Ayan Kumar Halder wrote: On 06/11/2022 18:04, Julien Grall wrote: Hi Ayan, Hi Julien, I need a clarification. In the

Re: [PATCH-for-4.17] tools/hotplug: fix systemd unit dependencies

2022-11-07 Thread Anthony PERARD
On Sun, Nov 06, 2022 at 07:15:17AM +0100, Juergen Gross wrote: > Commit 1283af6465cd ("tools/xenstore: remove XEN_LIB_STORED and > XENSTORED_ROOTDIR") removed the systemd file var-lib-xenstored.mount > without removing dependencies to this file. > > Fixes: 1283af6465cd ("tools/xenstore: remove XEN

[linux-5.4 test] 174655: regressions - trouble: broken/fail/pass

2022-11-07 Thread osstest service owner
flight 174655 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/174655/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-arndale

Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options

2022-11-07 Thread Jan Beulich
On 04.11.2022 17:18, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/viridian/viridian.c > +++ b/xen/arch/x86/hvm/viridian/viridian.c > @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t > leaf, > res->a = CPUID4A_RELAX_TIMER_INT; > if ( viridian_featur

Re: [RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-07 Thread Jan Beulich
On 07.11.2022 11:47, Luca Fancellu wrote: > +Here is an example to add a new justification in false-positive-.json:: With already present in the name, ... > +|{ > +|"version": "1.0", > +|"content": [ > +|{ > +|"id": "SAF-0-false-positive-", > +|"analyser":

[linux-linus test] 174654: regressions - trouble: broken/fail/pass

2022-11-07 Thread osstest service owner
flight 174654 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken test-armhf-armhf-xl-rtds

Re: [linux-linus test] 174539: regressions - FAIL

2022-11-07 Thread Bertrand Marquis
Hi Julien, > On 7 Nov 2022, at 15:58, Julien Grall wrote: > > > > On 03/11/2022 17:43, Bertrand Marquis wrote: >> Hi, > > Hi Bertrand, > >> +Julien and Stefano >>> On 2 Nov 2022, at 09:58, Jan Beulich wrote: >>> >>> On 01.11.2022 08:56, Juergen Gross wrote: On 29.10.22 23:50, osstest

Re: [linux-linus test] 174539: regressions - FAIL

2022-11-07 Thread Julien Grall
On 03/11/2022 17:43, Bertrand Marquis wrote: Hi, Hi Bertrand, +Julien and Stefano On 2 Nov 2022, at 09:58, Jan Beulich wrote: On 01.11.2022 08:56, Juergen Gross wrote: On 29.10.22 23:50, osstest service owner wrote: flight 174539 linux-linus real [real] http://logs.test-lab.xenproje

[PATCH][4.17] kexec: restore hypercall 1st arg's type

2022-11-07 Thread Jan Beulich
This reverts a small part of 7e21b25059ed ("xen: harmonize return types of hypercall handlers"). The change from "unsigned long" to "unsigned int" for the native handler function meant that previously invalid values became valid. While perhaps not a significant issue, strictly speaking that's still

[ovmf test] 174657: all pass - PUSHED

2022-11-07 Thread osstest service owner
flight 174657 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/174657/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 82e70d9ac0aabf48a0cbda3c373e94ef22413e49 baseline version: ovmf 35043a5ec05db6aa86b1b

Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-07 Thread Ayan Kumar Halder
On 07/11/2022 11:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need one clarification. On 07/11/2022 11:33, Ayan Kumar Halder wrote: On 06/11/2022 18:04, Julien Grall wrote: Hi Ayan, Hi Julien, I need a clarification. In the title you are using AArch32 but below you are using...

Re: [PATCH 02/12] xen/arm: add cache coloring initialization for domains

2022-11-07 Thread Carlo Nonato
Hi Julien, On Tue, Oct 25, 2022 at 1:15 PM Julien Grall wrote: > On 25/10/2022 11:53, Carlo Nonato wrote: > > Hi Julien, > > > > On Fri, Oct 21, 2022 at 8:02 PM Julien Grall wrote: > >> > >> Hi Carlo, > >> > >> On 26/08/2022 13:51, Carlo Nonato wrote: > >>> This commit adds array pointers to dom

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-07 Thread Jan Beulich
On 07.11.2022 12:53, Luca Fancellu wrote: >> On 7 Nov 2022, at 11:49, Jan Beulich wrote: >> On 07.11.2022 11:47, Luca Fancellu wrote: >>> --- a/xen/include/xen/kernel.h >>> +++ b/xen/include/xen/kernel.h >>> @@ -65,24 +65,28 @@ >>> 1; \ >>> }) >>> >>> +/* S

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-07 Thread Ayan Kumar Halder
On 07/11/2022 10:44, Julien Grall wrote: Hi Ayan, Hi Julien, On 07/11/2022 10:36, Ayan Kumar Halder wrote: On 06/11/2022 17:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need some clarification. To me the title and the explaination below suggests... On 04/11/2022 16:23, Ayan Kumar

Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-07 Thread Julien Grall
Hi Ayan, On 07/11/2022 11:33, Ayan Kumar Halder wrote: On 06/11/2022 18:04, Julien Grall wrote: Hi Ayan, Hi Julien, I need a clarification. In the title you are using AArch32 but below you are using... On 31/10/2022 15:13, Ayan Kumar Halder wrote: v->arch.vmpidr is assigned to uint64_t

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-07 Thread Luca Fancellu
> On 7 Nov 2022, at 11:49, Jan Beulich wrote: > > On 07.11.2022 11:47, Luca Fancellu wrote: >> --- a/xen/include/xen/kernel.h >> +++ b/xen/include/xen/kernel.h >> @@ -65,24 +65,28 @@ >> 1; \ >> }) >> >> +/* SAF-0-safe R8.6 linker script defined symbol

Re: [RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-07 Thread Jan Beulich
On 07.11.2022 11:47, Luca Fancellu wrote: > --- a/xen/include/xen/kernel.h > +++ b/xen/include/xen/kernel.h > @@ -65,24 +65,28 @@ > 1; \ > }) > > +/* SAF-0-safe R8.6 linker script defined symbols */ > extern char _start[], _end[], start[]; > #define i

Re: [XEN v2 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-07 Thread Ayan Kumar Halder
On 06/11/2022 18:04, Julien Grall wrote: Hi Ayan, Hi Julien, I need a clarification. In the title you are using AArch32 but below you are using... On 31/10/2022 15:13, Ayan Kumar Halder wrote: v->arch.vmpidr is assigned to uint64_t variable. This is to enable left shifts for Aarch32 so

[RFC PATCH 4/4] xen: Justify linker script defined symbols in include/xen/kernel.h

2022-11-07 Thread Luca Fancellu
Eclair and Coverity found violation of the MISRA rule 8.6 for the symbols _start, _end, start, _stext, _etext, _srodata, _erodata, _sinittext, _einittext which are declared in xen/include/xen/kernel.h. All those symbols are defined by the liker script so we can deviate from the rule 8.6 for these c

[RFC PATCH 3/4] tools/misra: fix skipped rule numbers

2022-11-07 Thread Luca Fancellu
Currently the script convert_misra_doc.py is using a loop through range(1,22) to enumerate rules that needs to be skipped, however range function does not include the stop counter in the enumeration ending up into list rules until 21.21 instead of including rule 22. Fix the issue using a dictionar

[RFC PATCH 2/4] xen/Makefile: add analysis-cppcheck and analysis-cppcheck-html

2022-11-07 Thread Luca Fancellu
Change cppcheck invocation method by substituting the Makefile targets cppcheck{-html} with analysis-cppcheck{-html}. Now cppcheck will build Xen while analysing the source files, and it will produce a text output when called with analysis-cppcheck and an additional html output when called with an

[RFC PATCH 1/4] xen/Makefile: add analysis-coverity and analysis-eclair

2022-11-07 Thread Luca Fancellu
Add new targets to makefile, analysis-{coverity,eclair} that will: - Create a tag database using a new tool called xenfusa-gen-tags.py - Get every file with the FuSa tag SAF- in-code comment, create a copy of it as .safparse and substituting the tags with proprietary tool syntax in-code com

[RFC PATCH 0/4] Static analyser finding deviation

2022-11-07 Thread Luca Fancellu
This serie introduces a way to suppress a static analyser finding providing a proper justification for it. The process is explained in the docs/misra/documenting-violations.rst document that this serie will provide. The tools currently supported are eclair, coverity and cppcheck, but the design is

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-07 Thread Julien Grall
Hi Ayan, On 07/11/2022 10:36, Ayan Kumar Halder wrote: On 06/11/2022 17:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need some clarification. To me the title and the explaination below suggests... On 04/11/2022 16:23, Ayan Kumar Halder wrote: From: Ayan Kumar Halder Refer ARM DDI 04

Re: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable

2022-11-07 Thread Julien Grall
On 07/11/2022 09:57, Penny Zheng wrote: Hi Julien Hi Penny, -Original Message- From: Xen-devel On Behalf Of Julien Grall Sent: Monday, November 7, 2022 4:56 AM To: Wei Chen ; xen-devel@lists.xenproject.org Cc: nd ; Penny Zheng ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr

Re: [XEN v2] xen/Arm: Enforce alignment check for atomic read/write

2022-11-07 Thread Ayan Kumar Halder
On 06/11/2022 17:54, Julien Grall wrote: Hi Ayan, Hi Julien, I need some clarification. To me the title and the explaination below suggests... On 04/11/2022 16:23, Ayan Kumar Halder wrote: From: Ayan Kumar Halder Refer ARM DDI 0487I.a ID081822, B2.2.1 "Requirements for single-copy ato

[xen-unstable test] 174652: tolerable FAIL

2022-11-07 Thread osstest service owner
flight 174652 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174652/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 174641 test-amd64-i386-xl-qemuu-win7-amd64

RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1

2022-11-07 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2022年11月7日 18:16 > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - > Part#1 > >

Re: Porting Xen in raspberry pi4B

2022-11-07 Thread Vipul Suneja
Hi Stefano, Thanks! Any input further on "xenstore-ls" logs? I am trying to run the x0vncserver & x11vnc server manually on guest machine(xen_guest_image_minimal) image but it's failing with the below error.

RE: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions

2022-11-07 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Monday, November 7, 2022 5:30 PM > To: Penny Zheng ; Wei Chen > ; xen-devel@lists.xenproject.org > Cc: nd ; Stefano Stabellini ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 09/11] xen/arm64: create boot-tim

Re: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1

2022-11-07 Thread Julien Grall
On 07/11/2022 09:52, Wei Chen wrote: Hi Julien, Hi, - Supports only a single Security state - Secure. - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. These patch series are implementing the Armv8-R64 MPU support for Xen, which are based on the discussion of "Propos

Re: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-11-07 Thread Jan Beulich
On 07.11.2022 11:09, Wei Chen wrote: > Hi Jan, > >> -Original Message- >> From: Jan Beulich >> Sent: 2022年11月3日 22:26 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Sub

RE: [PATCH v7 2/6] xen/x86: move generically usable NUMA code from x86 to common

2022-11-07 Thread Wei Chen
Hi Jan, > -Original Message- > From: Jan Beulich > Sent: 2022年11月3日 22:26 > To: Wei Chen > Cc: nd ; Andrew Cooper ; Roger Pau > Monné ; Wei Liu ; George Dunlap > ; Julien Grall ; Stefano > Stabellini ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v7 2/6] xen/x86: move generically

RE: [PATCH v6 10/11] xen/arm64: introduce helpers for MPU enable/disable

2022-11-07 Thread Penny Zheng
Hi Julien > -Original Message- > From: Xen-devel On Behalf Of > Julien Grall > Sent: Monday, November 7, 2022 4:56 AM > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Penny Zheng ; Stefano > Stabellini ; Bertrand Marquis > ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 10/11] x

RE: [PATCH v6 00/11] xen/arm: Add Armv8-R64 MPU support to Xen - Part#1

2022-11-07 Thread Wei Chen
Hi Julien, > > - Supports only a single Security state - Secure. > > - MPU in EL1 & EL2 is configurable, MMU in EL1 is configurable. > > > > These patch series are implementing the Armv8-R64 MPU support > > for Xen, which are based on the discussion of > > "Proposal for Porting Xen to Armv8-R6

Re: [PATCH v6 08/11] xen/arm64: move MMU related code from head.S to head_mmu.S

2022-11-07 Thread Julien Grall
On 06/11/2022 20:06, Julien Grall wrote: Hi Wei, On 04/11/2022 10:07, Wei Chen wrote: There are lots of MMU specific code in head.S. This code will not be used in MPU systems. If we use #ifdef to gate them, the code will become messy and hard to maintain. So we move MMU related code to head_

Re: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU

2022-11-07 Thread Julien Grall
Hi Penny, On 07/11/2022 08:13, Penny Zheng wrote: -Original Message- From: Julien Grall Sent: Monday, November 7, 2022 5:02 AM To: Wei Chen ; xen-devel@lists.xenproject.org Cc: nd ; Penny Zheng ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH v6 11/11] xe

Re: [PATCH v6 09/11] xen/arm64: create boot-time MPU protection regions

2022-11-07 Thread Julien Grall
On 07/11/2022 06:59, Penny Zheng wrote: Hi Julien Hi Penny, + +/* + * In boot stage, we will use 1 MPU region: + * Region#0: Normal memory for Xen text + data + bss (2MB) + */ Are we only going to modify the MPU in head.S? If not, then I would define the layout in config_mpu.h so there are

RE: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build

2022-11-07 Thread Henry Wang
Hi Julien, > -Original Message- > Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been > loaded in domain_build > >> (+ Henry) > >> I think this wants to be in 4.17. This will avoid Xen to have two > >> mappings with different caching attribute (initrd is part of the RA

Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build

2022-11-07 Thread Julien Grall
On 07/11/2022 01:33, Henry Wang wrote: Hi Julien, Hi Henry, -Original Message- Subject: Re: [PATCH v6 02/11] xen/arm: add iounmap after initrd has been loaded in domain_build (+ Henry) I think this wants to be in 4.17. This will avoid Xen to have two mappings with different cach

Re: [PATCH 19/20] tools/xenstore: introduce trace classes

2022-11-07 Thread Juergen Gross
On 06.11.22 23:18, Julien Grall wrote: Hi Juergen, I haven't yet look at the code itself. I wanted to comment on the external interfaces. On 01/11/2022 15:28, Juergen Gross wrote: Make the xenstored internal trace configurable by adding classes which can be switched on and off independently

Re: [PATCH 17/20] tools/xenstore: switch hashtable to use the talloc framework

2022-11-07 Thread Juergen Gross
On 06.11.22 23:02, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: Instead of using malloc() and friends, let the hashtable implementation use the talloc framework. Can you outline why switching to talloc() is better? It is more consistent within xenstored, and it

Re: [PATCH 13/20] tools/xenstore: don't allow creating too many nodes in a transaction

2022-11-07 Thread Juergen Gross
On 06.11.22 23:00, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: The accounting for the number of nodes of a domain in an active transaction is not working correctly, as it allows to create arbitrary number of nodes. The transaction will finally fail due to exceeding

[qemu-mainline test] 174651: tolerable FAIL - PUSHED

2022-11-07 Thread osstest service owner
flight 174651 qemu-mainline real [real] flight 174656 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174651/ http://logs.test-lab.xenproject.org/osstest/logs/174656/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

Re: [PATCH 09/20] tools/xenstore: introduce dummy nodes for special watch paths

2022-11-07 Thread Juergen Gross
On 06.11.22 22:38, Julien Grall wrote: Hi Juergen, On 01/11/2022 15:28, Juergen Gross wrote: Instead of special casing the permission handling and watch event firing for the special watch paths "@introduceDomain" and "@releaseDomain", use static dummy nodes added to the data base when starting

RE: [PATCH v6 11/11] xen/arm64: add setup_fixmap and remove_identity_mapping for MPU

2022-11-07 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Monday, November 7, 2022 5:02 AM > To: Wei Chen ; xen-devel@lists.xenproject.org > Cc: nd ; Penny Zheng ; Stefano > Stabellini ; Bertrand Marquis > ; Volodymyr Babchuk > > Subject: Re: [PATCH v6 11/11] xen/arm64: add setup_fixma