> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > > index 4fb5c20b13..bd30d3798c 100644
> > > --- a/xen/arch/arm/domain_build.c
> > > +++ b/xen/arch/arm/domain_build.c
> > > @@ -3418,6 +3418,8 @@ static void __init initrd_load(struct
> kernel_info
> > *kinfo)
> > > initrd, len);
> > > if ( res != 0 )
> > > panic("Unable to copy the initrd in the hwdom memory\n");
> > > +
> > > + iounmap(initrd);
> >
> > This looks good to me. But I am wondering whether using ioremap_wc() is
> > actually correct because we are reading the region. So it seems strang
> > to map it with write-combine.
> >
> > So I would consider to use ioremap_cache(). That said, this would be a
> > separate patch.
> >
>
> Ok, we will try to use ioremap_cache and test it. If everything works
> well we will introduce a separate patch in next version.
>
Or is it better to send a separate patch for this? Because I think we
might need something to address the v1 comments.
Cheers,
Wei Chen
> Cheers,
> Wei Chen
>
>
> > I think this wants to be in 4.17. This will avoid Xen to have two
> > mappings with different caching attribute (initrd is part of the RAM and
> > therefore directmap).
> >
> > Cheers,
> >
> > --
> > Julien Grall
