Re: [RFC PATCH] iommu: make no-quarantine mean no-quarantine

2021-04-26 Thread Jan Beulich
On 26.04.2021 19:25, Scott Davis wrote: > This patch modifies Xen's behavior when making devices assignable while the > iommu=no-quarantine command line option is in effect. Currently this option > only affects device deassignment, causing devices to get immediately assigned > back to Dom0 instead

[RFC PATCH] iommu: make no-quarantine mean no-quarantine

2021-04-26 Thread Scott Davis
This patch modifies Xen's behavior when making devices assignable while the iommu=no-quarantine command line option is in effect. Currently this option only affects device deassignment, causing devices to get immediately assigned back to Dom0 instead of to the quarantine dom_io domain. This patch e

Re: [PATCH 0/3] x86: Initial pieces for guest CET support

2021-04-26 Thread Jan Beulich
On 26.04.2021 19:54, Andrew Cooper wrote: > Some initial pieces for guest support. Everything will currently malfunction > for VMs which explicitly opt in to CET_SS/IBT. > > Still TODO as a minimum: > * Teach the pagewalk logic about shadow stack accesses and errors. > * Emulator support for th

[linux-linus test] 161468: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161468 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/161468/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

RE: Discussion of Xenheap problems on AArch64

2021-04-26 Thread Henry Wang
Hi Julien, Sorry for the late reply, I kinda missed this email somehow Please see my inline reply ^^ > -Original Message- > From: Xen-devel On Behalf Of > Julien Grall > Sent: Monday, April 26, 2021 4:20 AM > To: Henry Wang ; sstabell...@kernel.org; xen- > de...@lists.xenproject.org

[xen-4.12-testing test] 161465: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161465 xen-4.12-testing real [real] flight 161474 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161465/ http://logs.test-lab.xenproject.org/osstest/logs/161474/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[ovmf test] 161469: all pass - PUSHED

2021-04-26 Thread osstest service owner
flight 161469 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/161469/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5396354b868bd6652600a654bba7df16701ac1cb baseline version: ovmf f2f4c6be2dba3f8e97ac5

[RFC PATCH 2/2] libxl: allow to skip block script completely

2021-04-26 Thread Marek Marczykowski-Górecki
Default block script is quite slow and requires global lock which slows it down even more (for domains with multiple disks). The common case of a block device-based disk is trivial to handle and does not require locking. This can be handled directly within libxl, to avoid slow script execution and

[RFC PATCH 1/2] libxl: rename 'error' label to 'out' as it is used for success too

2021-04-26 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki --- tools/libs/light/libxl_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libs/light/libxl_linux.c b/tools/libs/light/libxl_linux.c index 8d62dfd255cb..cc8baf5c3eae 100644 --- a/tools/libs/light/libxl_linux.c +++ b

[RFC PATCH 0/2] libxl: support common cases without block script

2021-04-26 Thread Marek Marczykowski-Górecki
This series in an attempt to speed up the domain start by removing slow block script from the picture. The current RFC covers the simplest possible case only - target being a block device directly. This case does not require locking at all. Further version will cover also setting up a loop device.

[qemu-mainline test] 161464: regressions - trouble: broken/fail/pass

2021-04-26 Thread osstest service owner
flight 161464 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/161464/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl broken test-armhf-armhf-xl-credit1

Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-26 Thread Tim Deegan
At 16:42 +0200 on 23 Apr (1619196141), Jan Beulich wrote: > On 23.04.2021 16:17, Roger Pau Monné wrote: > > On Fri, Apr 23, 2021 at 12:52:57PM +0200, Jan Beulich wrote: > >> +if ( mfn_valid(mfn = shadow_l1e_get_mfn(sl1e)) && > > > > Nit: I would prefer if assigned mfn outside of the condition,

[PATCH 0/3] x86: Initial pieces for guest CET support

2021-04-26 Thread Andrew Cooper
Some initial pieces for guest support. Everything will currently malfunction for VMs which explicitly opt in to CET_SS/IBT. Still TODO as a minimum: * Teach the pagewalk logic about shadow stack accesses and errors. * Emulator support for the new instructions. WRUSS is an irritating corner

[PATCH 3/3] x86/VT-x: Enumeration for CET

2021-04-26 Thread Andrew Cooper
VT-x has separate entry/exit control for loading guest/host state. Saving guest state on vmexit is performed unconditionally. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Jun Nakajima CC: Kevin Tian --- xen/arch/x86/hvm/vmx/vmcs.c| 6 ++

[PATCH 1/3] x86/hvm: Introduce experimental guest CET support

2021-04-26 Thread Andrew Cooper
For now, let VMs opt into using CET by setting cet_ss/ibt in the CPUID policy. Also extend cr4 handling to permit CR4.CET being set, along with logic to interlock CR4.CET and CR0.WP. Everything else will malfunction for now, but this will help adding support incrementally - there is a lot to do b

[PATCH 2/3] x86/svm: Enumeration for CET

2021-04-26 Thread Andrew Cooper
On CET-capable hardware, VMRUN/EXIT unconditionally swaps S_SET, SSP and ISST (subject to cleanbits) without further settings. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/svm/svm.c | 1 + xen/arch/x86/hvm/svm/svmdebug.c|

Re: [PATCH v4 1/3] VMX: use a single, global APIC access page

2021-04-26 Thread Tim Deegan
At 12:52 +0200 on 23 Apr (1619182377), Jan Beulich wrote: > The address of this page is used by the CPU only to recognize when to > access the virtual APIC page instead. No accesses would ever go to this > page. It only needs to be present in the (CPU) page tables so that > address translation will

Re: [GIT PULL] xen: branch for v5.13-rc1

2021-04-26 Thread pr-tracker-bot
The pull request you sent on Mon, 26 Apr 2021 08:16:18 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.13-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8e47c5f0e23234659daea78256bc1b04ea019a4b Thank you! -- Deet-doot-dot, I

[xen-unstable test] 161460: tolerable FAIL

2021-04-26 Thread osstest service owner
flight 161460 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/161460/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 161451 test-armhf-armhf-libvirt 16 save

Re: [PATCH v5 16/16] of: Add plumbing for restricted DMA pool

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:35 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > If a device is not behind an IOMMU, we look up the device node and set > > up the restricted DMA when the restricted-dma-pool is presented. > > > > Signed-off-by: Claire Chang > > --- > > driver

Re: [PATCH v5 08/16] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:31 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > Update is_swiotlb_active to add a struct device argument. This will be > > useful later to allow for restricted DMA pool. > > > > Signed-off-by: Claire Chang > > --- > > drivers/gpu/drm/i915/gem

Re: [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 7:34 PM Steven Price wrote: > > On 22/04/2021 09:14, Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > > matching reserved-memory nodes. > > > > Signed-off-by: Claire Chang > > --- > > include/linux/device.h | 4 +++ > > inc

[PATCH v3 3/3] xen/pci: Refactor MSI code that implements MSI functionality within XEN

2021-04-26 Thread Rahul Singh
MSI code that implements MSI functionality to support MSI within XEN is not usable on ARM. Move the code under CONFIG_PCI_MSI_INTERCEPT flag to gate the code for ARM. Currently, we have no idea how MSI functionality will be supported for other architecture therefore we have decided to move the cod

[linux-linus test] 161457: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161457 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/161457/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

[PATCH v3 2/3] xen/pci: Refactor PCI MSI intercept related code

2021-04-26 Thread Rahul Singh
MSI intercept related code is not useful for ARM when MSI interrupts are injected via GICv3 ITS. Therefore introducing the new flag CONFIG_PCI_MSI_INTERCEPT to gate the MSI code for ARM in common code and also implemented the stub version for the unused code for ARM to avoid compilation error when

[PATCH v3 1/3] xen/iommu: Move iommu_update_ire_from_msi(..) to xen/iommu.h

2021-04-26 Thread Rahul Singh
Move iommu_update_ire_from_msi(..) from passthrough/pci.c to xen/iommu.h and wrap it under CONFIG_X86 as it is referenced in x86 code only to avoid compilation error for other architecture when HAS_PCI is enabled. No functional change intended. Signed-off-by: Rahul Singh --- Changes since v2: -

[PATCH v3 0/3] xen/pci: Make PCI passthrough code non-x86 specific

2021-04-26 Thread Rahul Singh
This patch series is preparatory work to implement the PCI passthrough support for the ARM architecture. Rahul Singh (3): xen/iommu: Move iommu_update_ire_from_msi(..) to xen/iommu.h xen/pci: Refactor PCI MSI intercept related code xen/pci: Refactor MSI code that implements MSI functionality

Re: [PATCH v2 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-26 Thread Luca Fancellu
> On 22 Apr 2021, at 09:06, Jan Beulich wrote: > > On 22.04.2021 09:39, Luca Fancellu wrote: >>> On 20 Apr 2021, at 11:27, Jan Beulich wrote: >>> On 20.04.2021 11:42, Luca Fancellu wrote: > On 20 Apr 2021, at 10:14, Jan Beulich wrote: > On 20.04.2021 10:46, Luca Fancellu wrote: >

[PATCH v3 0/3] Use Doxygen and sphinx for html documentation

2021-04-26 Thread Luca Fancellu
This serie introduce doxygen in the sphinx html docs generation. One benefit is to keep most of the documentation in the source files of xen so that it's more maintainable, on the other hand there are some limitation of doxygen that should be addressed modifying the current codebase (for example do

[PATCH v3 2/3] docs: hypercalls sphinx skeleton for generated html

2021-04-26 Thread Luca Fancellu
Create a skeleton for the documentation about hypercalls Signed-off-by: Luca Fancellu --- .gitignore | 1 + docs/Makefile | 4 docs/hypercall-interfaces/arm32.rst| 4 docs/hypercall-interfaces/arm64.rst| 32 +++

[PATCH v3 3/3] docs/doxygen: doxygen documentation for grant_table.h

2021-04-26 Thread Luca Fancellu
Modification to include/public/grant_table.h: 1) Add doxygen tags to: - Create Grant tables section - include variables in the generated documentation 2) Add .rst file for grant table for Arm64 Signed-off-by: Luca Fancellu --- v3 changes: - removed tags to skip anonymous union/struct - moved b

[libvirt test] 161459: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161459 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/161459/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH] x86/emul: Use existing X86_EXC_* constants

2021-04-26 Thread Andrew Cooper
... rather than having separate definitions locally. EXC_HAS_EC in particular is missing #CP, #VC and #SX vs X86_EXC_HAVE_EC. Also switch a raw 14 for X86_EXC_PF in x86_emul_pagefault(). No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu -

[xen-unstable-smoke test] 161462: tolerable all pass - PUSHED

2021-04-26 Thread osstest service owner
flight 161462 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/161462/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[xen-4.12-testing test] 161454: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161454 xen-4.12-testing real [real] flight 161463 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/161454/ http://logs.test-lab.xenproject.org/osstest/logs/161463/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[qemu-mainline test] 161455: regressions - FAIL

2021-04-26 Thread osstest service owner
flight 161455 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/161455/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-i3

Please Welcome Roger Pau Monné to the Security Team

2021-04-26 Thread George Dunlap
Dear Community Members, I am pleased to announce that Roger Pau Monné has been nominated and voted to become a new member of the XenProject Security Team. Roger has made significant contributions to the XenProject over the years; he is co-maintainer of the x86 subsystem, maintainer for many Xen

[PATCH] x86: fix build race when generating temporary object files (take 2)

2021-04-26 Thread Jan Beulich
The original commit wasn't quite sufficient: Emptying DEPS is helpful only when nothing will get added to it subsequently. xen/Rules.mk will, after including the local Makefile, amend DEPS by dependencies for objects living in sub-directories though. For the purpose of suppressing dependencies of t

Re: [PATCH RFCv2 12/15] xen/arm: add Persistent Map (PMAP) infrastructure

2021-04-26 Thread Xia, Hongyan
On Sun, 2021-04-25 at 21:13 +0100, Julien Grall wrote: > From: Wei Liu > > The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We > pre-populate all the relevant page tables before the system is fully > set up. > > We will need it on Arm in order to rework the arm64 version of > xenhe

Re: [PATCH v2] x86/oprofile: remove compat accessors usage from backtrace

2021-04-26 Thread Jan Beulich
On 23.04.2021 16:37, Roger Pau Monne wrote: > Remove the unneeded usage of the compat layer to copy frame pointers > from guest address space. Instead just use raw_copy_from_guest. > > While there drop the checks for the accessibility of one struct > frame_head beyond the current one: it's not cle

Re: [PATCH v3 19/22] x86emul: support TILELOADD{,T1} and TILESTORE

2021-04-26 Thread Paul Durrant
On 22/04/2021 16:11, Jan Beulich wrote: On 22.04.2021 17:06, Jan Beulich wrote: On 22.04.2021 16:55, Jan Beulich wrote: +do { +/* Limit rows to just as many to cover the next one to access. */ +cfg->start_row = i; +cfg->rows[modrm_reg] = i + 1; +