branch xen-unstable
xenbranch xen-unstable
job test-amd64-i386-libvirt-xsm
testid guest-start
Tree: libvirt git://xenbits.xen.org/libvirt.git
Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git
Tree: linux git://xenbits.xen.org/linux-pvops.git
Tree: linuxfirmware git://xenbit
flight 160640 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160640/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs.
152332
test-amd64-i3
flight 160638 xen-4.12-testing real [real]
flight 160653 xen-4.12-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/160638/
http://logs.test-lab.xenproject.org/osstest/logs/160653/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could
flight 160648 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160648/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 01/04/2021 09:44, Roger Pau Monné wrote:
> On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote:
>> On 01.04.2021 03:06, Roman Shaposhnik wrote:
>>> And the obvious next question: is my EVE usecase esoteric enough that
>>> I should just go ahead and do a custom GRUB patch or is there a mo
flight 160632 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160632/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs.
152631
test-amd64-i3
flight 160645 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160645/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Move the logic from xc_cpu_policy_apply_cpuid into libxl, now that the
> xc_cpu_policy_* helpers allow modifying a cpu policy. Having xenguest
> parsing CPUID data in xend format was a layering violation, and by
> moving such parsing into libxl directly
On 23/03/2021 09:58, Roger Pau Monne wrote:
> With the addition of the xc_cpu_policy_* now libxl can have better
> control over the cpu policy, this allows removing the
> xc_cpuid_apply_policy function and instead coding the required bits by
> libxl in libxl__cpuid_legacy directly.
>
> Remove xc_cp
On 23/03/2021 09:58, Roger Pau Monne wrote:
> This logic is pulled out from xc_cpuid_apply_policy and placed into a
> separate helper.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné
> ---
> tools/include/xenctrl.h | 4 +
> tools/libs/guest/xg_cpuid_x86.c | 181 +++
From: Julien Grall
In a follow-up patch we may want to automatically replace some
mnemonics (such as ret) with a different sequence.
To ensure all the assembly files will include asm/macros.h it is best to
automatically include it on single assembly. This can be done via
config.h.
It was necess
From: Julien Grall
Some CPUs can speculate past a RET instruction and potentially perform
speculative accesses to memory before processing the return.
There is no known gadget available after the RET instruction today.
However some of the registers (such as in check_pending_guest_serror())
may c
From: Julien Grall
Hi all,
Last year, Arm released a whitepaper about a new category of speculation.
(see [1] and [2]). In short, a processor may be able to speculate past
some of the unconditional control flow instructions (e.g eret, smc, br).
In some of the cases, the registers will contain v
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Older Xen versions used to expose some CPUID bits which are no longer
> exposed by default. In order to keep a compatible behavior with
> guests migrated from versions of Xen that don't encode the CPUID data
> on the migration stream introduce a functio
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Introduce a helper to obtain a compatible cpu policy based on two
> input cpu policies. Currently this is done by and'ing all CPUID leaves
> and MSR entries, except for MSR_ARCH_CAPABILITIES which has the RSBA
> bit or'ed.
>
> The _AC macro is pulled fr
Hi,
On 01/04/2021 15:13, Jan Beulich wrote:
On 01.04.2021 15:38, George Dunlap wrote:
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -26,6 +26,7 @@ The format is based on [Keep a
Changelog](https://keepachangelog.com/en/1.0.0/)
- Added XEN_SCRIPT_DIR configuration option to specify location for X
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Such helpers is just a wrapper to the existing
> x86_cpu_policies_are_compatible function. This requires building
> policy.c from libx86 on user land also.
>
> No user of the interface introduced.
>
> Signed-off-by: Roger Pau Monné
> ---
> tools/inclu
Hi Jan,
On 22/12/2020 08:14, Jan Beulich wrote:
Use ENXIO instead of EINVAL to cover the two cases of the address not
satisfying the requirements. This will make an issue here better stand
out at the call site.
Also add a missing compat-mode related size check: If the sizes
differed, other code
On 01/04/2021 16:25, Jan Beulich wrote:
On 01.04.2021 16:55, Julien Grall wrote:
On 01/04/2021 15:27, Jan Beulich wrote:
On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of functions
requiring overriding will likely be
pretty limited and #ifdef would be IMHO tolerable.
On 01/04/2021 14:38, George Dunlap wrote:
Signed-off-by: George Dunlap
---
CC: Paul Durrant
CC: Ian Jackson
CC: Wei Liu
Reviewed-by: Paul Durrant
---
CHANGELOG.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f7ce6682b9..086a0e
On 01.04.2021 17:05, Julien Grall wrote:
> On 01/04/2021 09:33, Jan Beulich wrote:
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -131,8 +131,8 @@ $(TARGET)-syms: prelink.o xen.lds
>> >$(@D)/$(@F).map
>> rm -f $(@D)/.$(@F).[0-9]*
>>
>> -asm-offsets.s: $(TAR
On 01.04.2021 16:55, Julien Grall wrote:
>
>
> On 01/04/2021 15:27, Jan Beulich wrote:
>> On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of
>> functions requiring overriding will likely be
>>> pretty limited and #ifdef would be IMHO tolerable.
>>>
>>> Although, I would be OK
On 01.04.2021 16:56, Julien Grall wrote:
> On 01/04/2021 11:19, Jan Beulich wrote:
>> --- a/xen/common/lib.c
>> +++ b/xen/lib/divmod.c
>> @@ -40,7 +40,6 @@
>>* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
>>* SUCH DAMAGE.
>>*/
>> -#if BITS_PER_LONG == 32
>
> I
Hi,
On 20/03/2021 11:47, Julien Grall wrote:
On 20/03/2021 00:01, Stefano Stabellini wrote:
On Sat, 27 Feb 2021, Julien Grall wrote:
(+ Dario and George)
Hi Stefano,
I have added Dario and George to get some inputs from the scheduling
part.
On 27/02/2021 01:58, Stefano Stabellini wrote:
Hi Jan,
On 01/04/2021 09:33, Jan Beulich wrote:
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -341,7 +341,7 @@ _clean: delete-unfresh-files
find . \( -name "*.o" -o -name ".*.d" -o -name ".*.d2" \
-o -name "*.gcno" -o -name ".*.cmd" \) -exec rm -f {} \;
rm -f include/a
On 23/03/2021 09:58, Roger Pau Monne wrote:
> To use the new cpu policy interface xc_cpu_policy_set_domain. Note
> that xc_set_domain_cpu_policy is removed from the interface and the
> function is made static to xg_cpuid_x86.c for it's internal callers.
>
> Signed-off-by: Roger Pau Monné
> ---
>
Hi Jan,
On 01/04/2021 11:20, Jan Beulich wrote:
These standard functions shouldn't need custom declarations. The only
case where redundancy might be needed is if there were inline functions
there. But we don't have any here (anymore). Prune the per-arch headers
of duplicate declarations while mo
Hi Jan,
On 01/04/2021 11:19, Jan Beulich wrote:
These were built for 32-bit architectures only (the same code could,
with some tweaking, sensibly be used to provide TI-mode helpers on
64-bit arch-es) - retain this property, while still avoiding to have
a CU without any contents at all. For this,
On 23/03/2021 09:58, Roger Pau Monne wrote:
> diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c
> index 091aeb70c9c..13c2972ccd3 100644
> --- a/tools/libs/guest/xg_cpuid_x86.c
> +++ b/tools/libs/guest/xg_cpuid_x86.c
> @@ -966,3 +966,70 @@ int xc_cpu_policy_get_msr(xc_in
On 01/04/2021 15:27, Jan Beulich wrote:
On 01.04.2021 16:04, Julien Grall wrote: >> So overall, the number of functions
requiring overriding will likely be
pretty limited and #ifdef would be IMHO tolerable.
Although, I would be OK with creating a file per function that are
already overrided
flight 160630 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160630/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-examine 4 memdisk-try-append fail pass in 160581
Tests which did not succeed, but
On 23/03/2021 09:58, Roger Pau Monne wrote:
> diff --git a/tools/libs/guest/xg_cpuid_x86.c b/tools/libs/guest/xg_cpuid_x86.c
> index 48351f1c4c6..a1e1bf10d5c 100644
> --- a/tools/libs/guest/xg_cpuid_x86.c
> +++ b/tools/libs/guest/xg_cpuid_x86.c
> @@ -883,3 +883,45 @@ int xc_cpu_policy_serialise(xc_
> On Apr 1, 2021, at 3:17 PM, Jan Beulich wrote:
>
> On 01.04.2021 15:38, George Dunlap wrote:
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -33,6 +33,7 @@ The format is based on [Keep a
>> Changelog](https://keepachangelog.com/en/1.0.0/)
>> - Some additional affordances in various xl sub
> On Apr 1, 2021, at 3:16 PM, Andrew Cooper wrote:
>
> On 01/04/2021 15:13, George Dunlap wrote:
>>
>>> On Apr 1, 2021, at 3:00 PM, Andrew Cooper wrote:
>>>
>>> On 01/04/2021 14:38, George Dunlap wrote:
...grouped by submitters / maintainers
Signed-off-by: George Dunlap
On Thu, Apr 01, 2021 at 01:44:59PM +0100, Andrew Cooper wrote:
> On 01/04/2021 11:22, Roger Pau Monne wrote:
> > The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
> > as current, as there's no support for EOI'ing interrupts on a remote
> > vCPU.
> >
> > While there also turn the un
On 01.04.2021 16:31, Andrew Cooper wrote:
> On 25/11/2020 08:51, Jan Beulich wrote:
>> @@ -102,19 +102,21 @@ void __dummy__(void)
>> BLANK();
>> #endif
>>
>> -#ifdef CONFIG_PV
>> +#ifdef CONFIG_PV32
>> OFFSET(DOMAIN_is_32bit_pv, struct domain, arch.pv.is_32bit);
>
> Even if PV32 is co
On 25/11/2020 08:51, Jan Beulich wrote:
> Except for the initial part of cstar_enter compat/entry.S is all dead
> code in this case. Further, along the lines of the PV conditionals we
> already have in entry.S, make code PV32-conditional there too (to a
> fair part because this code actually refere
On 01.04.2021 16:04, Julien Grall wrote:
> Hi Jan,
>
> On 01/04/2021 14:43, Jan Beulich wrote:
>> On 01.04.2021 13:54, Julien Grall wrote:
>>> On 01/04/2021 11:14, Jan Beulich wrote:
This is to dissolve / move xen/common/lib.c and xen/common/string.c.
One benefit of moving these function
Am Mon, 22 Mar 2021 14:17:44 +
schrieb Anthony PERARD :
> We use the deprecated QMP command "query-cpus"
There is also the already removed "cpu-add" command used, which apparently has
to be replaced by "device_add".
Do you happen to have a fix for this as well?
Another thread suggests tha
On 01.04.2021 16:01, Roger Pau Monné wrote:
> On Wed, Nov 25, 2020 at 09:51:33AM +0100, Jan Beulich wrote:
>> @@ -230,6 +230,13 @@ ENTRY(cstar_enter)
>> sti
>>
>> movq STACK_CPUINFO_FIELD(current_vcpu)(%rbx), %rbx
>> +
>> +#ifndef CONFIG_PV32
>> +
>> +jmp switch_to_ke
On 01.04.2021 15:38, George Dunlap wrote:
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -33,6 +33,7 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> - Some additional affordances in various xl subcommands.
> - Added the following ARM errata: Cortex A53 #8
On 01/04/2021 15:13, George Dunlap wrote:
>
>> On Apr 1, 2021, at 3:00 PM, Andrew Cooper wrote:
>>
>> On 01/04/2021 14:38, George Dunlap wrote:
>>> ...grouped by submitters / maintainers
>>>
>>> Signed-off-by: George Dunlap
>>> ---
>>> CC: Juergen Gross
>>> CC: Jan Beulich
>>> CC: Ian Jackson
flight 160641 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/160641/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On 01.04.2021 15:38, George Dunlap wrote:
> ...Grouped mostly by submitter / maintainer
>
> Signed-off-by: George Dunlap
Acked-by: Jan Beulich
> On Apr 1, 2021, at 3:00 PM, Andrew Cooper wrote:
>
> On 01/04/2021 14:38, George Dunlap wrote:
>> ...grouped by submitters / maintainers
>>
>> Signed-off-by: George Dunlap
>> ---
>> CC: Juergen Gross
>> CC: Jan Beulich
>> CC: Ian Jackson
>> ---
>> CHANGELOG.md | 3 +++
>> 1 file changed,
On Wed, Jul 15, 2020 at 09:45:47AM +0200, Jan Beulich wrote:
> Except for hvm_shadow_max_featuremask and deep_features they're
> referenced by __init functions only.
>
> Signed-off-by: Jan Beulich
AFAICT those are still only used by __init functions:
Acked-by: Roger Pau Monné
And making those
On 01.04.2021 15:38, George Dunlap wrote:
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -26,6 +26,7 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> - Added XEN_SCRIPT_DIR configuration option to specify location for Xen
> scripts, rather than hard-coding
Hi Jan,
On 01/04/2021 14:43, Jan Beulich wrote:
On 01.04.2021 13:54, Julien Grall wrote:
On 01/04/2021 11:14, Jan Beulich wrote:
This is to dissolve / move xen/common/lib.c and xen/common/string.c.
One benefit of moving these functions into an archive is that we can
drop some of the related __
On Wed, Nov 25, 2020 at 09:51:33AM +0100, Jan Beulich wrote:
> Except for the initial part of cstar_enter compat/entry.S is all dead
> code in this case. Further, along the lines of the PV conditionals we
> already have in entry.S, make code PV32-conditional there too (to a
> fair part because this
On 01/04/2021 14:38, George Dunlap wrote:
> ...grouped by submitters / maintainers
>
> Signed-off-by: George Dunlap
> ---
> CC: Juergen Gross
> CC: Jan Beulich
> CC: Ian Jackson
> ---
> CHANGELOG.md | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index
On 23/03/2021 09:58, Roger Pau Monne wrote:
> Such helper is based on the existing functions to fetch a CPUID and
> MSR policies, but uses the xc_cpu_policy_t type to return the data to
> the caller.
>
> Note some helper functions are introduced, those are split from
> xc_cpu_policy_get_system beca
On 01.04.21 15:38, George Dunlap wrote:
...grouped by submitters / maintainers
Signed-off-by: George Dunlap
Reviewed-by: Juergen Gross
Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys
OpenPGP_signature
Description: OpenPGP digital signature
On 01.04.2021 14:01, Andrew Cooper wrote:
> On 01/04/2021 10:44, Jan Beulich wrote:
>> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at
>> least 2.36 would silently truncate the (negative) difference when a
>> section is placed below the image base. Such sections would also be
On 01/04/2021 14:45, Jan Beulich wrote:
> On 01.04.2021 15:20, Andrew Cooper wrote:
>> On 31/03/2021 15:03, Jan Beulich wrote:
>>> On 31.03.2021 15:31, Andrew Cooper wrote:
vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the
error
path from __map_domain_page_glob
On 01.04.2021 15:20, Andrew Cooper wrote:
> On 31/03/2021 15:03, Jan Beulich wrote:
>> On 31.03.2021 15:31, Andrew Cooper wrote:
>>> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the
>>> error
>>> path from __map_domain_page_global() failing would doubly free
>>> vlapic->regs
On 01.04.2021 13:54, Julien Grall wrote:
> On 01/04/2021 11:14, Jan Beulich wrote:
>> This is to dissolve / move xen/common/lib.c and xen/common/string.c.
>> One benefit of moving these functions into an archive is that we can
>> drop some of the related __HAVE_ARCH_* #define-s: By living in an
>>
Signed-off-by: George Dunlap
---
CC: Ian Jackson
CC: Stefano Stabellini
CC: Julien Grall
---
CHANGELOG.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a12dab1c33..b3325a8371 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -26,6 +26,7 @@ The format is ba
...grouped by submitters / maintainers
Signed-off-by: George Dunlap
---
CC: Juergen Gross
CC: Jan Beulich
CC: Ian Jackson
---
CHANGELOG.md | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2f26cd5c87..9c272a0113 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.
Signed-off-by: George Dunlap
Signed-off-by: Ian Jackson
---
CC: Ian Jackson
---
CHANGELOG.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 086a0e50d0..a12dab1c33 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,6 +25,7 @@ The format is based on [Keep a
Signed-off-by: George Dunlap
---
CC: Olaf Hering
CC: Ian Jackson
---
CHANGELOG.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8964bacf73..f7ce6682b9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,8 @@ The format is based on [Keep a
Change
...Grouped mostly by submitter / maintainer
Signed-off-by: George Dunlap
---
CC: Ian Jackson
CC: Andrew Cooper
CC: Jan Beulich
CC: Roger Pau Monne
---
CHANGELOG.md | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index b3325a8371..2f26cd5c87 100644
--- a/CHA
Signed-off-by: George Dunlap
---
CC: Paul Durrant
CC: Ian Jackson
CC: Wei Liu
---
CHANGELOG.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f7ce6682b9..086a0e50d0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ The forma
Signed-off-by: George Dunlap
---
CC: Igor Druzhinin
CC: Jan Beulich
CC: Ian Jackson
---
CHANGELOG.md | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9c272a0113..7237b0a020 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,6 +33,7 @@ The format is based o
On 01.04.2021 14:44, Andrew Cooper wrote:
> On 01/04/2021 11:22, Roger Pau Monne wrote:
>> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
>> as current, as there's no support for EOI'ing interrupts on a remote
>> vCPU.
>>
>> While there also turn the unconditional assert at the
On 31/03/2021 12:06, Roger Pau Monné wrote:
> On Tue, Mar 30, 2021 at 05:37:02PM +0200, Jan Beulich wrote:
>> On 23.03.2021 10:58, Roger Pau Monne wrote:
>>> Such helper is based on the existing functions to fetch a CPUID and
>>> MSR policies, but uses the xc_cpu_policy_t type to return the data to
On 31/03/2021 15:03, Jan Beulich wrote:
> On 31.03.2021 15:31, Andrew Cooper wrote:
>> vlapic_init()'s caller calls vlapic_destroy() on error. Therefore, the error
>> path from __map_domain_page_global() failing would doubly free
>> vlapic->regs_page.
> I'm having difficulty seeing this. What I fi
On 01/04/2021 11:22, Roger Pau Monne wrote:
> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
> as current, as there's no support for EOI'ing interrupts on a remote
> vCPU.
>
> While there also turn the unconditional assert at the top of the
> function into an error on non-debug
FYI, The CFP for the XenSummit has been extended from 2 April (tomorrow) to 9
April.
-George Dunlap
On 01/04/2021 10:44, Jan Beulich wrote:
> PE binaries specify section addresses by (32-bit) RVA. GNU ld up to at
> least 2.36 would silently truncate the (negative) difference when a
> section is placed below the image base. Such sections would also be
> wrongly placed ahead of all "normal" ones. S
Hi Jan,
On 01/04/2021 11:14, Jan Beulich wrote:
This is to dissolve / move xen/common/lib.c and xen/common/string.c.
One benefit of moving these functions into an archive is that we can
drop some of the related __HAVE_ARCH_* #define-s: By living in an
archive, the per-arch functions will preempt
On 01/04/2021 10:44, Jan Beulich wrote:
> As of commit a6066af5b142 ("xen/init: Annotate all command line
> parameter infrastructure as const") .init.setup has been part of .init.
> As of commit 544ad7f5caf5 ("xen/init: Move initcall infrastructure into
> .init.data") .initcall* have been part of .
On 05/11/2020 15:56, Jan Beulich wrote:
> Using max undermines the separation between default and max. For example,
> turning off AVX512F on an MPX-capable system silently turns on MPX,
> despite this not being part of the default policy anymore. Since the
> information is used only for determining
On 01/04/2021 09:28, Jan Beulich wrote:
> Like Intel, AMD also records the date in their blobs. The field was
> merely misnamed as "data_code" so far; this was perhaps meant to be
> "date_code". Split it into individual fields, just like we did for Intel
> some time ago, and extend the message logg
On 31.03.2021 12:32, Roger Pau Monne wrote:
> EOIs are always executed in guest vCPU context, so there's no reason to
> pass a vCPU parameter around as can be fetched from current.
While not overly problematic, I'd like to point out that there's not a
single vcpu parameter being dropped here - in
On 01.04.2021 12:22, Roger Pau Monne wrote:
> The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
> as current, as there's no support for EOI'ing interrupts on a remote
> vCPU.
>
> While there also turn the unconditional assert at the top of the
> function into an error on non-debug
On 01/04/2021 11:22, Roger Pau Monne wrote:
The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
as current, as there's no support for EOI'ing interrupts on a remote
vCPU.
While there also turn the unconditional assert at the top of the
function into an error on non-debug builds.
Signed-off-by: Jan Beulich
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -40,7 +40,6 @@ obj-y += softirq.o
obj-y += smp.o
obj-y += spinlock.o
obj-y += stop_machine.o
-obj-y += string.o
obj-y += symbols.o
obj-y += tasklet.o
obj-y += time.o
--- a/xen/common/string.c
+++ /dev/null
@@
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -8,26 +8,6 @@
#include
#include
-#ifndef __HAVE_ARCH_STRPBRK
-/**
- * strpbrk - Find the first occurrence of a set of characters
- * @cs: The string to be searched
- * @ct: The characters to search for
- */
-c
In fact the function is unused at present, and hence will now get
omitted from the final binaries.
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -8,33 +8,6 @@
#include
#include
-#ifndef __HAVE_ARCH_STRSPN
-/**
- * strspn - Calculate the length of the ini
While moving the implementation, also rename it to match strcasecmp(),
allowing the similar use of a compiler builting in this case as well.
Signed-off-by: Jan Beulich
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1223,8 +1223,8 @@ static int __init map_range_to_domain(
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -41,21 +41,6 @@ int strnicmp(const char *s1, const char
}
#endif
-#ifndef __HAVE_ARCH_STRCASECMP
-int (strcasecmp)(const char *s1, const char *s2)
-{
-int c1, c2;
-
-do
-{
-c1 = tolower(*s1++
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -131,27 +131,6 @@ char * strsep(char **s, const char *ct)
}
#endif
-#ifndef __HAVE_ARCH_STRSTR
-/**
- * strstr - Find the first substring in a %NUL terminated string
- * @s1: The string to be searched
- * @s2: T
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -56,24 +56,6 @@ int (strcasecmp)(const char *s1, const c
}
#endif
-#ifndef __HAVE_ARCH_STRRCHR
-/**
- * strrchr - Find the last occurrence of a character in a string
- * @s: The string to be searched
- * @c: The
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -56,21 +56,6 @@ int (strcasecmp)(const char *s1, const c
}
#endif
-#ifndef __HAVE_ARCH_STRCHR
-/**
- * strchr - Find the first occurrence of a character in a string
- * @s: The string to be searched
- * @c: The
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -56,35 +56,6 @@ int (strcasecmp)(const char *s1, const c
}
#endif
-#ifndef __HAVE_ARCH_STRLCAT
-/**
- * strlcat - Append a %NUL terminated string into a sized buffer
- * @dest: Where to copy the string to
- * @s
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -56,32 +56,6 @@ int (strcasecmp)(const char *s1, const c
}
#endif
-#ifndef __HAVE_ARCH_STRLCPY
-/**
- * strlcpy - Copy a %NUL terminated string into a sized buffer
- * @dest: Where to copy the string to
- * @src
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -111,27 +111,6 @@ size_t strlcat(char *dest, const char *s
EXPORT_SYMBOL(strlcat);
#endif
-#ifndef __HAVE_ARCH_STRNCMP
-/**
- * strncmp - Compare two length-limited strings
- * @cs: One string
- * @ct: Another s
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -111,25 +111,6 @@ size_t strlcat(char *dest, const char *s
EXPORT_SYMBOL(strlcat);
#endif
-#ifndef __HAVE_ARCH_STRCMP
-/**
- * strcmp - Compare two strings
- * @cs: One string
- * @ct: Another string
- */
-int (
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -184,22 +184,6 @@ char *(strrchr)(const char *s, int c)
}
#endif
-#ifndef __HAVE_ARCH_STRNLEN
-/**
- * strnlen - Find the length of a length-limited string
- * @s: The string to be sized
- * @count: The maximum
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -184,21 +184,6 @@ char *(strrchr)(const char *s, int c)
}
#endif
-#ifndef __HAVE_ARCH_STRLEN
-/**
- * strlen - Find the length of a string
- * @s: The string to be sized
- */
-size_t (strlen)(const char * s)
-{
The HV_X64_MSR_EOI wrmsr should always happen with the target vCPU
as current, as there's no support for EOI'ing interrupts on a remote
vCPU.
While there also turn the unconditional assert at the top of the
function into an error on non-debug builds.
No functional change intended.
Requested-by:
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -311,26 +311,6 @@ char *(strstr)(const char *s1, const cha
}
#endif
-/**
- * memchr_inv - Find an unmatching character in an area of memory.
- * @s: The memory area
- * @c: The byte that is expected
- * @n: The
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -311,28 +311,6 @@ char *(strstr)(const char *s1, const cha
}
#endif
-#ifndef __HAVE_ARCH_MEMCHR
-/**
- * memchr - Find a character in an area of memory.
- * @s: The memory area
- * @c: The byte to search for
- *
Signed-off-by: Jan Beulich
--- a/xen/common/string.c
+++ b/xen/common/string.c
@@ -311,25 +311,6 @@ char *(strstr)(const char *s1, const cha
}
#endif
-#ifndef __HAVE_ARCH_MEMCMP
-/**
- * memcmp - Compare two areas of memory
- * @cs: One area of memory
- * @ct: Another area of memory
- * @coun
By moving the function into an archive, x86 doesn't need to announce
anymore that is has its own implementation - symbol resolution by the
linker will now guarantee that the generic function remains unused, and
the forwarding to the compiler built-in gets done by the common header
anyway.
Signed-o
By moving the function into an archive, x86 doesn't need to announce
anymore that is has its own implementation - symbol resolution by the
linker will now guarantee that the generic function remains unused, and
the forwarding to the compiler built-in gets done by the common header
anyway.
Signed-o
By moving the function into an archive, x86 doesn't need to announce
anymore that is has its own implementation - symbol resolution by the
linker will now guarantee that the generic function remains unused, and
the forwarding to the compiler built-in gets done by the common header
anyway.
Signed-o
These standard functions shouldn't need custom declarations. The only
case where redundancy might be needed is if there were inline functions
there. But we don't have any here (anymore). Prune the per-arch headers
of duplicate declarations while moving the asm/string.h inclusion past
the declaratio
These were built for 32-bit architectures only (the same code could,
with some tweaking, sensibly be used to provide TI-mode helpers on
64-bit arch-es) - retain this property, while still avoiding to have
a CU without any contents at all. For this, Arm's CONFIG_64BIT gets
generalized.
Signed-off-b
Make this a separate archive member under lib/. While doing so, don't
move latently broken x86 assembly though: Fix the constraints, such
that properly extending inputs to 64-bit won't just be a side effect of
needing to copy registers, and such that we won't fail to clobber %rdx.
Signed-off-by: J
1 - 100 of 142 matches
Mail list logo