[libvirt test] 158415: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158415 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/158415/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[xen-unstable test] 158409: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158409 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/158409/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-thunderx 8 xen-boot fail REGR. vs. 158290 test-arm64-arm64-x

RE: [PATCH V4 11/24] xen/mm: Make x86's XENMEM_resource_ioreq_server handling common

2021-01-13 Thread Wei Chen
Hi Oleksandr, > -Original Message- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: 2021年1月13日 5:52 > To: xen-devel@lists.xenproject.org > Cc: Julien Grall ; Jan Beulich ; > Andrew Cooper ; Roger Pau Monné > ; Wei Liu ; George Dunlap > ; Ian Jackson ; Julien Grall > ; Stefano

[xen-unstable-smoke test] 158412: tolerable all pass - PUSHED

2021-01-13 Thread osstest service owner
flight 158412 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/158412/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [PATCH V4 00/24] IOREQ feature (+ virtio-mmio) on Arm

2021-01-13 Thread Wei Chen
Hi Oleksandr, I have tested this series with latest master and staging branches. The virtio function works well for Arm as v3. For latest staging branch, it needs a tiny rebase for: 0011 xen/mm: Make x86's XENMEM_resource_ioreq_server handling common As staging branch changes rapidly, I had done

Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-13 Thread Jakub Kicinski
On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > Resending the stragglers again. > > > This set is part of a larger effort attempting to clean-up W=1 > > kern

[qemu-mainline test] 158406: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158406 qemu-mainline real [real] flight 158411 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/158406/ http://logs.test-lab.xenproject.org/osstest/logs/158411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 3/3] objtool: Support stack layout changes in alternatives

2021-01-13 Thread Josh Poimboeuf
On Fri, Jan 08, 2021 at 09:15:43AM +0100, Miroslav Benes wrote: > > That comment is indeed now obsolete. I can squash something like so: > > > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > > index 81d56fdef1c3..ce67437aaf3f 100644 > > --- a/tools/objtool/check.c > > +++ b/tools/o

RE: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-13 Thread Wei Chen
Hi Julien, > -Original Message- > From: Julien Grall > Sent: 2021年1月14日 2:30 > To: Wei Chen ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org > Cc: Bertrand Marquis ; Penny Zheng > ; Jiamei Xie ; nd > > Subject: Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for

Re: [PATCH 3/4] xen/domctl: Introduce fault_ttl

2021-01-13 Thread Andrew Cooper
On 05/01/2021 16:39, Jan Beulich wrote: > On 23.12.2020 17:34, Andrew Cooper wrote: >> To inject a simulated resource failure, for testing purposes. >> >> Given a specific set of hypercall parameters, the failure is in a repeatable >> position, for the currently booted Xen. The exact position of f

Re: [PATCH 1/4] xen/dmalloc: Introduce dmalloc() APIs

2021-01-13 Thread Andrew Cooper
On 05/01/2021 15:56, Jan Beulich wrote: > On 23.12.2020 17:34, Andrew Cooper wrote: >> RFC: >> * This probably wants to be less fatal in release builds > I'm not even convinced this wants to be a panic() in debug builds. Any memory leak spotted by this is an XSA, except in the narrow case of bein

Re: [PATCH 1/5] common: don't (kind of) open-code rcu_lock_domain_by_any_id()

2021-01-13 Thread Andrew Cooper
On 05/01/2021 14:17, Jan Beulich wrote: >>> --- >>> Besides get_pg_owner(), gnttab_copy_lock_domain() has similar strange(?) >>> behavior: They accept DOMID_SELF, but not the resolved ID of the caller. >> I queried that behaviour years and years ago. >> >> According to Keir, it is part of the attem

Re: [PATCH 3/5] argo: don't pointlessly use get_domain_by_id()

2021-01-13 Thread Christopher Clark
On Tue, Jan 5, 2021 at 5:26 AM Jan Beulich wrote: > > For short-lived references rcu_lock_domain_by_id() is the better > (slightly cheaper) alternative. This should scale better than the existing use of get_domain_by_id. I actually found it pretty hard to study the code for the effects of switch

[xen-unstable-smoke test] 158408: tolerable all pass - PUSHED

2021-01-13 Thread osstest service owner
flight 158408 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/158408/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk wrote: > > On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné wrote: > > > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > > > I have some laptops running OpenXT where the USB controller and NIC > > > share an interrupt, and I assig

Re: [PATCH] kconfig: ensure strndup() declaration is visible

2021-01-13 Thread Andrew Cooper
On 11/01/2021 14:42, Jan Beulich wrote: > Its guard was updated such that it is visible by default when POSIX 2008 > was adopted by glibc. It's not visible by default on older glibc. > > Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4") > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper

Re: Purpose of translate MSI interrupt into INTx for guest passthrough

2021-01-13 Thread Andrew Cooper
On 12/01/2021 15:51, Roger Pau Monné wrote: > On Tue, Jan 12, 2021 at 09:48:17AM -0500, Jason Andryuk wrote: >> On Tue, Jan 12, 2021 at 9:25 AM Roger Pau Monné wrote: >>> Dropping Qing He as this address bounces. >>> >>> On Tue, Jan 12, 2021 at 03:10:57PM +0100, Roger Pau Monné wrote: Hello,

[linux-linus test] 158401: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158401 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/158401/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

[xen-unstable test] 158399: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158399 xen-unstable real [real] flight 158407 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/158399/ http://logs.test-lab.xenproject.org/osstest/logs/158407/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH] x86/mem_sharing: fix wrong field name used in 2c5119d

2021-01-13 Thread Andrew Cooper
On 13/01/2021 02:28, Tamas K Lengyel wrote: > The arch_domain struct has "msr", not "msrs". > > Reported-by: Andrew Cooper > Signed-off-by: Tamas K Lengyel > --- > I've build tested originally with "msr" but typod "msrs" when creating the > patch that was sent in. Sorry for the noise. Acked-by:

Re: [PATCH] memory: avoid pointless continuation in xenmem_add_to_physmap()

2021-01-13 Thread Julien Grall
Hi Jan, On 04/12/2020 10:43, Jan Beulich wrote: Adjust so we uniformly avoid needlessly arranging for a continuation on the last iteration. Fixes: 5777a3742d88 ("IOMMU: hold page ref until after deferred TLB flush") I view this patch as an optimization because there is nothing wrong with the

Re: [PATCH 2/3] tools: Move xen-access from tests/ to misc/

2021-01-13 Thread Andrew Cooper
On 13/01/2021 18:50, Tamas K Lengyel wrote: > On Wed, Jan 13, 2021 at 7:35 AM Andrew Cooper > wrote: >> xen-access is a tool for a human to use, rather than a test. Move it >> into misc/ as a more appropriate location to live. >> >> Move the -DXC_WANT_COMPAT_DEVICEMODEL_API from CFLAGS into xen-

[PING] Re: [PATCH v2] xen/irq: Propagate the error from init_one_desc_irq() in init_*_irq_data()

2021-01-13 Thread Julien Grall
Hi all, On 28/11/2020 11:36, Julien Grall wrote: From: Julien Grall init_one_desc_irq() can return an error if it is unable to allocate memory. While this is unlikely to happen during boot (called from init_{,local_}irq_data()), it is better to harden the code by propagting the return value.

Re: [PATCH 2/3] tools: Move xen-access from tests/ to misc/

2021-01-13 Thread Tamas K Lengyel
On Wed, Jan 13, 2021 at 7:35 AM Andrew Cooper wrote: > > xen-access is a tool for a human to use, rather than a test. Move it > into misc/ as a more appropriate location to live. > > Move the -DXC_WANT_COMPAT_DEVICEMODEL_API from CFLAGS into xen-access.c itself > to avoid adding Makefile complexi

Re: [PATCH v2 2/2] mm: split out mfn_t / gfn_t / pfn_t definitions and helpers

2021-01-13 Thread Julien Grall
Hi Jan, On 05/01/2021 12:38, Jan Beulich wrote: xen/mm.h has heavy dependencies, while in a number of cases only these type definitions are needed. This separation then also allows pulling in these definitions when including xen/mm.h would cause cyclic dependencies. Replace xen/mm.h inclusion w

Re: [PATCH v2 1/2] include: don't use asm/page.h from common headers

2021-01-13 Thread Julien Grall
Hi Jan, On 05/01/2021 12:37, Jan Beulich wrote: Doing so limits what can be done in (in particular included by) this per- arch header. Abstract out page shift/size related #define-s, which is all the respective headers care about. Extend the replacement / removal to some x86 headers as well; som

Re: [PATCH v2] lib: drop (replace) debug_build()

2021-01-13 Thread Julien Grall
Hi Jan, On 23/12/2020 16:05, Jan Beulich wrote: Its expansion shouldn't be tied to NDEBUG - down the road we may want to allow enabling assertions independently of CONFIG_DEBUG. Replace the few uses by a new xen_build_info() helper, subsuming gcov_string at the same time (while replacing the sta

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > > On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné > > wrote: > > > > > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > > > From: Roger Pau Monne > > >

Re: [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support.

2021-01-13 Thread Christoph Hellwig
On Wed, Jan 13, 2021 at 06:27:08PM +, Robin Murphy wrote: >> Can we hook in somewhat lower level in the dma-direct code so that all >> the remapping in dma-direct can be reused instead of duplicated? That >> also becomes important if we want to use non-remapping uncached support, >> e.g. on mi

Re: [PATCH v2 2/2] xen/arm: Add defensive barrier in get_cycles for Arm64

2021-01-13 Thread Julien Grall
On 09/01/2021 12:16, Wei Chen wrote: HI Julien, Hi Wei, -Original Message- From: Julien Grall Sent: 2021年1月8日 19:56 To: Wei Chen ; xen-devel@lists.xenproject.org; sstabell...@kernel.org Cc: Bertrand Marquis ; Penny Zheng ; Jiamei Xie ; nd Subject: Re: [PATCH v2 2/2] xen/arm: Add

Re: [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support.

2021-01-13 Thread Robin Murphy
On 2021-01-13 12:48, Christoph Hellwig wrote: +#ifdef CONFIG_SWIOTLB + if (unlikely(dev->dma_io_tlb_mem)) + return swiotlb_alloc(dev, size, dma_handle, attrs); +#endif Another place where the dma_io_tlb_mem is useful to avoid the ifdef. -phys_addr_t swiotlb_tbl_map_single(

Re: Inconsistent console behavior during HVM direct boot

2021-01-13 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 10:48:02AM -0500, Tamas K Lengyel wrote: > On Wed, Jan 13, 2021 at 8:18 AM Roger Pau Monné wrote: > > > > On Tue, Jan 12, 2021 at 09:54:18PM -0500, Tamas K Lengyel wrote: > > > While direct booting a Linux kernel into an HVM VM no console output > > > is received if serial=

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote: > On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné wrote: > > > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > > From: Roger Pau Monne > > > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > > > > > Current inte

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Robin Murphy
On 2021-01-13 17:43, Florian Fainelli wrote: On 1/13/21 7:27 AM, Robin Murphy wrote: On 2021-01-13 13:59, Nicolas Saenz Julienne wrote: Hi All, On Tue, 2021-01-12 at 16:03 -0800, Florian Fainelli wrote: On 1/5/21 7:41 PM, Claire Chang wrote: Add the initialization function to create restrict

Re: Proposal - lightweight auto test binaries

2021-01-13 Thread Marek Marczykowski-Górecki
On Wed, Jan 13, 2021 at 03:45:10PM +, Andrew Cooper wrote: > On 12/01/2021 17:35, Ian Jackson wrote: > > * When appropriately configured, the xen.git build system > >will ship them into dist/install/usr/local/ > > > > * There will be a specific directory containing tests which > >

Re: [PATCH] xen/iommu: smmu: Use 1UL << 31 rather than 1 << 31

2021-01-13 Thread Julien Grall
Hi Hans, Sorry for the late reply. On 24/12/2020 19:48, Hans van Kranenburg wrote: On 12/24/20 4:24 PM, Julien Grall wrote: From: Julien Grall Replace all the use of 1 << 31 with 1UL << 31 to prevent undefined behavior in the SMMU driver. You're replacing it by 1U, not 1UL, in the patch be

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Florian Fainelli
On 1/13/21 7:27 AM, Robin Murphy wrote: > On 2021-01-13 13:59, Nicolas Saenz Julienne wrote: >> Hi All, >> >> On Tue, 2021-01-12 at 16:03 -0800, Florian Fainelli wrote: >>> On 1/5/21 7:41 PM, Claire Chang wrote: Add the initialization function to create restricted DMA pools from matching

Re: [PATCH v10 06/25] tools/xenstore: add live update command to xenstore-control

2021-01-13 Thread Edwin Torok
On Wed, 2021-01-13 at 17:34 +0100, Jürgen Groß wrote: > On 06.01.21 15:42, Edwin Torok wrote: > > [...] > > > > I'd prefer it if there was a more asynchronous protocol available > > for > > live-update: > > * the live-update on its own queues up the live update request and > > returns a generation

Re: [PATCH v2] xen/arm: don't read aarch32 regs when aarch32 isn't available

2021-01-13 Thread Julien Grall
Hi Stefano, I think you forgot to update the title to say the state is EL0. On 12/01/2021 23:44, Stefano Stabellini wrote: Don't read aarch32 system registers at boot time when the aarch32 state is not available at EL0. They are UNKNOWN, so it is not useful to read them. Moreover, on Cavium Th

Re: Proposal - lightweight auto test binaries

2021-01-13 Thread Ian Jackson
Andrew Cooper writes ("Re: Proposal - lightweight auto test binaries"): > I've submitted > https://lore.kernel.org/xen-devel/20210113123455.23209-1-andrew.coop...@citrix.com/T/#u > to clean up the not-really-tests from the tests dir. Yay. > This leaves us with cpu-policy, depriv, mce-test, vhpet,

[PATCH 2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2021-01-13 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed

[PATCH v2 0/7] Rid W=1 warnings in Ethernet

2021-01-13 Thread Lee Jones
Resending the stragglers again. This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with

Re: [PATCH v10 06/25] tools/xenstore: add live update command to xenstore-control

2021-01-13 Thread Jürgen Groß
On 06.01.21 15:42, Edwin Torok wrote: On Tue, 2020-12-15 at 17:35 +0100, Juergen Gross wrote: [...] +static int live_update_start(struct xs_handle *xsh, bool force, unsigned int to) +{ +    int len = 0; +    char *buf = NULL, *ret; +    time_t time_start; + +    if (asprintf(&ret, "%u", to) < 0

Re: Proposal - lightweight auto test binaries

2021-01-13 Thread Jürgen Groß
On 13.01.21 16:45, Andrew Cooper wrote: I reckon for a first stab, trying to convert xenstore and cpu-policy to the "simple" API would be a good start.  They both have trivial build requirements, and would be trivial to convert to an exit code based protocol, which would get us content to run for

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Jason Andryuk
On Wed, Jan 13, 2021 at 8:11 AM Roger Pau Monné wrote: > > On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > > From: Roger Pau Monne > > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > > > Current interrupt pass though code will setup a timer for each > > > interrupt injected t

Re: Inconsistent console behavior during HVM direct boot

2021-01-13 Thread Tamas K Lengyel
On Wed, Jan 13, 2021 at 8:18 AM Roger Pau Monné wrote: > > On Tue, Jan 12, 2021 at 09:54:18PM -0500, Tamas K Lengyel wrote: > > While direct booting a Linux kernel into an HVM VM no console output > > is received if serial="pty" is set in the VM config but the kernel > > command line specifies "co

Re: Proposal - lightweight auto test binaries

2021-01-13 Thread Andrew Cooper
On 12/01/2021 17:35, Ian Jackson wrote: > Andy and I were discussing some new tests he's written which (will) > live in xen.git and which we would like to wire into osstest. > > We came up with the following proposal (I have refined some of the > details beyond what we discussed on IRC): > > * Tes

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Robin Murphy
On 2021-01-13 13:59, Nicolas Saenz Julienne wrote: Hi All, On Tue, 2021-01-12 at 16:03 -0800, Florian Fainelli wrote: On 1/5/21 7:41 PM, Claire Chang wrote: Add the initialization function to create restricted DMA pools from matching reserved-memory nodes in the device tree. Signed-off-by: Cl

PCI passthrough regression on BSD* guests since 4.13.1

2021-01-13 Thread Samuel Verschelde
Hi list. XCP-ng users have reported a regression with PCI passthrough in XCP-ng 8.2. We're using Xen 4.13.1 + patches (like Citrix Hypervisor 8.2 does) [1]. Symptoms: after a shutdown or reboot of the VM, the passed-through device can't be passed-through anymore. We've build various versio

Re: [PATCH v4 0/5] Xen INTX/GSI event channel delivery fixes

2021-01-13 Thread Jürgen Groß
On 13.01.21 14:26, David Woodhouse wrote: Fix various breakages with INTX/GSI event channel interrupt delivery, and add a command line option to test it so that it hopefully doesn't get so broken again. Karim attempted to rip this out in 2017 but put it back because it's still necessary with old

Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

2021-01-13 Thread Oleksandr
On 12.01.21 13:58, Jan Beulich wrote: Hi Jan. On 11.01.2021 09:23, Oleksandr wrote: On 11.01.21 09:41, Jan Beulich wrote: If you could also provide your exact .config, I could see whether I can repro here with some of the gcc5 versions I have laying around. Please see attached Builds perf

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Nicolas Saenz Julienne
Hi All, On Tue, 2021-01-12 at 16:03 -0800, Florian Fainelli wrote: > On 1/5/21 7:41 PM, Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > > matching reserved-memory nodes in the device tree. > > > > Signed-off-by: Claire Chang > > --- > >  include/linu

[qemu-mainline test] 158396: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158396 qemu-mainline real [real] flight 158405 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/158396/ http://logs.test-lab.xenproject.org/osstest/logs/158405/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH 3/3] tools: Move memshrtool from tests/ to misc/

2021-01-13 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH 3/3] tools: Move memshrtool from tests/ to misc/"): > On 13/01/2021 13:01, Ian Jackson wrote: > > Andrew Cooper writes ("[PATCH 3/3] tools: Move memshrtool from tests/ to > > misc/"): > >> memshrtool is a tool for a human to use, rather than a test. Move it into

[PATCH v4 0/5] Xen INTX/GSI event channel delivery fixes

2021-01-13 Thread David Woodhouse
Fix various breakages with INTX/GSI event channel interrupt delivery, and add a command line option to test it so that it hopefully doesn't get so broken again. Karim attempted to rip this out in 2017 but put it back because it's still necessary with older versions of Xen. This fixes it properly,

[PATCH v4 1/5] xen: Fix event channel callback via INTX/GSI

2021-01-13 Thread David Woodhouse
From: David Woodhouse For a while, event channel notification via the PCI platform device has been broken, because we attempt to communicate with xenstore before we even have notifications working, with the xs_reset_watches() call in xs_init(). We tend to get away with this on Xen versions below

[PATCH v4 2/5] xen: Set platform PCI device INTX affinity to CPU0

2021-01-13 Thread David Woodhouse
From: David Woodhouse With INTX or GSI delivery, Xen uses the event channel structures of CPU0. If the interrupt gets handled by Linux on a different CPU, then no events are seen as pending. Rather than introducing locking to allow other CPUs to process CPU0's events, just ensure that the PCI in

[PATCH v4 3/5] x86/xen: Add xen_no_vector_callback option to test PCI INTX delivery

2021-01-13 Thread David Woodhouse
From: David Woodhouse It's useful to be able to test non-vector event channel delivery, to make sure Linux will work properly on older Xen which doesn't have it. It's also useful for those working on Xen and Xen-compatible hypervisors, because there are guest kernels still in active use which us

[PATCH v4 5/5] x86/xen: Fix xen_hvm_smp_init() when vector callback not available

2021-01-13 Thread David Woodhouse
From: David Woodhouse Only the IPI-related functions in the smp_ops should be conditional on the vector callback being available. The rest should still happen: • xen_hvm_smp_prepare_boot_cpu() This function does two things, both of which should still happen if there is no vector callback

[PATCH v4 4/5] x86/xen: Don't register Xen IPIs when they aren't going to be used

2021-01-13 Thread David Woodhouse
From: David Woodhouse In the case where xen_have_vector_callback is false, we still register the IPI vectors in xen_smp_intr_init() for the secondary CPUs even though they aren't going to be used. Stop doing that. Signed-off-by: David Woodhouse Reviewed-by: Boris Ostrovsky --- arch/x86/xen/en

Re: [PATCH 3/3] tools: Move memshrtool from tests/ to misc/

2021-01-13 Thread Andrew Cooper
On 13/01/2021 13:01, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH 3/3] tools: Move memshrtool from tests/ to > misc/"): >> memshrtool is a tool for a human to use, rather than a test. Move it into >> misc/ as a more appropriate location to live. Also rename it to >> xen-memshare-tool > Ack

Re: Inconsistent console behavior during HVM direct boot

2021-01-13 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 09:54:18PM -0500, Tamas K Lengyel wrote: > While direct booting a Linux kernel into an HVM VM no console output > is received if serial="pty" is set in the VM config but the kernel > command line specifies "console=hvc0". If "console=ttyS0" is specified > then the console ou

Re: [PATCH 1/3] tools/tests: Drop obsolete running scripts

2021-01-13 Thread Andrew Cooper
On 13/01/2021 13:03, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH 1/3] tools/tests: Drop obsolete running > scripts"): >> The python unit tests were dropped in Xen 4.12 due to being obsolete, but the >> scripts to run the tests were missed. Clean up .gitignore as well > I'm happy with this

Re: [PATCH] x86/dpci: remove the dpci EOI timer

2021-01-13 Thread Roger Pau Monné
On Wed, Jan 13, 2021 at 06:21:03AM +, Tian, Kevin wrote: > > From: Roger Pau Monne > > Sent: Wednesday, January 13, 2021 1:33 AM > > > > Current interrupt pass though code will setup a timer for each > > interrupt injected to the guest that requires an EOI from the guest. > > Such timer would

Re: [PATCH 2/3] tools: Move xen-access from tests/ to misc/

2021-01-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH 2/3] tools: Move xen-access from tests/ to misc/"): > xen-access is a tool for a human to use, rather than a test. Move it > into misc/ as a more appropriate location to live. > > Move the -DXC_WANT_COMPAT_DEVICEMODEL_API from CFLAGS into xen-access.c itself > to av

Re: [PATCH 1/3] tools/tests: Drop obsolete running scripts

2021-01-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH 1/3] tools/tests: Drop obsolete running scripts"): > The python unit tests were dropped in Xen 4.12 due to being obsolete, but the > scripts to run the tests were missed. Clean up .gitignore as well I'm happy with this part. > Also drop the libxenctrl {C,LD}FLAGS ad

Re: [PATCH 3/3] tools: Move memshrtool from tests/ to misc/

2021-01-13 Thread Ian Jackson
Andrew Cooper writes ("[PATCH 3/3] tools: Move memshrtool from tests/ to misc/"): > memshrtool is a tool for a human to use, rather than a test. Move it into > misc/ as a more appropriate location to live. Also rename it to > xen-memshare-tool Acked-by: Ian Jackson

Re: [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support.

2021-01-13 Thread Christoph Hellwig
> +#ifdef CONFIG_SWIOTLB > + if (unlikely(dev->dma_io_tlb_mem)) > + return swiotlb_alloc(dev, size, dma_handle, attrs); > +#endif Another place where the dma_io_tlb_mem is useful to avoid the ifdef. > -phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t > orig_ad

Re: [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available

2021-01-13 Thread Christoph Hellwig
> +#ifdef CONFIG_SWIOTLB > + if (unlikely(swiotlb_force == SWIOTLB_FORCE) || dev->dma_io_tlb_mem) > return swiotlb_map(dev, phys, size, dir, attrs); > +#endif Please provide a wrapper for the dev->dma_io_tlb_mem check that always returns false if the per-device swiotlb support is

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Christoph Hellwig
> +#ifdef CONFIG_SWIOTLB > + struct io_tlb_mem *dma_io_tlb_mem; > #endif Please add a new config option for this code instead of always building it when swiotlb is enabled. > +static int swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, > +

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Christoph Hellwig
On Wed, Jan 13, 2021 at 01:29:05PM +0100, Greg KH wrote: > > > Why does this have to be added here? Shouldn't the platform-specific > > > code handle it instead? > > > > The whole code added here is pretty generic. What we need to eventually > > do, though is to add a separate dma_device instead

[PATCH 1/3] tools/tests: Drop obsolete running scripts

2021-01-13 Thread Andrew Cooper
The python unit tests were dropped in Xen 4.12 due to being obsolete, but the scripts to run the tests were missed. Clean up .gitignore as well Also drop the libxenctrl {C,LD}FLAGS adjustments in the Makefile. This logic isn't used, and isn't appropriate even in principle, as there are tests in

[PATCH 2/3] tools: Move xen-access from tests/ to misc/

2021-01-13 Thread Andrew Cooper
xen-access is a tool for a human to use, rather than a test. Move it into misc/ as a more appropriate location to live. Move the -DXC_WANT_COMPAT_DEVICEMODEL_API from CFLAGS into xen-access.c itself to avoid adding Makefile complexity. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Tamas

[PATCH 3/3] tools: Move memshrtool from tests/ to misc/

2021-01-13 Thread Andrew Cooper
memshrtool is a tool for a human to use, rather than a test. Move it into misc/ as a more appropriate location to live. Also rename it to xen-memshare-tool Signed-off-by: Andrew Cooper --- CC: Ian Jackson I'm debating dropping the tool suffix, because I don't think that's much help either. --

[PATCH 0/3] Cleanup to tools/tests

2021-01-13 Thread Andrew Cooper
Move two non-test things out of tests/ and drop some obsolete infrastructure. Andrew Cooper (3): tools/tests: Drop obsolete running scripts tools: Move xen-access from tests/ to misc/ tools: Move memshrtool from tests/ to misc/ .gitignore | 5 -- to

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote: > On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -413,6 +413,7 @@ struct dev_links_info { > > > * @dma_pools: Dma pools (if dma'ble device)

Re: [PATCH v3 1/5] xen: Fix event channel callback via INTX/GSI

2021-01-13 Thread David Woodhouse
On Wed, 2021-01-13 at 12:20 +0100, Jürgen Groß wrote: > > /home/gross/korg/src/drivers/xen/xenbus/xenbus_probe.c: In function > 'xenbus_probe_initcall': > /home/gross/korg/src/drivers/xen/xenbus/xenbus_probe.c:711:41: > error: > 'xen_have_vector_callback' undeclared (first use in this function);

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Christoph Hellwig
On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -413,6 +413,7 @@ struct dev_links_info { > > * @dma_pools: Dma pools (if dma'ble device). > > * @dma_mem: Internal for coherent mem override. > > * @cma_

Re: [RFC PATCH v3 1/6] swiotlb: Add io_tlb_mem struct

2021-01-13 Thread Christoph Hellwig
On Wed, Jan 06, 2021 at 11:41:19AM +0800, Claire Chang wrote: > Added a new struct, io_tlb_mem, as the IO TLB memory pool descriptor and > moved relevant global variables into that struct. > This will be useful later to allow for restricted DMA pool. I like where this is going, but a few comments.

Re: [PATCH v2] xen/privcmd: allow fetching resource sizes

2021-01-13 Thread Jürgen Groß
On 12.01.21 12:53, Roger Pau Monne wrote: Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and addr = 0 in order to fetch the size of a specific resource. Add a shortcut to the default map resource path, since fetching the size requires no address to be passed in, and thus no VMA

Re: [PATCH v3 1/5] xen: Fix event channel callback via INTX/GSI

2021-01-13 Thread Jürgen Groß
On 06.01.21 16:39, David Woodhouse wrote: From: David Woodhouse For a while, event channel notification via the PCI platform device has been broken, because we attempt to communicate with xenstore before we even have notifications working, with the xs_reset_watches() call in xs_init(). We tend

Re: [PATCH RFC 0/3] xen: add hypfs per-domain abi-features

2021-01-13 Thread Jürgen Groß
On 08.01.21 16:44, Jan Beulich wrote: On 09.12.2020 17:16, Juergen Gross wrote: This small series is meant as an example how to add further dynamical directories to hypfs. It can be used to replace Paul's current approach to specify ABI-features via domain create flags and replace those by hypfs

[xen-unstable-coverity test] 158404: all pass - PUSHED

2021-01-13 Thread osstest service owner
flight 158404 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/158404/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 414be7b66349e7dca42bc1fd47c2b2f5b2d27432 baseline version: xen ce59

Re: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-13 Thread Manuel Bouyer
On Wed, Jan 13, 2021 at 09:22:38AM +, Christian Lindig wrote: > Acked-by: Christian Lindig thanks. What should I do now, submit a new patch with this tag, or just wait for it to be commited ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-13 Thread Christian Lindig
Acked-by: Christian Lindig From: Manuel Bouyer Sent: 12 January 2021 18:12 To: xen-devel@lists.xenproject.org Cc: Manuel Bouyer; Christian Lindig; David Scott; Ian Jackson; Wei Liu Subject: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h From: Manuel

[libvirt test] 158397: regressions - FAIL

2021-01-13 Thread osstest service owner
flight 158397 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/158397/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

Re: [PATCH v2] xen/arm: don't read aarch32 regs when aarch32 isn't available

2021-01-13 Thread Bertrand Marquis
Hi Stefano, > On 12 Jan 2021, at 23:44, Stefano Stabellini wrote: > > Don't read aarch32 system registers at boot time when the aarch32 state > is not available at EL0. They are UNKNOWN, so it is not useful to read > them. Moreover, on Cavium ThunderX reading ID_PFR2_EL1 causes a Xen > crash.

Re: [PATCH v7 0/7] xl / libxl: named PCI pass-through devices

2021-01-13 Thread Oleksandr Andrushchenko
Hi, Wei! Is this series good to go? Could you please tell if it breaks anything? Thank you in advance, Oleksandr On 1/5/21 7:46 PM, Paul Durrant wrote: > From: Paul Durrant > > These are re-worked versions of the remaining patches from v6 of the series > that were reverted by commit ac6a0af387