> -Original Message-
> From: Andrew Cooper
> Sent: 23 November 2020 22:18
> To: Paul Durrant ; xen-devel@lists.xenproject.org
> Cc: Paul Durrant ; Anthony PERARD
> ; Christian Lindig
> ; David Scott ; George Dunlap
> ; Ian Jackson ; Nick Rosbrook
> ;
> Wei Liu
> Subject: Re: [PATCH v3 0
flight 156972 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156972/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332
test-amd64-i386-xl-
The queue for a fifo event is depending on the vcpu_id and the
priority of the event. When sending an event it might happen the
event needs to change queues and the old queue needs to be kept for
keeping the links between queue elements intact. For this purpose
the event channel contains last_prior
Two cpus entering evtchn_fifo_set_pending() for the same event channel
can race in case the first one gets interrupted after setting
EVTCHN_FIFO_PENDING and when the other one manages to set
EVTCHN_FIFO_LINKED before the first one is testing that bit. This can
lead to evtchn_check_pollers() being c
This is an add-on of my event channel locking series.
It is a resend of the single patch not having been applied from my
V6 series (being the reason to name this one V7), plus two patches
addressing issues Jan identified with the previous approach (with
one issue being more a latent one, while the
In order to avoid latent races when updating an event channel put
xen_consumer and pending fields in different bytes.
At the same time move some other fields around to have less implicit
paddings and to keep related fields more closely together.
Signed-off-by: Juergen Gross
---
xen/include/xen/
flight 156970 qemu-mainline real [real]
flight 156976 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/156970/
http://logs.test-lab.xenproject.org/osstest/logs/156976/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be
On Mon, 23 Nov 2020, Joe Perches wrote:
> On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> > it's not for me to prove that such patches don't affect code
> > generation. That's for the patch author and (unfortunately) for
> > reviewers.
>
> Ideally, that proof would be provided by the c
On Sun, Nov 22, 2020 at 8:17 AM Kees Cook wrote:
>
> On Fri, Nov 20, 2020 at 11:51:42AM -0800, Jakub Kicinski wrote:
> > If none of the 140 patches here fix a real bug, and there is no change
> > to machine code then it sounds to me like a W=2 kind of a warning.
>
> FWIW, this series has found at
On Mon, 23 Nov 2020, Miguel Ojeda wrote:
> On Mon, 23 Nov 2020, Finn Thain wrote:
>
> > On Sun, 22 Nov 2020, Miguel Ojeda wrote:
> >
> > >
> > > It isn't that much effort, isn't it? Plus we need to take into
> > > account the future mistakes that it might prevent, too.
> >
> > We should als
On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> it's not for me to prove that such patches don't affect code
> generation. That's for the patch author and (unfortunately) for reviewers.
Ideally, that proof would be provided by the compilation system itself
and not patch authors nor reviewe
On 23/10/2020 11:17, Jan Beulich wrote:
> ... into its own CU, to build it into an archive.
>
> Signed-off-by: Jan Beulich
> ---
> xen/common/lib.c | 39 --
> xen/lib/Makefile | 1 +
> xen/lib/parse-size.c | 50
On 23/11/2020 22:49, Julien Grall wrote:
> Hi Jan,
>
> On 19/11/2020 10:27, Jan Beulich wrote:
>> On 18.11.2020 19:09, Julien Grall wrote:
>>> On 23/10/2020 11:19, Jan Beulich wrote:
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -12,6 +12,7 @@
#defin
On Mon, 23 Nov 2020, Julien Grall wrote:
> Hi Stefano,
>
> On 23/11/2020 22:27, Stefano Stabellini wrote:
> > On Fri, 20 Nov 2020, Julien Grall wrote:
> > > > >/*
> > > > > * For arm32, page-tables are different on each CPUs. Yet, they
> > > > > share
> > > > > @@ -1265,14 +1287,43
On Mon, 23 Nov 2020, Jan Beulich wrote:
> There's no point wrapping the function invocation when
> - the function body is already suitably wrapped,
> - the function itself is unconditionally available.
>
> Reported-by: Julien Grall
> Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
On Mon, 23 Nov 2020, Jan Beulich wrote:
> Pure code motion (plus the addition of "#ifdef CONFIG_X86); no
> functional change intended.
>
> Reported-by: Julien Grall
> Signed-off-by: Jan Beulich
Great cleanup
Reviewed-by: Stefano Stabellini
> ---
> v2: Re-base over new earlier patch.
>
> --
On Mon, 23 Nov 2020, Jan Beulich wrote:
> Pure code motion; no functional change intended.
>
> Signed-off-by: Jan Beulich
Reviewed-by: Stefano Stabellini
> ---
> v2: New.
>
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -153,312 +153,6 @@ struct ns16550_config_par
Hi Stefano,
On 23/11/2020 22:27, Stefano Stabellini wrote:
On Fri, 20 Nov 2020, Julien Grall wrote:
/*
* For arm32, page-tables are different on each CPUs. Yet, they
share
@@ -1265,14 +1287,43 @@ static int xen_pt_update(unsigned long virt,
spin_lock(&xen_pt_lock);
-
On Fri, Nov 20, 2020 at 04:36:26PM -0500, boris.ostrov...@oracle.com wrote:
>
> On 11/20/20 1:32 PM, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > by explicitly adding a break statement instead of letting the code fall
> > through to th
Hi Jan,
On 19/11/2020 10:27, Jan Beulich wrote:
On 18.11.2020 19:09, Julien Grall wrote:
On 23/10/2020 11:19, Jan Beulich wrote:
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -12,6 +12,7 @@
#define inline__inline__
#define always_inline __inline__ __at
On Fri, 20 Nov 2020, Jan Beulich wrote:
> On 19.11.2020 22:40, Stefano Stabellini wrote:
> > On Thu, 19 Nov 2020, Jan Beulich wrote:
> >> On 18.11.2020 22:00, Stefano Stabellini wrote:
> >>> On Wed, 18 Nov 2020, Jan Beulich wrote:
> On 18.11.2020 01:50, Stefano Stabellini wrote:
> > 1) It
On Mon, 23 Nov 2020, Jan Beulich wrote:
> Rahul,
>
> On 23.11.2020 12:54, Rahul Singh wrote:
> > Hello Jan,
>
> as an aside - it helps if you also put the addressee of your mail
> on the To list.
>
> >> On 20 Nov 2020, at 12:14 am, Stefano Stabellini
> >> wrote:
> >>
> >> On Thu, 19 Nov 2020,
Hi,
Thanks for your effort!
> -Ursprüngliche Nachricht-
> Von: Julien Grall
> Gesendet: Montag, 23. November 2020 19:42
> An: Rahul Singh ; Leo Krueger
>
> Cc: Stefano Stabellini ; Peng Fan
> ; bru...@xilinx.com; Cornelia Bruelhart
> ; oleksandr_andrushche...@epam.com; xen-
> de...@list
On Fri, 20 Nov 2020, Julien Grall wrote:
> > > /*
> > >* For arm32, page-tables are different on each CPUs. Yet, they
> > > share
> > > @@ -1265,14 +1287,43 @@ static int xen_pt_update(unsigned long virt,
> > > spin_lock(&xen_pt_lock);
> > > -for ( ; addr < addr_end; add
On 23/11/2020 17:44, Paul Durrant wrote:
> From: Paul Durrant
>
> Paul Durrant (23):
> xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
> libxl: make libxl__device_list() work correctly for
> LIBXL__DEVICE_KIND_PCI...
> libxl: Make sure devices added by pci-attach are refl
flight 156964 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156964/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332
test-amd64-i386-xl-
On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote:
> On Mon, Nov 23, 2020 at 4:58 PM James Bottomley
> wrote:
> > Well, I used git. It says that as of today in Linus' tree we have
> > 889 patches related to fall throughs and the first series went in
> > in october 2017 ... ignoring a couple o
flight 156962 qemu-mainline real [real]
flight 156968 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/156962/
http://logs.test-lab.xenproject.org/osstest/logs/156968/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be
On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote:
> IB/hfi1: Fix fall-through warnings for Clang
> IB/mlx4: Fix fall-through warnings for Clang
> IB/qedr: Fix fall-through warnings for Clang
> RDMA/mlx5: Fix fall-through warnings for Clang
I picked these four to the rdm
On 23.11.20 18:08, Ian Jackson wrote:
George Dunlap writes ("[PATCH] MAINTINERS: Propose Ian Jackson as new release
manager"):
Ian Jackson has agreed to be the release manager for 4.15. Signify
this by giving him maintainership over CHANGELOG.md.
Acked-by: Ian Jackson
Obviously that signif
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley
wrote:
>
> Well, I used git. It says that as of today in Linus' tree we have 889
> patches related to fall throughs and the first series went in in
> october 2017 ... ignoring a couple of outliers back to February.
I can see ~10k insertions over ~1
On 23/11/2020 11:41, Rahul Singh wrote:
Hello ,
Hi Rahul,
On 22 Nov 2020, at 10:55 pm, Leo Krueger wrote:
root@kontron-sal28:~# ip link set up dev gbe0
(XEN) vgic-v3-its.c:902:d0v0 vITS cmd 0x0c: 0017000c 0001
(XEN) vgic-v3-its.c:902
On 22/11/2020 22:55, Leo Krueger wrote:
Hi Julien,
Hi Leo,
finally I could try out what you suggested, please find my answers inline.
Thank you for sending the logs!
-Ursprüngliche Nachricht-
Von: Julien Grall
Gesendet: Mittwoch, 18. November 2020 13:24
An: Stefano Stabelli
From: Paul Durrant
... to be used by callers of libxl_device_pci_assignable_list().
Currently there is no API for callers of libxl_device_pci_assignable_list()
to free the list. The xl function pciassignable_list() calls
libxl_device_pci_dispose() on each element of the returned list, but
libxl_
From: Paul Durrant
This patch modifies libxl_device_pci_assignable_add() to take an optional
'name' argument, which (if supplied) is saved into xenstore and can hence be
used to refer to the now-assignable BDF in subsequent operations. To
facilitate this, a new libxl_device_pci_assignable_name2bd
From: Paul Durrant
... to use 'libxl_pci_bdf' rather than 'libxl_device_pci'.
This patch modifies the API and callers accordingly. It also modifies
several internal functions in libxl_pci.c that support the API to also use
'libxl_pci_bdf'.
NOTE: The OCaml bindings are adjusted to contain the in
From: Paul Durrant
... and prepare for adding support for non-positional parsing of 'bdf' and
'vslot' in a subsequent patch.
Also document 'BDF' as a first-class parameter type and fix the documentation
to state that the default value of 'rdm_policy' is actually 'strict', not
'relaxed', as can b
From: Paul Durrant
This patch largely re-writes the code to parse a PCI_SPEC_STRING and enters
it via the newly introduced function. The new parser also deals with 'bdf'
and 'vslot' as non-positional paramaters, as per the documentation in
xl-pci-configuration(5).
The existing xlu_pci_parse_bdf(
From: Paul Durrant
... and use in 'libxl_device_pci'
This patch is preparatory work for restricting the type passed to functions
that only require BDF information, rather than passing a 'libxl_device_pci'
structure which is only partially filled. In this patch only the minimal
mechanical changes
From: Paul Durrant
... and put it into a new xl-pci-configuration(5) manpage, akin to the
xl-network-configration(5) and xl-disk-configuration(5) manpages.
This patch moves the content of the section verbatim. A subsequent patch
will improve the documentation, once it is in its new location.
Si
From: Paul Durrant
This patch adds a 'name' field into the idl for 'libxl_device_pci' and
libxlu_pci_parse_spec_string() is modified to parse the new 'name'
parameter of PCI_SPEC_STRING detailed in the updated documention in
xl-pci-configuration(5).
If the 'name' field is non-NULL then both libx
From: Paul Durrant
Since assignable devices can be named, a subsequent patch will support use
of a PCI_SPEC_STRING containing a 'name' parameter instead of a 'bdf'. In
this case the name will be used to look up the 'bdf' in the list of assignable
(or assigned) devices.
Signed-off-by: Paul Durran
From: Paul Durrant
A subsequent patch will introduce code to allow a name to be specified to
'xl pci-assignable-add' such that the assignable device may be referred to
by than name in subsequent operations.
Signed-off-by: Paul Durrant
---
Cc: Ian Jackson
Cc: Wei Liu
---
docs/man/xl.1.pod.in
From: Paul Durrant
Currently the documentation completely fails to mention the existence of
PCI_SPEC_STRING. This patch tidies things up, specifically clarifying that
'pci-assignable-add/remove' take arguments where as 'pci-attach/detach'
take arguments (which will be enforced in a subsequent
p
From: Paul Durrant
Use of this function is a very inefficient way to check whether a device
has already been assigned.
This patch adds code that saves the domain id in xenstore at the point of
assignment, and removes it again when the device id de-assigned (or the
domain is destroyed). It is the
From: Paul Durrant
A previous patch introduced libxl_device_pci_list_free() which should be used
by callers of libxl_device_pci_list() to properly dispose of the exported
'libxl_device_pci' types and the free the memory holding them. Whilst all
current callers do ensure the memory is freed, only
From: Paul Durrant
... rather than an open-coded equivalent.
This patch tidies up the is_pci_in_array() function, making it take a single
'libxl_device_pci' argument rather than separate domain, bus, device and
function arguments. The already-available COMPARE_PCI() macro can then be
used and it
From: Paul Durrant
... to hold a pointer to the device.
There is already a 'pci' field in 'pci_add_state' so simply use that from
the start. This also allows the 'pci' (#3) argument to be dropped from
do_pci_add().
NOTE: This patch also changes the type of the 'pci_domid' field in
'pci_ad
From: Paul Durrant
The code currently checks explicitly whether the device is already assigned,
but this is actually unnecessary as assigned devices do not form part of
the list returned by libxl_device_pci_assignable_list() and hence the
libxl_pci_assignable() test would have already failed.
Si
From: Paul Durrant
For the purposes of re-binding a device to its previous driver
libxl__device_pci_assignable_add() writes the driver path into xenstore.
This path is then read back in libxl__device_pci_assignable_remove().
The functions that support this writing to and reading from xenstore ar
From: Paul Durrant
Currently libxl__device_pci_add_xenstore() is broken in that does not
update the domain's configuration for the first device added (which causes
creation of the overall backend area in xenstore). This can be easily observed
by running 'xl list -l' after adding a single device:
From: Paul Durrant
Simply spelling correction. Purely cosmetic fix.
Signed-off-by: Paul Durrant
---
Cc: Ian Jackson
Cc: Wei Liu
---
tools/libs/light/libxl_pci.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/libs/light/libxl_pci.c b/tools/l
From: Paul Durrant
Both 'domid' and 'pci' are available in 'pci_remove_state' so there is no
need to also pass them as separate arguments.
Signed-off-by: Paul Durrant
---
Cc: Ian Jackson
Cc: Wei Liu
---
tools/libs/light/libxl_pci.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(
From: Paul Durrant
... devices.
Currently there is an assumption built into libxl__device_list() that device
backends are fully enumarated under the '/libxl' path in xenstore. This is
not the case for PCI backend devices, which are only properly enumerated
under '/local/domain/0/backend'.
This
From: Paul Durrant
The seemingly arbitrary use of 'pci' and 'pcidev' in the code in libxl_pci.c
is confusing and also compromises use of some macros used for other device
types. Indeed it seems that DEFINE_DEVICE_TYPE_STRUCT_X exists solely because
of this duality.
This patch purges use of 'pcid
From: Paul Durrant
Paul Durrant (23):
xl / libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
libxl: make libxl__device_list() work correctly for
LIBXL__DEVICE_KIND_PCI...
libxl: Make sure devices added by pci-attach are reflected in the
config
libxl: add/recover 'rdm_poli
From: Paul Durrant
Other parameters, such as 'msitranslate' and 'permissive' are dealt with
but 'rdm_policy' appears to be have been completely missed.
Signed-off-by: Paul Durrant
---
Cc: Ian Jackson
Cc: Wei Liu
---
tools/libs/light/libxl_pci.c | 9 ++---
1 file changed, 6 insertions(+),
On Mon, Nov 23, 2020 at 06:06:10PM +0100, Roger Pau Monné wrote:
> OK, I'm afraid this is likely too verbose and messes with the timings.
>
> I've been looking (again) into the code, and I found something weird
> that I think could be related to the issue you are seeing, but haven't
> managed to t
Hi George,
NIT: s/MAINTINERS/MAINTAINERS/
On 23/11/2020 16:04, George Dunlap wrote:
Ian Jackson has agreed to be the release manager for 4.15. Signify
this by giving him maintainership over CHANGELOG.md.
Signed-off-by: George Dunlap
Acked-by: Julien Grall
Cheers,
--
Julien Grall
Hi Stefano,
On 20/11/2020 00:14, Stefano Stabellini wrote:
On Thu, 19 Nov 2020, Julien Grall wrote:
On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, wrote:
On Thu, 19 Nov 2020, Rahul Singh wrote:
> > On 19/11/2020 09:53, Jan Beulich wrote:
> >> On 19.11.2020 10:21, Julien Gr
George Dunlap writes ("[PATCH] MAINTINERS: Propose Ian Jackson as new release
manager"):
> Ian Jackson has agreed to be the release manager for 4.15. Signify
> this by giving him maintainership over CHANGELOG.md.
Acked-by: Ian Jackson
Obviously that signifies my consent but I think it needs mo
On 11/22/20 10:22 AM, Joe Perches wrote:
> On Sun, 2020-11-22 at 08:33 -0800, Tom Rix wrote:
>> On 11/21/20 9:10 AM, Joe Perches wrote:
>>> On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
A difficult part of automating commits is composing the subsystem
preamble in the commit
On Mon, Nov 23, 2020 at 03:31:50PM +0100, Manuel Bouyer wrote:
> On Mon, Nov 23, 2020 at 01:51:12PM +0100, Roger Pau Monné wrote:
> > Hm, yes, it's quite weird. Do you know whether a NetBSD kernel can be
> > multibooted from pxelinux with Xen? I would like to see if I can
> > reproduce this myself.
On 23.11.20 17:54, Paul Durrant wrote:
Hi Paul
-Original Message-
From: Oleksandr
Sent: 23 November 2020 15:48
To: Jan Beulich ; Paul Durrant
Cc: Oleksandr Tyshchenko ; Andrew Cooper
;
Roger Pau Monné ; Wei Liu ; George Dunlap
; Ian Jackson ; Julien Grall
; Stefano
Stabellini ; Ju
On Mon, 2020-11-23 at 07:58 -0800, James Bottomley wrote:
> We're also complaining about the inability to recruit maintainers:
>
> https://www.theregister.com/2020/06/30/hard_to_find_linux_maintainers_says_torvalds/
>
> And burn out:
>
> http://antirez.com/news/129
https://www.wired.com/story/o
On Mon, 2020-11-23 at 07:03 -0600, Gustavo A. R. Silva wrote:
> On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote:
> > On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote:
> > > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote:
> > > > On Sun, 2020-11-22 at 10:25 -0800, Joe P
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley
wrote:
>
> On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote:
> > On Sun, Nov 22, 2020 at 11:36 PM James Bottomley
> > wrote:
[cut]
> >
> > Maintainers routinely review 1-line trivial patches, not to mention
> > internal API changes, etc.
>
>
On Mon, Nov 23, 2020 at 4:52 PM Jani Nikula wrote:
>
> On Sat, 21 Nov 2020, James Bottomley
> wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
> >> A difficult part of automating commits is composing the subsystem
> >> preamble in the commit log. For the ongoing effort of a
> -Original Message-
> From: George Dunlap
> Sent: 23 November 2020 16:04
> To: xen-devel@lists.xenproject.org
> Cc: George Dunlap ; Ian Jackson
> ; Wei Liu
> ; Andrew Cooper ; Jan Beulich
> ; Roger Pau
> Monne ; Stefano Stabellini ;
> Julien Grall
> ; Paul Durrant
> Subject: [PATCH] M
On 23/11/2020 16:07, Roger Pau Monné wrote:
> On Mon, Nov 23, 2020 at 04:30:05PM +0100, Jan Beulich wrote:
>> On 23.11.2020 16:24, Roger Pau Monné wrote:
>>> On Mon, Nov 23, 2020 at 01:40:12PM +0100, Jan Beulich wrote:
--- a/xen/arch/x86/acpi/power.c
+++ b/xen/arch/x86/acpi/power.c
@
On Mon, Nov 23, 2020 at 04:04:00PM +, George Dunlap wrote:
> Ian Jackson has agreed to be the release manager for 4.15. Signify
> this by giving him maintainership over CHANGELOG.md.
>
> Signed-off-by: George Dunlap
Acked-by: Roger Pau Monné
Congratulations!
On Mon, Nov 23, 2020 at 04:30:05PM +0100, Jan Beulich wrote:
> On 23.11.2020 16:24, Roger Pau Monné wrote:
> > On Mon, Nov 23, 2020 at 01:40:12PM +0100, Jan Beulich wrote:
> >> --- a/xen/arch/x86/acpi/power.c
> >> +++ b/xen/arch/x86/acpi/power.c
> >> @@ -174,17 +174,20 @@ static void acpi_sleep_pre
Ian Jackson has agreed to be the release manager for 4.15. Signify
this by giving him maintainership over CHANGELOG.md.
Signed-off-by: George Dunlap
---
CC: Ian Jackson
CC: Wei Liu
CC: Andrew Cooper
CC: Jan Beulich
CC: Roger Pau Monne
CC: Stefano Stabellini
CC: Julien Grall
CC: Paul Durra
There was no feedback to this series within the past three weeks.
Please review this series.
Thanks,
Olaf
Am Thu, 29 Oct 2020 18:19:40 +0100
schrieb Olaf Hering :
> The current live migration code can easily saturate an 1Gb link.
> There is still room for improvement with faster network connect
On Mon, 2020-11-23 at 15:19 +0100, Miguel Ojeda wrote:
> On Sun, Nov 22, 2020 at 11:36 PM James Bottomley
> wrote:
> > Well, it seems to be three years of someone's time plus the
> > maintainer review time and series disruption of nearly a thousand
> > patches. Let's be conservative and assume th
flight 156956 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/156956/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 156935
test-amd64-i386-xl-qemuu-debianh
> -Original Message-
> From: Oleksandr
> Sent: 23 November 2020 15:48
> To: Jan Beulich ; Paul Durrant
> Cc: Oleksandr Tyshchenko ; Andrew Cooper
> ;
> Roger Pau Monné ; Wei Liu ; George Dunlap
> ; Ian Jackson ; Julien Grall
> ; Stefano
> Stabellini ; Jun Nakajima ;
> Kevin Tian
> ; Ju
On Sat, 21 Nov 2020, James Bottomley
wrote:
> On Sat, 2020-11-21 at 08:50 -0800, t...@redhat.com wrote:
>> A difficult part of automating commits is composing the subsystem
>> preamble in the commit log. For the ongoing effort of a fixer
>> producing
>> one or two fixes a release the use of 'tre
On 23.11.20 16:56, Jan Beulich wrote:
Hi Jan, Paul
On 23.11.2020 15:39, Oleksandr wrote:
As it was agreed, below the list of proposed renaming (naming) within
current series.
Thanks for compiling this. A couple of suggestions for consideration:
1. Global (existing):
hvm_map_mem_type_to_io
On Mon, Nov 23, 2020 at 01:41:06PM +0100, Jan Beulich wrote:
> We can be more tolerant as long as the data collected from FACS is only
> needed to enter S3. A prior change already added suitable checking to
> acpi_enter_sleep().
>
> Signed-off-by: Jan Beulich
Acked-by: Roger Pau Monné
Thanks,
On Mon, Nov 23, 2020 at 01:40:30PM +0100, Jan Beulich wrote:
> Use of __acpi_map_table() is kind of an abuse here, and doesn't work
> anymore for the majority of cases if any of the tables lives outside the
> low first Mb. Keep this (ab)use only prior to reaching SYS_STATE_boot,
> primarily to avoi
On 23.11.2020 16:24, Roger Pau Monné wrote:
> On Mon, Nov 23, 2020 at 01:40:12PM +0100, Jan Beulich wrote:
>> --- a/xen/arch/x86/acpi/power.c
>> +++ b/xen/arch/x86/acpi/power.c
>> @@ -174,17 +174,20 @@ static void acpi_sleep_prepare(u32 state
>> if ( state != ACPI_STATE_S3 )
>> return
On Mon, Nov 23, 2020 at 01:40:12PM +0100, Jan Beulich wrote:
> Use of __acpi_map_table() here was at least close to an abuse already
> before, but it will now consistently return NULL here. Drop the layering
> violation and use set_fixmap() directly. Re-use of the ACPI fixmap area
> is hopefully go
Build this code into an archive, partly paralleling bsearch().
Signed-off-by: Jan Beulich
Acked-by: Julien Grall
---
xen/common/Makefile| 1 -
xen/lib/Makefile | 1 +
xen/{common => lib}/sort.c | 0
3 files changed, 1 insertion(+), 1 deletion(-)
rename xen/{common => lib}/sor
Convert this code to an inline function (backed by an instance in an
archive in case the compiler decides against inlining), which results
in not having it in x86 final binaries. This saves a little bit of dead
code.
Signed-off-by: Jan Beulich
---
xen/common/Makefile| 1 -
xen/common/bs
Build this code into an archive, which results in not linking it into
x86 final binaries. This saves about 1.5k of dead code.
While moving the source file, take the opportunity and drop the
pointless EXPORT_SYMBOL() and an instance of trailing whitespace.
Signed-off-by: Jan Beulich
---
xen/comm
... into its own CU, for being unrelated to other things in
common/lib.c.
Signed-off-by: Jan Beulich
---
xen/common/lib.c | 14 --
xen/lib/Makefile | 1 +
xen/lib/ctors.c | 25 +
3 files changed, 26 insertions(+), 14 deletions(-)
create mode 100644 xen/lib/
... into its own CU, to build it into an archive.
Signed-off-by: Jan Beulich
Acked-by: Julien Grall
---
xen/common/lib.c | 39 --
xen/lib/Makefile | 1 +
xen/lib/parse-size.c | 50
3 files changed, 51 insertio
Build the source file always, as by putting it into an archive it still
won't be linked into final binaries when not needed. This way possible
build breakage will be easier to notice, and it's more consistent with
us unconditionally building other library kind of code (e.g. sort() or
bsearch()).
W
In order to (subsequently) drop odd things like CONFIG_NEEDS_LIST_SORT
just to avoid bloating binaries when only some arch-es and/or
configurations need generic library routines, combine objects under lib/
into an archive, which the linker then can pick the necessary objects
out of.
Note that we c
This case can occur when combining empty lists
obj-y :=
...
obj-y += $(empty)
or
obj-y := $(empty) $(empty)
where (only) blanks would accumulate. This was only a latent issue until
now, but would become an active issue for Arm once lib/ gets populated
with all respective objects going into the
In a few cases we link in library-like functions when they're not
actually needed. While we could use Kconfig options for each one
of them, I think the better approach for such generic code is to
build it always (thus making sure a build issue can't be introduced
for these in any however exotic con
> On Nov 22, 2020, at 9:22 PM, Jürgen Groß wrote:
>
> On 22.11.20 22:44, Andy Lutomirski wrote:
>>> On Sat, Nov 21, 2020 at 10:55 PM Jürgen Groß wrote:
>>>
>>> On 20.11.20 12:59, Peter Zijlstra wrote:
On Fri, Nov 20, 2020 at 12:46:23PM +0100, Juergen Gross wrote:
> +static __alwa
Introduce a helper function covering both the IRQ_GUEST check and the
cast involved in obtaining the (correctly typed) pointer. Where possible
add const and/or reduce variable scope.
Signed-off-by: Jan Beulich
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1042,6 +1042,11 @@ typedef struc
I didn't bother figuring which commit(s) should have deleted them while
removing their last uses.
Signed-off-by: Jan Beulich
---
v2: Yet one more.
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1402,7 +1402,6 @@ void desc_guest_eoi(struct irq_desc *des
{
irq_guest_action_t *action;
1: drop three unused variables
2: reduce casting involved in guest action retrieval
Jan
On 23.11.2020 15:39, Oleksandr wrote:
> As it was agreed, below the list of proposed renaming (naming) within
> current series.
Thanks for compiling this. A couple of suggestions for consideration:
> 1. Global (existing):
> hvm_map_mem_type_to_ioreq_server -> ioreq_server_map_mem_type
> hvm_
Hi Jan.
As it was agreed, below the list of proposed renaming (naming) within
current series.
If there are no objections I will follow the proposed renaming. If any
please let me know.
1. Global (existing):
hvm_map_mem_type_to_ioreq_server -> ioreq_server_map_mem_type
hvm_select_ior
While ver 041 of the ISA extensions doc also specifies
xcr0_supports_palette() returning false as one of the #GP(0) reasons for
LDTILECFG, the earlier #UD conditions look to make this fully dead.
Signed-off-by: Jan Beulich
---
v2: New.
---
SDE: -spr
--- a/tools/tests/x86_emulator/predicates.c
++
This is relatively straightforward, and hence best suited to introduce a
few other general pieces.
Testing of this will be added once a sensible test can be put together,
i.e. when support for other insns is also there.
Signed-off-by: Jan Beulich
---
v2: New.
--- a/tools/tests/x86_emulator/pred
1 - 100 of 172 matches
Mail list logo
