Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-28 Thread Bertrand Marquis
> On 28 Jul 2020, at 21:04, Stefano Stabellini wrote: > > On Tue, 28 Jul 2020, Bertrand Marquis wrote: >> At the moment on Arm, a Linux guest running with KTPI enabled will >> cause the following error when a context switch happens in user mode: >> (XEN) p2m.c:1890: d1v0: Failed to walk page-t

[ovmf test] 152270: all pass - PUSHED

2020-07-28 Thread osstest service owner
flight 152270 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152270/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 744ad444e5306ef68edbe899b5f5dc87e82c146b baseline version: ovmf 3887820e5fecdb9e948f8

[xen-unstable test] 152251: regressions - FAIL

2020-07-28 Thread osstest service owner
flight 152251 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152251/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 18 leak-check/check fail REGR. vs. 152233 Tests which did no

[seabios test] 152267: tolerable FAIL - PUSHED

2020-07-28 Thread osstest service owner
flight 152267 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/152267/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stopfail like 151947 test-amd64-amd64-xl-qemuu-win7-amd64 17 g

Re: dom0 LInux 5.8-rc5 kernel failing to initialize cooling maps for Allwinner H6 SoC

2020-07-28 Thread André Przywara
On 28/07/2020 19:52, Christopher Clark wrote: Hi Christopher, wow, this quickly got out of hand. I never meant to downplay anyone's work here, but on this particular platform some things might look a bit different than normal. See below. > On Tue, Jul 28, 2020 at 11:16 AM Stefano Stabellini > w

[xen-unstable-smoke test] 152269: tolerable all pass - PUSHED

2020-07-28 Thread osstest service owner
flight 152269 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/152269/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: fwupd support under Xen - firmware updates with the UEFI capsule

2020-07-28 Thread Marek Marczykowski-Górecki
On Tue, Jul 28, 2020 at 10:01:33PM +0100, Andrew Cooper wrote: > On 28/07/2020 21:00, Jan Beulich wrote: > > On 28.07.2020 09:41, Norbert Kaminski wrote: > >> I'm trying to add support for the firmware updates with the UEFI > >> capsule in > >> Qubes OS. I've got the troubles with reading ESRT (EFI

[linux-linus test] 152246: regressions - FAIL

2020-07-28 Thread osstest service owner
flight 152246 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/152246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-xsm 16 guest-start/debian.repeat fail REGR. vs. 151214 Tests which are fa

Re: fwupd support under Xen - firmware updates with the UEFI capsule

2020-07-28 Thread Andrew Cooper
On 28/07/2020 21:00, Jan Beulich wrote: > On 28.07.2020 09:41, Norbert Kaminski wrote: >> I'm trying to add support for the firmware updates with the UEFI >> capsule in >> Qubes OS. I've got the troubles with reading ESRT (EFI System >> Resource Table) >> in the dom0, which is based on the EFI memo

Re: fwupd support under Xen - firmware updates with the UEFI capsule

2020-07-28 Thread Jan Beulich
On 28.07.2020 09:41, Norbert Kaminski wrote: I'm trying to add support for the firmware updates with the UEFI capsule in Qubes OS. I've got the troubles with reading ESRT (EFI System Resource Table) in the dom0, which is based on the EFI memory map. The EFI_MEMMAP is not enabled despite the loade

Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-28 Thread Jan Beulich
On 28.07.2020 17:52, Bertrand Marquis wrote: At the moment on Arm, a Linux guest running with KTPI enabled will cause the following error when a context switch happens in user mode: (XEN) p2m.c:1890: d1v0: Failed to walk page-table va 0xff837ebe0cd0 The error is caused by the virtual address

Re: [PATCH 3/4] x86: drop ASM_{CL,ST}AC

2020-07-28 Thread Jan Beulich
On 28.07.2020 16:51, Andrew Cooper wrote: On 15/07/2020 11:49, Jan Beulich wrote: Use ALTERNATIVE directly, such that at the use sites it is visible that alternative code patching is in use. Similarly avoid hiding the fact in SAVE_ALL. No change to generated code. Signed-off-by: Jan Beulich

Re: [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary

2020-07-28 Thread Jan Beulich
On 28.07.2020 16:29, Andrew Cooper wrote: On 15/07/2020 11:48, Jan Beulich wrote: Now that I've done this I'm not longer sure which direction is better to follow: On one hand this introduces dead code (even if just NOPs) into CET-SS-disabled builds. Otoh this is a step towards breaking the tool

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Jan Beulich
On 28.07.2020 15:59, Andrew Cooper wrote: On 27/07/2020 20:47, Jan Beulich wrote: On 27.07.2020 16:55, Roger Pau Monné wrote: On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: --- /dev/null +++ b/xen/include/asm-x86/asm-defns.h Maybe this could be asm-insn.h or a different name? I

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Jan Beulich
On 28.07.2020 15:55, Andrew Cooper wrote: On 15/07/2020 11:48, Jan Beulich wrote: --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -20,6 +20,7 @@ $(call as-option-add,CFLAGS,CC,"rdrand % $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) $(call as-option-add,CFLAGS,CC

[ovmf test] 152261: all pass - PUSHED

2020-07-28 Thread osstest service owner
flight 152261 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152261/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3887820e5fecdb9e948f88eb4e92298f6c3dd86f baseline version: ovmf ffde22468e2f0e93b51f9

Re: [PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-28 Thread Stefano Stabellini
On Tue, 28 Jul 2020, Bertrand Marquis wrote: > At the moment on Arm, a Linux guest running with KTPI enabled will > cause the following error when a context switch happens in user mode: > (XEN) p2m.c:1890: d1v0: Failed to walk page-table va 0xff837ebe0cd0 > > The error is caused by the virtual

Re: dom0 LInux 5.8-rc5 kernel failing to initialize cooling maps for Allwinner H6 SoC

2020-07-28 Thread Christopher Clark
On Tue, Jul 28, 2020 at 11:16 AM Stefano Stabellini wrote: > > On Tue, 28 Jul 2020, André Przywara wrote: > > On 28/07/2020 11:39, Alejandro wrote: > > > Hello, > > > > > > El dom., 26 jul. 2020 a las 22:25, André Przywara > > > () escribió: > > >> So this was actually my first thought: The firmwa

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-28 Thread Stefano Stabellini
On Tue, 28 Jul 2020, Roger Pau Monné wrote: > On Mon, Jul 27, 2020 at 05:06:25PM -0700, Stefano Stabellini wrote: > > On Mon, 27 Jul 2020, Roger Pau Monné wrote: > > > On Sat, Jul 25, 2020 at 10:59:50AM +0100, Julien Grall wrote: > > > > On Sat, 25 Jul 2020 at 00:46, Stefano Stabellini > > > > wr

Re: dom0 LInux 5.8-rc5 kernel failing to initialize cooling maps for Allwinner H6 SoC

2020-07-28 Thread Stefano Stabellini
On Tue, 28 Jul 2020, André Przywara wrote: > On 28/07/2020 11:39, Alejandro wrote: > > Hello, > > > > El dom., 26 jul. 2020 a las 22:25, André Przywara > > () escribió: > >> So this was actually my first thought: The firmware (U-Boot SPL) sets up > >> some basic CPU frequency (888 MHz for H6 [1]),

Re: Porting Xen to Jetson Nano

2020-07-28 Thread Rich Persaud
On Jul 28, 2020, at 13:19, Srinivas Bangalore wrote: > >  >> >> I struggled to find your comment inline as your e-mail client doesn't >> quote my answer. Please configure your e-mail client to use some form >> of quoting (the usual is '>'). >> >> [] Done! Sorry about that. > > Thanks this i

Re: [PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Jan Beulich
On 28.07.2020 12:15, Andrew Cooper wrote: The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied. I'm enti

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

2020-07-28 Thread Jan Beulich
On 28.07.2020 11:26, Andrew Cooper wrote: Does this work? diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index ca94e8b453..638f6174de 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -62,8 +62,7 @@  #define timer_int_route(h, n)    MASK_EXTR(timer_config(

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:12:46PM +0100, Julien Grall wrote: > Hi Roger, > > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > > > To be used in order to create forei

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:06:25PM +0100, Andrew Cooper wrote: > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > >> Hi, > >> > >> On 27/07/2020 10:13, Roger Pau Monne wrote: > >>> To be used in order to create foreign mappings. This is

RE: Porting Xen to Jetson Nano

2020-07-28 Thread Srinivas Bangalore
> I struggled to find your comment inline as your e-mail client doesn't > quote my answer. Please configure your e-mail client to use some form > of quoting (the usual is '>'). > > [] Done! Sorry about that. Thanks this is a good start. Unfortunately, it doesn't fully help it when you have a r

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Julien Grall
Hi Roger, On 28/07/2020 17:59, Roger Pau Monné wrote: On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: Hi, On 27/07/2020 10:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devi

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Andrew Cooper
On 28/07/2020 17:59, Roger Pau Monné wrote: > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: >> Hi, >> >> On 27/07/2020 10:13, Roger Pau Monne wrote: >>> To be used in order to create foreign mappings. This is based on the >>> ZONE_DEVICE facility which is used by persistent memory d

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > Hi, > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create struct pages and k

Re: Porting Xen to Jetson Nano

2020-07-28 Thread Julien Grall
On 27/07/2020 23:09, Srinivas Bangalore wrote: Hi, On 24/07/2020 16:01, Srinivas Bangalore wrote: Hi Julien, Hello, Thanks for the tips. Comments inline... I struggled to find your comment inline as your e-mail client doesn't quote my answer. Please configure your e-mail client to us

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Julien Grall
Hi, On 27/07/2020 10:13, Roger Pau Monne wrote: To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kerne

[PATCH v2] xen/arm: Convert runstate address during hypcall

2020-07-28 Thread Bertrand Marquis
At the moment on Arm, a Linux guest running with KTPI enabled will cause the following error when a context switch happens in user mode: (XEN) p2m.c:1890: d1v0: Failed to walk page-table va 0xff837ebe0cd0 The error is caused by the virtual address for the runstate area registered by the guest

Re: [PATCH] x86/hvm: Clean up track_dirty_vram() calltree

2020-07-28 Thread Andrew Cooper
On 23/07/2020 11:25, Jan Beulich wrote: > On 23.07.2020 11:40, Andrew Cooper wrote: >> On 22/07/2020 17:13, Jan Beulich wrote: >>> On 22.07.2020 17:15, Andrew Cooper wrote: * Rename nr to nr_frames. A plain 'nr' is confusing to follow in the the lower levels. * Use DIV_ROUND_UP

[qemu-mainline test] 152241: regressions - FAIL

2020-07-28 Thread osstest service owner
flight 152241 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/152241/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 14 xen-boot/l1 fail REGR. vs. 151065 test-amd64-i386-x

Re: [PATCH 3/4] x86: drop ASM_{CL,ST}AC

2020-07-28 Thread Andrew Cooper
On 15/07/2020 11:49, Jan Beulich wrote: > Use ALTERNATIVE directly, such that at the use sites it is visible that > alternative code patching is in use. Similarly avoid hiding the fact in > SAVE_ALL. > > No change to generated code. > > Signed-off-by: Jan Beulich Definitely +1 to not hiding the S

Re: [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary

2020-07-28 Thread Andrew Cooper
On 15/07/2020 11:48, Jan Beulich wrote: > Commit b586a81b7a90 ("x86/CET: Fix build following c/s 43b98e7190") had > to introduce a number of #ifdef-s to make the build work with older tool > chains. Introduce an assembler macro covering for tool chains not > knowing of CET-SS, allowing some conditi

Re: [PATCH 5/5] tools/foreignmem: Support querying the size of a resource

2020-07-28 Thread Andrew Cooper
On 28/07/2020 12:37, Andrew Cooper wrote: > With the Xen side of this interface fixed to return real sizes, userspace > needs to be able to make the query. > > Introduce xenforeignmemory_resource_size() for the purpose, bumping the > library minor version and providing compatiblity for the non-Linu

Re: [PATCH 2/5] xen/gnttab: Rework resource acquisition

2020-07-28 Thread Andrew Cooper
On 28/07/2020 12:37, Andrew Cooper wrote: > diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c > index 9f0cae52c0..122d1e7596 100644 > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -4013,6 +4013,72 @@ static int gnttab_get_shared_frame_mfn(struct domain > *d, >

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Andrew Cooper
On 27/07/2020 20:47, Jan Beulich wrote: > On 27.07.2020 16:55, Roger Pau Monné wrote: >> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: >>> --- /dev/null >>> +++ b/xen/include/asm-x86/asm-defns.h >> >> Maybe this could be asm-insn.h or a different name? I find it >> confusing to have

Re: [PATCH] xen/balloon: add header guard

2020-07-28 Thread Boris Ostrovsky
On 7/28/20 7:42 AM, Roger Pau Monne wrote: > In order to protect against the header being included multiple times > on the same compilation unit. > > Signed-off-by: Roger Pau Monné Reviewed-by: Boris Ostrovsky

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Andrew Cooper
On 15/07/2020 11:48, Jan Beulich wrote: > --- a/xen/arch/x86/arch.mk > +++ b/xen/arch/x86/arch.mk > @@ -20,6 +20,7 @@ $(call as-option-add,CFLAGS,CC,"rdrand % > $(call as-option-add,CFLAGS,CC,"rdfsbase %rax",-DHAVE_AS_FSGSBASE) > $(call as-option-add,CFLAGS,CC,"xsaveopt (%rax)",-DHAVE_AS_XSAVEOPT

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

2020-07-28 Thread Andrew Cooper
On 28/07/2020 12:09, Eslam Elnikety wrote: > On 28.07.20 11:26, Andrew Cooper wrote: >> On 28/07/2020 09:33, Eslam Elnikety wrote: >>> The macro timer_int_route_cap evalutes to a 64 bit value. Extend the >>> size of left side of timer_int_route_valid to match. >>> >>> This bug was discovered and re

[ovmf test] 152249: all pass - PUSHED

2020-07-28 Thread osstest service owner
flight 152249 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152249/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ffde22468e2f0e93b51f97b801e6c7a181088c61 baseline version: ovmf a44f558a84c67cd88b821

[PATCH] xen/balloon: add header guard

2020-07-28 Thread Roger Pau Monne
In order to protect against the header being included multiple times on the same compilation unit. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-devel@lists.xenproject.org --- This is required as a pre-patch to use ZONE_DEVICE, or else

[PATCH 1/5] xen/memory: Introduce CONFIG_ARCH_ACQUIRE_RESOURCE

2020-07-28 Thread Andrew Cooper
New architectures shouldn't be forced to implement no-op stubs for unused functionality. Introduce CONFIG_ARCH_ACQUIRE_RESOURCE which can be opted in to, and provide compatibility logic in xen/mm.h No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pa

[PATCH 5/5] tools/foreignmem: Support querying the size of a resource

2020-07-28 Thread Andrew Cooper
With the Xen side of this interface fixed to return real sizes, userspace needs to be able to make the query. Introduce xenforeignmemory_resource_size() for the purpose, bumping the library minor version and providing compatiblity for the non-Linux builds. Its not possible to reuse the IOCTL_PRIV

[PATCH 3/5] xen/memory: Fix compat XENMEM_acquire_resource for size requests

2020-07-28 Thread Andrew Cooper
Copy the nr_frames from the correct structure, so the caller doesn't unconditionally receive 0. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Paul Durrant CC: Michał Lesz

[PATCH 4/5] xen/memory: Fix acquire_resource size semantics

2020-07-28 Thread Andrew Cooper
Calling XENMEM_acquire_resource with a NULL frame_list is a request for the size of the resource, but the returned 32 is bogus. If someone tries to follow it for XENMEM_resource_ioreq_server, the acquire call will fail as IOREQ servers currently top out at 2 frames, and it is only half the size of

RE: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: 28 July 2020 11:09 > To: qemu-de...@nongnu.org > Cc: Paul Durrant ; Paolo Bonzini ; > xen-devel@lists.xenproject.org; > Stefano Stabellini ; Anthony Perard > ; Philippe > Mathieu-Daudé ; Paul Durrant ; Peter > Maydell > > Subj

[PATCH 2/5] xen/gnttab: Rework resource acquisition

2020-07-28 Thread Andrew Cooper
The existing logic doesn't function in the general case for mapping a guests grant table, due to arbitrary 32 frame limit, and the default grant table limit being 64. In order to start addressing this, rework the existing grant table logic by implementing a single gnttab_acquire_resource(). This

[PATCH 0/5] Multiple fixes to XENMEM_acquire_resource

2020-07-28 Thread Andrew Cooper
I thought this was going to be a very simple small bugfix for Michał's Processor Trace series. Serves me right for expecting it not to be full of bear traps... The sole implementation of acquire_resource never asks for size, so its little surprise that Xen is broken for compat callers, and return

Re: dom0 LInux 5.8-rc5 kernel failing to initialize cooling maps for Allwinner H6 SoC

2020-07-28 Thread André Przywara
On 28/07/2020 11:39, Alejandro wrote: > Hello, > > El dom., 26 jul. 2020 a las 22:25, André Przywara > () escribió: >> So this was actually my first thought: The firmware (U-Boot SPL) sets up >> some basic CPU frequency (888 MHz for H6 [1]), which is known to never >> overheat the chip, even under

Re: dom0 LInux 5.8-rc5 kernel failing to initialize cooling maps for Allwinner H6 SoC

2020-07-28 Thread Alejandro
Hello, El dom., 26 jul. 2020 a las 22:25, André Przywara () escribió: > So this was actually my first thought: The firmware (U-Boot SPL) sets up > some basic CPU frequency (888 MHz for H6 [1]), which is known to never > overheat the chip, even under full load. So any concern from your side > about

Re: [PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Julien Grall
Hi Andrew, On 28/07/2020 11:15, Andrew Cooper wrote: The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied

Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200728100925.10454-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH] public/domctl: Fix the struct xen_domctl ABI in 32bit builds

2020-07-28 Thread Andrew Cooper
The Xen domctl ABI currently relies on the union containing a field with alignment of 8. 32bit projects which only copy the used subset of functionality end up with an ABI breakage if they don't have at least one uint64_aligned_t field copied. Insert explicit padding, and some build assertions to

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 11:00, Philippe Mathieu-Daudé wrote: > Apparently kvm_enabled() checks CONFIG_KVM_IS_POSSIBLE instead > of CONFIG_KVM, I suppose to bypass this limitation (from osdep.h): > > 21 #ifdef NEED_CPU_H > 22 # ifdef CONFIG_KVM > 24 # define CONFIG_KVM_IS_POSSIBLE > 25 # endif

Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"

2020-07-28 Thread George Dunlap
> On Jul 27, 2020, at 5:04 PM, Julien Grall wrote: > > Hmmm I forgot to CC George. Sorry for that. > > On 27/07/2020 17:04, Julien Grall wrote: >> From: Julien Grall >> The operator + will just concatenate two strings. As the result, the >> configure cmdline for "xentools" will look like: >>

[PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects

2020-07-28 Thread Philippe Mathieu-Daudé
CONFIG_XEN is generated by configure and stored in "config-target.h", which is (obviously) only include for target-specific objects. This is a problem for target-agnostic objects as CONFIG_XEN is never defined and xen_enabled() is always inlined as 'false'. Fix by following the KVM schema, definin

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:56 AM, Philippe Mathieu-Daudé wrote: > On 7/28/20 11:53 AM, Peter Maydell wrote: >> On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé >> wrote: >>> I'd rather uninline xen_enabled() but I'm not sure this has perf >>> penalties. Paolo is that OK to uninline it? > > I suppose no b

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:53 AM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé > wrote: >> I'd rather uninline xen_enabled() but I'm not sure this has perf >> penalties. Paolo is that OK to uninline it? I suppose no because it is in various hot paths: exec.c:588:if (xen_en

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:51, Philippe Mathieu-Daudé wrote: > I'd rather uninline xen_enabled() but I'm not sure this has perf > penalties. Paolo is that OK to uninline it? Can we just follow the same working pattern we already have for kvm_enabled() etc ? thanks -- PMM

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Philippe Mathieu-Daudé
On 7/28/20 11:27 AM, Peter Maydell wrote: > On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: >> >> From: Paul Durrant >> >> The recent commit da278d58a092 "accel: Move Xen accelerator code under >> accel/xen/" introduced a subtle semantic change, making xen_enabled() always >> return false unles

Re: [PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 10:19, Paul Durrant wrote: > > From: Paul Durrant > > The recent commit da278d58a092 "accel: Move Xen accelerator code under > accel/xen/" introduced a subtle semantic change, making xen_enabled() always > return false unless CONFIG_XEN is defined prior to inclusion of syse

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

2020-07-28 Thread Andrew Cooper
On 28/07/2020 09:33, Eslam Elnikety wrote: > The macro timer_int_route_cap evalutes to a 64 bit value. Extend the > size of left side of timer_int_route_valid to match. > > This bug was discovered and resolved using Coverity Static Analysis > Security Testing (SAST) by Synopsys, Inc. > > Signed-off

[PATCH] configure: define CONFIG_XEN when Xen is enabled

2020-07-28 Thread Paul Durrant
From: Paul Durrant The recent commit da278d58a092 "accel: Move Xen accelerator code under accel/xen/" introduced a subtle semantic change, making xen_enabled() always return false unless CONFIG_XEN is defined prior to inclusion of sysemu/xen.h, which appears to be the normal case. This causes var

Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC

2020-07-28 Thread Roger Pau Monné
On Mon, Jul 27, 2020 at 09:47:52PM +0200, Jan Beulich wrote: > On 27.07.2020 16:55, Roger Pau Monné wrote: > > On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: > > > --- /dev/null > > > +++ b/xen/include/asm-x86/asm-defns.h > > > > Maybe this could be asm-insn.h or a different name? I

Re: [PATCH] x86/vhpet: Fix type size in timer_int_route_valid

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 08:33:57AM +, Eslam Elnikety wrote: > The macro timer_int_route_cap evalutes to a 64 bit value. Extend the > size of left side of timer_int_route_valid to match. I'm very dull with this things, so forgive me. Isn't the left side just promoted to an unsigned 64bit value

Re: [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary

2020-07-28 Thread Roger Pau Monné
On Mon, Jul 27, 2020 at 09:50:23PM +0200, Jan Beulich wrote: > On 27.07.2020 17:00, Roger Pau Monné wrote: > > On Wed, Jul 15, 2020 at 12:48:46PM +0200, Jan Beulich wrote: > > Should the setssbsy be quoted, or it doesn't matter? I'm asking > > because the same construction used by CLAC/STAC doesn't

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-28 Thread Roger Pau Monné
On Mon, Jul 27, 2020 at 05:06:25PM -0700, Stefano Stabellini wrote: > On Mon, 27 Jul 2020, Roger Pau Monné wrote: > > On Sat, Jul 25, 2020 at 10:59:50AM +0100, Julien Grall wrote: > > > On Sat, 25 Jul 2020 at 00:46, Stefano Stabellini > > > wrote: > > > > > > > > On Fri, 24 Jul 2020, Julien Grall

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 08:06:17AM +, Rahul Singh wrote: > > > > On 24 Jul 2020, at 3:44 pm, Roger Pau Monné wrote: > > > > On Thu, Jul 23, 2020 at 04:40:21PM +0100, Rahul Singh wrote: > >> + > >> +struct pci_host_bridge *bridge = pci_find_host_bridge(sbdf.seg, > >> sbdf.bus); > >> + >

[xen-unstable test] 152233: tolerable FAIL - PUSHED

2020-07-28 Thread osstest service owner
flight 152233 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/152233/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 17 guest-start.2fail REGR. vs. 152045 Tests which did not succeed

Re: [RFC PATCH v1 1/4] arm/pci: PCI setup and PCI host bridge discovery within XEN on ARM.

2020-07-28 Thread Rahul Singh
> On 24 Jul 2020, at 3:44 pm, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 04:40:21PM +0100, Rahul Singh wrote: >> XEN during boot will read the PCI device tree node “reg” property >> and will map the PCI config space to the XEN memory. >> >> XEN will read the “linux, pci-domain” propert

[libvirt test] 152247: regressions - FAIL

2020-07-28 Thread osstest service owner
flight 152247 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/152247/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

fwupd support under Xen - firmware updates with the UEFI capsule

2020-07-28 Thread Norbert Kaminski
Hello all, I'm trying to add support for the firmware updates with the UEFI capsule in Qubes OS. I've got the troubles with reading ESRT (EFI System Resource Table) in the dom0, which is based on the EFI memory map. The EFI_MEMMAP is not enabled despite the loaded drivers (CONFIG_EFI, CONFIG_EF

Re: [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*()

2020-07-28 Thread Jürgen Groß
On 28.07.20 09:10, Souptick Joarder wrote: Hi Boris, On Sun, Jul 12, 2020 at 9:01 AM Souptick Joarder wrote: This series contains few clean up, minor bug fixes and Convert get_user_pages() to pin_user_pages(). I'm compile tested this, but unable to run-time test, so any testing help is much

Re: [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*()

2020-07-28 Thread Souptick Joarder
Hi Boris, On Sun, Jul 12, 2020 at 9:01 AM Souptick Joarder wrote: > > This series contains few clean up, minor bug fixes and > Convert get_user_pages() to pin_user_pages(). > > I'm compile tested this, but unable to run-time test, > so any testing help is much appriciated. > > v2: > Addre

[ovmf test] 152244: all pass - PUSHED

2020-07-28 Thread osstest service owner
flight 152244 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/152244/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a44f558a84c67cd88b8215d4c076123cf58438f4 baseline version: ovmf 6074f57e5b19c4cfd45a1