Re: [Xen-devel] [PATCH RFC v1 55/74] xen/pvshim: forward evtchn ops between L0 Xen and L2 DomU

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > +case EVTCHNOP_close: { > +struct evtchn_close close; > + > +if ( copy_from_guest(&close, arg, 1) != 0 ) > +return -EFAULT; > + > +if ( !port_is_valid(d, close.port) ) > +return -EINVAL; > + > +if ( evtc

[Xen-devel] [xen-4.10-testing test] 117713: FAIL

2018-01-08 Thread osstest service owner
flight 117713 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/117713/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-ws16-amd64 broken in 117683 test-

[Xen-devel] [xen-4.9-testing test] 117710: regressions - FAIL

2018-01-08 Thread osstest service owner
flight 117710 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/117710/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm broken in 117680 test-amd64-i386-xl-qemut-de

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
On 08/01/18 19:49, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> On 08/01/18 17:10, Peter Zijlstra wrote: >>> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and frowned upon by others. >>>

Re: [Xen-devel] [Xen-users] DomU not starting under pvhv2

2018-01-08 Thread Peter
On 2018-01-09 07:01, George Dunlap wrote: Moving to xen-devel, and cc'ing Roger and Boris (who developed PVH) On Mon, Jan 8, 2018 at 5:24 AM, Peter wrote: Hi. Running Xen 4.10.0 What version of Linux are you using? 4.14.12-1.el6xen.x86_64 #2 SMP Fri Jan 5 22:32:01 UTC 2018 x86_64 x86_64

[Xen-devel] [xen-4.7-testing test] 117705: tolerable FAIL - PUSHED

2018-01-08 Thread osstest service owner
flight 117705 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/117705/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-1 49 xtf/test-hvm64-lbr-tsx-vmentry fail like 117195 test-xtf-amd64-amd64-4 49 xt

Re: [Xen-devel] Xen Project Spectre/Meltdown FAQ

2018-01-08 Thread Stefano Stabellini
On Sun, 7 Jan 2018, Marek Marczykowski-Górecki wrote: > On Fri, Jan 05, 2018 at 07:05:56PM +, Andrew Cooper wrote: > > On 05/01/18 18:16, Rich Persaud wrote: > > >> On Jan 5, 2018, at 06:35, Lars Kurth > >> > wrote: > > >> Linux’s KPTI series is designed to add

[Xen-devel] [linux-3.18 baseline-only test] 74113: trouble: blocked/broken

2018-01-08 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74113 linux-3.18 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74113/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

Re: [Xen-devel] [PATCH v10 00/11] Enable Memory Bandwidth Allocation in Xen

2018-01-08 Thread Yi Sun
On 18-01-08 12:25:02, Wei Liu wrote: > On Mon, Jan 08, 2018 at 12:28:58PM +0800, Yi Sun wrote: > > On 17-12-20 02:11:32, Jan Beulich wrote: > > > >>> On 19.12.17 at 01:42, wrote: > > > > We plan to bring a new PSR (Platform Shared Resource) feature called > > > > Intel Memory Bandwidth Allocation

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Andrew Cooper
On 08/01/2018 17:45, Ian Jackson wrote: > AIUI we have a series for pv-in-pvh shim which is nearing completion > in the sense that it will have been well-tested (especially the > hypervisor parts) and has good functionality. (Wei is handling the > assembly of this series.) > > The series, however,

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Rich Persaud
> On Jan 8, 2018, at 16:44, Anthony Liguori wrote: >> On Mon, Jan 8, 2018 at 1:01 PM, Rich Persaud wrote: >> On a similarly pragmatic note: would a variation of Anthony's vixen patch >> series be suitable for pre-PVH Xen 4.6 - 4.9? These versions are currently >> documented as security-support

[Xen-devel] [linux-4.9 test] 117701: regressions - FAIL

2018-01-08 Thread osstest service owner
flight 117701 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/117701/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-buildfail REGR. vs. 117637 Tests which are faili

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 1:01 PM, Rich Persaud wrote: >> On Jan 8, 2018, at 12:45, Ian Jackson wrote: >> >> AIUI we have a series for pv-in-pvh shim which is nearing completion >> in the sense that it will have been well-tested (especially the >> hypervisor parts) and has good functionality. (Wei

[Xen-devel] [xen-4.8-testing baseline-only test] 74098: trouble: blocked/broken

2018-01-08 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 74098 xen-4.8-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/74098/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Rich Persaud
> On Jan 8, 2018, at 12:45, Ian Jackson wrote: > > AIUI we have a series for pv-in-pvh shim which is nearing completion > in the sense that it will have been well-tested (especially the > hypervisor parts) and has good functionality. (Wei is handling the > assembly of this series.) > > The seri

Re: [Xen-devel] [PATCH v6.5 13/26] x86/amd: Try to set lfence as being Dispatch Serialising

2018-01-08 Thread Andrew Cooper
On 04/01/18 09:32, Jan Beulich wrote: On 04.01.18 at 01:15, wrote: >> --- a/xen/arch/x86/cpu/amd.c >> +++ b/xen/arch/x86/cpu/amd.c >> @@ -558,8 +558,41 @@ static void init_amd(struct cpuinfo_x86 *c) >> wrmsr_amd_safe(0xc001100d, l, h & ~1); >> } >> >> +/* >> +

[Xen-devel] [seabios test] 117703: regressions - FAIL

2018-01-08 Thread osstest service owner
flight 117703 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/117703/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

Re: [Xen-devel] [PATCH] xen-netfront: enable device after manual module load

2018-01-08 Thread David Miller
From: Eduardo Otubo Date: Fri, 5 Jan 2018 09:42:16 +0100 > When loading the module after unloading it, the network interface would > not be enabled and thus wouldn't have a backend counterpart and unable > to be used by the guest. > > The guest would face errors like: > > [root@guest ~]# eth

[Xen-devel] [linux-3.18 test] 117702: tolerable FAIL - PUSHED

2018-01-08 Thread osstest service owner
flight 117702 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/117702/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check

Re: [Xen-devel] [PATCH v6.5 11/26] x86: Support indirect thunks from assembly code

2018-01-08 Thread Andrew Cooper
On 04/01/18 09:23, Jan Beulich wrote: On 04.01.18 at 01:15, wrote: >> --- a/xen/arch/x86/boot/trampoline.S >> +++ b/xen/arch/x86/boot/trampoline.S >> @@ -153,8 +153,28 @@ trampoline_protmode_entry: >> .code64 >> start64: >> /* Jump to high mappings. */ >> -movabs $

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Lars Kurth
> On 8 Jan 2018, at 17:45, Ian Jackson wrote: > > > But this is not a usual situation. This time, we don't have the time > to wait. > > Opinions ? > > Ian. +1 ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Ingo Molnar
* Juergen Gross wrote: > On 08/01/18 17:10, Peter Zijlstra wrote: > > On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: > >> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > >> frowned upon by others. > >> > >> https://lkml.org/lkml/2013/9/23/500 > >> >

[Xen-devel] [qemu-mainline test] 117699: regressions - FAIL

2018-01-08 Thread osstest service owner
flight 117699 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/117699/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd broken in 117633 test-amd64-amd64-libvirt-xsm

Re: [Xen-devel] [PATCH 22/22] vixen: dom0 builder support

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 10:22 AM, Konrad Rzeszutek Wilk wrote: > .snip.. >> +printk("Vixen Xenstore evtchn is %d, pfn is 0x%" PRIx64 "\n", >> + *pstore_evtchn, *pstore_mfn); > > So.. patch " console: do not print banner if below info log threshold" > speaks about having the printk be

Re: [Xen-devel] [PATCH 22/22] vixen: dom0 builder support

2018-01-08 Thread Konrad Rzeszutek Wilk
.snip.. > +printk("Vixen Xenstore evtchn is %d, pfn is 0x%" PRIx64 "\n", > + *pstore_evtchn, *pstore_mfn); So.. patch " console: do not print banner if below info log threshold" speaks about having the printk be as close to what the PV guest would be but here you are providing the pr

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 10:13 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 08, 2018 at 05:45:32PM +, Ian Jackson wrote: >> AIUI we have a series for pv-in-pvh shim which is nearing completion >> in the sense that it will have been well-tested (especially the >> hypervisor parts) and has good

Re: [Xen-devel] [RFC PATCH 1/8] x86/domctl: introduce a pair of hypercall to set and get cpu topology

2018-01-08 Thread Daniel De Graaf
On 01/07/2018 11:01 PM, Chao Gao wrote: Define interface, structures and hypercalls for toolstack to build cpu topology and for guest that will retrieve it [1]. Two subop hypercalls introduced by this patch: XEN_DOMCTL_set_cpu_topology to define cpu topology information per domain and XENMEM_get_

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Konrad Rzeszutek Wilk
On Mon, Jan 08, 2018 at 05:45:32PM +, Ian Jackson wrote: > AIUI we have a series for pv-in-pvh shim which is nearing completion > in the sense that it will have been well-tested (especially the > hypervisor parts) and has good functionality. (Wei is handling the > assembly of this series.) >

Re: [Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 9:45 AM, Ian Jackson wrote: > AIUI we have a series for pv-in-pvh shim which is nearing completion > in the sense that it will have been well-tested (especially the > hypervisor parts) and has good functionality. (Wei is handling the > assembly of this series.) > > The seri

Re: [Xen-devel] [Xen-users] DomU not starting under pvhv2

2018-01-08 Thread George Dunlap
Moving to xen-devel, and cc'ing Roger and Boris (who developed PVH) On Mon, Jan 8, 2018 at 5:24 AM, Peter wrote: > Hi. > > Running Xen 4.10.0 What version of Linux are you using? > > A VM is not starting with type = 'pvh'. The VM starts, but exits prior to > any data being read off the domU di

Re: [Xen-devel] [PATCH 2/3] x86/xsm: Use the exported bootstrap_map() function

2018-01-08 Thread Daniel De Graaf
On 01/08/2018 06:56 AM, Andrew Cooper wrote: ... rather than obtaining it via function pointer. Signed-off-by: Andrew Cooper Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/l

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Ian Jackson
Anthony Liguori writes ("Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim"): > hvmloader is still used. The full HVM boot stack is intact so it's > hvmloader -> {pcbios,seabios} -> boot loader. > > For testing, I've been using grub as the boot loader but isolinux > works fine too. > > The

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Roger Pau Monné
On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: > On Mon, Jan 8, 2018 at 4:11 AM, Roger Pau Monné wrote: > > On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: > >> Hi Anthony > >> > >> On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: > >> > From: Anthony Lig

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 9:34 AM, Wei Liu wrote: > On Mon, Jan 08, 2018 at 09:03:44AM -0800, Anthony Liguori wrote: >> On Mon, Jan 8, 2018 at 8:39 AM, Ian Jackson >> wrote: >> > Wei Liu writes ("Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim"): >> >> On Mon, Jan 08, 2018 at 08:02:07AM -0800

[Xen-devel] Radical proposal: ship not-fully-tidied shim as 4.10.1

2018-01-08 Thread Ian Jackson
AIUI we have a series for pv-in-pvh shim which is nearing completion in the sense that it will have been well-tested (especially the hypervisor parts) and has good functionality. (Wei is handling the assembly of this series.) The series, however, needs proper review and tidying up. Specifically,

Re: [Xen-devel] [PATCH RFC v1 55/74] xen/pvshim: forward evtchn ops between L0 Xen and L2 DomU

2018-01-08 Thread Roger Pau Monné
On Mon, Jan 08, 2018 at 09:05:40AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 14:06, wrote: > > +unsigned long evtchn = xchg(&XEN_shared_info->evtchn_pending[l1], > > 0); > > + > > +__clear_bit(l1, &pending); > > +evtchn &= ~XEN_shared_info->evtchn_mask[l1]; > > +

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Wei Liu
On Mon, Jan 08, 2018 at 09:03:44AM -0800, Anthony Liguori wrote: > On Mon, Jan 8, 2018 at 8:39 AM, Ian Jackson wrote: > > Wei Liu writes ("Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim"): > >> On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: > >> > OTOH, the HVM version of

Re: [Xen-devel] [PATCH RFC v1 56/74] xen/pvshim: add grant table operations

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > @@ -30,11 +31,17 @@ > #include > #include > > +#include Interesting: The event channel patch gave me the impression that it is not intended to deal with 32-bit guests. > @@ -360,6 +367,173 @@ void pv_shim_inject_evtchn(unsigned int port) > } > } >

Re: [Xen-devel] [PATCH v2 00/23] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 9:13 AM, Wei Liu wrote: > On Sun, Jan 07, 2018 at 12:28:16PM -0800, Anthony Liguori wrote: >> From: Anthony Liguori >> >> CVE-2017-5754 is problematic for paravirtualized x86 domUs because it >> appears to be very difficult to isolate the hypervisor's page tables >> from PV

Re: [Xen-devel] [PATCH v2 00/23] Vixen: A PV-in-HVM shim

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:16PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > CVE-2017-5754 is problematic for paravirtualized x86 domUs because it > appears to be very difficult to isolate the hypervisor's page tables > from PV domUs while maintaining ABI compatibility. Instead o

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 8:30 AM, Wei Liu wrote: > On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: >> On Mon, Jan 8, 2018 at 4:11 AM, Roger Pau Monné wrote: >> > On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: >> >> Hi Anthony >> >> >> >> On Sat, Jan 06, 2018 at 02:54:15PM

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 8:39 AM, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim"): >> On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: >> > OTOH, the HVM version of the series requires no tools changes and >> > works on Xen versions going

Re: [Xen-devel] [PATCH RFC v1 20/74] x86: produce a binary that can be booted as PVH

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 16:59, wrote: > On Fri, Jan 05, 2018 at 04:39:33AM -0700, Jan Beulich wrote: >> >>> On 04.01.18 at 14:05, wrote: >> > --- a/xen/arch/x86/Makefile >> > +++ b/xen/arch/x86/Makefile >> > @@ -75,6 +75,8 @@ efi-y := $(shell if [ ! -r >> > $(BASEDIR)/include/xen/compile.h -o \ >> >

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Jan 8, 2018 8:28 AM, "George Dunlap" wrote: On Mon, Jan 8, 2018 at 4:02 PM, Anthony Liguori wrote: >>> I do want to make the shim be able to run in both pvh and hvm mode >>> (which doesn't seem to be too hard in practice). >> >> AFAIK the pv-shim code will already work in HVM mode. It's just

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim"): > On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: > > OTOH, the HVM version of the series requires no tools changes and > > works on Xen versions going back to 3.4 (at least). That depends, I think, on how y

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Boris Ostrovsky
On 01/08/2018 11:28 AM, Juergen Gross wrote: > On 08/01/18 17:20, Boris Ostrovsky wrote: >> On 01/08/2018 11:10 AM, Peter Zijlstra wrote: >>> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and frowned

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Wei Liu
On Mon, Jan 08, 2018 at 08:02:07AM -0800, Anthony Liguori wrote: > On Mon, Jan 8, 2018 at 4:11 AM, Roger Pau Monné wrote: > > On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: > >> Hi Anthony > >> > >> On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: > >> > From: Anthony Lig

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread George Dunlap
On Mon, Jan 8, 2018 at 4:02 PM, Anthony Liguori wrote: >>> I do want to make the shim be able to run in both pvh and hvm mode >>> (which doesn't seem to be too hard in practice). >> >> AFAIK the pv-shim code will already work in HVM mode. It's just that >> booting the pv-shim in HVM mode requires

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
On 08/01/18 17:20, Boris Ostrovsky wrote: > On 01/08/2018 11:10 AM, Peter Zijlstra wrote: >> On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >>> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and >>> frowned upon by others. >>> >>> https://lkml.org/lkml/2013/

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Juergen Gross
On 08/01/18 17:10, Peter Zijlstra wrote: > On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and >> frowned upon by others. >> >> https://lkml.org/lkml/2013/9/23/500 >> >> Here, the VLAIS was used because the si

Re: [Xen-devel] [PATCH RFC v1 18/74] x86/link: Relocate program headers

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 16:43, wrote: > On Fri, Jan 05, 2018 at 04:20:36AM -0700, Jan Beulich wrote: >> >>> On 04.01.18 at 14:05, wrote: >> I'm also rather uncertain about the entry point >> change wrt various (and especially older) boot loaders. > > What (older) boot loaders do you have in mind? gr

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Boris Ostrovsky
On 01/08/2018 11:10 AM, Peter Zijlstra wrote: > On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: >> Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and >> frowned upon by others. >> >> https://lkml.org/lkml/2013/9/23/500 >> >> Here, the VLAIS was used because t

Re: [Xen-devel] [PATCH] xl: Don't warn on using 'deprecated' mode selection

2018-01-08 Thread Ian Jackson
George Dunlap writes ("[PATCH] xl: Don't warn on using 'deprecated' mode selection"): > We generally support old config formats indefinintely (see the disk > format) without emitting warnings. Acked-by: Ian Jackson > This is a candidate to backport to 4.10. I agree. Ian.

Re: [Xen-devel] [PATCH RFC v1 00/74] Run PV guest in PVH container

2018-01-08 Thread Ian Jackson
Wei Liu writes ("[Xen-devel] [PATCH RFC v1 00/74] Run PV guest in PVH container"): > 1. ARM build and some Clang build are broken by this series. > 2. The host will see a lot over-allocation messages, nothing too harmful and >will be fixed once toolstack is ready. My revised toolstack part of

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Peter Zijlstra
On Sat, Jan 06, 2018 at 01:39:48PM -0800, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry()

Re: [Xen-devel] [BUG] unable to shutdown (page fault in mwait_idle()/do_dbs_timer()/__find_next_bit()) (fwd)

2018-01-08 Thread Martin Cerveny
Hello. On Mon, 8 Jan 2018, Jan Beulich wrote: On 07.01.18 at 13:34, wrote: (XEN) [ Xen-4.10.0-vgpu x86_64 debug=n Not tainted ] The -vgpu tag makes me wonder whether you have any patches in your tree on top of plain 4.10.0 (or 4.10-staging). Also the debug=n above ... 4.10.0 +

Re: [Xen-devel] [PATCH RFC v1 55/74] xen/pvshim: forward evtchn ops between L0 Xen and L2 DomU

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > From: Roger Pau Monne > > Note that the unmask and the virq operations are handled by the shim > itself, and that FIFO event channels are not exposed to the guest. > > Signed-off-by: Anthony Liguori > Signed-off-by: Roger Pau Monné > Signed-off-by: Sergey Dy

Re: [Xen-devel] [PATCH RFC v1 06/74] tools/libelf: fix elf notes check for PVH guest

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 16:34, wrote: > On Thu, Jan 04, 2018 at 07:37:20AM -0700, Jan Beulich wrote: >> >>> On 04.01.18 at 14:05, wrote: >> I'm also surprised that I can't find any use of any of the three >> values checked in libxc. > > Libxc delegates the work to libelf AIUI. But libelf doesn't its

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Anthony Liguori
On Mon, Jan 8, 2018 at 4:11 AM, Roger Pau Monné wrote: > On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: >> Hi Anthony >> >> On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: >> > From: Anthony Liguori >> > >> > CVE-2017-5754 is problematic for paravirtualized x86 domUs be

Re: [Xen-devel] [PATCH RFC v1 20/74] x86: produce a binary that can be booted as PVH

2018-01-08 Thread Wei Liu
On Fri, Jan 05, 2018 at 04:39:33AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 14:05, wrote: > > Signed-off-by: Wei Liu > > Signed-off-by: Andrew Cooper > > Again I assume a description is still being intended to be written > > > --- a/xen/arch/x86/Makefile > > +++ b/xen/arch/x86/Makefile >

Re: [Xen-devel] [PATCH v2] x86: xen: remove the use of VLAIS

2018-01-08 Thread Boris Ostrovsky
On 01/06/2018 04:39 PM, Nick Desaulniers wrote: > Variable Length Arrays In Structs (VLAIS) is not supported by Clang, and > frowned upon by others. > > https://lkml.org/lkml/2013/9/23/500 > > Here, the VLAIS was used because the size of the bitmap returned from > xen_mc_entry() depended on possibl

[Xen-devel] [PATCH] xl: Don't warn on using 'deprecated' mode selection

2018-01-08 Thread George Dunlap
We generally support old config formats indefinintely (see the disk format) without emitting warnings. Signed-off-by: George Dunlap --- This is a candidate to backport to 4.10. CC: Ian Jackson CC: Wei Liu CC: Roger Pau Monne CC: Jan Beulich --- tools/xl/xl_parse.c | 3 --- 1 file changed, 3

Re: [Xen-devel] [PATCH RFC v1 18/74] x86/link: Relocate program headers

2018-01-08 Thread Wei Liu
On Fri, Jan 05, 2018 at 04:20:36AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 14:05, wrote: > > From: Andrew Cooper > > > > When the xen binary is loaded by libelf (in the future) we rely on the > > elf loader to load the binary accordingly. > > It would really help if it was said here what

Re: [Xen-devel] [PATCH RFC v1 06/74] tools/libelf: fix elf notes check for PVH guest

2018-01-08 Thread Wei Liu
On Thu, Jan 04, 2018 at 07:37:20AM -0700, Jan Beulich wrote: > >>> On 04.01.18 at 14:05, wrote: > > PVH only requires PHYS32_ENTRY to be set. Return immediately if that's > > the case. > > So I guess the bug(?) being fixed is that so far loader or guest_os, > and xen_ver settings are also require

[Xen-devel] Preparing for GSoC and Outreachy : getting Outreach Program Projects into good shape

2018-01-08 Thread Lars Kurth
Hi All, it's this time of the year again to prepare for GSoC/Outreachy! The application deadline for orgs is January 23 - February 11: ideally we will have a good updated lists of projects by then as Google will look at the quality of the project list. I will also need co-org admins: @Mindy are

Re: [Xen-devel] [PATCH] xen-netfront: enable device after manual module load

2018-01-08 Thread Boris Ostrovsky
On 01/05/2018 03:42 AM, Eduardo Otubo wrote: > When loading the module after unloading it, the network interface would > not be enabled and thus wouldn't have a backend counterpart and unable > to be used by the guest. > > The guest would face errors like: > > [root@guest ~]# ethtool -i eth0 >

Re: [Xen-devel] [PATCH v2 08/23] vixen: allow dom0 to be created with a domid != 0

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:24PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > Some older guests special case domid=0 instead of checking the > shared info flags so in order to get PV drivers loaded properly, > we need to make the guest always appear with a domid != 0. > > While th

Re: [Xen-devel] [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops()

2018-01-08 Thread Boris Ostrovsky
On 01/06/2018 03:35 PM, Nick Desaulniers wrote: > On Tue, Jan 2, 2018 at 7:00 AM, Boris Ostrovsky > wrote: >> On 01/02/2018 09:32 AM, Andrew Cooper wrote: >>> On 02/01/18 14:24, Juergen Gross wrote: On 02/01/18 15:18, Boris Ostrovsky wrote: > On 12/23/2017 09:50 PM, Nick Desaulniers wrote

Re: [Xen-devel] [PATCH 1/3] xen: remove tests for pvh mode in pure pv paths

2018-01-08 Thread Boris Ostrovsky
On 01/08/2018 01:50 AM, Juergen Gross wrote: > On 06/01/18 06:55, HW42 wrote: >> >> Not sure if you prefer to change the grant-table code or to revert this >> part of the commit. The patch bellow works for me: > The patch looks fine. > >> From: Simon Gaiser >> Date: Sat, 6 Jan 2018 06:40:32 +0100

Re: [Xen-devel] [PATCH 3/3] x86/microcode: Use the exported bootstrap_map() function

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 12:56, wrote: > ... rather than obtaining it via function pointer. The internal ucode_mod_map > function pointer can also be dropped. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@l

Re: [Xen-devel] [PATCH 2/3] x86/xsm: Use the exported bootstrap_map() function

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 12:56, wrote: > ... rather than obtaining it via function pointer. > > Signed-off-by: Andrew Cooper Assuming this doesn't break ARM Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xe

Re: [Xen-devel] [PATCH 1/3] x86/boot: Export bootstrap_map() for use in other translation units

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 12:56, wrote: > There is one static bootstrap_map() function which is passed via function > pointer to all of its users. This is wasteful. > > Export bootstrap_map() for all x86 users, and drop the function pointer > parameter from the construct_dom0*() infrastructure. > > Si

Re: [Xen-devel] [PATCH RFC v1 54/74] xen/pvshim: set correct domid value

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > @@ -94,6 +95,24 @@ void __init pv_shim_setup_dom(struct domain *d, > l4_pgentry_t *l4start, > #undef SET_AND_MAP_PARAM > } > > +void pv_shim_shutdown(uint8_t reason) > +{ > +/* XXX: handle suspend */ > +xen_hypercall_shutdown(reason); > +} Does this

[Xen-devel] [xen-unstable-smoke test] 117728: tolerable all pass - PUSHED

2018-01-08 Thread osstest service owner
flight 117728 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/117728/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH RFC v1 53/74] xen/pvshim: modify Dom0 builder in order to build a DomU

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > From: Roger Pau Monne > > According to the PV ABI the initial virtual memory regions should > contain the xenstore and console pages after the start_info. Fix this > and add the pages to the p2m/m2p after the start_info page also. I don't think "fix" is the ri

Re: [Xen-devel] [PATCH RFC v1 52/74] xen: mark xenstore/console pages as RAM and add them to dom_io

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > From: Roger Pau Monne > > Signed-off-by: Roger Pau Monné > Signed-off-by: Wei Liu There being no description at all makes it rather harder to review this one. I assume that marking the pages as RAM is necessary to make sure a struct page_info is being create

Re: [Xen-devel] [PATCH RFC v1 51/74] xen/pvshim: don't allow access to iomem or ioports

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > From: Roger Pau Monne > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich Could perhaps be folded into patch 50, as both relate to not being Dom0. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.o

Re: [Xen-devel] [PATCH RFC v1 50/74] xen/pvshim: remove Dom0 kernel support check

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > From: Roger Pau Monne > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH RFC v1 49/74] x86/guest: map per-cpu vcpu_info area.

2018-01-08 Thread Jan Beulich
>>> On 04.01.18 at 14:06, wrote: > So that the limit of XEN_LEGACY_MAX_VCPUS can be lifted. > > Signed-off-by: Roger Pau Monné > --- > Should be moved earlier maybe? Especially the changes to time.c undoing/redoing earlier changes suggests so. > --- a/xen/arch/x86/guest/xen.c > +++ b/xen/arch/

[Xen-devel] [xen-4.8-testing test] 117697: tolerable FAIL - PUSHED

2018-01-08 Thread osstest service owner
flight 117697 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/117697/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 16 guest-localmigrate/x10 fail in 117660 pass in 117697

Re: [Xen-devel] [PATCH] x86/Rules: Use -mskip-rax-setup if the compiler supports it

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 13:10, wrote: > On 08/01/18 12:04, Jan Beulich wrote: > On 08.01.18 at 11:46, wrote: >>> This option is available from GCC 5 onwards, and was specifically introduced >>> as an optimisation for Linux. When using varadic functions, the caller >>> needs >>> to know how many

[Xen-devel] [PATCH v2] x86/mm: Suppresses vm_events caused by page-walks

2018-01-08 Thread Alexandru Isaila
This patch is adding a way to enable/disable nested pagefault events. It introduces the xc_monitor_nested_pagefault function and adds the nested_pagefault_disabled in the monitor structure. This is needed by the introspection so it will only get gla faults and not get spammed with other faults. In

Re: [Xen-devel] Xen 4.11 Development Update

2018-01-08 Thread Juergen Gross
On 08/01/18 13:29, Wei Liu wrote: > On Fri, Jan 05, 2018 at 10:16:38AM +0100, Juergen Gross wrote: >> This email only tracks big items for xen.git tree. Please reply for items you >> would like to see in 4.11 so that people have an idea what is going on and >> prioritise accordingly. >> >> You're w

Re: [Xen-devel] Xen 4.11 Development Update

2018-01-08 Thread Wei Liu
On Fri, Jan 05, 2018 at 10:16:38AM +0100, Juergen Gross wrote: > This email only tracks big items for xen.git tree. Please reply for items you > would like to see in 4.11 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use ca

Re: [Xen-devel] [PATCH v10 00/11] Enable Memory Bandwidth Allocation in Xen

2018-01-08 Thread Wei Liu
On Mon, Jan 08, 2018 at 12:28:58PM +0800, Yi Sun wrote: > On 17-12-20 02:11:32, Jan Beulich wrote: > > >>> On 19.12.17 at 01:42, wrote: > > > We plan to bring a new PSR (Platform Shared Resource) feature called > > > Intel Memory Bandwidth Allocation (MBA) to Xen. > > > > > > Besides the MBA enab

Re: [Xen-devel] [PATCH v10 10/11] tools: implement new generic set value interface and MBA set value command

2018-01-08 Thread Wei Liu
On Tue, Dec 19, 2017 at 08:42:21AM +0800, Yi Sun wrote: > This patch implements new generic set value interfaces in libxc and libxl. > These interfaces are suitable for all allocation features. It also adds a > new MBA set value command in xl. > > Signed-off-by: Yi Sun Acked-by: Wei Liu __

Re: [Xen-devel] [PATCH v2 05/23] char: optionally redirect {, g}printk output to QEMU debug log

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:21PM -0800, Anthony Liguori wrote: > From: Matt Wilson > > When using Vixen, it is helpful to get the Xen messages in a > separate channel than the console output. Add an option to > output to the QEMU backdoor logging port. > > Signed-off-by: Matt Wilson I think

Re: [Xen-devel] [PATCH v2 07/23] vixen: introduce is_vixen() to allow altering behavior

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:23PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > Vixen (Virtualized Xen) is a paravirtual mode of Xen where > paravirtual I/O is passed through from the parent hypervisor > all the way through the dom0 guest. The dom0 guest is also > deprivileged and r

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Wei Liu
On Mon, Jan 08, 2018 at 12:11:55PM +, Roger Pau Monné wrote: > On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: > > Hi Anthony > > > > On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: > > > From: Anthony Liguori > > > > > > CVE-2017-5754 is problematic for paravirtual

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Roger Pau Monné
On Mon, Jan 08, 2018 at 11:54:57AM +, Wei Liu wrote: > Hi Anthony > > On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: > > From: Anthony Liguori > > > > CVE-2017-5754 is problematic for paravirtualized x86 domUs because it > > appears to be very difficult to isolate the hyper

Re: [Xen-devel] [PATCH] x86/Rules: Use -mskip-rax-setup if the compiler supports it

2018-01-08 Thread Andrew Cooper
On 08/01/18 12:04, Jan Beulich wrote: On 08.01.18 at 11:46, wrote: >> This option is available from GCC 5 onwards, and was specifically introduced >> as an optimisation for Linux. When using varadic functions, the caller >> needs >> to know how many floating point arguments were passed. Xe

Re: [Xen-devel] [PATCH v2 06/23] console: do not print banner if below info log threshold

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:22PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > Only print the banner if the log threshold is at least info. > > For Vixen guests, we want the console output to be exactly what the > PV guest would show on it's own. That means the inner Xen banner >

Re: [Xen-devel] [PATCH] x86/Rules: Use -mskip-rax-setup if the compiler supports it

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 11:46, wrote: > This option is available from GCC 5 onwards, and was specifically introduced > as an optimisation for Linux. When using varadic functions, the caller > needs > to know how many floating point arguments were passed. Xen, like Linux, > doesn't uses floating poin

Re: [Xen-devel] [PATCH v2 12/23] vixen: paravirtualization TSC frequency calculation

2018-01-08 Thread Wei Liu
On Sun, Jan 07, 2018 at 12:28:28PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > Otherwise when time sharing a physical CPU, the calculation can > be bogus resulting in time drift for the guest due to improper > frequency within pvclock. > What clock source is vixen using? What abou

[Xen-devel] [PATCH 2/3] x86/xsm: Use the exported bootstrap_map() function

2018-01-08 Thread Andrew Cooper
... rather than obtaining it via function pointer. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Daniel De Graaf --- xen/arch/x86/setup.c | 2 +- xen/include/xsm/xsm.h | 7 ++- xen/xsm/xsm_core.c| 9 ++--- xen/xsm/xsm_policy.c | 2 +- 4 files changed, 10 insertions(+), 10

[Xen-devel] [PATCH 1/3] x86/boot: Export bootstrap_map() for use in other translation units

2018-01-08 Thread Andrew Cooper
There is one static bootstrap_map() function which is passed via function pointer to all of its users. This is wasteful. Export bootstrap_map() for all x86 users, and drop the function pointer parameter from the construct_dom0*() infrastructure. Signed-off-by: Andrew Cooper --- CC: Jan Beulich

[Xen-devel] [PATCH 3/3] x86/microcode: Use the exported bootstrap_map() function

2018-01-08 Thread Andrew Cooper
... rather than obtaining it via function pointer. The internal ucode_mod_map function pointer can also be dropped. Signed-off-by: Andrew Cooper --- CC: Jan Beulich I'm not entirely convinced of the correctness of the uses of bootstrap_map(NULL) here especially as it is used over an extended p

[Xen-devel] [PATCH 0/3] x86: Don't pass bootstrap_map() by function pointer

2018-01-08 Thread Andrew Cooper
This series is presented on its code-hygene argument alone. However, it should be noted that compiler-based mitigations for SP2 do increase the overhead of indirect branches, and even just on the boot path, its wasteful to needlessly take the overhead. It should be noted that this series textural

Re: [Xen-devel] [PATCH 00/22] Vixen: A PV-in-HVM shim

2018-01-08 Thread Wei Liu
Hi Anthony On Sat, Jan 06, 2018 at 02:54:15PM -0800, Anthony Liguori wrote: > From: Anthony Liguori > > CVE-2017-5754 is problematic for paravirtualized x86 domUs because it > appears to be very difficult to isolate the hypervisor's page tables > from PV domUs while maintaining ABI compatibility

Re: [Xen-devel] [PATCH RFC v1 36/74] --- x86/shim: Kconfig and command line options

2018-01-08 Thread Jan Beulich
>>> On 08.01.18 at 12:33, wrote: > On 08/01/18 08:22, Jan Beulich wrote: > On 05.01.18 at 18:51, wrote: >>> On 05/01/18 15:26, Jan Beulich wrote: >>> On 04.01.18 at 14:05, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -133,6 +133,28 @@ config PVH_GUEST

  1   2   >