Re: [Xen-devel] [PATCH] gdbsx: prefer privcmd character device

2017-10-31 Thread Elena Ufimtseva
On Tue, Oct 31, 2017 at 03:25:39PM +, Wei Liu wrote: > On Tue, Oct 31, 2017 at 10:20:11AM -0500, Doug Goldstein wrote: > > Prefer using the character device over the proc file if the character > > device exists. > > > > CC: Elena Ufimtseva > > CC: Ian Ja

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-03-01 Thread Elena Ufimtseva
uot;hvm", > device_model_version="none". This is done because otherwise xl would start > parsing PV like options, and filling the PV struct at libxl_domain_build_info > (which in turn pollutes the HVM one because it's a union). > > Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [PATCH v13 3/3] iommu: add rmrr Xen command line option for extra rmrrs

2017-01-18 Thread Elena Ufimtseva
On Thu, Jan 12, 2017 at 04:44:42AM -0700, Jan Beulich wrote: > >>> On 10.01.17 at 23:57, wrote: > > Changes in v13: > > - Implement feedback from Kevin Tian. > > > > https://lists.xenproject.org/archives/html/xen-devel/2015-10/msg03169.html > > > > https://lists.xenproject.org/archives/h

Re: [Xen-devel] [PATCH v13 3/3] iommu: add rmrr Xen command line option for extra rmrrs

2017-01-19 Thread Elena Ufimtseva
On Thu, Jan 19, 2017 at 01:29:15AM -0700, Jan Beulich wrote: > >>> On 18.01.17 at 20:56, wrote: > > I am looking at rmrr_identity_mapping where the RMRR paddr get converted > > to pfn and then mapped with iommu. > > If ( rmrr->end_address & ~PAGE_SHIFT_MASK_4K ) == 0, the while loop > > while

Re: [Xen-devel] [PATCH] xen/x86: Fix CONFIG_CRASH_DEBUG build following c/s 897129dea

2017-01-06 Thread Elena Ufimtseva
On Fri, Jan 06, 2017 at 02:34:17PM +, Andrew Cooper wrote: > Found by a Travis RANDCONFIG run. > > Signed-off-by: Andrew Cooper Acked-by: Elena Ufimtseva > --- > CC: Jan Beulich > CC: Elena Ufimtseva > --- > xen/arch/x86/gdbstub.c| 8 > xen/ar

Re: [Xen-devel] [PATCH v3 2/4] x86: remove PVHv1 code

2017-03-03 Thread Elena Ufimtseva
> Reviewed-by: Andrew Cooper > Acked-by: George Dunlap > Reviewed-by: Paul Durrant > Acked-by: Elena Ufimtseva > Reviewed-by: Kevin Tian > --- > Changes since v1: > - Remove dom0pvh option from the command line docs. > - Bump domctl interface version due to the remov

Re: [Xen-devel] [PATCH v3 3/4] x86: remove has_hvm_container_{domain/vcpu}

2017-03-03 Thread Elena Ufimtseva
Kevin Tian > Reviewed-by: Boris Ostrovsky > Acked-by: George Dunlap > --- > Cc: Christoph Egger > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Boris Ostrovsky > Cc: Suravee Suthikulpanit > Cc: Jun Nakajima > Cc: Kevin Tian > Cc: Elena Ufimtseva Hmm, I dont s

Re: [Xen-devel] [PATCH v12 3/3] iommu: add rmrr Xen command line option for extra rmrrs

2015-11-05 Thread Elena Ufimtseva
On Wed, Oct 28, 2015 at 10:05:31AM -0600, Jan Beulich wrote: > >>> On 27.10.15 at 21:36, wrote: > > +static void __init add_extra_rmrr(void) > > +{ > > +struct acpi_rmrr_unit *acpi_rmrr; > > +struct acpi_rmrr_unit *rmrru; > > +unsigned int dev, seg, i; > > +unsigned long pfn; > > +

Re: [Xen-devel] [PATCH v12 3/3] iommu: add rmrr Xen command line option for extra rmrrs

2015-11-06 Thread Elena Ufimtseva
On Fri, Nov 06, 2015 at 04:05:25AM -0700, Jan Beulich wrote: > >>> On 06.11.15 at 05:22, wrote: > > On Wed, Oct 28, 2015 at 10:05:31AM -0600, Jan Beulich wrote: > >> >>> On 27.10.15 at 21:36, wrote: > >> > +static void __init add_extra_rmrr(void) > >> > +{ > >> > +struct acpi_rmrr_unit *acpi_

Re: [Xen-devel] RFC: making the PVH 64bit ABI as stableo

2015-06-10 Thread Elena Ufimtseva
On Fri, Jun 05, 2015 at 05:29:21PM +0100, Ian Campbell wrote: > On Wed, 2015-06-03 at 09:35 -0400, Boris Ostrovsky wrote: > > > What I'm hearing from the x86 maintainers is that this is actually a > > > high priority and not a "nice to have cleanup". > > > > > >> I picked 32-bit support, Elena is l

[Xen-devel] [PATCH 3/6] AMD-PVH: call hvm_emulate_one instead of handle_mmio

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva Certain IOIO instructions and CR access instructions like lmsw/clts etc need to be emulated. handle_mmio is incorrectly called to accomplish this. Create svm_emulate() to call hvm_emulate_one which is more appropriate, and works for pvh as well. handle_mmio call is

[Xen-devel] [PATCH 0/6] AMD-PVH: DomU support

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva This is a re-spin of patches for AMD PVH DomU from Mukesh Rathor. As I am diving into more details of AMD PVH, I am reposting his series with minor changes that reviewers (Jan and Boris) posted in comments. The issue with handle_mmio is not yet addressed and I would like

[Xen-devel] [PATCH 5/6] AMD-PVH: Support TSC_MODE_NEVER_EMULATE for PVH

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva On AMD, MSR_AMD64_TSC_RATIO must be set for rdtsc instruction in guest to properly read the cpu tsc. To that end, set tsc_khz in struct domain. Signed-off-by: Mukesh Rathor --- xen/arch/x86/time.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/time.c b

[Xen-devel] [PATCH 6/6] AMD-PVH: enable pvh if requirements met

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva Finally, enable pvh if the cpu supports NPT and svm decode. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 64d22fe..9945550 100644 --- a/xen

[Xen-devel] [PATCH 2/6] AMD-PVH: cpuid intercept

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva Call pv_cpuid for pvh cpuid intercept. Note, we modify svm_vmexit_do_cpuid instead of the intercept switch because the guest eip needs to be adjusted for pvh also. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 25 ++--- 1 file changed

[Xen-devel] [PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva PVH doesn't use apic emulation hence vlapic->regs ptr is not set for it. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/

[Xen-devel] [PATCH 1/6] pvh: domu construct vmcb 64 bit mode start

2015-06-22 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/vmcb.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c index 6339d2a..70a6588 100644 --- a/xen/arch/x86/hvm/svm/vmcb.c

Re: [Xen-devel] [Question] PARSEC benchmark has smaller execution time in VM than in native?

2016-03-01 Thread Elena Ufimtseva
On Tue, Mar 01, 2016 at 08:48:30AM -0500, Meng Xu wrote: > On Mon, Feb 29, 2016 at 12:59 PM, Konrad Rzeszutek Wilk > wrote: > >> > Hey! > >> > > >> > CC-ing Elena. > >> > >> I think you forgot you cc.ed her.. > >> Anyway, let's cc. her now... :-) > >> > >> > > >> >> We are measuring the execution

Re: [Xen-devel] [Question] PARSEC benchmark has smaller execution time in VM than in native?

2016-03-01 Thread Elena Ufimtseva
On Tue, Mar 01, 2016 at 02:52:14PM -0500, Meng Xu wrote: > Hi Elena, > > Thank you very much for sharing this! :-) > > On Tue, Mar 1, 2016 at 1:20 PM, Elena Ufimtseva > wrote: > > > > On Tue, Mar 01, 2016 at 08:48:30AM -0500, Meng Xu wrote: > > > O

Re: [Xen-devel] [Question] PARSEC benchmark has smaller execution time in VM than in native?

2016-03-01 Thread Elena Ufimtseva
> >> > >> On Tue, Mar 1, 2016 at 1:20 PM, Elena Ufimtseva > >> wrote: > >> > > >> > On Tue, Mar 01, 2016 at 08:48:30AM -0500, Meng Xu wrote: > >> > > On Mon, Feb 29, 2016 at 12:59 PM, Konrad Rzeszutek Wilk > >> > > w

Re: [Xen-devel] [PATCH 1/6] pvh: domu construct vmcb 64 bit mode start

2015-06-24 Thread Elena Ufimtseva
On Tue, Jun 23, 2015 at 01:02:49PM +0100, Jan Beulich wrote: > >>> On 22.06.15 at 18:37, wrote: > > From: Elena Ufimtseva > > > > Signed-off-by: Mukesh Rathor > > As long as this patch originally cam from Mukesh, From: should > reflect that imo. On

Re: [Xen-devel] [PATCH 1/6] pvh: domu construct vmcb 64 bit mode start

2015-06-24 Thread Elena Ufimtseva
On Tue, Jun 23, 2015 at 01:02:49PM +0100, Jan Beulich wrote: > >>> On 22.06.15 at 18:37, wrote: > > From: Elena Ufimtseva > > > > Signed-off-by: Mukesh Rathor > > As long as this patch originally cam from Mukesh, From: should > reflect that imo. On

Re: [Xen-devel] [PATCH 6/6] AMD-PVH: enable pvh if requirements met

2015-06-24 Thread Elena Ufimtseva
On Wed, Jun 24, 2015 at 07:24:18PM +0100, Andrew Cooper wrote: > On 24/06/15 08:49, Jan Beulich wrote: > On 24.06.15 at 04:34, wrote: > >> On 06/23/2015 08:30 AM, Jan Beulich wrote: > >> On 22.06.15 at 18:37, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/sv

Re: [Xen-devel] [PATCH 6/6] AMD-PVH: enable pvh if requirements met

2015-06-25 Thread Elena Ufimtseva
On Wed, Jun 24, 2015 at 02:41:54PM -0700, Mukesh Rathor wrote: > On Wed, 24 Jun 2015 16:26:44 -0400 > Elena Ufimtseva wrote: > > > On Wed, Jun 24, 2015 at 07:24:18PM +0100, Andrew Cooper wrote: > > > On 24/06/15 08:49, Jan Beulich wrote: > > > >>>> On

[Xen-devel] [PATCH v4] dmar: device scope mem leak fix

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva Release memory allocated for scope.devices when disabling dmar units. Also set device count after memory allocation when device scope parsing. This is explanation of why the code should be moved imho and answers Jan question about why I needed to do this. In

[Xen-devel] [PATCH v8 3/4] pci: add wrapper for parse_pci

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva For sbdf'si parsing in rmrr command line add __parse_pci with addtional parameter def_seg. __parse_pci will help to identify if segment was found in string being parsed or default segment was used. Make a wrapper parse_pci so the rest of the callers are not aff

[Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva --- xen/include/xen/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 3908146..414106a 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -33,6 +33,8 @@ #define

[Xen-devel] [PATCH v8 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory regions. These regions are

[Xen-devel] [PATCH v8 2/4] iommu VT-d: separate rmrr addition function

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. Also free memery for rmrr device scope in error path. I will also post additional patch with cleanups to address other non-functional changes as

[Xen-devel] [PATCH v8 0/4] iommu: add rmrr Xen command line option

2015-06-30 Thread elena . ufimtseva
From: Elena Ufimtseva v8 of rmrr comman line patches. Add Xen command line option rmrr to specify RMRR regions for devices that are

Re: [Xen-devel] [PATCH v4] dmar: device scope mem leak fix

2015-07-01 Thread Elena Ufimtseva
On Wed, Jul 01, 2015 at 11:00:45AM +0100, Andrew Cooper wrote: > On 01/07/15 00:20, elena.ufimts...@oracle.com wrote: > > --- a/xen/drivers/passthrough/vtd/dmar.c > > +++ b/xen/drivers/passthrough/vtd/dmar.c > > @@ -81,6 +81,13 @@ static int __init acpi_register_rmrr_unit(struct > > acpi_rmrr_unit

[Xen-devel] [PATCH v5] dmar: device scope mem leak fix

2015-07-01 Thread elena . ufimtseva
From: Elena Ufimtseva Release memory allocated for scope.devices when disabling dmar units. Also set device count after memory allocation when device scope parsing. This is explanation of why the code should be moved imho and answers Jan question about why I needed to do this. In

Re: [Xen-devel] can't create a vNUMA enabled PV guest

2015-07-02 Thread Elena Ufimtseva
On Wed, Jul 1, 2015 at 10:42 AM, Dario Faggioli wrote: > Hey, > > I know Wei is away, so I'll try to find the time to look at this myself, > but I figured I'll let know about it, in case someone has obvious (or > not :-D) ideas. > > I think I'm facing a bug that prevents creating PV guests with a

Re: [Xen-devel] [CALL-FOR-AGENDA] Monthly Xen.org Technical Call (2015-07-08)

2015-07-06 Thread Elena Ufimtseva
- ian.campb...@citrix.com wrote: > On Fri, 2015-07-03 at 13:55 +0100, Ian Campbell wrote: > > On Thu, 2015-07-02 at 16:16 +0100, Ian Jackson wrote: > > > Ian Campbell writes ("Re: [Xen-devel] [CALL-FOR-AGENDA] Monthly > Xen.org Technical Call (2015-07-08)"): > > > > On Thu, 2015-07-02 at 09:4

Re: [Xen-devel] [PATCH v5] dmar: device scope mem leak fix

2015-07-07 Thread Elena Ufimtseva
On Tue, Jul 07, 2015 at 10:54:25AM +0100, Jan Beulich wrote: > >>> On 01.07.15 at 20:30, wrote: > > Release memory allocated for scope.devices when disabling > > dmar units. Also set device count after memory allocation when > > device scope parsing. > > This is explanation of why the code should

[Xen-devel] [PATCH v6] dmar: device scope mem leak fix

2015-07-07 Thread elena . ufimtseva
From: Elena Ufimtseva Release memory allocated for scope.devices dmar units on various failure paths and when disabling dmar. Set device count after successful memory allocation, not before, in device scope parsing function. Signed-off-by: Elena Ufimtseva --- Changes in v6

[Xen-devel] [PATCH v9 3/4] pci: add wrapper for parse_pci

2015-07-08 Thread elena . ufimtseva
From: Elena Ufimtseva For sbdf's parsing in RMRR command line add __parse_pci with additional parameter def_seg. __parse_pci will help to identify if segment was found in string being parsed or default segment was used. Make a wrapper parse_pci so the rest of the callers are not aff

[Xen-devel] [PATCH v9 2/4] iommu VT-d: separate rmrr addition function

2015-07-08 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. Also free memery for rmrr device scope in error path. Signed-off-by: Elena Ufimtseva --- xen/drivers/passthrough/vtd/dmar.c | 126

[Xen-devel] [PATCH v9 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-07-08 Thread elena . ufimtseva
From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory regions. These regions are

[Xen-devel] [PATCH v9 0/4] iommu: add rmrr Xen command line option

2015-07-08 Thread elena . ufimtseva
From: Elena Ufimtseva v9 of rmrr command line patches. Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus causing IO Page Fault while booting dom0 in PVH mode. These additional regions will be added to the list of RMRR regions parsed from ACPI

[Xen-devel] [PATCH v9 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-07-08 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for patch "iommu: add rmrr Xen command line option for extra rmrrs" which will use it. Signed-off-by: Elena Ufimtseva --- xen/include/xen/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/p

Re: [Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-07-09 Thread Elena Ufimtseva
On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote: > >>> On 08.07.15 at 19:27, wrote: > > On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimts...@oracle.com wrote: > >> From: Elena Ufimtseva > >> > > > > You usually say why you need

Re: [Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-07-09 Thread Elena Ufimtseva
- jbeul...@suse.com wrote: > >>> On 09.07.15 at 13:13, wrote: > > On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote: > >> >>> On 08.07.15 at 19:27, wrote: > >> > On Tue, Jun 30, 2015 at 07:33:59PM -0400, > elena.ufimts

Re: [Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-07-09 Thread Elena Ufimtseva
- jbeul...@suse.com wrote: > >>> On 09.07.15 at 14:07, wrote: > > You are right, it needs to be rebased. I can post later rebased on > memory > > leak fix version, if you thin its a way to go. > > I didn't look at v9 yet, and can't predict when I will be able to. > > Jan Jan Would you

Re: [Xen-devel] [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-07-09 Thread Elena Ufimtseva
- wei.l...@citrix.com wrote: > On Thu, Jul 09, 2015 at 05:00:45PM +0100, Jan Beulich wrote: > > >>> On 09.07.15 at 17:53, wrote: > > > - jbeul...@suse.com wrote: > > >> >>> On 09.07.15 at 14:07, wrote: > > >> > You are right, it needs to be rebased. I can post later rebased > on > > >>

Re: [Xen-devel] [PATCH v4 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-05-08 Thread Elena Ufimtseva
On Thu, May 07, 2015 at 06:47:12AM +0100, Jan Beulich wrote: > >>> Elena Ufimtseva 05/06/15 6:50 PM >>> > >On Tue, May 05, 2015 at 11:14:30AM +0100, Jan Beulich wrote: > >> >>> On 28.04.15 at 01:50, wrote: > >> >

[Xen-devel] [PATCH] dmar: device scope mem leak fix

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva Release memory allocated for scope.devices when disabling dmar units. Also set device count after memory allocation when device scope parsing. Signed-off-by: Elena Ufimtseva --- xen/drivers/passthrough/vtd/dmar.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[Xen-devel] [PATCH v5 3/4] pci: add wrapper for parse_pci

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva For sbdf'si parsing in rmrr command line add __parse_pci with addtional parameter def_seg. __parse_pci will help to identify if segment was found in string being parsed or default segment was used. Make a wrapper parse_pci so the rest of the callers are not aff

[Xen-devel] [PATCH v5 1/4] pci: add PCI_SBDF macro

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva --- xen/include/xen/pci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 4377f3e..4ddf791 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -33,6 +33,7 @@ #define

[Xen-devel] [PATCH v5 2/4] iommu VT-d: separate rmrr addition function

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. Also free memery for rmrr device scope in error path. Signed-off-by: Elena Ufimtseva --- xen/drivers/passthrough/vtd/dmar.c | 130

[Xen-devel] [PATCH v5 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory regions. These regions are

[Xen-devel] [PATCH v5 0/4] iommu: add rmrr Xen command line option

2015-05-22 Thread elena . ufimtseva
From: Elena Ufimtseva Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus causing IO Page Fault while booting dom0 in PVH mode. These additional regions will be added to the list of RMRR regions parsed from ACPI. Changes in v5: - make

Re: [Xen-devel] [PATCH v5 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-05-27 Thread Elena Ufimtseva
On Tue, May 26, 2015 at 01:02:27PM +0100, Jan Beulich wrote: > >>> On 23.05.15 at 03:33, wrote: > > --- a/docs/misc/xen-command-line.markdown > > +++ b/docs/misc/xen-command-line.markdown > > @@ -1185,6 +1185,19 @@ Specify the host reboot method. > > 'efi' instructs Xen to reboot using the EFI re

Re: [Xen-devel] [PATCH] dmar: device scope mem leak fix

2015-05-27 Thread Elena Ufimtseva
On Tue, May 26, 2015 at 10:46:30AM +0100, Jan Beulich wrote: > >>> On 23.05.15 at 03:27, wrote: > > @@ -318,13 +321,13 @@ static int __init acpi_parse_dev_scope( > > if ( (cnt = scope_device_count(start, end)) < 0 ) > > return cnt; > > > > -scope->devices_cnt = cnt; > > if

Re: [Xen-devel] [PATCH] dmar: device scope mem leak fix

2015-05-28 Thread Elena Ufimtseva
On Thu, May 28, 2015 at 08:57:16AM +0100, Jan Beulich wrote: > >>> On 27.05.15 at 21:56, wrote: > > On Tue, May 26, 2015 at 10:46:30AM +0100, Jan Beulich wrote: > >> >>> On 23.05.15 at 03:27, wrote: > >> > @@ -658,6 +661,7 @@ acpi_parse_one_rmrr(struct acpi_dmar_header *header) > >> >

[Xen-devel] [PATCH v2] dmar: device scope mem leak fix

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva Release memory allocated for scope.devices when disabling dmar units. Also set device count after memory allocation when device scope parsing. Changes in v2: - release memory for devices scope on error paths in acpi_parse_one_drhd and acpi_parse_one_atsr and set the

[Xen-devel] [PATCH v6 0/4] iommu: add rmrr Xen command line option

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva v6 of extra rmrr series with addressed comments from Jan Beulich. Any suggestions are welcome. Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus causing IO Page Fault while booting dom0 in PVH mode. These additional

[Xen-devel] [PATCH 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory regions. These regions are

[Xen-devel] [PATCH v6 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva --- xen/include/xen/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 3908146..414106a 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -33,6 +33,8 @@ #define

[Xen-devel] [PATCH v6 3/4] pci: add wrapper for parse_pci

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva For sbdf'si parsing in rmrr command line add __parse_pci with addtional parameter def_seg. __parse_pci will help to identify if segment was found in string being parsed or default segment was used. Make a wrapper parse_pci so the rest of the callers are not aff

[Xen-devel] [PATCH v6 2/4] iommu VT-d: separate rmrr addition function

2015-05-29 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. Also free memery for rmrr device scope in error path. No changes since v5. Signed-off-by: Elena Ufimtseva Reviewed-by: Jan Beulich --- xen/drivers/passthrough/vtd

Re: [Xen-devel] [PATCH v2] dmar: device scope mem leak fix

2015-06-01 Thread Elena Ufimtseva
On Mon, Jun 01, 2015 at 09:45:51AM +0100, Jan Beulich wrote: > >>> On 01.06.15 at 06:47, wrote: > >> From: Tian, Kevin > >> Sent: Monday, June 01, 2015 12:43 PM > >> > >> > >> and looks you dropped earlier changes to acpi_parse_one_rmrr. any > >> elaboration why it's not required in this versio

Re: [Xen-devel] [PATCH v6 2/4] iommu VT-d: separate rmrr addition function

2015-06-01 Thread Elena Ufimtseva
On Mon, Jun 01, 2015 at 04:51:55AM +, Tian, Kevin wrote: > > From: elena.ufimts...@oracle.com [mailto:elena.ufimts...@oracle.com] > > Sent: Saturday, May 30, 2015 5:39 AM > > > > From: Elena Ufimtseva > > > > In preparation for auxiliary RMRR data provide

Re: [Xen-devel] [PATCH v6 2/4] iommu VT-d: separate rmrr addition function

2015-06-01 Thread Elena Ufimtseva
path. > > No changes since v5. > > Certainly there is. (And the statement wouldn't belong here anyway, > but below the first --- separator.) > > > Signed-off-by: Elena Ufimtseva > > Reviewed-by: Jan Beulich > > And certainly I didn't approve it in t

[Xen-devel] [PATCH v3] dmar: device scope mem leak fix

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva Third attempt to incorporate memory leak fix. Thanks for comment on v2. Release memory allocated for scope.devices when disabling dmar units. Also set device count after memory allocation when device scope parsing. Changes in v3: - make freeing memory for scope devices

[Xen-devel] [PATCH v7 1/4] pci: add PCI_SBDF and PCI_SEG macros

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva --- xen/include/xen/pci.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 3908146..414106a 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -33,6 +33,8 @@ #define

[Xen-devel] [PATCH v7 0/4] iommu: add rmrr Xen command line option

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva v7 of rmrr comman line patches. Thank you for comments on v6. Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus

[Xen-devel] [PATCH v7 3/4] pci: add wrapper for parse_pci

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva For sbdf'si parsing in rmrr command line add __parse_pci with addtional parameter def_seg. __parse_pci will help to identify if segment was found in string being parsed or default segment was used. Make a wrapper parse_pci so the rest of the callers are not aff

[Xen-devel] [PATCH v7 4/4] iommu: add rmrr Xen command line option for extra rmrrs

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory

[Xen-devel] [PATCH v7 2/4] iommu VT-d: separate rmrr addition function

2015-06-02 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. Also free memery for rmrr device scope in error path. Signed-off-by: Elena Ufimtseva --- xen/drivers/passthrough/vtd/dmar.c | 130

[Xen-devel] pcie error containment: kill domain and dm without xend

2016-06-22 Thread Elena Ufimtseva
Hello I am working on PCIe errors containment and XSA-124 relevant problem. This is only small part of the problem and I can provide more details later if that is of someone's interest. As the temporary solution, guest domain with passthrough device without SRIOV gets killed when certain AER erro

Re: [Xen-devel] pcie error containment: kill domain and dm without xend

2016-06-24 Thread Elena Ufimtseva
Thanks George! On Fri, Jun 24, 2016 at 4:37 AM, George Dunlap wrote: > On Wed, Jun 22, 2016 at 9:16 PM, Elena Ufimtseva wrote: >> Hello >> >> I am working on PCIe errors containment and XSA-124 relevant problem. >> This is only small part of the problem and I can

Re: [Xen-devel] GDBSX Maintainer

2016-06-28 Thread Elena Ufimtseva
Hi Julien, Andrew I was talking to Konrad some time ago about looking into this and the possibility of maintaining gdbsx code. I am willing sign up for this if there are no objections. Elena On Tue, Jun 28, 2016 at 9:46 AM, Andrew Cooper wrote: > On 28/06/16 17:31, Julien Grall wrote: >> Hi, >>

[Xen-devel] [PATCH RESEND] MAINTAINERS/gdbsx: change maintainer

2016-06-28 Thread elena . ufimtseva
From: Elena Ufimtseva Change gdbsx maintainer to myself. Signed-off-by: Elena Ufimtseva --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a8e0043..e91140f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -206,7 +206,7 @@ F: xen

Re: [Xen-devel] [PATCH v6 03/14] xen: Use a typesafe to define INVALID_MFN

2016-07-08 Thread Elena Ufimtseva
On Wed, Jul 06, 2016 at 02:04:17PM +0100, Julien Grall wrote: > (CC Elena). > > On 06/07/16 14:01, Julien Grall wrote: > >Also take the opportunity to convert arch/x86/debug.c to the typesafe > >mfn and use proper printf format for MFN/GFN when the code around is > >modified. > > > >Signed-off-by:

Re: [Xen-devel] [PATCH v6 04/14] xen: Use a typesafe to define INVALID_GFN

2016-07-08 Thread Elena Ufimtseva
gfn) > > unsigned long old_root_mfn; > > struct domain_iommu *hd = dom_iommu(d); > > > >-if ( gfn == INVALID_GFN ) > >+if ( gfn == gfn_x(INVALID_GFN) ) > > return -EADDRNOTAVAIL; > > ASSERT(!(gfn >> DEFAULT_DOMAIN_ADDRESS_WIDTH)); > > > >diff --git a/xen/drivers/passthrough/vtd/iommu.c > >b/xen/drivers/passthrough/vtd/iommu.c > >index f010612..c322b9f 100644 > >--- a/xen/drivers/passthrough/vtd/iommu.c > >+++ b/xen/drivers/passthrough/vtd/iommu.c > >@@ -611,7 +611,7 @@ static int __must_check iommu_flush_iotlb(struct domain > >*d, > > if ( iommu_domid == -1 ) > > continue; > > > >-if ( page_count != 1 || gfn == INVALID_GFN ) > >+if ( page_count != 1 || gfn == gfn_x(INVALID_GFN) ) > > rc = iommu_flush_iotlb_dsi(iommu, iommu_domid, > > 0, flush_dev_iotlb); > > else > >@@ -640,7 +640,7 @@ static int __must_check iommu_flush_iotlb_pages(struct > >domain *d, > > > > static int __must_check iommu_flush_iotlb_all(struct domain *d) > > { > >-return iommu_flush_iotlb(d, INVALID_GFN, 0, 0); > >+return iommu_flush_iotlb(d, gfn_x(INVALID_GFN), 0, 0); > > } > > > > /* clear one page's page table */ > >diff --git a/xen/drivers/passthrough/x86/iommu.c > >b/xen/drivers/passthrough/x86/iommu.c > >index cd435d7..69cd6c5 100644 > >--- a/xen/drivers/passthrough/x86/iommu.c > >+++ b/xen/drivers/passthrough/x86/iommu.c > >@@ -61,7 +61,7 @@ int arch_iommu_populate_page_table(struct domain *d) > > unsigned long mfn = page_to_mfn(page); > > unsigned long gfn = mfn_to_gmfn(d, mfn); > > > >-if ( gfn != INVALID_GFN ) > >+if ( gfn != gfn_x(INVALID_GFN) ) > > { > > ASSERT(!(gfn >> DEFAULT_DOMAIN_ADDRESS_WIDTH)); > > BUG_ON(SHARED_M2P(gfn)); > >diff --git a/xen/include/asm-x86/guest_pt.h b/xen/include/asm-x86/guest_pt.h > >index a8d980c..79ed4ff 100644 > >--- a/xen/include/asm-x86/guest_pt.h > >+++ b/xen/include/asm-x86/guest_pt.h > >@@ -32,7 +32,7 @@ > > #error GUEST_PAGING_LEVELS not defined > > #endif > > > >-#define VALID_GFN(m) (m != INVALID_GFN) > >+#define VALID_GFN(m) (m != gfn_x(INVALID_GFN)) > > > > static inline int > > valid_gfn(gfn_t m) > >@@ -251,7 +251,7 @@ static inline gfn_t > > guest_walk_to_gfn(walk_t *gw) > > { > > if ( !(guest_l1e_get_flags(gw->l1e) & _PAGE_PRESENT) ) > >-return _gfn(INVALID_GFN); > >+return INVALID_GFN; > > return guest_l1e_get_gfn(gw->l1e); > > } > > > >diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h > >index 4ab3574..194020e 100644 > >--- a/xen/include/asm-x86/p2m.h > >+++ b/xen/include/asm-x86/p2m.h > >@@ -324,7 +324,7 @@ struct p2m_domain { > > #define NR_POD_MRP_ENTRIES 32 > > > > /* Encode ORDER_2M superpage in top bit of GFN */ > >-#define POD_LAST_SUPERPAGE (INVALID_GFN & ~(INVALID_GFN >> 1)) > >+#define POD_LAST_SUPERPAGE (gfn_x(INVALID_GFN) & ~(gfn_x(INVALID_GFN) >> 1)) > > > > unsigned long list[NR_POD_MRP_ENTRIES]; > > unsigned int idx; > >diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h > >index 7f207ec..58bc0b8 100644 > >--- a/xen/include/xen/mm.h > >+++ b/xen/include/xen/mm.h > >@@ -84,7 +84,7 @@ static inline bool_t mfn_eq(mfn_t x, mfn_t y) > > > > TYPE_SAFE(unsigned long, gfn); > > #define PRI_gfn "05lx" > >-#define INVALID_GFN (~0UL) > >+#define INVALID_GFN _gfn(~0UL) > > > > #ifndef gfn_t > > #define gfn_t /* Grep fodder: gfn_t, _gfn() and gfn_x() are defined above > > */ > > > > -- > Julien Grall Acked-by: Elena Ufimtseva ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6 03/14] xen: Use a typesafe to define INVALID_MFN

2016-07-08 Thread Elena Ufimtseva
On Fri, Jul 08, 2016 at 08:20:03PM +0100, Andrew Cooper wrote: > On 08/07/2016 23:01, Elena Ufimtseva wrote: > > > >>> @@ -838,7 +838,6 @@ mfn_t oos_snapshot_lookup(struct domain *d, mfn_t > >>> gmfn) > >>> > >>> SHADOW_ERROR(&quo

Re: [Xen-devel] how to enable kdb for xen

2015-12-16 Thread Elena Ufimtseva
On Wed, Dec 16, 2015 at 9:30 AM, Konrad Rzeszutek Wilk wrote: > On December 16, 2015 3:08:04 AM EST, quizyjones > wrote: >>The version embedded with kdb only updates to 4.1.0. How can I use it >>with xen 4.6? Or is there any other debuggers which can step in Xen? > > CCing Elena who poked at it

Re: [Xen-devel] how to enable kdb for xen

2015-12-18 Thread Elena Ufimtseva
On Fri, Dec 18, 2015 at 11:24 PM, quizyjones wrote: > Is there any progress? Hey I did look into this and I could not find the trace of what I have done before. So I decided to ytu and port it to current version from this Mukesh patch: http://lists.xen.org/archives/html/xen-devel/2014-04/msg

Re: [Xen-devel] schedulers and topology exposing questions

2016-01-22 Thread Elena Ufimtseva
On Fri, Jan 22, 2016 at 06:29:19PM +0100, Dario Faggioli wrote: > On Fri, 2016-01-22 at 11:54 -0500, Elena Ufimtseva wrote: > > Hello all! > > > Hello, > > > Let me put some intro to our findings. I may forget something or put > > something > > not too ex

Re: [Xen-devel] schedulers and topology exposing questions

2016-01-27 Thread Elena Ufimtseva
On Wed, Jan 27, 2016 at 10:27:01AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 27, 2016 at 03:10:01PM +, George Dunlap wrote: > > On 27/01/16 14:33, Konrad Rzeszutek Wilk wrote: > > > On Tue, Jan 26, 2016 at 11:21:36AM +, George Dunlap wrote: > > >> On 2

Re: [Xen-devel] schedulers and topology exposing questions

2016-01-28 Thread Elena Ufimtseva
On Wed, Jan 27, 2016 at 02:01:35PM +, Dario Faggioli wrote: > On Fri, 2016-01-22 at 11:54 -0500, Elena Ufimtseva wrote: > > Hello all! > > > Hey, here I am again, > > > Konrad came up with a workaround that was setting the flag for domain > > scheduler in li

Re: [Xen-devel] schedulers and topology exposing questions

2016-01-29 Thread Elena Ufimtseva
On Thu, Jan 28, 2016 at 09:46:46AM +, Dario Faggioli wrote: > On Wed, 2016-01-27 at 11:03 -0500, Elena Ufimtseva wrote: > > On Wed, Jan 27, 2016 at 10:27:01AM -0500, Konrad Rzeszutek Wilk > > wrote: > > > On Wed, Jan 27, 2016 at 03:10:01PM +, George Dunlap wrote: &

Re: [Xen-devel] schedulers and topology exposing questions

2016-01-29 Thread Elena Ufimtseva
On Thu, Jan 28, 2016 at 09:55:45AM +, Dario Faggioli wrote: > On Wed, 2016-01-27 at 15:53 +, George Dunlap wrote: > > On 27/01/16 15:27, Konrad Rzeszutek Wilk wrote: > > >  > > > So Elena started looking at the CPU bound and seeing how Xen > > > behaves then > > > and if we can improve the

Re: [Xen-devel] [PATCH 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-10 Thread Elena Ufimtseva
On Tue, Mar 10, 2015 at 02:47:24AM +, Tian, Kevin wrote: > > From: elena.ufimts...@oracle.com [mailto:elena.ufimts...@oracle.com] > > Sent: Monday, March 09, 2015 10:43 PM > > > > From: Elena Ufimtseva > > > > On some platforms RMRR regions may be not spe

Re: [Xen-devel] [PATCH 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-10 Thread Elena Ufimtseva
On Tue, Mar 10, 2015 at 04:27:15PM +, Jan Beulich wrote: > >>> On 10.03.15 at 17:16, wrote: > > On Tue, Mar 10, 2015 at 02:47:24AM +, Tian, Kevin wrote: > >> > From: elena.ufimts...@oracle.com [mailto:elena.ufimts...@oracle.com] > >> > --- a/xen/drivers/passthrough/vtd/iommu.c > >> > +++ b

Re: [Xen-devel] [PATCH 1/2] iommu VT-d: separate rmrr addition function

2015-03-12 Thread Elena Ufimtseva
On Wed, Mar 11, 2015 at 10:29:54AM +, Jan Beulich wrote: > >>> On 09.03.15 at 15:42, wrote: > > --- a/xen/drivers/passthrough/vtd/dmar.c > > +++ b/xen/drivers/passthrough/vtd/dmar.c > > @@ -567,6 +567,66 @@ out: > > return ret; > > } > > > > +int register_one_rmrr(struct acpi_rmrr_unit

Re: [Xen-devel] [PATCH 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-12 Thread Elena Ufimtseva
On Mon, Mar 09, 2015 at 05:16:18PM +, Andrew Cooper wrote: > On 09/03/15 14:42, elena.ufimts...@oracle.com wrote: > > From: Elena Ufimtseva > > > > On some platforms RMRR regions may be not specified > > in ACPI and thus will not be mapped 1:1 in dom0. This &g

Re: [Xen-devel] [PATCH 1/2] iommu VT-d: separate rmrr addition function

2015-03-12 Thread Elena Ufimtseva
- elena.ufimts...@oracle.com wrote: > On Wed, Mar 11, 2015 at 10:29:54AM +, Jan Beulich wrote: > > >>> On 09.03.15 at 15:42, wrote: > > > --- a/xen/drivers/passthrough/vtd/dmar.c > > > +++ b/xen/drivers/passthrough/vtd/dmar.c > > > @@ -567,6 +567,66 @@ out: > > > return ret; > > >

Re: [Xen-devel] [PATCH 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-13 Thread Elena Ufimtseva
- jbeul...@suse.com wrote: > >>> On 12.03.15 at 21:52, wrote: > > On Mon, Mar 09, 2015 at 05:16:18PM +, Andrew Cooper wrote: > >> On 09/03/15 14:42, elena.ufimts...@oracle.com wrote: > >> > --- a/xen/drivers/passthrough/iommu.c > >> > +++ b/xen/drivers/passthrough/iommu.c > >> > @@ -55,6

[Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

2015-03-24 Thread elena . ufimtseva
From: Elena Ufimtseva Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus causing IO Page Fault while booting dom0 in PVH mode. These additional regions will

[Xen-devel] [PATCH v2 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-24 Thread elena . ufimtseva
From: Elena Ufimtseva On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory regions. These regions are

[Xen-devel] [PATCH v2 1/2] iommu VT-d: separate rmrr addition function

2015-03-24 Thread elena . ufimtseva
From: Elena Ufimtseva In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. No functional changes. Signed-off-by: Elena Ufimtseva --- xen/drivers/passthrough/vtd/dmar.c | 125 - 1 file changed, 66

Re: [Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

2015-03-24 Thread Elena Ufimtseva
On Tue, Mar 24, 2015 at 04:19:24PM +, Jan Beulich wrote: > >>> On 24.03.15 at 17:08, wrote: > > Changes in v2: > > > > > > - move rmrr parser to dmar.c and make it custom_param; > > > > > > - chang

Re: [Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

2015-03-25 Thread Elena Ufimtseva
On Wed, Mar 25, 2015 at 10:08:20AM +, Jan Beulich wrote: > >>> On 24.03.15 at 19:54, wrote: > > On Tue, Mar 24, 2015 at 04:19:24PM +, Jan Beulich wrote: > >> >>> On 24.03.15 at 17:08, wrote: > >> > Changes in v2: > >> > > >

Re: [Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

2015-03-25 Thread Elena Ufimtseva
On Wed, Mar 25, 2015 at 10:39:36AM +, Jan Beulich wrote: > >>> On 25.03.15 at 11:32, wrote: > > Looks like ';' is a valid syntax reserved character for grub, see > > section > > 5.2: > > > > > > http://www.gnu

Re: [Xen-devel] [PATCH v2 0/2] iommu: add rmrr Xen command line option

2015-03-25 Thread Elena Ufimtseva
On Wed, Mar 25, 2015 at 10:57:17AM +, Jan Beulich wrote: > >>> On 25.03.15 at 11:44, wrote: > > On Wed, Mar 25, 2015 at 10:39:36AM +, Jan Beulich wrote: > >> >>> On 25.03.15 at 11:32, wrote: > >> > Looks like ';' is a valid syntax reserved character for grub, see > >> > section > >

Re: [Xen-devel] [PATCH v2 1/2] iommu VT-d: separate rmrr addition function

2015-03-25 Thread Elena Ufimtseva
On Wed, Mar 25, 2015 at 05:04:38PM +, Jan Beulich wrote: > >>> On 24.03.15 at 17:08, wrote: > > +static int register_one_rmrr(struct acpi_rmrr_unit *rmrru) > > +{ > > +bool_t ignore = 0; > > +unsigned int i = 0; > > +int ret = 0; > > + > > +/* Skip checking if segment is not ac

Re: [Xen-devel] [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check

2015-02-13 Thread Elena Ufimtseva
On Fri, Feb 13, 2015 at 10:12 AM, Wei Liu wrote: > On Fri, Feb 13, 2015 at 02:15:47PM +, Ian Jackson wrote: >> Wei Liu writes ("[PATCH v5 08/24] libxl: introduce >> libxl__vnuma_config_check"): >> > This function is used to check whether vNUMA configuration (be it >> > auto-generated or suppl

Re: [Xen-devel] [PATCH v5 08/24] libxl: introduce libxl__vnuma_config_check

2015-02-13 Thread Elena Ufimtseva
On Fri, Feb 13, 2015 at 11:06 AM, Wei Liu wrote: > On Fri, Feb 13, 2015 at 10:39:25AM -0500, Elena Ufimtseva wrote: >> On Fri, Feb 13, 2015 at 10:12 AM, Wei Liu wrote: >> > On Fri, Feb 13, 2015 at 02:15:47PM +, Ian Jackson wrote: >> >> Wei Liu writes (&quo

  1   2   >