On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote:
> On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote:
> >
> > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote:
> > > On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote:
> > >
n be called when PAT initialization may not be performed.
This also assures that pat_disable() called from pat_bsp_init()
to set PAT table properly when CPU does not support PAT.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Robert Elliott
Cc: Ingo Molnar
Cc
isable properly, and
makes PAT code to bypass the memtype check. This avoids issue #1
(which can be dealt in lower priority).
[1]: https://lkml.org/lkml/2016/3/3/828
[2]: https://lkml.org/lkml/2016/3/4/775
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
AT is set to
disable.
1. CPU supports PAT: Set PAT table to be consistent with PAT MSR.
2. CPU does not support PAT: Set PAT table to be consistent with
PWT and PCD bits in a PTE.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Cc
On Tue, 2016-03-22 at 17:57 +0100, Borislav Petkov wrote:
> $Subject is misleading - there's no non-default PAT MSR - the setting is
> non-default.
Right. Will change to "Add support of non-default PAT MSR setting at
handoff".
> On Wed, Mar 16, 2016 at 06:44:57PM -0600,
On Tue, 2016-03-22 at 17:59 +0100, Borislav Petkov wrote:
> On Wed, Mar 16, 2016 at 06:46:55PM -0600, Toshi Kani wrote:
> > In preparation to fix a regression caused by 'commit 9cd25aac1f44
> > ("x86/mm/pat: Emulate PAT when it is disabled")', PAT needs to
>
On Tue, 2016-03-22 at 18:00 +0100, Borislav Petkov wrote:
> On Wed, Mar 16, 2016 at 06:46:56PM -0600, Toshi Kani wrote:
> > A Xorg failure on qemu32 was reported as a regression caused
> > by 'commit 9cd25aac1f44 ("x86/mm/pat: Emulate PAT when it is
> > disable
On Tue, 2016-03-22 at 18:01 +0100, Borislav Petkov wrote:
> Subject: [PATCH v2 4/6] x86/mtrr: Fix PAT init handling when MTRR MSR is
> disabled
>
> s/ MSR//
Will do.
> On Wed, Mar 16, 2016 at 06:46:57PM -0600, Toshi Kani wrote:
> > get_mtrr_state() calls pat_init() o
On Tue, 2016-03-22 at 18:02 +0100, Borislav Petkov wrote:
> On Wed, Mar 16, 2016 at 06:46:59PM -0600, Toshi Kani wrote:
> > Update PAT documentation to describe how PAT is initialized under
> > various configurations.
> >
:
> >
> > +PAT Initialization
>
On Wed, 2016-03-23 at 09:43 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 12:35:19PM -0600, Toshi Kani wrote:
> > Right. Will change to "Add support of non-default PAT MSR setting at
> > handoff".
>
> Please remove this "handoff" notion fr
On Wed, 2016-03-23 at 09:51 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 03:40:45PM -0600, Toshi Kani wrote:
> > Will change to "Prevent the OS from initializing the PAT MSR".
> >
> > I wanted to clarify that "disable" does not mean to disable
On Wed, 2016-03-23 at 09:44 +0100, Borislav Petkov wrote:
> On Tue, Mar 22, 2016 at 03:53:30PM -0600, Toshi Kani wrote:
> > Yes. I had to remove this number since checkpatch complained that I
> > needed to quote the whole patch tile again. I will ignore this
> > checkpat
with AP's,
mtrr_ap_init() and mtrr_aps_init().
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Thomas Gleixner
---
arch/x86/kernel/cpu/mtrr/generic.c | 24 ++--
arch/x86/kernel/cpu/m
atch.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Thomas Gleixner
---
arch/x86/include/asm/pat.h |2 +
arch/x86/mm/pat.c | 73
arch/x86/xen/enlighten.c
Update PAT documentation to describe how PAT is initialized under
various configurations.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Thomas Gleixner
---
Documentation/x86/pat.txt | 32
vide the SDM-defined sequence to initialize PAT.
This also assures pat_disable() called from pat_bsp_init() to
set PAT table properly when CPU does not support PAT.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Robert Elliott
Cc: Ingo Molnar
Cc: H. Pet
Borislav Petkov wrote:
> Please use on init paths boot_cpu_has(X86_FEATURE_PAT) and on fast
> paths static_cpu_has(X86_FEATURE_PAT). No more of that cpu_has_XXX
> ugliness.
Replace the use of cpu_has_pat on init paths with boot_cpu_has().
Suggested-by: Borislav Petkov
Signed-off-by: T
en MTRRs are disabled.
By setting PAT to disable properly, PAT bypasses the memtype check,
and avoids issue #1.
[1]: https://lkml.org/lkml/2016/3/3/828
[2]: https://lkml.org/lkml/2016/3/4/775
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Xen-specific PAT init code
is no longer necessary. Delete it from xen_start_kernel().
Also change __init_cache_modes() to a static function since
PAT table should not be tweaked by other modules.
Signed-off-by: Toshi Kani
Acked-by: Juergen Gross
Cc: Konrad Rzeszutek Wilk
Cc: Borislav Petkov
etkov)
- Update changelog, comments, and doc per review. (Borislav Petkov)
v2:
- Divide patch-set into a single change. (Borislav Petkov)
- Xen's case must be handled properly. (Luis R. Rodriguez)
- Change changelog and title to describe the issue. (Ingo Molnar)
- Update an error message. (R
On Wed, 2016-03-23 at 09:53 -0600, Toshi Kani wrote:
> On Wed, 2016-03-23 at 09:44 +0100, Borislav Petkov wrote:
> > On Tue, Mar 22, 2016 at 03:53:30PM -0600, Toshi Kani wrote:
> > > Yes. I had to remove this number since checkpatch complained that I
> > > needed to
On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote:
> * Toshi Kani wrote:
>
> > A Xorg failure on qemu32 was reported as a regression [1] caused by
> > 'commit 9cd25aac1f44 ("x86/mm/pat: Emulate PAT when it is disabled")'.
> > This patch-set fixes
On Tue, 2016-03-29 at 10:46 -0400, Boris Ostrovsky wrote:
> On 03/29/2016 10:19 AM, Toshi Kani wrote:
> > On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote:
> >
> > > > I'd appreciate if someone can test this patch-set on Xen to verify
> > > > that t
On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote:
> On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani wrote:
> > On Thu, 2016-03-17 at 17:06 -0700, Luis R. Rodriguez wrote:
> > > On Mar 17, 2016 2:04 PM, "Toshi Kani" wrote:
> > > >
:
> >
&g
On Tue, 2016-03-29 at 10:22 -0700, Luis R. Rodriguez wrote:
> On Thu, Mar 17, 2016 at 11:56 AM, Luis R. Rodriguez
> wrote:
> > On Thu, Mar 17, 2016 at 11:13:03AM +, David Vrabel wrote:
> > > On 16/03/16 20:08, Luis R. Rodriguez wrote:
> > > > Toshi noted a while ago as well that if BIOS/firmwa
On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote:
> On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani wrote:
> > On Tue, 2016-03-29 at 10:14 -0700, Luis R. Rodriguez wrote:
> > > On Fri, Mar 18, 2016 at 2:35 PM, Toshi Kani
> > > wrote:
:
> > >
&g
On Tue, 2016-03-29 at 16:43 -0700, Luis R. Rodriguez wrote:
> On Tue, Mar 29, 2016 at 5:16 PM, Toshi Kani wrote:
> > On Tue, 2016-03-29 at 15:12 -0700, Luis R. Rodriguez wrote:
> > > On Tue, Mar 29, 2016 at 2:46 PM, Toshi Kani
> > > wrote:
> > > > On
+xen-devl
On Tue, 2016-04-05 at 13:09 +0200, Borislav Petkov wrote:
> On Fri, Apr 01, 2016 at 04:19:45PM -0600, Toshi Kani wrote:
> >
> > The following BUG_ON error was reported on QEMU/i386:
> >
> > kernel BUG at arch/x86/mm/physaddr.c:79!
> > Call Trace:
&
On Tue, 2016-04-05 at 09:24 -0600, Toshi Kani wrote:
> +xen-devl
>
> On Tue, 2016-04-05 at 13:09 +0200, Borislav Petkov wrote:
> > On Fri, Apr 01, 2016 at 04:19:45PM -0600, Toshi Kani wrote:
> > >
:
> > >
> > > When the system does not have much me
On Fri, 2016-04-08 at 18:00 +0100, David Vrabel wrote:
> On 08/04/16 17:34, Toshi Kani wrote:
> >
> > On Tue, 2016-04-05 at 09:24 -0600, Toshi Kani wrote:
> > >
> > > +xen-devl
> > >
> > > On Tue, 2016-04-05 at 13:09 +0200, Borislav Petkov wr
On Sat, 2016-04-09 at 04:04 +0200, Luis R. Rodriguez wrote:
> On Thu, Mar 17, 2016 at 03:56:47PM -0600, Toshi Kani wrote:
> >
> > On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote:
> > >
> > > On x86 Linux code we now have ioremap_uc() that can't
robot
Link: https://lkml.org/lkml/2016/4/1/608
Signed-off-by: Toshi Kani
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Borislav Petkov
Cc: David Vrabel
---
This patch is based on -tip.
v2: Change to remove the code block.
---
arch/x86/mm/pat.c | 19 ---
On Wed, 2016-04-13 at 11:35 +0200, Ingo Molnar wrote:
> * Toshi Kani wrote:
:
> >
> > However, this code block, originally written for Pentiums and
> > earlier, is no longer adequate since a 32-bit Xen guest has
> > MTRRs disabled and supports ZONE_HIGHMEM. In this s
On Thu, 2015-06-11 at 13:36 -0700, Luis R. Rodriguez wrote:
:
> Pending RIP MTRR patches
>
>
> There are a few pending series so I wanted to provide a status update
> on those series.
>
> mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()
>
> This is the nail on the MTRR
On Fri, 2015-06-12 at 02:52 +0200, Luis R. Rodriguez wrote:
> On Thu, Jun 11, 2015 at 05:23:16PM -0600, Toshi Kani wrote:
> > On Thu, 2015-06-11 at 13:36 -0700, Luis R. Rodriguez wrote:
> > :
> > > Pending RIP MTRR patches
> > >
> > >
On Fri, 2015-06-12 at 08:59 +0100, Jan Beulich wrote:
> >>> On 12.06.15 at 01:23, wrote:
> > There are two usages on MTRRs:
> > 1) MTRR entries set by firmware
> > 2) MTRR entries set by OS drivers
> >
> > We can obsolete 2), but we have no control over 1). As UEFI firmwares
> > also set this
n.
Can you try the attached patches? They apply on top of my original patch-
set. With this change, PAT code generally supports Xen, and the PAT init
code in Xen is now removed. If they look OK, I will reorganize the patch
series.
Thanks,
-ToshiFrom: Toshi Kani
Add support of PAT emulation t
On Tue, 2016-03-15 at 11:01 +, Borislav Petkov wrote:
> On Mon, Mar 14, 2016 at 09:11:16PM -0600, Toshi Kani wrote:
> > - pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC)
> > |
> > - PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);
&g
On Tue, 2016-03-15 at 16:47 +0100, Borislav Petkov wrote:
> On Tue, Mar 15, 2016 at 09:43:15AM -0600, Toshi Kani wrote:
> > > Please use on init paths boot_cpu_has(X86_FEATURE_PAT) and on fast
> > > paths static_cpu_has(X86_FEATURE_PAT). No more of that cpu_h
On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote:
> On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote:
> > On Fri, 2016-03-11 at 15:34 -0800, Luis R. Rodriguez wrote:
> > > On Fri, Mar 11, 2016 at 3:56 PM, Toshi Kani
> > > wrote:
> > > >
Update PAT documentation to describe how PAT is initialized under
various configurations.
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen Gross
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Thomas Gleixner
---
Documentation/x86/pat.txt | 32
On Wed, 2016-03-16 at 00:29 +0100, Luis R. Rodriguez wrote:
> On Tue, Mar 15, 2016 at 05:48:44PM -0600, Toshi Kani wrote:
> > On Tue, 2016-03-15 at 01:15 +0100, Luis R. Rodriguez wrote:
> > > On Fri, Mar 11, 2016 at 06:16:36PM -0700, Toshi Kani wrote:
> > > > On
quot;x86/PAT: Configuration [0-7] .."
message in dmesg.
---
v2:
- Divide patch-set into a single change. (Borislav Petkov)
- Xen's case must be handled properly. (Luis R. Rodriguez)
- Change changelog and title to describe the issue. (Ingo Molnar)
- Update an error message. (Robert E
state() to mtrr_bp_pat_init().
Change mtrr_bp_init() to call mtrr_bp_pat_init() if MTRR is enabled.
This keeps BSP's calling condition to pat_init() consistent with AP's,
mtrr_ap_init() and mtrr_aps_init().
Signed-off-by: Toshi Kani
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Cc: Juergen
Xen-specific PAT init code
is no longer necessary. Delete it from xen_start_kernel().
Also change pat_init_cache_modes() to a static function since
PAT table should not be tweaked by other modules.
Signed-off-by: Toshi Kani
Cc: Konrad Rzeszutek Wilk
Cc: Borislav Petkov
Cc: Luis R. Rodriguez
Set IORESOURCE_SYSTEM_RAM to the flags of memory hotplug resource
ranges with "System RAM".
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xenproject.org
Signed-off-by: Toshi Kani
---
drivers/xen/balloon.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
blank line before if-statement. Remove an unnecessary brakets.
(Borislav Petkov)
prev-v2:
- Change the EINJ driver to call region_intersects_ram() for checking
RAM with a specified size. (Dan Williams)
---
Toshi Kani (11):
01/11 resource: Add System RAM resource type
02/11 resource: make re
Set IORESOURCE_SYSTEM_RAM to 'flags' of struct resource entries
with "System RAM".
Cc: Andrew Morton
Cc: Konrad Rzeszutek Wilk
Cc: xen-de...@lists.xenproject.org
Signed-off-by: Toshi Kani
---
drivers/xen/balloon.c |2 +-
mm/memory_hotplug.c |2 +-
2 files changed
odifier to IORESOURCE_MEM.
(Linus Torvalds)
- NVDIMM check needs to be able to distinguish legacy and NFIT pmem
ranges. (Dan Williams)
---
Toshi Kani (16):
01/16 resource: Add System RAM resource type
02/16 resource: make resource flags handled properly
03/16 resource: Add I/O resource descrip
eck needs to be able to distinguish legacy and NFIT pmem
ranges. (Dan Williams)
---
Toshi Kani (17):
01/17 resource: Add System RAM resource type
02/17 resource: make resource flags handled properly
03/17 resource: Add I/O resource descriptor
04/17 x86/e820: Set System RAM type and descrip
Set IORESOURCE_SYSTEM_RAM to 'flags' of struct resource entries
with "System RAM".
Cc: Andrew Morton
Cc: linux...@kvack.org
Cc: xen-de...@lists.xenproject.org
Acked-by: David Vrabel # xen
Signed-off-by: Toshi Kani
---
drivers/xen/balloon.c |2 +-
mm/memory_hotplug.c
On Mon, 2016-01-25 at 20:18 +0100, Borislav Petkov wrote:
> On Tue, Jan 05, 2016 at 11:54:28AM -0700, Toshi Kani wrote:
> > This patch-set enhances the iomem table and its search interfacs, and
> > then changes EINJ to support NVDIMM.
> >
:
>
> Ok, all applied ontop
On Mon, 2015-03-23 at 12:20 -0500, Bjorn Helgaas wrote:
:
> pci_iomap_range() already makes a cacheable mapping if
> IORESOURCE_CACHEABLE; I'm guessing that you would like it to
> automatically use WC if the BAR if IORESOURCE_PREFETCH, e.g.,
>
> if (flags & IORESOURCE_CACHEABLE)
> return io
On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote:
:
> @@ -734,6 +742,7 @@ void __init mtrr_bp_init(void)
> }
>
> if (mtrr_if) {
> + mtrr_enabled = true;
> set_num_var_ranges();
> init_table();
> if (use_intel()) {
On Thu, 2015-04-02 at 23:49 +0200, Luis R. Rodriguez wrote:
> On Sat, Mar 28, 2015 at 12:56:30AM +0100, Luis R. Rodriguez wrote:
> > On Fri, Mar 27, 2015 at 02:40:17PM -0600, Toshi Kani wrote:
> > > On Fri, 2015-03-20 at 16:17 -0700, Luis R. Rodriguez wrote:
> > >
On Thu, 2015-08-06 at 12:53 -0700, Luis R. Rodriguez wrote:
> On Fri, Jun 12, 2015 at 9:58 AM, Toshi Kani wrote:
> > On Fri, 2015-06-12 at 08:59 +0100, Jan Beulich wrote:
> > > > > > On 12.06.15 at 01:23, wrote:
> > > > There are two usages on MTRRs:
&
On Fri, 2015-08-07 at 13:25 -0700, Luis R. Rodriguez wrote:
> On Thu, Aug 6, 2015 at 3:58 PM, Toshi Kani wrote:
> > On Thu, 2015-08-06 at 12:53 -0700, Luis R. Rodriguez wrote:
> > > On Fri, Jun 12, 2015 at 9:58 AM, Toshi Kani wrote:
> > > > On Fri, 2015-06-12 at
On Fri, 2015-08-07 at 15:23 -0700, Luis R. Rodriguez wrote:
> On Fri, Aug 7, 2015 at 2:56 PM, Toshi Kani wrote:
> > On Fri, 2015-08-07 at 13:25 -0700, Luis R. Rodriguez wrote:
> > > On Thu, Aug 6, 2015 at 3:58 PM, Toshi Kani wrote:
> > > > On Thu, 2015-08-06 at
On Fri, 2015-08-07 at 17:08 -0600, Toshi Kani wrote:
> On Fri, 2015-08-07 at 15:23 -0700, Luis R. Rodriguez wrote:
> > On Fri, Aug 7, 2015 at 2:56 PM, Toshi Kani wrote:
> > > On Fri, 2015-08-07 at 13:25 -0700, Luis R. Rodriguez wrote:
> > > > On Thu, Aug
On Fri, 2015-08-07 at 16:26 -0700, Luis R. Rodriguez wrote:
> On Fri, Aug 7, 2015 at 4:08 PM, Toshi Kani wrote:
> > On Fri, 2015-08-07 at 15:23 -0700, Luis R. Rodriguez wrote:
> > > On Fri, Aug 7, 2015 at 2:56 PM, Toshi Kani wrote:
> > > > On Fri, 2015-08-07 at
On Fri, 2015-09-04 at 03:40 +0200, Luis R. Rodriguez wrote:
> On Thu, Sep 03, 2015 at 06:48:46PM -0600, Toshi Kani wrote:
> > On Fri, 2015-09-04 at 01:54 +0200, Luis R. Rodriguez wrote:
> > > On Thu, Sep 03, 2015 at 05:21:14PM -0600, Toshi Kani wrote:
> > > > On
61 matches
Mail list logo
