[Xen-devel] [PATCH] xen/arm: Don't unflatten DT when booting with ACPI

2017-04-21 Thread Punit Agrawal
unflatten the device tree only when acpi is disabled. Signed-off-by: Punit Agrawal --- xen/arch/arm/setup.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 92a2de6b70..4d62ea8157 100644 --- a/xen/arch/arm/setup.c +

[Xen-devel] [PATCH v2 for-4.9] xen/arm: Don't unflatten DT when booting with ACPI

2017-04-21 Thread Punit Agrawal
unflatten the device tree only when acpi is disabled. Signed-off-by: Punit Agrawal Reviewed-by: Julien Grall --- v1 -> v2 * Changed tab to spaces * Added tag --- xen/arch/arm/setup.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen

Re: [Xen-devel] [PATCH v2 for-4.9] xen/arm: Don't unflatten DT when booting with ACPI

2017-04-24 Thread Punit Agrawal
Stefano Stabellini writes: > On Fri, 21 Apr 2017, Punit Agrawal wrote: >> Unflattening the device tree when booting with "acpi=force" leads to the >> following stack trace on AMD Seattle platform - >> >> (XEN) Xen call trace: >> (XEN)[<000

Re: [Xen-devel] [For Xen-4.10 RFC PATCH 3/3] Prevent redundant icache flushes in populate_physmap()

2017-05-12 Thread Punit Agrawal
Hi Julien, Julien Grall writes: > Hi Punit, > > Sorry for the late answer. > > On 31/03/17 11:24, Punit Agrawal wrote: >> populate_physmap() calls alloc_heap_pages() per requested extent. As >> alloc_heap_pages() performs icache maintenance operations affecting the

[Xen-devel] [For Xen-4.10 PATCH 1/3] Allow control of icache invalidations when calling flush_page_to_ram()

2017-05-15 Thread Punit Agrawal
. This is in preparations for adding logic to make the callers perform the necessary icache maintenance operations. Signed-off-by: Punit Agrawal --- xen/arch/arm/mm.c | 5 +++-- xen/arch/arm/p2m.c | 2 +- xen/common/page_alloc.c| 2 +- xen/include/asm-arm/page.h

[Xen-devel] [For Xen-4.10 PATCH 2/3] arm: p2m: Prevent redundant icache flushes

2017-05-15 Thread Punit Agrawal
ndant icache operations by flush_page_to_ram(). Signed-off-by: Punit Agrawal Reviewed-by: Stefano Stabellini --- xen/arch/arm/p2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 29f2e2fad3..07357bce7d 100644 --- a/xen/arch/arm/

[Xen-devel] [For Xen-4.10 PATCH 0/3] Reduce unnecessary icache maintenance operations

2017-05-15 Thread Punit Agrawal
in populate_physmap() during domain creation. As I couldn't find icache maintenance operations for x86, an empty helper is introduced. Thanks, Punit [0] https://www.mail-archive.com/xen-devel@lists.xen.org/msg102934.html Punit Agrawal (3): Allow control of icache invalidations when ca

[Xen-devel] [For Xen-4.10 PATCH 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-15 Thread Punit Agrawal
ne concern is the lack of synchronisation around testing for "creation_finished". But it seems, in practice the window where it is out of sync should be small enough to not matter. Signed-off-by: Punit Agrawal --- xen/common/memory.c| 31 ++- xen

Re: [Xen-devel] [For Xen-4.10 PATCH 0/3] Reduce unnecessary icache maintenance operations

2017-05-15 Thread Punit Agrawal
Looks like I've got Konrad's email wrong. Please ignore this thread. I'll repost with the right address. :( Apologies for the spam. Punit Punit Agrawal writes: > Hi, > > This series was previously posted as an RFC[0]. An issue was discovered > in the RFC

[Xen-devel] [For Xen-4.10 Resend PATCH 0/3] Reduce unnecessary icache maintenance operations

2017-05-15 Thread Punit Agrawal
in populate_physmap() during domain creation. As I couldn't find icache maintenance operations for x86, an empty helper is introduced. Thanks, Punit [0] https://www.mail-archive.com/xen-devel@lists.xen.org/msg102934.html Punit Agrawal (3): Allow control of icache invalidations when ca

[Xen-devel] [For Xen-4.10 Resend PATCH 1/3] Allow control of icache invalidations when calling flush_page_to_ram()

2017-05-15 Thread Punit Agrawal
. This is in preparations for adding logic to make the callers perform the necessary icache maintenance operations. Signed-off-by: Punit Agrawal --- xen/arch/arm/mm.c | 5 +++-- xen/arch/arm/p2m.c | 2 +- xen/common/page_alloc.c| 2 +- xen/include/asm-arm/page.h

[Xen-devel] [For Xen-4.10 Resend PATCH 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-15 Thread Punit Agrawal
ne concern is the lack of synchronisation around testing for "creation_finished". But it seems, in practice the window where it is out of sync should be small enough to not matter. Signed-off-by: Punit Agrawal --- xen/common/memory.c| 31 ++- xen

[Xen-devel] [For Xen-4.10 Resend PATCH 2/3] arm: p2m: Prevent redundant icache flushes

2017-05-15 Thread Punit Agrawal
ndant icache operations by flush_page_to_ram(). Signed-off-by: Punit Agrawal Reviewed-by: Stefano Stabellini --- xen/arch/arm/p2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 29f2e2fad3..07357bce7d 100644 --- a/xen/arch/arm/

Re: [Xen-devel] [For Xen-4.10 Resend PATCH 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-17 Thread Punit Agrawal
Jan Beulich writes: On 15.05.17 at 16:10, wrote: >> --- a/xen/include/asm-x86/page.h >> +++ b/xen/include/asm-x86/page.h >> @@ -375,6 +375,10 @@ perms_strictly_increased(uint32_t old_flags, uint32_t >> new_flags) >> >> #define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) >> >> +s

Re: [Xen-devel] [For Xen-4.10 Resend PATCH 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-18 Thread Punit Agrawal
"Jan Beulich" writes: On 17.05.17 at 18:15, wrote: >> Jan Beulich writes: >> >> On 15.05.17 at 16:10, wrote: --- a/xen/include/asm-x86/page.h +++ b/xen/include/asm-x86/page.h @@ -375,6 +375,10 @@ perms_strictly_increased(uint32_t old_flags, uint32_t new_flags) >>

Re: [Xen-devel] [For Xen-4.10 Resend PATCH 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-24 Thread Punit Agrawal
Stefano Stabellini writes: > On Mon, 15 May 2017, Punit Agrawal wrote: >> populate_physmap() calls alloc_heap_pages() per requested >> extent. alloc_heap_pages() invalidates the entire icache per >> extent. During domain creation, the icache invalidations can be deffered >

[Xen-devel] [For Xen-4.10 PATCH v2 0/3] Reduce unnecessary icache maintenance operations

2017-05-26 Thread Punit Agrawal
002.html [1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg102934.html Punit Agrawal (3): Allow control of icache invalidations when calling flush_page_to_ram() arm: p2m: Prevent redundant icache flushes Avoid excess icache flushes in populate_physmap() before domain has been cr

[Xen-devel] [For Xen-4.10 PATCH v2 1/3] Allow control of icache invalidations when calling flush_page_to_ram()

2017-05-26 Thread Punit Agrawal
. This is in preparations for adding logic to make the callers perform the necessary icache maintenance operations. Signed-off-by: Punit Agrawal Acked-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/arch/arm/mm.c | 5 +++-- xen/arch/arm/p2m.c | 2 +- xen/common

[Xen-devel] [For Xen-4.10 PATCH v2 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-05-26 Thread Punit Agrawal
ne concern is the lack of synchronisation around testing for "creation_finished". But it seems, in practice the window where it is out of sync should be small enough to not matter. Signed-off-by: Punit Agrawal Reviewed-by: Stefano Stabellini --- xen/common/

[Xen-devel] [For Xen-4.10 PATCH v2 2/3] arm: p2m: Prevent redundant icache flushes

2017-05-26 Thread Punit Agrawal
ndant icache operations by flush_page_to_ram(). Signed-off-by: Punit Agrawal Reviewed-by: Stefano Stabellini --- xen/arch/arm/p2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 291998938e..b7bbea1d81 100644 --- a/xen/arch/arm/

Re: [Xen-devel] [For Xen-4.10 PATCH v2 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-06-07 Thread Punit Agrawal
"Jan Beulich" writes: On 26.05.17 at 13:14, wrote: >> --- a/xen/include/asm-x86/page.h >> +++ b/xen/include/asm-x86/page.h >> @@ -375,6 +375,14 @@ perms_strictly_increased(uint32_t old_flags, uint32_t >> new_flags) >> >> #define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) >> >>

[Xen-devel] [For Xen-4.10 PATCH] Ensure invalidate_icache() definition is visible only when !__ASSEMBLY__

2017-06-07 Thread Punit Agrawal
Avoid excess icache flushes in populate_physmap() before domain has been created") Signed-off-by: Punit Agrawal --- Hi Stefano, Jan, This commit fixes the build breakage in staging for me. I'm not sure whether staging gets rebased so sending this as a separate commit. Please feel free t

Re: [Xen-devel] [For Xen-4.10 PATCH v2 0/3] Reduce unnecessary icache maintenance operations

2017-06-07 Thread Punit Agrawal
Stefano Stabellini writes: > On Tue, 6 Jun 2017, Julien Grall wrote: >> On 26/05/17 12:14, Punit Agrawal wrote: >> > Hi, >> >> Hi, >> >> It looks like this patch series has been fully acked. Can someone apply it? > > Done. It was appropriately m

Re: [Xen-devel] [For Xen-4.10 PATCH v2 3/3] Avoid excess icache flushes in populate_physmap() before domain has been created

2017-06-07 Thread Punit Agrawal
Julien Grall writes: > On 07/06/17 12:19, Andrew Cooper wrote: >> On 26/05/17 12:14, Punit Agrawal wrote: >>> @@ -211,7 +221,6 @@ static void populate_physmap(struct memop_args *a) >>> } >>> >>> mfn = gpfn

[Xen-devel] [For Xen-4.10 PATCH] memory: Re-introduce an erroneously dropped line

2017-06-07 Thread Punit Agrawal
missing hunk. Fixes: 726b737574 ("Avoid excess icache flushes in populate_physmap() before domain has been created") Signed-off-by: Punit Agrawal --- xen/common/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/memory.c b/xen/common/memory.c index 34d2dda8b4..a3cb572

[Xen-devel] Notes from PCI Passthrough design discussion at Xen Summit

2017-07-19 Thread Punit Agrawal
I took some notes for the PCI Passthrough design discussion at Xen Summit. Due to the wide range of topics covered, the notes got sparser towards the end of the session. I've tried to attribute names against comments but have very likely got things mixed up. Apologies in advance. Although the ses

[Xen-devel] [PATCH 0/4] Drop uninformative messages from bootlog

2017-07-20 Thread Punit Agrawal
merged. Thanks, Punit Punit Agrawal (4): arm64/numa: Drop duplicate message mailbox: pcc: Drop uninformative output during boot ACPI / APEI: Drop uninformative messages during boot xen: Drop un-informative message during boot arch/arm64/mm/numa.c | 7 +-- drivers/acpi/apei

[Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

2017-07-20 Thread Punit Agrawal
-off-by: Punit Agrawal Cc: Boris Ostrovsky Cc: Juergen Gross --- drivers/xen/xenfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c index 967f069385d0..71ddfb4cf61c 100644 --- a/drivers/xen/xenfs/super.c +++ b/drivers/xen/xenfs

Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

2017-07-21 Thread Punit Agrawal
Boris Ostrovsky writes: > On 07/20/2017 07:04 AM, Punit Agrawal wrote: >> On systems that are not booted as a Xen domain, the xenfs driver prints >> the following message during boot. >> >> [3.460595] xenfs: not registering filesystem on non-xen platform >> &

Re: [Xen-devel] [PATCH 4/4] xen: Drop un-informative message during boot

2017-07-21 Thread Punit Agrawal
Juergen Gross writes: > On 21/07/17 12:12, Punit Agrawal wrote: >> Boris Ostrovsky writes: >> >>> On 07/20/2017 07:04 AM, Punit Agrawal wrote: >>>> On systems that are not booted as a Xen domain, the xenfs driver prints >>>> the following mes

[Xen-devel] [For Xen-4.10 RFC PATCH 0/3] Reduce unnecessary icache maintenance operations

2017-03-31 Thread Punit Agrawal
tions) might not be equivalent. This is my first contribution to Xen, so please go gentle if I've missed something obvious. Thanks, Punit Punit Agrawal (3): Allow control of icache invalidations when calling flush_page_to_ram() arm: p2m: Prevent redundant icache flushes Prevent redund

[Xen-devel] [For Xen-4.10 RFC PATCH 3/3] Prevent redundant icache flushes in populate_physmap()

2017-03-31 Thread Punit Agrawal
a new flag "MEMF_no_icache_flush" which can be used prevent alloc_heap_pages() to perform unnecessary icache maintenance operations. Use the flag in populate_physmap() and perform the required icache maintenance function at the end of the operation. Signed-off-by: Punit Agrawal ---

[Xen-devel] [For Xen-4.10 RFC PATCH 2/3] arm: p2m: Prevent redundant icache flushes

2017-03-31 Thread Punit Agrawal
ndant icache operations by flush_page_to_ram(). Signed-off-by: Punit Agrawal --- xen/arch/arm/p2m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 76cd1c34f3..8136522ed8 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -14

[Xen-devel] [For Xen-4.10 RFC PATCH 1/3] Allow control of icache invalidations when calling flush_page_to_ram()

2017-03-31 Thread Punit Agrawal
. This is in preparations for adding logic to make the callers perform the necessary icache maintenance operations. Signed-off-by: Punit Agrawal --- xen/arch/arm/mm.c | 5 +++-- xen/arch/arm/p2m.c | 2 +- xen/common/page_alloc.c| 2 +- xen/include/asm-arm/page.h

Re: [Xen-devel] [For Xen-4.10 RFC PATCH 3/3] Prevent redundant icache flushes in populate_physmap()

2017-03-31 Thread Punit Agrawal
Hi Wei, Thanks for taking a look at this RFC. Responses/questions below... Wei Liu writes: > On Fri, Mar 31, 2017 at 11:24:24AM +0100, Punit Agrawal wrote: >> populate_physmap() calls alloc_heap_pages() per requested extent. As >> alloc_heap_pages() performs icache mainten

Re: [Xen-devel] [For Xen-4.10 RFC PATCH 3/3] Prevent redundant icache flushes in populate_physmap()

2017-03-31 Thread Punit Agrawal
Wei Liu writes: > On Fri, Mar 31, 2017 at 02:53:55PM +0100, Punit Agrawal wrote: > [...] >> >> Correct! >> >> invalidate_icache() flushes the entire instruction cache which ends up >> being called each time flush_page_to_ram() is invoked from >> alloc

Re: [Xen-devel] [For Xen-4.10 RFC PATCH 2/3] arm: p2m: Prevent redundant icache flushes

2017-04-03 Thread Punit Agrawal
Hi Stefano, Stefano Stabellini writes: > On Fri, 31 Mar 2017, Punit Agrawal wrote: >> When toolstack requests flushing the caches, flush_page_to_ram() is >> called for each page of the requested domain. This needs to unnecessary >> icache invalidation operations.

Re: [Xen-devel] Xen on ARM IRQ latency and scheduler overhead

2017-02-20 Thread Punit Agrawal
Dario Faggioli writes: > On Fri, 2017-02-17 at 19:44 +, Julien Grall wrote: >> On 02/17/2017 06:40 PM, Dario Faggioli wrote: >> > Does ARM >> > have frequency scaling (I did remember something on xen-devel, but >> > I am >> > not sure whether it landed upstream)? >> >> I guess you mean the s